a3345057f2
FIX: prevents rendering empty timeline-controls ( #9304 )
...
The streamlength/height code when true would return just after we had inserted the timeline-controls, resulting, on topic-progress event to display an empty timeline-controls when clicked.
I think this code in unecessary and we should only rely on the code in `hideProgress` which will currenly hide the progress is the stream has only one post displayed on desktop (always shown on mobile).
2020-03-30 19:17:08 +02:00
aeaea3c154
FIX: correctly take category/group filters into csv export ( #9300 )
2020-03-30 19:08:47 +02:00
f8cb46c0e1
FIX: prevents exception when clicking component title above ace editor ( #9309 )
2020-03-30 18:55:15 +02:00
acdbcabd0e
DEV: Allows moduleForWidget to use before/afterEach options ( #9296 )
2020-03-30 18:12:32 +02:00
96e841a635
DEV: trigger :username_changed when a user is renamed ( #9301 )
2020-03-30 18:02:34 +02:00
6c2717eda0
UX: ensures esc key is correctly working when in dates form ( #9299 )
...
1 esc close modal focus date button in toolbar
2 esc reduces composer
2020-03-30 17:59:25 +02:00
d0d5f0c912
DEV: Add Ember.PromiseProxyMixin to ember modules ( #9312 )
2020-03-30 11:37:14 -04:00
14b8e221e7
Build(deps): Bump cose from 0.11.0 to 1.0.0 ( #9307 )
...
Bumps [cose](https://github.com/cedarcode/cose-ruby ) from 0.11.0 to 1.0.0.
- [Release notes](https://github.com/cedarcode/cose-ruby/releases )
- [Changelog](https://github.com/cedarcode/cose-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/cedarcode/cose-ruby/compare/v0.11.0...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 11:18:55 -04:00
0841ba1c6b
Build(deps): Bump unf_ext from 0.0.7.6 to 0.0.7.7 ( #9306 )
...
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext ) from 0.0.7.6 to 0.0.7.7.
- [Release notes](https://github.com/knu/ruby-unf_ext/releases )
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md )
- [Commits](https://github.com/knu/ruby-unf_ext/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 11:18:31 -04:00
2b78bd01ab
FIX: allows adapters to define a custom primaryKey ( #9254 )
2020-03-30 15:23:59 +02:00
92e81d2ae5
UX: Fix composer position on iPads with a hardware keyboard
...
Adds padding to the composer when the keyboard accessory bar is shown (i.e. submit button no longer hides behind said bar)
2020-03-30 09:23:00 -04:00
435fe8ac6e
FIX: allow invite email field to be blank for invite tokens
2020-03-30 10:35:49 +05:30
8ab39f6916
Build(deps): Bump logster from 2.7.1 to 2.8.0 ( #9310 )
...
This includes Font Awesome upgrade to version 5.
Bumps [logster](https://github.com/discourse/logster ) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.7.1...v2.8.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 07:52:04 +03:00
3914e9cb5c
FIX: get_size_from_image_sizes should return [width, height] or nil ( #9298 )
2020-03-28 20:20:51 +02:00
7a32a99595
FIX: Quoting a nested quote should preserve original post info.
2020-03-28 22:24:43 +05:30
a3d47f1aad
UX: Better spacing for icons in select-kit labels
...
Followup to c14e3adac5
2020-03-27 16:06:40 -04:00
104b647ca4
DEV: Fix another time-sensitive flaky spec
2020-03-27 20:39:25 +01:00
9026c55fe4
FIX: custom SQL with a trailing comment might break BadgeGranter SQL ( #9285 )
...
For example given a custom badge with SQL:
```
SELECT 1
-- I am a comment
```
You end up with
```
FROM (SELECT 1
-- I am a comment) q
```
This fix adds newlines so you end up with the now-valid:
```
FROM (
SELECT 1
-- I am a comment
) q
```
2020-03-27 14:16:14 -04:00
702879cbda
FIX: check for presence of name before normalizing
2020-03-27 23:01:48 +05:30
7ff889574d
DEV: Add rubocop-rspec ( #9288 )
...
This adds rubocop-rspec, and enables some cops that were either already passing or are passing now, after fixing them in this commit.
Some new cops are disabled for now, with annotation: "TODO" or "To be decided". Those either need to be discussed first, or require manual changes, or the number of found and fixed offenses is too large to bundle them up in a single PR.
Includes:
* DEV: Update rubocop's `TargetRubyVersion` to 2.6
* DEV: Enable RSpec/VoidExpect
* DEV: Enable RSpec/SharedContext
* DEV: Enable RSpec/EmptyExampleGroup (Removed an obsolete empty spec file)
* DEV: Enable RSpec/ItBehavesLike
* DEV: Remove RSpec/ScatteredLet (It's too strict, as it doesn't recognize fab! as a let-like)
* DEV: Remove RSpec/MultipleExpectations
2020-03-27 17:35:40 +01:00
b2b7afd310
Rename the server side widget hbs compiler
2020-03-27 12:06:14 -04:00
38e347aee6
DEV: allows to decorate topic list item ( #9294 )
...
Co-authored-by: David Taylor <david@taylorhq.com>
2020-03-27 16:50:31 +01:00
c721bdb300
DEV: Add build_plugin_html to wizard head ( #9293 )
2020-03-27 10:02:48 -05:00
eda8f319a2
FIX: keep date object ( #9292 )
2020-03-27 14:15:14 +01:00
1b09a0cd17
UX: improves date-time-input on mobile ( #9291 )
2020-03-27 13:29:58 +01:00
e6e6d20912
Revert "DEV: Enable and fix link-href-attributes lint"
...
Introducing an href attribute on the upload button caused the page to reload when clicked
This reverts commit a17fa222af
2020-03-27 11:43:00 +00:00
57321b90f0
Completely remove read only mode during backups ( #9279 )
2020-03-27 07:38:55 -03:00
0cb40fe9ed
FIX: Narrative bot not working for bookmarks with reminders ( #9289 )
...
Reported https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/42?u=mjrbrennan
* There was no callback on the bookmark model to trigger the next step of the narrative bot on bookmark.
* Also the translation URL path was hardcoded, needs to be conditional based on whether the site setting is enabled.
2020-03-27 12:17:18 +10:00
40b6e278a0
FIX: ensure wiki editor is assigned consistently
...
`DISTINCT ON` was not providing stability, this ensures the backfill will
be stable on a specific post avoiding risk around double grants.
2020-03-27 12:41:06 +11:00
33350c31c0
UX: Align bulk select menu toggle relative to main wrapper when possible
2020-03-26 19:15:33 -04:00
bed3f7f69a
DEV: long poll for 20 extra minutes when user stops interacting
...
We have no way of detecting if a browser window is behind another window
or off screen on a virtual desktop.
In some cases we may want events to be delivered quicker to the browser.
Specifically a user may still have a window in view but is not interacting.
This gives users 20 minutes of extra "long polling time" prior to shifting
to short polling.
2020-03-27 10:14:13 +11:00
257f59f366
FEATURE: option to update child theme components via theme CLI.
...
423ce44112
2020-03-27 03:41:56 +05:30
67b34600d5
DEV: Use `type` instead of `method` in ajax calls ( #8974 )
...
Even though `type` is an alias for `method`, we have custom logic in `/discourse/lib/ajax` that checks only `type`, and ~200 other ajax calls in the codebase already use `type` param.
2020-03-26 21:00:10 +01:00
17211b940f
DEV: Enable and fix the 'no-duplicate-attributes' lint
2020-03-26 12:31:34 -07:00
7c14d9ae9f
DEV: Add and disable all failing 'stylistic' lints
2020-03-26 12:31:34 -07:00
e98e83a1ff
DEV: Disable all failing 'recommended' lints and extend 'recommended'
2020-03-26 12:31:34 -07:00
eff4974829
sorting fix
2020-03-26 12:31:34 -07:00
07dc8d20c4
DEV: Enable and fix the 'require-iframe-title' lint
2020-03-26 12:31:34 -07:00
a17fa222af
DEV: Enable and fix link-href-attributes lint
2020-03-26 12:31:34 -07:00
af41c37d42
DEV: Enable all 'recommended' passing ember template linting rules
...
Also sort the ember template linting rules
2020-03-26 12:31:34 -07:00
05e2824a23
DEV: Fix flaky emoji-store tests
...
This set of tests cleared the emoji store *before* each test, while the other set - *after*. So if these were run first, they would break a single test from the other set.
2020-03-26 19:59:33 +01:00
7d2c71dd5f
FIX: Auto redirect had invalid extension
2020-03-26 13:21:04 -04:00
388e14b9dc
FIX: Broken transpilation
2020-03-26 13:12:17 -04:00
358ddb9b95
FIX: `nil` != `false`
2020-03-26 12:47:10 -04:00
6f2e3d61ee
Revert "FIX: Resolver wasn't being set properly"
...
This reverts commit 661aebdc87
2020-03-26 12:33:29 -04:00
60df2ade8d
Retry: Rename all test files from JS -> ES6
2020-03-26 12:25:46 -04:00
739430c01e
FIX: mbox import failed if no tags were configured
2020-03-26 16:41:11 +01:00
5bffb033df
FIX: The migrate_to_s3 rake task couldn't find the AWS SDK
2020-03-26 16:41:10 +01:00
d216483c53
FIX: Importing with pgbouncer failed
...
Checking if all records have been imported uses a temp table in PostgreSQL. This fails when pgbouncer is used unless the temp table is created inside a transaction.
2020-03-26 16:41:09 +01:00
c94b63bc75
DEV: Improve import of attachments from Telligent
2020-03-26 16:37:55 +01:00
Joffrey JAFFEUX
Zdravko Curic
dependabot-preview[bot]
Penar Musaraj
Arpit Jalan
Bianca Nenciu
Vinoth Kannan
Jarek Radosz
Michael Brown
Robin Ward
Mark VanLandingham
David Taylor
Roman Rizzi
Martin Brennan
Sam Saffron
Kris
Kane York
Gerhard Schlager