22fbae8556
Merge pull request #2674 from akshaymohite/optimization-fixes
...
renamed unused variables properly
2014-09-02 08:22:43 +10:00
e0c8abc911
Merge pull request #2717 from riking/badge-solid
...
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
202656a679
Merge pull request #2725 from cpradio/german-keyboard-support
...
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
02a7a579f4
FIX: Duplicate badge titles can still occur
...
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
03a7b01e4b
Merge pull request #2735 from techAPJ/patch-3
...
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
eba3f6b408
suppress post count on avatar for single post
2014-09-01 14:23:34 +05:30
68cc4fb285
we need more height
2014-09-01 17:42:27 +10:00
60559b42be
got to move inidicator a bit
2014-09-01 17:17:50 +10:00
69e418facf
FEATURE: wider search with more context
2014-09-01 17:04:57 +10:00
808460a28f
Fix magic numbers, extra param references
2014-08-31 19:36:31 -07:00
6234284243
FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings
2014-08-31 21:42:03 -04:00
bf679f1626
FIX: destroy CategoryGroup when Category or Group is destroyed
2014-08-31 22:10:38 +02:00
1833b43ae2
FEATURE: Badge query validation, preview results, and EXPLAIN
...
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.
Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.
On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).
The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.
The Badge.save() method is amended to propogate errors.
Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.
Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.
An uninitialized variable path is removed in the backfill() method.
TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
5c244c6f8f
FIX: autocomplete username failing to pop up
...
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises
This also fixes a promise leak
2014-09-01 01:48:17 +10:00
6d1be665a1
Merge pull request #2729 from cpradio/firefox-kbd-post-navigation
...
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
37639308c0
FIX: Firefox j/k post navigation is inconsistent
...
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
3f5d530553
Change SHIFT+J and SHIFT+K to move up/down sections instead of posts.
2014-08-30 07:31:38 -04:00
82d4c29c88
TRIVIAL: add line break before time for post navigator
2014-08-30 16:14:00 +05:30
7a50ba600a
Merge pull request #2726 from techAPJ/patch-4
...
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
3c005557e6
FIX: use short date format for post navigator
2014-08-30 11:34:33 +05:30
4281b16616
UX: dim the new and unread education
2014-08-29 22:54:11 -07:00
89eb03aff0
FIX: Support J/K bindings on German Keyboards
...
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
8b349b43a5
UX: Add keyboard binding for reply as new topic
...
Removed extra translation in the keyboard shortcut modal window
2014-08-29 20:10:34 -04:00
2e200ffbf0
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
...
Conflicts:
config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
875b39fb5f
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
2014-08-29 19:56:39 -04:00
cb45d5fa25
Merge pull request #2724 from cpradio/key-binding-reply-new-topic
...
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
d74f94afa1
Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
...
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
68e807f791
UX: Add keyboard binding for reply as new topic
2014-08-29 19:14:42 -04:00
bc07bc4819
Remove incoming/updated topics logic (not sure how that got in here, but it is causing a conflict)
2014-08-29 18:19:06 -04:00
1291e94c78
Merge pull request #2715 from cpradio/master
...
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
6dcde9ccc3
FIX: Navigating to None was not working
2014-08-29 15:51:28 -04:00
9062719480
Merge pull request #2720 from techAPJ/patch-3
...
FIX: do not redirect topic for JSON request
2014-08-29 13:59:45 -04:00
926e45d030
SECURITY: User action route was returning too much data
2014-08-29 13:46:50 -04:00
84d0b599a4
FIX: do not redirect topic for JSON request
2014-08-29 23:09:02 +05:30
16c9f073b5
FIX: Back button breaks translation of incoming stuff
2014-08-29 12:53:06 -04:00
ec42b61a4d
FIX: suspended users cannot be trust level 3
2014-08-29 12:33:34 -04:00
8033972536
UX: Add keyboard bidning for incoming/updated topics
...
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
5ca96e741d
UX: Add keyboard bidning for incoming/updated topics
2014-08-29 09:44:26 -04:00
096bc0c0ae
Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
...
Conflicts:
app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cde64580b1
Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding
2014-08-29 09:35:38 -04:00
3f085c3fd3
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 09:22:47 -04:00
ede9d1e057
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 08:46:35 -04:00
9e72b97a75
Corrected an issue with using the same ID for the header/footer of the buttons
2014-08-29 08:33:45 -04:00
e4ce995369
FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu
2014-08-29 08:11:23 -04:00
ed8d828ff1
FIX: Added keyboard bindings for dismiss buttons
2014-08-29 08:04:57 -04:00
fd6dd88afb
FIX: dual modal when deleting spammer in the flag modal
2014-08-29 13:05:51 +02:00
521cb6bd0d
FIX: dual modal when selecting 'delete spammer' in flags section
2014-08-29 12:54:24 +02:00
8bda8a2235
Revert "UX: stop displaying "user deleted, OK" dialog"
...
This reverts commit 36405287b4
2014-08-29 03:49:00 -07:00
36405287b4
UX: stop displaying "user deleted, OK" dialog
2014-08-29 03:34:23 -07:00
3396e6fea3
Centralize MessageBus post updates
...
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
Sam
cpradio
Jeff Atwood
Arpit Jalan
riking
Kamil Bielawski
Neil Lalonde
Robin Ward
Régis Hanol