0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
a7bc1ecbae
FEATURE: Add support for Unicode usernames and group names
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
81c87df18a
FIX: don't raise an error on integer usernames
2018-09-10 22:17:56 +05:30
bb0fa5abbc
FIX: suggested username should not be more than setting max_username_length
2017-03-29 18:19:28 +05:30
30909ec54e
Add support for username regex.
2017-03-02 13:53:45 +02:00
c4ec1d0fcf
FIX: Don't suggest invalid username
2016-02-21 23:28:57 +01:00
0916007d01
Fix the build.
2016-01-27 16:04:11 +08:00
0337964759
a bit better email name inference
2016-01-26 16:39:02 -08:00
c2c01cdb5d
FIX: username suggester to account for the more relaxed username rules ( closes #3907 )
2016-01-20 15:37:34 +01:00
3083657358
FEATURE: better email in support
...
FEATURE: new incoming_email model
FEATURE: infinite scrolling in emails admin
FEATURE: new 'emails:import' rake task
2016-01-19 00:57:55 +01:00
d73d4d4769
FIX: UserNameSuggester should not suggest usernames with a sequence of 2 or more special chars
2015-09-11 16:53:26 +05:30
d80ed94608
more username cycling avoidance
2015-03-27 10:10:53 +11:00
7aaf718cf3
update bbcode dialect and fix vBulletin importer
2014-08-25 10:48:29 +02:00
d3f1eb395d
Updated import for TypePad
2014-03-19 15:02:49 -04:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
Sam Saffron
Gerhard Schlager
Rishabh Nambiar
Arpit Jalan
Bianca Nenciu
Guo Xiang Tan
Jeff Atwood
Régis Hanol
Robin Ward
Juan de Dios Herrero