d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
434035f167
FIX: Link post to uploads in `PostCreator`.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
6aee22b88f
FIX: Onebox images are not downloaded locally without css class
2018-08-01 02:51:02 +05:30
806f0ca19d
FIX: URL with params for svg images should not be light boxed.
2018-06-20 10:47:14 +08:00
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
c18b86d9b2
UX: Don't add light box for SVG images.
2018-06-18 17:11:06 +08:00
dc61eaad37
FEATURE: new 'min ratio to crop' site setting
2018-06-05 17:13:00 +02:00
c91071bb2a
FIX: don't 💥 when 'FastImage.size' has trouble with SSL
2018-05-26 00:55:19 +02:00
b75b6de982
FIX: respect nofollow settings for onebox links
2018-03-26 18:21:16 +05:30
17584bca5e
UX: wrap full-size Twitter onebox images in aspect-ratio
2018-03-23 18:25:04 +05:30
33c1aeb2ac
UX: wrap instagram images with aspect ratio
2018-03-22 21:35:10 +05:30
31a0c4a9be
FEATURE: Add `quote-modified` class if a quote has been modified
2018-03-13 13:41:06 -04:00
f028ffaf29
SECURITY: correct local onebox category checks
...
Also removes ugly "source_topic_id" from cooked posts
Patch was authored by @zogstrip
Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
7d2283167a
UX: only crops images taller than 18:9 instead of 16:9
2018-01-31 22:31:16 +01:00
7fea15ca4d
FIX: rescue login required / broken images
2018-01-11 22:18:56 +05:30
b3b55e18d1
UX: stop warping tiny onebox images
2017-11-28 12:32:35 +11:00
1f3e9a4350
FIX: Should skip the loop if the image src is blank
2017-11-27 13:41:28 +05:30
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
5c11104f9f
FIX: Duplicate a tag if image url is same to href
2017-11-15 17:36:48 +05:30
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
23baaa5dcc
FIX: don't crop iPhone X screenshots
2017-11-14 20:37:27 +01:00
ed0751f288
always double check there is a class first
2017-11-13 16:06:18 +11:00
3ac7d041ae
UX: generic onebox treats all square images as avatars and renders them smaller
2017-11-13 11:21:19 +11:00
fc7dca58fe
UX: oneboxes with avatars now display consistently
...
Onebox avatar size is reduced to 60px
Also fixes regression with some oneboxes not cooking after post
2017-11-08 11:50:01 +11:00
2792c3c80e
fix typo
2017-11-01 15:51:17 +05:30
f5cc28d740
UX: correct regression with twitter onebox
2017-11-01 16:42:56 +11:00
9197feefb8
UX: onebox images no longer cause jiggle
...
This stops pages from "jiggling" while oneboxes download.
see: http://cssmojo.com/aspect-ratio-using-custom-properties-and-calc/
2017-10-31 13:50:58 +11:00
17e5fb0dc0
fix the build
2017-10-23 19:09:38 +02:00
80ad32094d
Small re-organization of CookedPostProcessor workflow
...
- only 'limit_size!' of oneboxed images once
- update post image at the end
- move 'enforce_nofollow' in its own method
2017-10-23 18:15:51 +02:00
04ae79896c
Exit early when the 'img is already inside an 'a' tag
2017-10-23 17:43:53 +02:00
4205c1ad2b
FIX: postprocessing ignored cook method
2017-10-20 10:26:45 +02:00
cbdfc85466
FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd)
2017-10-18 23:54:36 +02:00
65dc47adb4
FIX: prevent infinite 'pull_hotlinked_images' jobs when a oneboxed image has a different scheme
2017-10-18 01:50:23 +02:00
646c6eb7cd
FEATURE: add :before_post_process_cooked hook
...
Also reduce amount of image downloading
2017-10-17 16:22:54 +11:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
4a5907b116
Merge branch 'master' into search_posts_with_images
2017-07-31 10:44:41 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
ea0e90b2b0
Merge branch 'master' into search_posts_with_images
2017-07-26 10:15:55 -04:00
a5295591b8
FEATURE: post_process_cooked event
2017-06-23 14:35:46 -04:00
bf002e0873
Add extraction of image_url for oneboxed images. Fix search by images filter name.
2017-06-19 15:18:02 +02:00
d4d0aa8ca7
Minor fixes for https://github.com/discourse/discourse/pull/4845 .
2017-06-07 10:03:19 +09:00
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
009e120e13
FIX: Don't raise an error when the img attribute cannot be found
2017-05-08 15:35:31 -04:00
02bb7beaaf
FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled
2017-02-07 18:06:44 +01:00
19f7beaa2c
FIX: topic links were getting dropped when post is rebaked
2017-01-30 14:55:53 +05:30
a655e4b092
ensure we allow self oneboxing of login required sites
2016-11-03 22:48:32 +01:00
382803cb05
FEATURE: include post image in OpenGraph image tag
2016-10-31 15:11:33 +05:30
Guo Xiang Tan
Sam
Régis Hanol
Vinoth Kannan
Arpit Jalan
Robin Ward
Vinoth Kannan
Gerhard Schlager
Neil Lalonde
Guo Xiang Tan
Jakub Macina