a8d58c3b21
DEV: Make filterModes obsolete
...
This mixin handles the translation between old filterModes and new
filterTypes. filterModes have context information, filterTypes do not.
2019-11-21 10:51:18 +00:00
026832fb80
FIX: Mobile top topic list with a period and a category or tag
2019-11-21 10:17:24 +00:00
09579bffbe
UX: More obvious alt auth link
2019-11-20 23:44:10 -05:00
947416004f
FIX: EventTarget error
2019-11-20 15:51:42 -05:00
d7ae052efe
DEV: Don't allow `Promise` unless imported from `"rsvp"`
...
We want to make sure we are using the correct promise implementation so
let's lint out the browser version.
2019-11-20 15:24:59 -05:00
797045f5a9
DEV: Move some autocomplete input styling to SCSS ( #8381 )
2019-11-20 12:32:00 -05:00
3b5c214ac3
DEV: fix linting
2019-11-20 14:03:45 +00:00
d541183906
DEV: Make it possible to deprecate plugin outlet properties
2019-11-20 13:56:26 +00:00
9b60900b8d
FIX: More `Promise` uses that were not imported
2019-11-19 15:58:40 -05:00
6f9afde9a8
UX: Allow enter key to submit test email in admin panel
2019-11-18 15:36:06 +00:00
172832f353
DEV: Submit forms via `type=submit` button, not explicit form action ( #8368 )
2019-11-18 13:26:26 +00:00
3650c64bca
FIX: Ensure load-more considers current position ( #8357 )
...
The loadMore action was not called if user was already at the bottom
of the page.
2019-11-18 15:09:47 +02:00
352d43b101
FIX: Better handling of Group model state ( #8356 )
...
The group card and group members page were affecting each other and were
leaking members list and the query parameters which led to bad UX
experience and sub-optimal performance (client made more queries because
it was loading fewer members).
This commit refactors the group model to make it more consistent, remove
dead code, move error handling outside of model.
2019-11-18 14:59:28 +02:00
1c1c3cae85
FIX: Enter key should submit password reset form, not refresh the page
2019-11-18 11:54:41 +00:00
84107c61a7
FIX: PM glyph in user-menu should always be shown to staff
2019-11-18 17:25:07 +08:00
3bb7ad4be1
FEATURE: remove support for 'suppress_from_latest' category setting. ( #8308 )
2019-11-18 12:28:35 +05:30
79b8c08d45
DEV: give categories-separator class to HR after cateogries
...
This allows for better styling of the hamburger menu
2019-11-18 17:31:01 +11:00
a9704da34c
FIX: A pmOnly tag should link to messages ( #8361 )
...
isPrivateMessages represents that the tag list is shown in the context
of private messages and pmOnly represents that the tag is used only in
private messages.
2019-11-18 16:44:08 +11:00
102909edb3
FEATURE: Add support for secure media ( #7888 )
...
This PR introduces a new secure media setting. When enabled, it prevent unathorized access to media uploads (files of type image, video and audio). When the `login_required` setting is enabled, then all media uploads will be protected from unauthorized (anonymous) access. When `login_required`is disabled, only media in private messages will be protected from unauthorized access.
A few notes:
- the `prevent_anons_from_downloading_files` setting no longer applies to audio and video uploads
- the `secure_media` setting can only be enabled if S3 uploads are already enabled and configured
- upload records have a new column, `secure`, which is a boolean `true/false` of the upload's secure status
- when creating a public post with an upload that has already been uploaded and is marked as secure, the post creator will raise an error
- when enabling or disabling the setting on a site with existing uploads, the rake task `uploads:ensure_correct_acl` should be used to update all uploads' secure status and their ACL on S3
2019-11-18 11:25:42 +10:00
56b19ba740
UX: instead of total user count display only the count of users going to be affected.
...
edec922803
2019-11-18 00:09:38 +05:30
4cf3c9cccb
FEATURE: Filter reviewables by date range ( #8354 )
2019-11-15 15:29:59 -03:00
6e74350f18
Fix Prettier again
...
Not sure how I missed a few files in the last commit
2019-11-15 10:52:06 -05:00
cc8baa1a7c
Fix Prettier using correct version (1.19.1)
2019-11-15 10:34:26 -05:00
676a1c8749
FIX: Use this.content.category instead of this.category on navigation-item
...
this.category isn't always available.
2019-11-15 13:47:55 +00:00
337fdccfeb
DEV: Make context available to ExtraNavItems
...
This context is available to other NavItems so this makes things more
consistent.
2019-11-15 13:46:49 +00:00
59ee89f0b7
UX: Adds +n indicator in PM topic list ( #8353 )
...
Shows the number of additional PM recipients in list when there are more than 5.
2019-11-14 14:14:23 -05:00
d4b7c028fa
REFACTOR: Move upload utilities to their own file
2019-11-14 12:51:08 -05:00
f175afa0d9
FIX: Revert mobile jump to last post behaviour
...
Disables jumping to bottom of the page (added in 87f0b56
2019-11-14 11:15:11 -05:00
0bb6b64747
DEV: Run prettier
2019-11-14 11:01:22 +00:00
7b63c92f47
DEV: Remove path building indirection
...
Tags are now handled just like other context information.
2019-11-14 10:47:14 +00:00
126b9bd16d
FIX: Tag topic lists should pass on noSubcategories when building the top menu
2019-11-14 10:40:14 +00:00
a1cf0b88a8
DEV: Make NavItem.fromText take a filterType instead of a URL
...
This is step one of removing filterMode URLs entirely.
2019-11-14 09:43:15 +00:00
03efbad932
DEV: lint files
2019-11-14 11:52:29 +11:00
e7226a8c84
FEATURE: Allow scoping search to tag ( #8345 )
...
* When viewing a tag, the search widget will now show a checkbox to scope the search by tag, which will limit search results to that tag on desktop and mobile
2019-11-14 10:40:26 +10:00
6e1fe22a9d
FEATURE: Dismiss new per category ( #8330 )
...
Ability to dismiss new topics per category.
2019-11-14 11:16:13 +11:00
bc2067898e
FIX: Missing User objects in Utilities
2019-11-13 15:55:32 -05:00
f5ed0dc2e6
FIX: Failing tests
2019-11-13 15:34:30 -05:00
4843414de6
WIP - set Discourse.currentUser
2019-11-13 15:34:30 -05:00
38cc1962e7
WIP - discourse/models/user not defined
2019-11-13 15:34:30 -05:00
f9894aec97
DEV: Remove Discourse.User and import instead
2019-11-13 15:34:30 -05:00
3c5df82590
DEV: Remove Discourse.Site in favor of import ( #8344 )
...
* DEV: Remove Discourse.Site in favor of importing Site
* Ran prettier
2019-11-13 12:13:47 -05:00
d2b3ac1282
FIX: Missing braces
2019-11-13 12:04:40 -05:00
f518065654
FIX: computed is part of `@ember/object` not `@ember/object/computed`
2019-11-13 11:58:09 -05:00
e98d94f17f
DEV: Commas in top_menu items are no longer used
...
According to eviltrout, commas and pipes were the delimiters of a
Discourse specific microformat, but this is no longer the case and
hasn't been for some time.
2019-11-13 16:21:34 +00:00
d2d846a88e
DEV: prevents input/change events to cause a full rerender ( #8339 )
...
Code should decide when to do something with the event value, and maybe cause a re-rerender but it shouldn't be automatic. This is currently a gigantic waste of resources.
2019-11-13 15:49:01 +01:00
a7dd31496e
DEV: Defer creation of extraNavItems until they are required
...
This also means that each list view gets a fresh set of ExtraNavItems.
2019-11-13 14:04:37 +00:00
e00ec22582
DEV: Remove extraneous intermediates
2019-11-13 14:03:47 +00:00
13c5381027
DEV: Don't return navigation item from addNavigationBarItem
...
No plugin or theme that I could find used the return value. Not
providing this to plugins affords us leeway to change the internals.
2019-11-13 13:07:09 +00:00
58b5d1434b
FIX: Allow forceActive without a customHref
2019-11-13 12:17:57 +00:00
60e804ad5c
DEV: No need to use call to call these callbacks
...
This is safe because addNavigationBarItem decorates these callbacks,
throwing away the context.
2019-11-13 11:50:40 +00:00
e4df3792f6
DEV: provides a way to hook into createWidget constructor ( #8340 )
2019-11-13 09:29:12 +01:00
38a18b7aa0
DEV: call destroy() on widget when glue is cleaned up ( #8338 )
2019-11-13 09:28:43 +01:00
3b36326cb7
Add plugin outlet after flagged post bodies
2019-11-12 17:47:56 -08:00
1c179177e7
REFACTOR: Attach resize controls to images from the markdown pipeline ( #8314 )
2019-11-12 17:32:37 -03:00
4422d9a4bf
DEV: Provide a nicer error when JSON is malformed
...
This is very useful for development. It will give a much nicer error if
the JSON that comes back from the server is missing a required key.
2019-11-12 13:04:52 -05:00
c9bd463e9d
DEV: Let is not supported, use var instead
2019-11-12 14:58:16 -03:00
213ebc3b32
DEV: Deprecation warning for aliased module usage ( #8341 )
2019-11-12 10:20:14 -06:00
cf4356cd81
UX: Do not add leading/trailing spaces when copying API key in Firefox
...
If there is any other whitespace in the container, then Firefox will add a leading/trailing space when double clicking the key. This commit wraps the key in a div with no whitespace, to work around the problem.
2019-11-12 16:00:57 +00:00
f49494b0bf
REFACTOR: Remove a few `Discourse.Site` globals
2019-11-12 10:53:22 -05:00
afadf361b3
REFACTOR: `idMap` should be a private API
2019-11-12 10:53:22 -05:00
7f651b9666
REFACTOR: Deprecate `Discourse.Site` and `Discourse.User`
2019-11-12 10:53:22 -05:00
3dd2f2f701
DEV: Remove RSS feed polling in favor of plugin ( #8233 )
2019-11-12 09:49:02 -06:00
241d9a3034
FIX: Topic lists filtered by tag and a specified filter don't work
...
This was a regression caused by 59241df2
2019-11-12 11:34:52 +00:00
9b841ea83f
DEV: Run prettier
2019-11-12 11:49:31 +01:00
5d4b240453
DEV: Provide radix argument to parseInt ( #8281 )
...
* DEV: Provide radix 10 argument to parseInt
* DEV: Provide radix 16 argument to parseInt
* DEV: Remove unnecessary parseInt calls
* Fix year formatting
parseInt was used here to convert decimals to ints
2019-11-12 10:47:42 +01:00
34665d3f96
FIX: In case `@ember/object` hasn't been loaded yet
2019-11-11 15:56:58 -05:00
e39d89ecd9
REFACTOR: Remove `InputValidation` which was simply an `Ember.Object`
2019-11-11 15:48:56 -05:00
211410c3b9
DEV: It doesn't make sense for a filterMode to be weekly, quarterly, etc
2019-11-11 18:46:27 +00:00
da04c602ba
REFACTOR: Remove `debounce` to `discourseDebounce`
...
Otherwise it can be confused with the ember debounce
2019-11-11 13:34:01 -05:00
e8dae447bd
REFACTOR: Remove `discourse/lib/throttle`
2019-11-11 13:21:03 -05:00
4ddb69e9c6
DEV: Removed needless indirection
...
An artifact of when tagging was a plugin no doubt.
2019-11-11 17:59:26 +00:00
e79cec9fc7
DEV: Remove handling of category top menu items
...
Support for these kinds of navigation items was dropped in 88f52514
2019-11-11 17:36:29 +00:00
55bdd9e6a2
FIX: Do not skip some emails in user search ( #8317 )
...
It used to skip the email addresses containing the plus sign.
2019-11-11 18:42:45 +02:00
20266325fc
combined import definitions in discourse-loader
2019-11-11 10:37:21 -05:00
1bbb9b30fc
DEV: Import isNone for @ember/utils
2019-11-11 10:37:21 -05:00
0c8ae1e849
FIX: More missing RSVP imports
2019-11-11 09:25:33 -05:00
2a6713c2ba
FIX: Was using a native browser Promise instead of RSVP
2019-11-11 09:23:26 -05:00
920f8c6d75
REFACTOR: Remove `Discourse.Route` in lieu of importing
2019-11-08 15:18:13 -05:00
c0e105fc8c
FIX: Return a deprecation for `Discourse.Session`
2019-11-08 14:55:36 -05:00
bd92fdeb4d
FIX: Add deprecation for Discourse.NavItem in case themes are using it
2019-11-08 14:14:51 -05:00
f03edb36be
REFACTOR: Remove `Discourse.Model`
2019-11-08 14:13:35 -05:00
291572a97a
REFACTOR: Remove `Discourse.Session` constants
2019-11-08 13:46:50 -05:00
7ac2a55588
REFACTOR: Remove `Discourse.Category` constants
2019-11-08 13:31:00 -05:00
e51efce356
DEV: Remove all instances of Ember.computed ( #8324 )
2019-11-08 12:28:11 -06:00
7e44065bcb
REFACTOR: Migrate `Discourse.Post` to imports
2019-11-08 13:13:13 -05:00
932c169d46
REFACTOR: Remove Discourse.NavItem constants
2019-11-08 12:56:13 -05:00
779ee3558d
REFACTOR: Remove `Discourse.UserAction` from code
2019-11-08 12:52:39 -05:00
562acb21ca
FIX: Ran prettier to fix build ( #8323 )
2019-11-08 10:50:03 -06:00
7f3812b90a
DEV: Removed all Ember.computed. in select-kit ( #8322 )
2019-11-08 10:32:20 -06:00
47e3e56905
FIX: Alias modules that are required AND imported ( #8315 )
2019-11-08 09:48:02 -06:00
5a016b7eb0
DEV: Adds a new plugin outles to add custom icons on the admin users list ( #8277 )
2019-11-08 10:32:57 -03:00
edec922803
FIX: use 'about.json' endpoint instead of using ember model to get the data.
2019-11-08 14:17:51 +05:30
ba5b78a348
FEATURE: support to mute all categories by default. ( #8295 )
...
Instead of enabling `suppress_from_latest` setting on many categories now we can enable `mute_all_categories_by_default` site setting. Then users should opt-in to categories for them to appear in the latest and categories pages.
2019-11-08 08:28:11 +05:30
99b0697bd9
FIX: Correct display of last used date in API key details UI
2019-11-07 23:41:43 +00:00
6275c05c0d
DEV: Move computed to discourseComputed ( #8312 )
2019-11-07 15:38:28 -06:00
d74546f50e
REFACTOR: Remove `Discourse.Topic` constant
2019-11-07 15:46:58 -05:00
9d457fa51f
REFACTOR: Remove `Discourse.TrustLevel` constant
2019-11-07 15:26:26 -05:00
f8d69253e8
FIX: Prettier to fix build ( #8311 )
2019-11-07 12:07:08 -06:00
9ffdbf912f
DEV: Import ember ENV instead of Ember.testing ( #8305 )
2019-11-07 11:20:35 -06:00
063a1d4077
Revert "FIX: The internal position on the topic timeline is a scroll position"
...
This reverts commit 9c1a713c6e
2019-11-07 11:04:39 +00:00
9c1a713c6e
FIX: The internal position on the topic timeline is a scroll position
...
... instead of a post index. This is so that updatePosition is called
when switching between the last two scroll positions.
2019-11-07 10:10:17 +00:00
7d25d65ccb
DEV: adds support for input/change events on widgets ( #8309 )
2019-11-07 10:15:05 +01:00
cf0f2c70cd
FIX: regression not showing excerpts in mobile timeline
...
I think this is a result of: 87f0b56191
2019-11-07 16:10:31 +11:00
6c9af6d81e
FIX: Too much blank padding in video oneboxes
2019-11-06 15:07:51 -05:00
9ef97ff44f
fix for 1aa96a5
2019-11-06 14:16:23 -05:00
b066a4128d
Adding a text-overflow: ellipsis; mixin and related cleanup
2019-11-06 14:00:29 -05:00
f611aa6ada
FIX: Correct translation key for api key revoke button
2019-11-06 16:13:12 +00:00
e3b7f07916
DEV: Run prettier
2019-11-05 22:30:23 +00:00
59241df251
FIX: Display tags topic list correctly when none is selected for subcategories
2019-11-05 20:12:36 +00:00
ca14e3d83c
FIX: Build with prettier for imports ( #8298 )
2019-11-05 13:32:43 -06:00
edc135d9c5
DEV: Import set, setProperties, helper, and string functions ( #8297 )
2019-11-05 12:43:49 -06:00
61b1f9c36b
FEATURE: Load translation overrides without JS `eval`
2019-11-05 19:16:38 +01:00
014f19b6ea
DEV: Import Promise from rsvp ( #8296 )
2019-11-05 10:37:32 -06:00
52c5cf33f8
FEATURE: Overhaul of admin API key system ( #8284 )
...
- Allow revoking keys without deleting them
- Auto-revoke keys after a period of no use (default 6 months)
- Allow multiple keys per user
- Allow attaching a description to each key, for easier auditing
- Log changes to keys in the staff action log
- Move all key management to one place, and improve the UI
2019-11-05 14:10:23 +00:00
c008443f2d
FIX: filterQueryParams mutates state that is essentially global
...
Let's prevent it from doing this by duplicating the input first.
2019-11-05 11:47:29 +00:00
8e419a772f
FIX: improve regex used for image sizing controls ( #8291 )
2019-11-05 18:40:02 +08:00
5502128105
DEV: Remove uneeded comment
...
followup to 4b43816b
2019-11-05 16:26:32 +11:00
2b3e248927
FIX: on mobile setting active on navItem would not work
...
navigation bar would not have the current nav item selected when it overrode
2019-11-05 16:15:43 +11:00
4b43816bb6
FIX: Skip composer blur event when switching apps in iOS
2019-11-04 22:16:31 -05:00
fa56ba89a5
Import getProperties from @ember/object
2019-11-04 14:24:30 -05:00
d43e7354ec
DEV: Convert <button> tags to {{d-button}} components ( #8224 )
...
* DEV: Convert <button> tags to {{d-button}}
* Fixes
2019-11-04 11:23:54 +01:00
f66e5d38d3
FEATURE: add an "init" method for extra nav items
...
This allows us to trigger special initialization code prior to adding an
extra nav item to the navigation menu.
2019-11-04 19:07:31 +11:00
7eb26e5bbb
FIX: ensure menu not too tall on desktop only
...
Followup to af65809e
2019-11-03 18:47:53 -05:00
8d69944b4e
FIX: update action should be in setting-component mixin ( #8287 )
...
This was causing an exception on some component (eg: value-list in a theme-component setting) which couldn't find an action named update.
2019-11-02 18:24:41 +05:30
af65809ec6
FIX: ensures menu panel is not too tall for screen ( #8248 )
2019-11-02 12:01:24 +01:00
29ee467a04
FIX: do not add personal message link in user menu if they are disabled
2019-11-01 22:40:41 -07:00
66e0bdc053
FEATURE: Create New Topic button on embed with params ( #8280 )
...
* FEATURE: Create New Topic button on embed with params
2019-11-01 14:19:10 -05:00
0e2261c414
FIX: Linting
2019-11-01 13:57:22 -04:00
dceb72bc69
FIX: Move `makeArray` to discourse-common
2019-11-01 13:50:15 -04:00
6300ac699a
FIX: Missing `run` import
2019-11-01 13:50:15 -04:00
75b751c108
REFACTOR: An ember.get we missed
2019-11-01 13:50:15 -04:00
785ebb674d
REFACTOR: Split off raw handlebars helpers from compiler
...
This allows us to compile without Ember being present
2019-11-01 13:50:15 -04:00
640a05c4ee
REFACTOR: Remove `Ember.get`
2019-11-01 13:50:15 -04:00
89f602f66b
REFACTOR: `Ember.makeArray` was removed from the public API
2019-11-01 13:50:15 -04:00
90f934a660
REFACTOR: Use a module for `Ember.isEmpty`
2019-11-01 13:50:15 -04:00
72aa26c8c5
FEATURE: New site settings for default tags in user preferences. ( #8283 )
2019-11-01 12:40:13 +05:30
9fb09d147d
DEV: allow positioning of nav items and allow selection
...
Previously we could not place extra nav items in a particular order.
This change introduces a new `before` attribute to addNavigationBarItem
with this attribute we can place a nav item before "top" or any other place.
Additionally this allows navigation items to force active state. In some
cases we may want an items that is simply a "filter" on latest using `?query_params`
when we do that we can "force" the filter active.
A concrete example is the assign plugin that adds a nav item for
Unassigned => `/c/cat-slug/l/latest?assigned=nobody&status=open`
If we did not force then latest would be selected even though the filter
is clicked.
2019-11-01 13:52:25 +11:00
b93f253486
FIX: Hide muted subcategories for mobile ( #8273 )
...
That bug was mentioned in [meta](https://meta.discourse.org/t/muting-categories-hides-them-muting-subcategories-should-too/131316 )
Fix was done in that PR https://github.com/discourse/discourse/pull/8239
however I forgot about mobile template
2019-11-01 08:22:21 +11:00
5a0d30105f
FIX: Enter key on forms submits rather than refresh ( #8274 )
...
Both for forgot password form, and confirm password for second factor
2019-10-31 15:44:20 -05:00
d777844ed6
FEATURE: categories can require topics have a tag from a tag group
...
In a category's settings, the Tags tab has two new fields to
specify the number of tags that must be added to a topic
from a tag group. When creating a new topic, an error will be
shown to the user if the requirement isn't met.
2019-10-31 16:10:19 -04:00
091d058ff2
UX: widen tag group name input field and add placeholder text
2019-10-31 16:10:19 -04:00
e1679d744c
DEV: Add plugin outlets to advanced search options
...
Also adds classes for the filter containers, allowing for more granular styling.
2019-10-31 16:06:39 -04:00
5efa95b5f8
FIX: make notification consent banner usable via keyboard and screenreader ( #8255 )
...
* update d-button to support btn-link class
* add display attribute to d-button rather than computing on class
2019-10-31 15:36:24 -04:00
11f50eee3b
DEV: Remove pretty_text import hack & still work server-side ( #8266 )
...
* FIX: move attachment_css_class constant out of upload-short-url for discourse-markdown-it
* Use setTimeout instead of ember later
* WIP. Not sure if this worked.
* oneboxer cache in separate file
* Reset onebox cache still
* set functions for oneboxers cache
2019-10-31 11:54:46 -05:00
c5e67726fd
FIX: under some conditions draft would say it was saving when not
...
This is a major change to draft internals. Previously there were quite a
few cases where the draft system would say "draft saved", when in fact
we just skipped saving.
This commit ensures the draft system deals with draft ownership handover in
a predictable way.
For example:
- Window 1 editing draft
- Window 2 editing same draft at the same time
Previously we would allow window 1 and 2 to just fight on the same draft
each window overwriting the same draft over an over.
This commit introduces an ownership concept where either window 1 or 2 win
and user is prompted on the loser window to reload screen to correct the issue
This also corrects edge cases where a user could have multiple browser windows
open and posts in 1 window, later to post in the second window. Previously
drafts would break in the second window, this corrects it.
2019-10-31 17:15:58 +11:00
d355506123
FEATURE: Option to update user preferences of all users when default site setting changed.
2019-10-31 06:48:03 +05:30
7a264217f2
FIX: default user preferenced categories are not updating in admin site setting UI.
2019-10-31 05:45:57 +05:30
13cca3eaa0
DEV: run files through prettier
...
2ae21e9
2019-10-31 10:18:29 +11:00
02a886ce13
DEV: Import `Ember.on` from @ember/object/evented ( #8268 )
...
* DEV: Import `Ember.on` from @ember/object/evented
* Dont import "on" outsie of the js or admin app
* Fixed error when resolving merge conflicts
2019-10-30 17:05:27 -05:00
2ae21e9c35
DEV: Import every instance of Ember.computed function ( #8267 )
...
* DEV: Import every instance of Ember.computed function
* export default for Ember.computed
2019-10-30 15:28:29 -05:00
Daniel Waterworth
Kris
Robin Ward
Penar Musaraj
David Taylor
Dan Ungureanu
Joe
Vinoth Kannan
Sam Saffron
Roman Rizzi
Martin Brennan
Krzysztof Kotlarek
Mark VanLandingham
Mark VanLandingham
Joffrey JAFFEUX
Jeff Wong
Jarek Radosz
Gerhard Schlager
Neil Lalonde
Leo McArdle