df56ab172a
DEV: Remove remaining hardcoded ids ( #18735 )
2022-10-25 15:29:09 +08:00
b082f459c9
FEATURE: Limit maximum recipients for group emails ( #17971 )
...
New maximum_recipients_per_new_group_email site setting can be used to
prevent spam group emails with many recipients.
2022-08-18 18:18:58 +03:00
3eaac56797
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
91b6b5eee7
DEV: Don’t use `change { … }.by(0)` in specs
2022-07-26 10:34:15 +02:00
3f0e767106
DEV: Use `FakeLogger` in RequestTracker specs ( #16640 )
...
`TestLogger` was responsible for some flaky specs runs:
```
Error during failsafe response: undefined method `debug' for #<TestLogger:0x0000556c4b942cf0 @warnings=1>
Did you mean? debugger
```
This commit also cleans up other uses of `FakeLogger`
2022-05-05 09:53:54 +08:00
567be512c9
FIX: save email rejection error class names for incoming email logs ( #16095 )
2022-03-03 18:58:13 +05:30
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
45cc16098d
DEV: Move spec/components to spec/lib ( #15987 )
...
Lib specs were inexplicably split into two directories (`lib` and `components`)
This moves them all into `lib`.
2022-02-18 19:41:54 +01:00
Jarek Radosz
Bianca Nenciu
Loïc Guitaut
Phil Pirozhkov
Arpit Jalan
David Taylor