0a5a6dfded
DEV: stop mutating inputs as a side effect
...
We had quite a few cases in core where inputs are being mutated as a side
effect of calling a method.
This handles all the cases where specs caught this.
Mutating inputs makes code harder to reason about. Eg:
```
frog = "frog"
jump(frog)
puts frog
"fly" # ?????
```
This commit is part of a followup commit that adds # frozen_string_literal
to all our specs.
2019-04-30 10:25:53 +10:00
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
74ed2e82ac
UX: Wiggle invalid form elements. Don't allow a site title of Discourse
2016-09-22 09:52:19 -04:00
29cf47cfb2
Track steps the user has completed, nag them to finish it.
2016-09-22 09:52:19 -04:00
35b767f6af
Company Name Step which updates the TOS
2016-09-22 09:52:19 -04:00
28b6c300a0
Clean up wizard updater API for better plugin use
2016-09-22 09:52:19 -04:00
e3640ee5f6
Privacy Step
2016-09-22 09:52:19 -04:00
af83c8dc14
Upload Logos Step
2016-09-22 09:52:19 -04:00
c94e6f1b96
Add locale step
2016-09-22 09:52:19 -04:00
3f6e3b9aff
Wizard - Color Scheme Step
2016-09-22 09:52:19 -04:00
9f12b571ef
Wizard: Server Side Validation + Finished Step
2016-09-22 09:52:19 -04:00
3a4615c205
Wizard: Step 1
2016-09-22 09:48:58 -04:00
Sam Saffron
Guo Xiang Tan
Robin Ward