Sam Saffron
8e5edae093
FEATURE: unconditionally skip indexing on search controller
...
There are absolutely no actions in search that need indexing
Also no point adding this header on non get requests
2020-02-28 09:21:31 +11:00
Mark VanLandingham
f358114361
FIX: Prettier on iframed-html component ( #9062 )
2020-02-27 11:56:13 -06:00
Mark VanLandingham
337b823ec6
Merge pull request from GHSA-vw39-6w7q-gfx5
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-02-27 11:47:15 -06:00
Roman Rizzi
87f15f9ed6
FIX: When appending tags to restricted category posts, we need to pass the category id, or it won't work. ( #9020 )
2020-02-27 14:10:14 -03:00
Joffrey JAFFEUX
c9b53d5647
FIX: prevnets loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:30 +01:00
Joffrey JAFFEUX
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
romanrizzi
4673f31c75
FIX: Bulk badge awards should work even if the CSV has nil values
2020-02-27 11:08:24 -03:00
Dan Ungureanu
d461772661
FIX: Skip poll tutorial if user cannot create polls ( #9058 )
2020-02-27 16:01:59 +02:00
adam j hartz
0af2f5db64
UX: Differentiate Between PMs and Topics in Search Results ( #8933 )
...
PMs will now display an envelope icon next to the topic title in search results. This is especially useful when searching using `in:all`.
Co-authored-by: adam j hartz <hz@mit.edu>
2020-02-27 13:25:32 +00:00
Joffrey JAFFEUX
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
Dan Ungureanu
60908a94ec
FIX: Skip 'invited' small action if user is in an invited group ( #9056 )
...
Inviting a user that is already invited through a group used to generate
a small action and a notification. This commit skips that small action.
2020-02-27 14:45:20 +02:00
David Taylor
dfe11321d8
FIX: Polyfill Promise for IE11 ( #9057 )
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2020-02-27 12:13:07 +00:00
Joffrey JAFFEUX
a4fc6ccc12
UX: prevents jumpyness when displaying poll voters ( #9054 )
2020-02-27 11:09:54 +01:00
Vinoth Kannan
acf337d583
FEATURE: auto archive group message if topic is closed. ( #9046 )
...
Co-Authored-By: Régis Hanol <regis@hanol.fr>
2020-02-27 11:09:37 +05:30
Vinoth Kannan
5774107a2d
FIX: downloaded image URLs incorrectly replaced in post raw. ( #9014 )
...
Previously, while replacing the downloaded image URL `http://wiki.mozilla.org/images/2/2e/Longcat1.png ` similar non-image URL `http://wiki.mozilla.org/images/2 ` was replaced wrongly.
2020-02-27 10:22:55 +05:30
Neil Lalonde
9f528f0ec2
Version bump to v2.5.0.beta1
2020-02-26 16:56:11 -05:00
dependabot-preview[bot]
87b2871074
Build(deps): Bump logster from 2.6.3 to 2.7.0 ( #9050 )
...
This includes a new feature that allows you to control the length of log messages via `Logster.config.maximum_message_length`. More details at: e5c4fc0b6e
Bumps [logster](https://github.com/discourse/logster ) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.6.3...v2.7.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-26 22:08:39 +03:00
Dan Ungureanu
3568f296a3
FIX: Another attempt at fixing reviewable claiming
...
Follow-up to 9314751e5c
.
2020-02-26 10:46:10 +02:00
Dan Ungureanu
9314751e5c
FIX: Claim reviewable button did not show up for all topics
...
Follow-up to 514c22e64b
.
2020-02-26 10:36:35 +02:00
Robin Ward
603c56f71c
FIX: Lefthook was not excluding enough JS
2020-02-25 17:28:53 -05:00
Joffrey JAFFEUX
baba1cc02e
FIX: ensures destroying a user with security keys doesn't fail ( #9042 )
2020-02-25 14:07:57 -05:00
David Taylor
96ac4fc072
FIX: Include `.json` suffix for email login route ( #9041 )
...
In IE11, the browser returns the cached HTML response, rather than the JSON formatted response. Adding the `.json` suffix ensures that the cache is not shared. Same root cause as b0211772
2020-02-25 18:01:33 +00:00
Neil Lalonde
b0675075f7
Update translations
2020-02-25 10:29:14 -05:00
Dan Ungureanu
514c22e64b
FIX: Make reviewable claiming work with deleted topics ( #9040 )
...
This fixes the case when the reviewed topic is deleted (for example, in
discourse-akismet).
2020-02-25 15:49:23 +02:00
Dan Ungureanu
5905930c32
FIX: Sync Ember and non-Ember layouts ( #9028 )
2020-02-25 15:31:04 +02:00
spirobel
41ee7cad0e
FIX plugin generator: mobile, desktop stylesheets registering ( #9039 )
...
After adding styles in the mobile scss they will also be applied to desktop without this change.
https://meta.discourse.org/t/registering-assets-for-mobile-and-desktop-making-site-responsive/65041/2
2020-02-25 11:43:17 +01:00
Joffrey JAFFEUX
a5c7f0c98d
UX: hides emoji picker from edit category tab topic template ( #9036 )
2020-02-25 00:49:41 +01:00
Joffrey JAFFEUX
e303b4d181
UX: hides local-date picker when used outside of main composer
2020-02-25 00:17:43 +01:00
Joffrey JAFFEUX
bd49368942
FIX: ensures topic count is correctly showing in box category badges ( #9034 )
2020-02-24 23:41:36 +01:00
Penar Musaraj
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
dependabot-preview[bot]
709772ea52
Build(deps): Bump bootsnap from 1.4.5 to 1.4.6 ( #9032 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.5...v1.4.6 )
Simple low risk dependency, only used in dev
2020-02-25 07:54:24 +11:00
Justin DiRose
f35ee5e887
DEV: Improvements to SMF2 script ( #9006 )
2020-02-24 12:51:45 -06:00
dependabot-preview[bot]
fee7a4be8a
Build(deps-dev): Bump simplecov from 0.18.2 to 0.18.3 ( #9025 )
...
Bumps [simplecov](https://github.com/colszowka/simplecov ) from 0.18.2 to 0.18.3.
- [Release notes](https://github.com/colszowka/simplecov/releases )
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov/compare/v0.18.2...v0.18.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-24 13:32:38 -05:00
dependabot-preview[bot]
dedd37503e
Build(deps): Bump simplecov-html from 0.12.0 to 0.12.1 ( #9024 )
...
Bumps [simplecov-html](https://github.com/colszowka/simplecov-html ) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/colszowka/simplecov-html/releases )
- [Changelog](https://github.com/colszowka/simplecov-html/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov-html/compare/v0.12.0...v0.12.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-24 13:31:52 -05:00
Joffrey JAFFEUX
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
Kris
832a0e410a
UX: Restrict icon height in btn-small to prevent height inconsistency
2020-02-24 13:18:46 -05:00
Joffrey JAFFEUX
0ea11a9d49
FIX: ensures we don't attempt to create a new PM on an existing topic ( #9029 )
...
This fix attempts to both fix it at UI level and server side. A previous attempt related to this behavior has been made in commit: 49c750ca78
2020-02-24 08:55:12 -06:00
dependabot-preview[bot]
31f3ed8d36
Build(deps-dev): Bump ruby-prof from 1.2.0 to 1.3.0 ( #9023 )
...
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases )
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES )
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.2.0...1.3.0 )
Minor change only impacts development
2020-02-24 13:13:09 +11:00
Sam Saffron
372f6f4f22
FEATURE: limit number of notifications per user to 10,000
...
Introduces a new site setting `max_notifications_per_user`.
Out-of-the-box this is set to 10,000. If a user exceeds this number of
notifications, we will delete the oldest notifications keeping only 10,000.
To disable this safeguard set the setting to 0.
Enforcement happens weekly.
This is in place to protect the system from pathological states where a
single user has enormous amounts of notifications causing various queries
to time out. In practice nobody looks back more than a few hundred notifications.
2020-02-24 11:42:50 +11:00
Sam Saffron
f93de763b7
DOC: improve documentation of image limit site settings
...
max_image_megapixels is a hard limit
max_image_size_kb is a soft limit and images are resized to fit
2020-02-24 09:32:07 +11:00
Kris
e5bc649057
modal footer button height fix
2020-02-21 20:13:23 -05:00
Neil Lalonde
f73ed45de9
FIX: blank popular posts in summary emails due to lightbox images
...
When looking for the first paragraph with content in a post,
it was matching the lightboxed image paragraph as "<p></p>".
Fix that and other potential empty paragraphs with the
p:not(:empty) selector.
Add a new selector to find the image links in lightboxed
images as valid content for emails.
2020-02-21 16:18:38 -05:00
Joffrey JAFFEUX
69a2ad626b
FIX: ensures group automatic membership dropdown works ( #9022 )
...
This commit also fixes a deprecation warning as the previous component was overriding a computed property from the group model.
Finally a test has been added as this is the only place where we use list-setting outside of the settings, this was highly subject to regressions.
2020-02-21 22:14:24 +01:00
Kris
90e701b470
UX: Eliminate double modal scroll on long mobile create account forms
2020-02-21 16:08:19 -05:00
Kris
5b358a2ca7
Follow up padding fix to de559f3
2020-02-21 15:44:34 -05:00
Joffrey JAFFEUX
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
Dan Ungureanu
533495169e
FEATURE: Publish a message when reviewable claimer changes ( #9019 )
...
This commit ensures that all users are kept in sync and no user can claim
a topic that has been claimed already.
2020-02-21 19:11:50 +02:00
Dan Ungureanu
cf0c6d5761
FIX: Ensure web hooks are retried at most 5 times
2020-02-21 17:02:40 +02:00
Jarek Radosz
6ba326a9f4
DEV: Deprecate `ember` module imports ( #9011 )
...
Removes remaining `ember` module imports.
2020-02-21 15:56:49 +01:00
Jarek Radosz
c607870f08
DEV: Add more `@ember` imports ( #9012 )
2020-02-21 14:27:04 +01:00