Commit Graph

14485 Commits

Author SHA1 Message Date
Régis Hanol 19b7658dc3 Add 'primary_group_name' to CurrentUserSerializer 2017-08-12 04:05:16 +02:00
Neil Lalonde 9813f9f0f8 FIX: more cases of case sensitive group membership in sso 2017-08-11 18:09:29 -04:00
Robin Ward c2016e2bc6 Revert "Fix up some markup to making styling latest categories easier"
This reverts commit 2589b59f39.
2017-08-11 17:08:58 -04:00
Robin Ward 2589b59f39 Fix up some markup to making styling latest categories easier 2017-08-11 16:49:15 -04:00
Arpit Jalan 51f9c23e48 UX: add a divider line between regular user fields and custom user fields
https://meta.discourse.org/t/differentiate-user-fields-on-signup-form-better/66427/2?u=techapj
2017-08-11 17:46:40 +05:30
Bianca Nenciu 117417848e Remove like on change of ownership. (#5038) 2017-08-11 09:55:00 +02:00
Guo Xiang Tan f2539a86d0 Merge pull request #5036 from tgxworld/another_pass_at_removing_duplicated_users
FIX: Staged users were incorrectly created multiple times with same e…
2017-08-11 12:30:28 +09:00
Neil Lalonde 15a74d6d3e FIX: don't enforce newuser_spam_host_threshold on private messages 2017-08-10 17:19:08 -04:00
Robin Ward e6398bac21 Accept no arguments for `NavItem` options 2017-08-10 15:16:52 -04:00
Neil Lalonde 3c538270e4 UX: placeholder text in watched word input field 2017-08-10 11:25:17 -04:00
Régis Hanol 05a74d2534 FIX: navigation item counters weren't updating properly 2017-08-10 12:22:15 +02:00
Guo Xiang Tan 793eccf6c5 FIX: Staged users were incorrectly created multiple times with same email. 2017-08-10 18:56:15 +09:00
Guo Xiang Tan b84e87dedd FIX: Don't raise an error if URL timesout. 2017-08-10 12:58:56 +09:00
Guo Xiang Tan a849959915 Fix missing parameter. 2017-08-10 11:15:51 +09:00
Guo Xiang Tan b404a4b97c Merge pull request #5034 from tgxworld/fix_staged_primary_email
FIX: Staged users are still missing primary email.
2017-08-10 10:30:51 +09:00
Robin Ward c3051b89c0 Allow explicit hover and active buttons 2017-08-09 16:39:43 -04:00
Neil Lalonde ca1609c821 FIX: user directory didn't update stats of users with no recent activity 2017-08-09 15:57:42 -04:00
Robin Ward 53e6ccf17b Allow reloading of translation keys for plugins in development mode 2017-08-09 13:58:20 -04:00
Neil Lalonde 197944edaa UX: when staff change their email address, show a message saying an email has been sent to their current address, not their new one 2017-08-09 13:43:01 -04:00
Robin Ward 5ba3a2bd9d Allow route maps to access `site` easily 2017-08-09 11:49:18 -04:00
Guo Xiang Tan 705f75dd8c Merge pull request #5032 from xrav3nz/ux-hide-options-in-adv-search
UX: exclude irrelevant search filters for anonymous users
2017-08-09 18:21:44 +09:00
Guo Xiang Tan 90d7dd1f05 FIX: Ensure that post action moderation post uses the site's default locale.
https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld
2017-08-09 18:20:20 +09:00
Arpit Jalan e993d53260 FIX: handle missing parent category when exporting user archive
https://meta.discourse.org/t/download-my-posts-failed/67613?u=techapj
2017-08-09 14:37:21 +05:30
Arpit Jalan bf2c35aa99 FEATURE: add RSS feed for badge pages 2017-08-09 13:43:49 +05:30
Guo Xiang Tan 49c6959dfc Adjust width for membership request input field. 2017-08-09 16:05:20 +09:00
Guo Xiang Tan 898c6ba037 Merge pull request #5033 from tgxworld/reason_when_requesting_to_join_a_group
FEATURE: Force user to enter reason when requesting for group members…
2017-08-09 15:54:21 +09:00
Guo Xiang Tan a9613163b5 FEATURE: Force user to enter reason when requesting for group membership. 2017-08-09 15:45:28 +09:00
Guo Xiang Tan 0bc690ed11 FIX: Staged users are still missing primary email. 2017-08-09 12:03:49 +09:00
Neil Lalonde c4b49fbabe send args to user-preferences-nav plugin outlet 2017-08-08 17:30:10 -04:00
Kyle Zhao cea2a9fe53 UX: exclude irrelevant search filters for anonymous users
On the advanced search page, filters like "I've read", "I'm watch
-ing", etc, are irrelevant to anonymous users and should be hidden
2017-08-08 15:25:40 -04:00
Régis Hanol 15fa27a1ff Add warning when using the 'modifyClass' plugin API after it's been cached in the container 2017-08-08 20:07:35 +02:00
Arpit Jalan e36a20660d FIX: handle topics without excerpt for meta description tag 2017-08-08 22:17:05 +05:30
Régis Hanol d182f0f2d1 Add support for preloaded custom_fields on Group 2017-08-08 15:45:27 +02:00
Régis Hanol 76a217c4bc add support for classNames binding in Navigation Item 2017-08-08 15:44:31 +02:00
Robin Ward 6ecb7cdff4 UX: Support for `none` style of category badge 2017-08-07 12:49:19 -04:00
Régis Hanol 4bfb049054 Add new 'group-edit' plugin outlet 2017-08-07 18:16:54 +02:00
Régis Hanol 770efee25f Add support for disabled attribute to the d-checkbox component 2017-08-07 18:16:43 +02:00
Robin Ward 2e4b3e9b06 Don't include all html builders on client and server side 2017-08-07 11:29:35 -04:00
Régis Hanol 4c306f9f49 New 'topic:current-post-changed' application event 2017-08-07 15:56:08 +02:00
Régis Hanol 125cc356f3 FIX: don't break the site when adding a navigation item without a 'name' field 2017-08-07 10:45:35 +02:00
Régis Hanol ce7d97a9a8 move title computed property back to nav-item so it can be overriden in a plugin 2017-08-07 09:53:03 +02:00
Guo Xiang Tan f496302c2c `order` scope is ignored when using `find_each`. 2017-08-07 11:46:18 +09:00
Guo Xiang Tan 3f24ed2b3e Can't revert due to incompatibility of new site setting types.
Revert "Revert "FEATURE: Site settings defaults per locale""

This reverts commit 439fe8ba24.
2017-08-07 10:43:09 +09:00
Guo Xiang Tan 439fe8ba24 Revert "FEATURE: Site settings defaults per locale"
This reverts commit 468a8fcd20.
2017-08-07 10:31:50 +09:00
Régis Hanol 4b53fe3cc7 new 'addNavigationBarItem' plugin api 2017-08-05 02:23:35 +02:00
Régis Hanol e958500735 extract 'timeline-controls' and 'timeline-footer-controls' widgets 2017-08-05 01:22:01 +02:00
Leo McArdle a7b7fe335f FIX: allow an admin to click on blank errors (#5027)
* FIX: allow an admin to click on blank errors

* i18nlize strings

* what would a rails master do?
2017-08-04 20:04:26 +02:00
Robin Ward a3ef814245 UX: Show proper HTML for category preview in site settings 2017-08-04 13:56:27 -04:00
Robin Ward 58d452fc41 FIX: Site setting previews were not rendering 2017-08-04 13:48:02 -04:00
Régis Hanol 3c0de22bf0 FIX: wasn't able to remove a user's primary group 2017-08-04 18:13:20 +02:00
Régis Hanol 519b70ea46 FIX: always trigger the ':user_updated' event
We don't always use the UserUpdated class to update a user's record
2017-08-04 18:12:10 +02:00
Régis Hanol c26ba890bd prevent N+1 when loading custom emojis 2017-08-04 17:04:59 +02:00
Leo McArdle 99527af38a FIX: show rejected emails with unrecognized errors (#5026)
Although 407a23663d will send rejection
messages for unrecognized errors, sometimes processing the email will
raise an error which has a blank message.

This commit:

1. Shows rejected emails which have already been processed and contain
   a blank error in /admin/email/rejected

2. Replaces new blank error messages with the error type
2017-08-04 16:20:44 +02:00
Guo Xiang Tan 40fc6c429a Merge pull request #5018 from discourse/wekbit-embedded-referer
FIX: First load of embed comments would always fail on WebKit
2017-08-04 14:12:26 +09:00
Robin Ward 2589b17cb7 Add wrapper divs with classes to the topic footer button area 2017-08-03 15:59:26 -04:00
Robin Ward 82230a1830 Support forcing badge styles 2017-08-03 14:55:36 -04:00
Arpit Jalan 2d95b9dfbf FIX: prevent Cloudflare from obfuscating emails
https://support.cloudflare.com/hc/en-us/articles/200170016-What-is-Email-Address-Obfuscation-
2017-08-03 15:06:13 +05:30
Guo Xiang Tan a47e297508 Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
Robin Ward edc7fae0b0 FIX: The ellipsis should be a `flat-button` 2017-08-02 17:30:40 -04:00
Sam 5942ad83c0 Skip inline onebox for domain only 2017-08-02 17:27:58 -04:00
Rafael dos Santos Silva 57a214e920 FIX: First load of embed comments would always fail on WebKit 2017-08-02 17:43:31 -03:00
Sam 902be91a5a FEATURE: CTRL+/ to trigger search even from composer 2017-08-02 16:26:03 -04:00
Sam a4e1920604 FIX: inline oneboxer not applying to lists 2017-08-02 16:10:08 -04:00
Erick Guan 468a8fcd20 FEATURE: Site settings defaults per locale
This change-set allows setting different defaults for different locales. 

It also:

- Adds extensive testing around site setting validation

- raises deprecation error if site setting has the default property based on env

- relocated site settings for dev and tests in the initializer

- deprecated client_setting in the site setting's loading process

- ensure it raises when a enum site setting being set

- default_locale is promoted to `required` category.

- fixes incorrect default setting and validation

- fixes ensure type check for site settings

- creates a benchmark for site setting

- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Neil Lalonde 3de45ce0cd FIX: use case insensitive group name search when applying group rules from SSO 2017-08-02 11:30:37 -04:00
Guo Xiang Tan 33e22cf598 Add back `Admin::GroupsController#index` route for now.
* The endpoint is being used by discourse_api.
2017-08-03 00:24:23 +09:00
Neil Lalonde be30d4510a FIX: change email success message container was too narrow 2017-08-02 10:50:18 -04:00
Neil Lalonde 47fa536f46 FIX: plugin outlet in user preferences nav needs to be li tag 2017-08-02 10:05:11 -04:00
Guo Xiang Tan 9bc3038728 Fix Redis command errors when trying to start app with a readonly Redis. 2017-08-02 21:33:56 +09:00
Guo Xiang Tan 1c80c233cf FIX: Adding group owners returns 400 error. 2017-08-02 19:18:41 +09:00
Régis Hanol e43799134c fix the regexp used to valide user's website 2017-08-02 10:19:24 +02:00
Benjamin Elijah Griffin d471ad08c6 Website RE validator without a 10 char limit on TLD. 2017-08-01 23:37:28 -07:00
Jeff Atwood 3538b63305 FIX: on desktop, anon topic reply btn too far over 2017-08-01 16:47:52 -07:00
Robin Ward 53e78edbef Silence ESLint 2017-08-01 17:26:49 -04:00
Robin Ward 8dd7c0c984 UX: Convert buttons to `d-button` 2017-08-01 17:24:06 -04:00
Robin Ward 75d10a4098 UX: Add consistent classes to buttons 2017-08-01 17:24:06 -04:00
Robin Ward 513b7bf706 REFACTOR: DRY up New Topic button code 2017-08-01 15:04:07 -04:00
Guo Xiang Tan bd0efb8525 Fix the build. 2017-08-01 17:57:26 +09:00
Guo Xiang Tan 1197750e7d PERF: Allow plugins to preload custom fields for topics in `CategoryList`. 2017-08-01 17:27:28 +09:00
Matt Palmer 67882ec37d Hunt-and-kill a few more mis-encoded params
https://meta.discourse.org/t/tags-does-not-work-with-cyrillic/67217/6?u=mpalmer
2017-08-01 18:03:44 +10:00
Matt Palmer 7ee861f457 FIX: Return a UTF-8 string in tag notifications
https://meta.discourse.org/t/tags-does-not-work-with-cyrillic/67217
2017-08-01 16:27:52 +10:00
Neil Lalonde fa3c240e8b Merge pull request #4981 from dmacjam/fix_limited_search_results
FIX: limited search results
2017-07-31 20:23:57 -04:00
Leo McArdle 836dee1120 FIX: add additional email to tests and clean up resulting mess 2017-07-31 22:27:29 +00:00
Neil Lalonde ec85b41078 UX: Move watched words to the Logs section of admin 2017-07-31 17:06:50 -04:00
Robin Ward ce27783da4 UX: Add new plugin outlet before reply count 2017-07-31 16:50:25 -04:00
Neil Lalonde 7c1d7fb423 Merge branch 'master' into fix_limited_search_results 2017-07-31 15:55:31 -04:00
Erick Guan f1eccd113c Replace rmmseg gem for cppjieba_rb since better dictionary (#5006)
* Rename locale to ts config in search module to make it clear

* Replace rmmese-cpp for cppjieba_rb
2017-07-31 15:28:48 -04:00
Arpit Jalan 6c997b65d9 optimize enqueuing activation email code 2017-07-31 22:57:39 +05:30
Arpit Jalan 0b01d0e95d FIX: staff cannot manually activate accounts after 48 hours has elapsed
https://meta.discourse.org/t/staff-cannot-manually-activate-invited-accounts-after-48-hours-has-elapsed/66292/14?u=techapj
2017-07-31 22:24:09 +05:30
Neil Lalonde 5d528f0d15 Merge pull request #4958 from dmacjam/search_posts_by_filetype
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
Neil Lalonde 4a5907b116 Merge branch 'master' into search_posts_with_images 2017-07-31 10:44:41 -04:00
Robin Ward 31deebc8e6 FIX: Extra `<` character after icon refactor 2017-07-31 10:18:56 -04:00
Arpit Jalan 2e2b5e28aa FIX: add slight delay when enqueuing activation email 2017-07-31 16:52:07 +05:30
Jakub Macina f8edf2636c Fix rspec tests for search pagination. 2017-07-31 12:16:23 +02:00
Guo Xiang Tan 83bb042311 FIX: `Group#visibility_level` isn't shown in admin group edit page. 2017-07-31 16:34:22 +09:00
jomaxro 65c4e81bb2 Add placeholder text to group member add field 2017-07-30 23:52:46 -04:00
Guo Xiang Tan 24e0e000b9 FIX: Always validate presence of user's primary_email. 2017-07-31 11:47:29 +09:00
Robin Ward 307311fdb1 Add class to admin wrench button 2017-07-28 16:38:10 -04:00
Robin Ward 15fa514791 Add classes to notification dropdown buttons 2017-07-28 16:35:14 -04:00
Robin Ward 67556e6381 REFACTOR: Category / Tag Dropdown headers had extra classes 2017-07-28 16:19:33 -04:00
Robin Ward e4c2b5e430 REFACTOR: CSS improvements to improve targetting and remove !important 2017-07-28 15:52:57 -04:00
Sam a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Sam 64d54bc549 FIX: when quoting add a newline
so **highlight** > quote

Does not end like:

[quote]
test
[quote]~
2017-07-28 10:49:49 -04:00
Sam ae68795d82 FIX: deleting own post results in error 2017-07-28 10:14:11 -04:00
Guo Xiang Tan 4620dfe92d FEATURE: Add group settngs to allow users to leave a group freely.
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Robin Ward ff4e295c4f FIX: Notifications dropdown had incorrect spacing 2017-07-27 19:22:19 -04:00
Sam 4f574e7c93 FEATURE: support inline bbcode blocks eg: [quote]test[/quote] 2017-07-27 17:55:17 -04:00
Robin Ward c3b7419a08 UX: Remove `hidden` from the `#discourse-modal` when the modal is shown 2017-07-27 17:14:41 -04:00
Robin Ward 1b1fd64639 FIX: Badge icons disappeared 2017-07-27 16:57:26 -04:00
Robin Ward 41afd9c818 Bump Plugin API version for icon api 2017-07-27 15:13:03 -04:00
Robin Ward 6dfa3625df REFACTOR: Replace `fa-*` in SCSS with `d-icon-*` 2017-07-27 15:09:30 -04:00
Robin Ward 5b590b9637 REFACTOR: Replace some `fa-*` uses with helpers 2017-07-27 14:55:41 -04:00
Robin Ward d0c41a578e Rename `{{fa-icon}}` to `{{d-icon}}` so it can be more generic 2017-07-27 14:55:41 -04:00
Neil Lalonde 68b3dd43ce fix intermittent failing tests, some watched word refactoring 2017-07-27 12:27:01 -04:00
Robin Ward 5cfc2d8972 Run wizard specs in docker:test 2017-07-27 11:29:18 -04:00
Robin Ward 32c9ad6f7f FIX: Wizard was broken 2017-07-27 10:48:31 -04:00
Guo Xiang Tan 75374c76b3 UX: Display button to message group on group page.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
Guo Xiang Tan 4d25d61e9c UX: Change group membership requests icons on groups pages.
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 16:24:15 +09:00
Guo Xiang Tan 2442bba131 UX: Better group creation workflow.
* Owners and users can now be added to a group during creation.

https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3
2017-07-27 16:12:42 +09:00
Guo Xiang Tan fd95c971ec REFACTOR: Better variable name. 2017-07-27 16:10:53 +09:00
Robin Ward e87125b63c FEATURE: Plugins can overwrite and add support for new icons 2017-07-26 13:21:17 -04:00
Neil Lalonde 24cb950432 FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block 2017-07-26 11:01:09 -04:00
David Taylor 27539e15e1 Allow whitespace around % scaler in markdown image syntax (#5000) 2017-07-26 10:54:20 -04:00
Neil Lalonde ea0e90b2b0 Merge branch 'master' into search_posts_with_images 2017-07-26 10:15:55 -04:00
David Taylor febd7621ea Qunit plugin rake tasks (#4985)
* Allow running specific plugin tests using ENV variables

* Add a `rake plugin:qunit` task to match the existing `rake plugin:spec` task

* Improve docker.rake to allow running specific plugin qunit tests

* Purge cache before and after qunit tests

* Stop module auto-loader trying to auto-load tests

* Use URL query parameters to pass config into Qunit, avoiding caching issues

* Oops, searchParams doesn’t work in phantomJS. Parse the URL manually.

* Escape ampersands before passing URL to phantomJS, otherwise multiple parameters go wrong
2017-07-26 09:07:46 -04:00
Guo Xiang Tan 917d186303 REFACTOR: Reduce number of queries sent to the DB. 2017-07-26 17:20:00 +09:00
Guo Xiang Tan 3a46ea8bad Sanitize SQL arguments to prevent injections. 2017-07-26 17:20:00 +09:00
Guo Xiang Tan f9627f4533 UX: Don't show empty user list for groups without members. 2017-07-26 16:11:06 +09:00
Guo Xiang Tan b59dfb86f4 UX: Include group name in email when group is invited to a PM.
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
Guo Xiang Tan 93130b15e3 Fix invalid CSS syntax. 2017-07-26 10:38:34 +09:00
Guo Xiang Tan e3ac6585bd FIX: Search by topic_id should not be restricted by `SiteSetting.min_search_term_length`. 2017-07-26 09:52:39 +09:00
cpradio feb423d07a Update ul padding/margin to match ol.
https://meta.discourse.org/t/numbers-cut-off-in-long-list/59856/16?u=cpradio
2017-07-25 18:54:28 -04:00
Sam ec2506c32b Merge pull request #4996 from ryantm/patch-2
safely call html_safe on category description
2017-07-25 15:34:07 -04:00
Sam 17d56a4cb7 FEATURE: use Markdown for image pasted in as opposed to IMG tags 2017-07-25 15:11:38 -04:00
Neil Lalonde d8c27e3871 Merge branch 'master' into search_posts_by_filetype 2017-07-25 14:41:20 -04:00
Ryan Mulligan f3f7dd02d1 safely call html_safe on category description
The `categories.description` column is not modified as "not null", so it is possible for the description to be nil. This changes the code not call html_safe on nil.
2017-07-25 11:40:02 -07:00
Sam 0d66a41753 Merge pull request #4989 from begrif/html-safe-category-desc
Stop Rails from escaping the HTML in this description.
2017-07-25 13:41:30 -04:00
Robin Ward f2e592c1ab UX: Apply `btn-flat` class to flat buttons on posts 2017-07-25 12:00:19 -04:00
Robin Ward 3152eabbb0 UX: Use flat button style for bulk selection 2017-07-25 12:00:19 -04:00
Robin Ward 5da848088a UX: Refactor composer buttons into flat buttons 2017-07-25 12:00:19 -04:00
Régis Hanol d67fe4c674 FIX: block all emails associated to a user when destroying their record 2017-07-25 17:44:46 +02:00
Guo Xiang Tan 601064a95a Remove stray debugger. 2017-07-25 22:51:47 +09:00
Guo Xiang Tan bdf1be65a3 FIX: Broken topic invite button. 2017-07-25 22:48:10 +09:00
Jakub Macina 2d45b3fc6d Add infinite loading to full page search. 2017-07-25 15:33:25 +02:00
Joffrey JAFFEUX 8556d3c27f FIX: emoji-picker do not reload all everything when changing diversity 2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX 22c5fb20b4 FIX: emoji-picker broken and skipped specs 2017-07-25 12:23:38 +02:00
Régis Hanol c7c93e7159 FEATURE: new 'strip image metadata' site setting 2017-07-25 11:48:39 +02:00
Guo Xiang Tan 6c0a29698b Fix JS tests failing when running in `RAILS_ENV=test`.
Fixes the following error:

```
phantomjs /home/tgxworld/work/discourse/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit
2017-07-25 16:27:41 +0900: Rack app error handling request { GET /stylesheets/desktop.css }
<Errno::ENOENT: No such file or directory @ rb_sysopen - /home/tgxworld/work/discourse/tmp/stylesheet-cache/desktop.css>
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `write'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `show_resource'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:9:in `show'
```
2017-07-25 16:31:31 +09:00
awesomerobot 3905d6bc0d mildly lighter @mention 2017-07-24 22:26:14 -04:00