0b2d65f77a
Include the site setting file path for which a default value is missing.
2017-08-16 11:42:08 +09:00
1646bc0031
FIX: fails loud if default setting is not set
...
Noted:
- `push_api_secret_key` is set in initializer. Shimed with ''
- `default_theme_key` is set in seeding. Shimed with ''
2017-08-15 12:07:25 +02:00
2c39743d5d
Introduce multisite tests for better coverage.
2017-08-08 12:58:22 +09:00
764957dfc4
Merge pull request #5030 from tgxworld/fix_defaults_cache_cross_talk
...
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 17:07:31 +09:00
22a1db7b8a
FIX: Make `DbProvider#table_exits?` work with multisite.
2017-08-07 16:37:42 +09:00
c5850422f0
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 15:16:57 +09:00
412fa78b1f
FIX: `default_locale` cross talk in multisite setup.
2017-08-07 11:14:28 +09:00
3f24ed2b3e
Can't revert due to incompatibility of new site setting types.
...
Revert "Revert "FEATURE: Site settings defaults per locale""
This reverts commit 439fe8ba24
2017-08-07 10:43:09 +09:00
439fe8ba24
Revert "FEATURE: Site settings defaults per locale"
...
This reverts commit 468a8fcd20
2017-08-07 10:31:50 +09:00
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
3ee5cea9e2
fix the build
2015-09-09 15:34:53 +02:00
9a999bfe84
FIX: ensure we never have a string when an enum is Fixnum
2015-09-09 12:59:49 +02:00
9fbc763902
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-18 21:53:53 +10:00
65156bd8f6
FIX: hide dangerous dev only site settings in production
...
(port/force hostname/queue jobs)
2014-10-03 15:53:01 +10:00
9aec32688b
BUGFIX: when RTT is short likes may not appear to work
...
BUGFIX: site settings db provider not triggering updates
at the correct point
2014-03-31 12:34:13 +11:00
8fc2549873
Stop using global vars where not needed
...
Simplify local process site setting provider
Stop setting up methods over and over
Centralize cache clearing
2014-03-31 12:34:13 +11:00
791f5ac94e
Load site settings from config/site_settings.yml
2013-11-14 16:02:13 -05:00
34be27f425
table_exists should be called aggresively while it is false or nil, to avoid bootstrapping issues
...
don't test 1.9.3 in travis, it blows up randomly due to incorrect implementation of weak refs in 1.9.3
2013-10-30 11:02:10 +11:00
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
f9120f1250
let us not fail the spec suite cause the local provider for site settings reloads.
2013-07-04 16:49:17 +10:00
89b621d31a
Refactor update_all statements in order to prevent deprecation warnings in Rails 4
2013-07-02 18:36:47 +02:00
0b94c3c456
fix all sorts of issues with random spec order
...
SiteSetting no longer persisted across tests
2013-06-23 13:35:25 +10:00
Guo Xiang Tan
Erick Guan
Guo Xiang Tan
Régis Hanol
Tan Le
Sam
Neil Lalonde
Stephan Kaag