66214eee85
SECURITY: Strip HTML from invite emails
...
We also strip new lines from the emails because it ruins the markdown
formatting which expects a one line message.
2019-07-05 14:57:11 -04:00
14bae6d52d
Make `email_excerpt` method take an optional `post` param ( #7570 )
...
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.
This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
2019-05-20 10:04:23 +02:00
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
3d545d66df
FEATURE: Send user activation reminders. ( #7280 )
2019-04-10 16:53:52 +02:00
6815f777f9
DEV: Remove unused method.
2019-04-04 14:19:39 +08:00
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
858a456aaf
FEATURE: Use email_site_title in From of digest emails
2019-01-04 17:06:19 +01:00
c0a8bb9a91
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
a06d310855
DEV: Refactor location string builders. ( #6794 )
2018-12-20 10:23:05 +01:00
9248ad1905
DEV: Enable `Style/SingleLineMethods` and `Style/Semicolon` in Rubocop ( #6717 )
2018-12-04 11:48:13 +08:00
6a3767cde7
FEATURE: Warn users via email about suspicious logins. ( #6520 )
...
* FEATURE: Warn users via email about suspicious logins.
* DEV: Move suspicious login check to a job.
2018-10-25 09:45:31 +00:00
2c5d9269a0
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 11:44:28 +02:00
9d35240620
Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled"
...
This reverts commit c788737eed
2018-09-05 01:53:22 +02:00
c788737eed
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 00:47:39 +02:00
87537b679c
Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.
2018-07-30 11:39:28 +08:00
0c59346478
PERF: reduce querying when creating notifications
...
also style avoid shadowing of vars
2018-07-11 12:38:11 +10:00
0942e2c795
allow adding tags as a custom subject format for emails ( #5846 )
...
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
392f184b24
FIX: check for existence of topic before looking for category
2018-05-17 10:49:01 +05:30
62a8904729
Feature: Include participants at the bottom of PM emails ( #5797 )
...
* Feature: Include participants at the bottom of PM emails
... as undecorated links.
https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast
Fix: missing translation for PM mentions
* display membership count as `group (count)`
2018-05-03 15:50:06 -07:00
74ce2220a7
Make rubocop happy.
2018-03-12 09:48:41 +08:00
89f41f8236
FIX: error when group_in_subject enabled but no group in pm
2018-03-11 12:22:11 +00:00
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
f85055d653
FIX: Remove activation link from account approved email ( #5548 )
2018-02-01 14:59:37 +01:00
0e0794dff9
FIX: correct use of invitee vs inviter in email templates
2017-12-04 14:09:48 +05:30
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
bf00ab5d4a
FIX: grant admin on subfolder
2017-10-27 16:46:02 -04:00
e47f5cedd2
FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup
2017-10-03 15:28:30 -04:00
677b016387
Send a suspension message via email to a user
2017-09-25 12:26:41 -04:00
7181fce71e
remove unused file pending_flags_mailer.rb
2017-09-12 18:00:51 -04:00
beea5cac48
FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email
2017-09-12 18:00:51 -04:00
94d8f6d734
FIX: digest emails should not include posts that are still in the edit grace period
2017-08-14 12:47:33 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
b59dfb86f4
UX: Include group name in email when group is invited to a PM.
...
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
574681dc47
FIX: Show emoji in inline oneboxes
2017-07-21 14:24:48 -04:00
c79418d334
DEV: Move RTL into lib where it belongs
2017-07-03 15:26:57 -04:00
16d356ab4e
FEATURE: resending invite should include original custom message
...
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
2017-06-30 18:13:33 +05:30
5be7a2dad4
FIX: invalid html in notification emails when template has been customized
2017-05-10 14:01:26 -04:00
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
982e3d04f6
PERF: Allow memory to be freed instead of fetching all the objects into memory at once.
...
```
MemoryProfiler.report do
Jobs::UserEmail.new.execute(type: :mailing_list, user_id: user.id)
end.pretty_print
```
Before:
```
Total allocated: 180096119 bytes (1962025 objects)
Total retained: 2194 bytes (16 objects)
allocated memory by gem
-----------------------------------
66979096 activerecord-4.2.8
43507184 nokogiri-1.7.1
43365188 mail-2.6.4
5960201 activesupport-4.2.8
5056267 discourse/lib
4835284 rack-mini-profiler-0.10.1
3825817 arel-6.0.4
2186088 i18n-0.8.1
1719330 discourse/app
```
After:
```
Total allocated: 161935975 bytes (1473940 objects)
Total retained: 2234 bytes (17 objects)
allocated memory by gem
-----------------------------------
45430264 activerecord-4.2.8
43568627 nokogiri-1.7.1
43430754 mail-2.6.4
11233878 rack-mini-profiler-0.10.1
5260825 activesupport-4.2.8
5054491 discourse/lib
2186088 i18n-0.8.1
1822494 arel-6.0.4
```
2017-05-03 17:01:57 +08:00
b193ae2d15
FIX: missing link in unsubscribe text of summary emails
2017-04-28 10:37:52 -04:00
a545117d2e
FIX: Forgot to clear out a topic excerpt
2017-04-27 11:49:39 -04:00
Robin Ward
Osama Sayegh
Neil Lalonde
Guo Xiang Tan
Sam Saffron
Joffrey JAFFEUX
Bianca Nenciu
Gerhard Schlager
David Taylor
Maja Komel
Jeff Wong
Arpit Jalan
Leo McArdle
Leo McArdle
Erick Guan
Joshua Rosenfeld
Guo Xiang Tan