5 Commits

Author	SHA1	Message	Date
Rafael dos Santos Silva	75e40baa64	FIX: min/max username length limits weren't validated (#17382) ... * FIX: min/max username length limits weren't validated The custom validators introduced in e0d7cda made so we ignored the mix and max values set on site_settings.yml. That change allowed admins to set values outside of the range defined on the yaml file. Related to https://meta.discourse.org/t/group-names-with-more-than-60-characters-broken/232115?u=falco Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>	2022-07-08 12:00:47 -03:00
Daniel Waterworth	55a1394342	DEV: pluck_first ... Doing .pluck(:column).first is a very common pattern in Discourse and in most cases, a limit cause isn't being added. Instead of adding a limit clause to all these callsites, this commit adds two new methods to ActiveRecord::Relation: pluck_first, equivalent to limit(1).pluck(*columns).first and pluck_first! which, like other finder methods, raises an exception when no record is found	2019-10-21 12:08:20 +01:00
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files ... This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Guo Xiang Tan	3b1e13e4ab	Remove unecessary code.	2018-10-02 15:24:12 +08:00
Bianca Nenciu	e0d7cdac12	UX: Improve error messages for minimum and maximum username lengths.	2018-10-02 13:10:20 +08:00