Commit Graph

6356 Commits

Author SHA1 Message Date
cpradio eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
2014-09-15 21:10:24 -04:00
Sam Saffron bb64c2236b SECURITY: Escape strings in logs 2014-09-16 07:53:17 +10:00
Sam Saffron 8ba8846589 FIX: Allow Reader badge if you over read a topic 2014-09-16 07:07:47 +10:00
Jonathan Richard Henry Evans (JRHE) 38202d5037 Adds govcloud region to s3 region list 2014-09-15 19:34:12 +01:00
riking 34db30396c FIX: Bracked category link in no-JS view 2014-09-14 21:55:30 -07:00
Jeff Atwood 10e2c3f693 consolidate <aside> quote CSS styles in base 2014-09-13 23:02:46 -07:00
lidlanca e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
2014-09-13 23:59:20 -04:00
Erick Guan bd59a5caba return true when invoke verbose_localization_session 2014-09-14 10:10:48 +08:00
lidlanca 13cedce0cf Fix: Cancel link click if triggered as part of text selection
Prevent a click if the user select content in a topic and release the mouse over a link.

https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846
2014-09-13 04:05:03 -04:00
Jeff Atwood 35ca9525aa move pre/kbd to base css, remove obscure CSS 2014-09-12 22:58:15 -07:00
Robin Ward 9593cb2419 Merge pull request #2791 from lidlanca/patch-1
stripping port information from Discourse.BaseUrl
2014-09-12 16:54:44 -04:00
Robin Ward 0c32bf9c34 Removed stupid `{{log}}` message that I left in because I'm stupid. 2014-09-12 16:29:25 -04:00
lidlanca 33e1790408 stripping port information from Discourse.BaseUrl
Port information if presented in Discourse.BaseUrl may break user avatar URL in the template generation.

https://github.com/discourse/discourse/edit/master/app/assets/javascripts/discourse/models/user.js
avatarTemplate()

In the future there should be a way to reference baseUrl with or without port information
2014-09-12 16:29:17 -04:00
Robin Ward 46d8db3d70 Use dashed names for all templates when using `{{render}}` for future
Ember compatibility
2014-09-12 15:03:33 -04:00
Robin Ward 22fd7fb07d Better resolver support for underscored templates. Eventually we'll
migrate to dashed only.
2014-09-12 14:44:35 -04:00
Robin Ward 1de9c3b04a Migrate more helpers to ES6 format. 2014-09-12 14:27:34 -04:00
Robin Ward 6f149edecc FIX: Scroll position when hitting back button to category filter 2014-09-12 14:07:04 -04:00
riking 2c6d03f87f SECURITY: Limit passwords to 200 characters
Prevents layer 8 attack.
2014-09-12 12:07:11 -04:00
Zane Beckman 216ee9f2f1 Add css selector for 'star' th element
Allows custom css rules to hide this column.
2014-09-12 11:04:47 -04:00
Robin Ward 05bb756ec4 Merge pull request #2790 from mfeckie/admin-group-styling
Make style more consistent with rest of site
2014-09-12 10:57:21 -04:00
Martin Feckie b266b16b6a Make style more consistent with rest of site 2014-09-12 16:44:40 +08:00
Sam 6d5e6b3e33 FIX: max 1 day of view time per topic
we were overflowing ints in some conditions and flooding error logs
2014-09-12 16:59:43 +10:00
Robin Ward fbf86c4e2e FIX: Badge scroll position 2014-09-11 17:50:47 -04:00
Robin Ward e1826e3025 Remove constants from initializers 2014-09-11 17:50:47 -04:00
Neil Lalonde 9b5f506339 FIX: in activity stream, move category badge to be under topic title. Long titles could cause it to be cut off. Category badge replaces the text that was there. 2014-09-11 17:26:09 -04:00
Robin Ward 52094fe554 Remove the last of the `Discourse` globals in our templates 2014-09-11 17:13:03 -04:00
Robin Ward cedc409461 Remove deprecation notices for `Discourse.banner` 2014-09-11 17:01:35 -04:00
Robin Ward f322b500a7 Replaced many global Discourse.SiteSetting calls in templates with
computed properties due to deprecations.
2014-09-11 16:46:34 -04:00
Robin Ward 8559bbe508 Remove many usages of `Discourse` in templates as it's deprecated in new
releases of Ember
2014-09-11 16:30:47 -04:00
Robin Ward af6936cf72 Refactor some deprecations for newer versions of Ember. Also set up
injection for some globals so we can migrate away from them.
2014-09-11 16:16:21 -04:00
Jeff Atwood 0446a0e19e set maxlength="200" attrib on password field 2014-09-11 12:41:03 -07:00
Robin Ward eb512f07a7 FIX: Spec failures for feeds related to enabling categories as default
page for anons when latest is deleted.
2014-09-11 15:30:41 -04:00
Neil Lalonde d492bac587 Remove the git commits widget from the admin dashboard 2014-09-11 14:45:42 -04:00
Robin Ward 15936f4742 Use the `{{fa-icon}}` helper on user expansion 2014-09-11 14:42:45 -04:00
Jeff Atwood 07a021d050 Merge pull request #2785 from awesomerobot/master
fixing message highlight in admin
2014-09-11 11:23:28 -07:00
Kris Aubuchon 6839cd6430 fixing message highlight in admin 2014-09-11 14:07:39 -04:00
Jeff Atwood c661b6ded5 FIX: home icon was incorrectly sized 2014-09-11 10:42:11 -07:00
Robin Ward 3c26bca56a Migrated more helpers to ES6 preferred format 2014-09-11 13:32:57 -04:00
Robin Ward d010eee5d8 Remove unused `titled-link-to` helper 2014-09-11 13:14:11 -04:00
Robin Ward ad813e57ec FIX: Badges scrolling 2014-09-11 13:10:54 -04:00
Robin Ward 57e3865d18 FIX: Scroll position when using the back button 2014-09-11 13:06:01 -04:00
Jeff Atwood 299013b471 lighten staff post bg color 2014-09-11 09:53:35 -07:00
Neil Lalonde 0a9e284277 FIX: rake admin:invite sends an email that makes it clear that an account was created for the recipient 2014-09-11 12:49:01 -04:00
Robin Ward 4a3e46ee4a Merge pull request #2783 from chapel/proper-responsive-extra-info
Make extra info header properly responseive
2014-09-11 12:42:34 -04:00
Neil Lalonde dd8e7fd7d1 Use a label tag on the checkbox for 'I have read and accept the TOS' 2014-09-11 11:11:14 -04:00
Neil Lalonde 91d114756c FIX: don't always say that an email is not verified in admin 2014-09-11 10:58:07 -04:00
Régis Hanol 9a668a7e7b FIX: clear selection when transitioning out of a topic 2014-09-11 16:35:04 +02:00
Régis Hanol e56fcf0c43 FEATURE: add 'rebake post' in post wrench menu 2014-09-11 16:04:40 +02:00
Jacob Chapel 0d0d9adb80 FIX: Make extra info header properly responseive
The current solution assumed the width of the logo which caused
the user info and icons bar to shift down when the title is shown.

This fixes that by making the extra info wrapper responsive
and use up the full width, not needing manual breakpoints.
2014-09-11 01:21:19 -07:00
Jeff Atwood 0f2e8a65e2 remove optimizelegibility from h1 chrome buggy 2014-09-11 00:40:44 -07:00
Sam 0f585bcdbe FIX: PM should never be allowed to have a category
FIX: TL3 should not be allowed to muck with PM titles
2014-09-11 17:39:34 +10:00
Sam 45e8337a29 FEATURE: renames forgot_password_verbose, forgot_password_strict 2014-09-11 15:53:29 +10:00
Sam 42104685f7 FIX: badge flood 2014-09-11 13:34:19 +10:00
Sam 43e132d5a6 FEATURE: sharing badges (nice share, good share, great share)
FIX: bad translation
2014-09-11 13:10:37 +10:00
Sam 7f3797b635 FEATURE: Nice Topic, Good Topic and Great Topic badges
Note we will revoke all old badges post badges that went to post #1
and instead get topic badges
2014-09-11 12:36:37 +10:00
Sam 61bcde6284 FEATURE: inform users if forgot password works or not
FIX: flash dialog in forgot password often had wrong color

(this can be disabled by setting forgot_password_verbose to false)
2014-09-11 12:04:44 +10:00
Sam 16c61f1eab Merge pull request #2780 from riking/post-finder-404
FIX: Unknown /posts/id.json should 404
2014-09-11 11:16:10 +10:00
Sam 306d31b92e fix test 2014-09-11 11:15:49 +10:00
riking b62699707d FIX: Unknown /posts/id.json should 404 2014-09-10 18:10:27 -07:00
Sam 5cb7c8ee11 FEATURE: suppress admin glyph for admins
If you want to a shield you must grant moderation to the admin.
2014-09-11 10:54:25 +10:00
Sam 70eb7b8fdf FEATURE: All on user page is now only should posts + topics 2014-09-11 10:45:59 +10:00
cpradio 37ad1f96b5 UX: Add Suspension Message to User Card
Add the suspension message to the user card of the user. This replaces the about me (bio) just like it does on their profile page.
https://meta.discourse.org/t/profile-page-on-mobile-selecting-menu-item-should-jump-to-the-selected-content/19896/2
2014-09-10 19:30:32 -04:00
cpradio 1ac7a8277d UX: Add Suspension Message to User Card
Add the suspension message to the user card of the user. This replaces the about me (bio) just like it does on their profile page.
https://meta.discourse.org/t/profile-page-on-mobile-selecting-menu-item-should-jump-to-the-selected-content/19896/2
2014-09-10 19:16:36 -04:00
Jeff Atwood abe420b322 darken names in quote titles 2014-09-10 15:17:03 -07:00
Sam fd29fe503d Merge pull request #2778 from Elberet/fix-parser-block-ordering
FIX: fix dialect block ordering
2014-09-11 08:14:17 +10:00
Jeff Atwood 86533a322e remove bg on user profiles 2014-09-10 15:06:20 -07:00
Régis Hanol 18f8038015 FEATURE: add new 'convert to staff message' in post wrench menu 2014-09-10 23:08:33 +02:00
Robin Ward ffc136e9ac FIX: Category topic new posts were the wrong color 2014-09-10 16:10:49 -04:00
Robin Ward 5dea3720a4 FIX: Only use cached list when we have less than 1 page worth of topics.
We only need it then to maintain the scroll position.
2014-09-10 15:17:51 -04:00
Neil Lalonde d15b609e0a FIX: support Permalink urls with query string 2014-09-10 13:58:52 -04:00
Régis Hanol 8f45091ba5 FIX: don't try to feature a topic more than once per category 2014-09-10 16:18:28 +02:00
Régis Hanol dbcaf1276a FIX: move wiki/via-email glyphs + add green background on wiki posts 2014-09-10 15:25:31 +02:00
Sam ca2100d012 PERF: work around LIMIT breaking query plan
(CTE is a optimisation boundary, so limit no longer has any effect on plan)
2014-09-10 22:19:49 +10:00
Jens Maier 30dbb570e5 FIX: fix dialect block ordering 2014-09-10 13:29:40 +02:00
Jeff Atwood c80ef9e3fa remove bgcolor on buttons over user profile 2014-09-10 00:47:31 -07:00
Sam 91dcc56fb3 Revert "PERF: avoid OR in complex query"
This reverts commit a8dc6daa38.
2014-09-10 17:10:57 +10:00
Jeff Atwood 126dfa0ec7 remove hover border for reply as new topic 2014-09-10 00:09:35 -07:00
Sam a8dc6daa38 PERF: avoid OR in complex query
10x perf improvement on front page for sitepoint
2014-09-10 16:33:39 +10:00
Sam b9c8ae588a minor refactor 2014-09-10 16:33:39 +10:00
riking 637371e60a Switch to count of all notifications 2014-09-09 20:13:36 -07:00
Jeff Atwood 5dfd3fc8eb Merge pull request #2776 from cpradio/add-reset-password-instructions
UX: Add password instructions to Reset Password page
2014-09-09 18:42:52 -07:00
cpradio 3bd0c94d96 UX: Add password instructions to Reset Password page
Added the password instructions to the reset password page.
https://meta.discourse.org/t/reset-password-doesnt-give-password-requirements/19799
2014-09-09 20:37:39 -04:00
riking bf06878601 FIX: Broken notification history 2014-09-09 17:25:25 -07:00
Sam 51d9a59d53 copy, "notification history" is just too long 2014-09-10 10:14:42 +10:00
riking 5994b630b7 Final dirty diff cleanup 2014-09-09 16:29:08 -07:00
riking 69bc552054 FEATURE: Actually show more notifications
The "Show more notifications..." link in the notifications dropdown now
links to /my/notifications, which is a historical view of all
notifications you have recieved.

Notification history is loaded in blocks of 60 at a time.

Admins can see others' notification history. (This was requested for
'debugging purposes', though that's what impersonation is for, IMO.)
2014-09-09 16:29:08 -07:00
Sam 5001e826ff Merge pull request #2756 from cpradio/add-go-to-top-shortcut
UX: Add g, t keyboard shortcut to modal window for go to top
2014-09-10 09:11:16 +10:00
Sam 4edbb5b98c Merge pull request #2773 from riking/post-handlebars
(Trivial) Handlebars structure tweaks to post.handlebars
2014-09-10 09:04:12 +10:00
Robin Ward 2d32325ac7 FIX: Show user expansion on user stream too 2014-09-09 17:55:55 -04:00
Robin Ward 62c9e4228d Rename `{{icon}}` helper to `{{fa-icon}}` for future Ember
compatibility.
2014-09-09 17:29:05 -04:00
Robin Ward cec6b64a45 FIX: Don't show filter on user card if not in topic 2014-09-09 16:53:43 -04:00
Robin Ward a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts
are available in the DOM.
2014-09-09 16:05:17 -04:00
Robin Ward 504d61de94 FIX: Clicking on expanded user actions uses user expansion. Also added
integration test.
2014-09-09 15:18:04 -04:00
Jeff Atwood bcfd2778d7 Merge pull request #2774 from awesomerobot/master
changing the header now that fullname was dropped
2014-09-09 11:52:50 -07:00
Kris Aubuchon ebe71ea491 changing the header now that fullname was dropped 2014-09-09 14:42:44 -04:00
Régis Hanol 79030c874e FIX: allow staff members to restore withdrawn posts that are flagged 2014-09-09 20:26:40 +02:00
riking 7bb1b8bc97 Handlebars structure tweaks to post.handlebars
- Combine bind-attrs on the <article> (seriously that made no sense)
 - Hoist a bind-attr class to the view, allowing more fancy styling
 - Hoist a <div> outside a conditional
 - Change href='#' to unvalued hrefs
2014-09-09 11:20:25 -07:00
Robin Ward 8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Robin Ward a96ba8ed78 Revert "FIX: unread/new counts out of sync with tabs"
This reverts commit c093187d34.
2014-09-09 12:57:51 -04:00
Régis Hanol 598a3f3e10 FIX: 'disable_edit_notifications' will only disable revisions made by the system user 2014-09-09 18:56:04 +02:00
Régis Hanol eb34ecfc0c FEATURE: new 'prevent anons from download files' site setting 2014-09-09 18:41:13 +02:00
Régis Hanol 7f498a8795 FIX: N+1 query on /categories page 2014-09-09 15:32:58 +02:00
Régis Hanol 69bc24a16d FIX: clicking a button that disappears in a modal would close the modal (take 2) 2014-09-09 10:44:26 +02:00
Régis Hanol 357c43e941 FIX: clicking the 'edit permission' button would close the category modal 2014-09-09 10:16:12 +02:00
Sam c093187d34 FIX: unread/new counts out of sync with tabs
We were serving cached lists of topics to non popstate reqs
2014-09-09 16:56:20 +10:00
Robin Ward 2f04b53c9f FIX: Clicking outside of modal wasn't closing it 2014-09-08 16:53:05 -04:00
Robin Ward 9d9d93ad3c Merge pull request #2771 from techAPJ/patch-1
Don't show new topic indicator on New tab
2014-09-08 15:35:23 -04:00
Arpit Jalan 80510c5114 Don't show new topic indicator on New tab 2014-09-09 01:02:16 +05:30
Robin Ward 56eda5abf9 FIX: Don't allow profile bios longer than 3k chars 2014-09-08 15:23:21 -04:00
Robin Ward 4f6b9815ae FEATURE: List moderator warnings on admin dashboard 2014-09-08 13:25:02 -04:00
Jeff Atwood 0ccb1dcca6 remove border from "reply as new topic" 2014-09-08 10:02:54 -07:00
Régis Hanol 948e0740c9 FEATURE: add glyphs in the composer 'save' button 2014-09-08 19:02:53 +02:00
Régis Hanol ea6cab66cb FIX: remove curvy arrow on reply to topic button 2014-09-08 19:02:14 +02:00
Régis Hanol 00bd665c96 FEATURE: add count of previous flags on the post 2014-09-08 17:53:29 +02:00
Robin Ward 7d6f3a5089 FIX: Only show warning creation to staff. Server side was OK. 2014-09-08 11:22:11 -04:00
Robin Ward 334e21a03a Revert "Revert "FEATURE: Can create warnings for users via PM""
This reverts commit 1c7559380c.
2014-09-08 11:11:56 -04:00
Robin Ward 1c7559380c Revert "FEATURE: Can create warnings for users via PM"
This reverts commit b0bfc1f93f.
2014-09-08 10:38:59 -04:00
Robin Ward b0bfc1f93f FEATURE: Can create warnings for users via PM 2014-09-08 10:27:06 -04:00
Neil Lalonde a8e4c4caa1 Add classes to the FAQ, Terms of Service, and Privacy nav links so they can be individually styled 2014-09-08 09:32:26 -04:00
Jeff Atwood 9b2e850553 UX: suppress outgoing right arrow on gutter links 2014-09-08 01:15:40 -07:00
Jeff Atwood 107cffcc84 FIX: revert readonly on share link field 2014-09-08 01:03:50 -07:00
Sam fb7fbd3c96 Merge pull request #2761 from techAPJ/patch-2
FEATURE: hide google search on 404 page for private instance
2014-09-08 13:11:41 +10:00
Sam 563a313179 Merge pull request #2767 from gschlager/i18n_fix04
FIX: Some default group names could not be translated
2014-09-08 13:06:29 +10:00
Kris Aubuchon 9eed47f7c5 dark themes now carry over to admin without looking absolutely terrible 2014-09-07 22:46:04 -04:00
Sam 2a7355405e FEATURE: add age to results of search 2014-09-08 10:02:47 +10:00
Jeff Atwood 65e941f652 UX: remove current username from header 2014-09-07 14:01:51 -07:00
Jeff Atwood 3cf433ab1e FIX: quote icon in Quote Reply not clickable 2014-09-07 13:55:31 -07:00
Jeff Atwood aa0d14825a add spaces for flag/admin glyphs on hamburger 2014-09-07 13:24:33 -07:00
Jeff Atwood f5e1a5a669 UX: remove bookmark icon from Unread topnav 2014-09-07 13:20:40 -07:00
Gerhard Schlager 970aafecb4 FIX: Some default group names could not be translated 2014-09-07 14:48:03 +02:00
Jeff Atwood 5b892df2b4 Merge pull request #2764 from awesomerobot/master
making topic/post selection left border stronger
2014-09-06 12:26:23 -07:00
Jeff Atwood d4b8974fd5 Merge pull request #2763 from techAPJ/patch-3
Add group names to user export csv
2014-09-06 12:26:00 -07:00
Kris Aubuchon 127c2f3d21 making topic/post selection left border stronger 2014-09-06 12:12:22 -04:00
Arpit Jalan f8effbcffe Add group names to user export csv 2014-09-06 21:11:05 +05:30
Arpit Jalan 362c05db43 Show category badge on 404 page topics 2014-09-06 17:06:12 +05:30
Arpit Jalan a597f1fa30 FEATURE: hide google search on 404 page for private instance 2014-09-06 15:26:46 +05:30
Jeff Atwood 3e74a19b67 remove hard-coded CSS on 404 page 2014-09-06 01:01:05 -07:00
Jeff Atwood 3772102972 better display of topic glyphs in search 2014-09-05 13:17:26 -07:00
Jeff Atwood 3bdc6f9fad UX: remove email display from profile page 2014-09-05 13:11:50 -07:00
Robin Ward 66501190bd FIX: Missing `id` attribute caused failing test 2014-09-05 13:15:50 -04:00
Robin Ward 4bec839d9d Using `Discourse.XYZ` in templates is deprecated. This fixes that, plus
adds some more integration tests to make sure login required is working.
2014-09-05 13:09:01 -04:00
Neil Lalonde ca5f361d0a FEATURE: restrict admin access based on IP address 2014-09-05 12:06:01 -04:00
Jeff Atwood dc8fc8c9e4 UX: move "show more" in search to bottom of results 2014-09-05 02:19:06 -07:00
Sam 2d615e4f8f lesson, this is why you don't mock 2014-09-05 16:55:48 +10:00
Jeff Atwood 8b634b5f0f Merge pull request #2759 from techAPJ/patch-2
Add education panel for starred tab
2014-09-04 23:47:44 -07:00
Arpit Jalan 0db66d3a18 Add education panel for starred tab 2014-09-05 11:15:10 +05:30
Sam 59d04c0695 Internal renaming of elder,leader,regular,basic to numbers
Changed internals so trust levels are referred to with

TrustLevel[1], TrustLevel[2] etc.

This gives us much better flexibility naming trust levels, these names
are meant to be controlled by various communities.
2014-09-05 15:20:52 +10:00
Kris Aubuchon 5e9dd7da66 fixing egg-shaped badges on mobile 2014-09-04 21:05:38 -04:00
cpradio 2ef499d021 UX: Add g, t keyboard shortcut to modal window for go to top
https://meta.discourse.org/t/add-shortcut-g-t-to-go-to-top-page/19586
2014-09-04 18:28:03 -04:00
Jeff Atwood ea36daf51a lighten wiki and email left gutter icons a bit 2014-09-04 14:42:41 -07:00