discourse

Commit Graph

Author	SHA1	Message	Date
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Rishabh	ad6ad3f679	DEV: Remove SiteSetting.s3_force_path_style (#7210 ) - s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base. - Our new migrate_to_s3 rake task does not work reliably with path style urls too - Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests. - Add migration to drop s3_force_path_style from the site_settings table	2019-03-20 14:58:20 +01:00

Author

SHA1

Message

Date

Sam Saffron

30990006a9

DEV: enable frozen string literal on all files

This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging

2019-05-13 09:31:32 +08:00

Rishabh

ad6ad3f679

DEV: Remove SiteSetting.s3_force_path_style (#7210 )

- s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base.
- Our new migrate_to_s3 rake task does not work reliably with path style urls too
- Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests.
- Add migration to drop s3_force_path_style from the site_settings table

2019-03-20 14:58:20 +01:00

2 Commits