081aa6ad2b
UX: Use new FA5 icons on Backups tab
2018-12-18 16:01:14 +01:00
a313b01148
DEV: raise error if search term length is less than required
2018-12-18 20:06:59 +05:30
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column ( #6791 )
2018-12-18 19:13:46 +05:30
98d09c90ac
Current user serializer groups ( ef7f84b follow-up)
2018-12-18 09:05:45 +01:00
2a518c88d0
Prevent bullet badge from shrinking/growing as flex item
2018-12-17 21:05:32 -05:00
7d7b6baab9
Topic-list category width restriction no longer needed
2018-12-17 21:01:04 -05:00
ece44a44f8
UX: Change default date range of dashboard trending search report to a month
2018-12-18 03:00:30 +05:30
f0027961c7
FIX: Properly reset controller of admin-user-index. ( #6760 )
2018-12-17 15:28:29 +01:00
1023003eba
FIX: Strip remote url before import. ( #6762 )
2018-12-17 15:27:49 +01:00
22cea9ce90
FIX: adusts select-kit position even if not expanded ( #6785 )
2018-12-17 12:29:51 +01:00
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render ( #6784 )
2018-12-17 12:15:03 +01:00
1a8ca68ea3
FEATURE: Improve backup stats on admin dashboard
...
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
2018-12-17 11:35:11 +01:00
040ddec63d
Fix avatar flair styles
2018-12-17 10:44:34 +01:00
c0aae16f6b
FIX: Clear anon cache when disabling readonly mode.
...
`SiteSerializer#is_readonly` is cached for an anonymous user so we have
to clear the cache when disabling readonly mode. Otherwise, the site may
appear to be in readonly mode for an extended period of time.
2018-12-17 17:27:44 +08:00
ed1a309fe4
FIX: use new key for delete topic to make it lowercased as all other buttons label around it ( #6778 )
2018-12-17 10:55:19 +08:00
d803dfc14a
FIX: makes more resilient select-kit positioning ( #6776 )
2018-12-15 16:23:23 +01:00
6213e020e6
Improving usercard badge alignment
2018-12-14 22:16:18 -05:00
e9ea0102a5
FIX: Consistency about our response for invalid user id in `Admin::UsersController`.
2018-12-15 08:01:35 +08:00
ef0e84e3d9
FIX: clear the site_contact_username setting if the user's staff privileges are revoked
2018-12-14 16:52:44 -05:00
1960236822
FIX: Suspicious login detection ( #6772 )
2018-12-14 16:30:34 +00:00
9f3e2a9e34
FIX: Only serialize group membership domains for administrators ( #6771 )
2018-12-14 15:47:00 +00:00
a19f69590a
DEV: add "topic-list-before-relative-date" plugin outlet
2018-12-14 10:39:22 -05:00
2f70bd83a3
Increase contrast of pinned excerpt for dark themes
2018-12-14 10:04:44 -05:00
03014b0d05
FEATURE: adds security tab to dashboard ( #6768 )
...
This commit also includes the new staff_logins report
2018-12-14 13:47:59 +01:00
9f89aadd33
FIX: delete all posts in batches without hijack ( #6747 )
2018-12-14 11:04:18 +01:00
05104600ea
FIX: Incorrect translation key on admin search logs.
2018-12-14 17:12:33 +08:00
6553744e50
Fixing topic status alignment in search
2018-12-13 21:49:43 -05:00
6cbcd58603
Lighten lazyload placeholder background
2018-12-13 15:38:33 -05:00
afdd244486
UX: removes superfluous posters column header ( #6765 )
2018-12-13 21:29:00 +01:00
60189e8c92
Mobile alignment fixes
2018-12-13 15:26:52 -05:00
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder ( #6764 )
2018-12-13 18:21:12 +01:00
5cb99d08ed
FIX: define actions on connector class early ( #6763 )
...
This would prevent failure with connectors templates defining actions as closures. In this case action existence is checked at compile time and not runtime.
2018-12-13 15:43:30 +01:00
8ef2085585
UX: increase selector specificity so that "inline" lightboxes in quotes don't get backgrounds
...
When a quote is not expanded and it contains lightboxes, those lightboxes are not displayed and instead we show a link that looks like this `[image_title]`
These still have the lightbox CSS class and so they still get the backgrounds we add to lightboxes while they load. Increasing the selector specificity prevents that from happening.
2018-12-13 15:17:08 +08:00
7ee9a6a7ec
SECURITY: do not delete avatars uploads when deleting accounts
...
We rely on the clean up uploads job to do this safely
2018-12-13 16:26:07 +11:00
f74ef71130
DEV: add transaction and active check to invalidate job
...
Follows up on 3b76f19668
2018-12-13 14:59:56 +11:00
94b8ba4f8f
FIX: remove slow platform detection from server side
...
Historically due to https://meta.discourse.org/t/why-is-discourse-so-slow-on-android/8823
we decreased page sizes of both home page and topic page on android by half.
This was done on the server side and as a side effect and caused page sizes on android
to mismatch between Android and non Android.
Unfortunately about a year ago googlebot started pretending it is Android,
this cause Google to start indexing pages as what android would see. So
it saw double the amount of pages in the index as what exists on desktop.
This in turn caused double the amount of indexing work and a large amount
of broken links on long topics.
This fix removes all special behavior which is no longer needed due to
other performance work in Discourse including raw handlebars on home page
and virtual dom on topic pages.
I tested we do not need this on Blu Advance 5.0 it has 1.3 GHZ mediatec mt6580
This phone retails for around $50 USD.
If we decide long term that we want any hacks like this we will shift them
to the client side. It can just hold data in memory without rendering.
2018-12-13 13:57:05 +11:00
92df7b212c
rename `visible` to `visibleSiteSettings`
2018-12-13 13:00:13 +11:00
c9279a118e
FIX: always show filtered site settings
2018-12-13 13:00:13 +11:00
3b76f19668
FIX: invalidating inactive admin emails should mark them as not active
2018-12-12 17:07:49 -05:00
a1db15fead
FEATURE: require admins to re-validate their email addresses if they haven't been seen for a number of days, configurable with the invalidate_inactive_admin_email_after_days site setting. Social logins are also revoked. Default is 365 days.
2018-12-12 15:32:38 -05:00
dbbadb5c35
FEATURE: add short_site_description setting to be included in title tag on homepage
2018-12-12 11:46:58 +01:00
793f1274d1
FIX: makes charts more resilient to resizing ( #6758 )
2018-12-12 11:11:56 +01:00
3a799ed922
FEATURE: Check if draft exists before starting a new one ( #6755 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
2018-12-12 10:21:51 +01:00
0ca61242b8
FEATURE: polyfill intersection observer for IE11 / iOS Safari
...
This feature is used for defer loading of images and in future for post cloaking
This gives us a polyfill so we can safely use the feature in problem browsers
The polyfill supports "polling" but it does not appear we need it yet.
If we discover anything odd here, consider setting poll interval per:
https://github.com/w3c/IntersectionObserver/tree/master/polyfill
```
var io = new IntersectionObserver(callback);
io.POLL_INTERVAL = 100; // Time in milliseconds.
```
Keeping the mutation observer cause we often mutate the DOM
2018-12-12 15:36:08 +11:00
6d353a1e47
Alignment & spacing fix for quote controls
2018-12-11 21:17:31 -05:00
86926f4aee
DEV: Let `create!` handle the check for persistence.
...
This is unlikely to fail but we want to know when it does.
2018-12-12 08:36:13 +08:00
6797a710aa
FEATURE: Lazily Load Images as they scroll into the viewport.
...
This feature uses the Intersection Observer API
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API
It should be compatible with all modern browsers. Non-Edge IE is *NOT*
supported, so in that particular browser images are loaded by default.
2018-12-12 10:12:49 +11:00
5358f25fc6
FIX: Support RTL languages in header menu
2018-12-11 10:33:56 -08:00
d2569f8e77
make linter happy
2018-12-11 09:41:40 -08:00
0f734e2ae2
FIX: Return authenticated=true when reconnecting
...
This prevents a registration popup on the client
2018-12-11 17:40:02 +00:00
71d8807fec
Full height swipe-able menus ( #6566 )
...
* Feature: Full height swipe enabled menus
support pan events on iphone
2018-12-11 09:15:20 -08:00
688755baf2
DEV: Improve specs and handle invalid email token
...
Follow-up to 7977b09025
2018-12-11 18:04:10 +01:00
8c227715ae
$primary-high contrast reduction for dark themes
2018-12-11 10:08:00 -05:00
4cc0a3503b
Adding space between badges for medium-sized viewports
2018-12-11 09:45:49 -05:00
c7c56af397
FEATURE: Allow connecting associated accounts when two-factor is enabled ( #6754 )
...
Previously the 'reconnect' process was a bit magic - IF you were already logged into discourse, and followed the auth flow, your account would be reconnected and you would be 'logged in again'.
Now, we explicitly check for a reconnect=true parameter when the flow is started, store it in the session, and then only follow the reconnect logic if that variable is present. Setting this parameter also skips the 'logged in again' step, which means reconnect now works with 2fa enabled.
2018-12-11 13:19:00 +00:00
2ee2e5c981
UX: fix cropped image thumbnails
2018-12-11 12:23:39 +01:00
3fedb2ad20
DEV: Style and performance improvements
...
Follow-up from 9db8291
2018-12-11 09:58:20 +00:00
671469bcc7
FIX: URLs containing two # would fail to work
...
Some URLs in browsers are non compliant and contain twos `#` this commit adds
special handling for this edge case by auto encoding any fragments containing `#`
2018-12-11 18:03:13 +11:00
bb4ef644bf
UX: reduce show dismiss.. at top of unread/new to 15
...
Previously we would require 30 unread or new topic to show the button at the top.
2018-12-11 14:11:54 +11:00
7977b09025
FEATURE: Activate users invited via email when invite is redeemed
...
Do not send an activation email to users invited via email. They
already confirmed their email address by clicking the invite link.
Users invited via link will need to confirm their email address before
they can login.
2018-12-11 00:09:53 +01:00
73d2fc194d
UX: More consistent category lock and topic-status styles
2018-12-10 16:06:26 -05:00
071bd15463
FIX: Redirect to default homepage when visiting `/login`
...
Previously this was hard-coded to redirect to `/latest`
2018-12-10 15:39:05 +00:00
ef7f84b59b
Add groups to current user serializer ( #6748 )
2018-12-10 16:23:29 +01:00
9db829134c
FIX: Use database to persist metadata during social registration ( #6750 )
...
Previously was using the cookie_store, which is limited to 4kb. This caused issues for providers sending large volumes of metadata about a user.
2018-12-10 15:10:06 +00:00
e06a8980fb
FIX: category-drop initial state was incorrect ( #6743 )
2018-12-10 14:05:00 +01:00
7f361a546e
UX: Add styling for updated twitter status icons in onebox
...
Minor adjustments needed by onebox version 1.8.69
2018-12-09 21:58:02 -05:00
c84b837d50
category badge alignment fix
2018-12-08 22:33:11 -05:00
0f41770547
Make Danger happy by running prettier
2018-12-08 02:59:09 +01:00
050c02228e
UX: Globally dim categories slightly
2018-12-07 20:01:38 -05:00
67450ba402
UX: when composer is minimized, let user open composer in regular size instead of full screen
2018-12-07 17:45:13 -05:00
ccd80a8b14
update png assets for push notification images
2018-12-07 14:00:39 -08:00
b26d0f20cc
Fixing slight misalignment of login/signup buttons
2018-12-07 13:56:54 -05:00
d16a4b895f
only dim categories, not all topic stats per 547eaa6
2018-12-07 13:35:57 -05:00
98c18f8349
button and alignment fixes for mobile user page
2018-12-07 12:34:37 -05:00
547eaa6060
UX: Dim visited post info along with title
2018-12-07 11:09:56 -05:00
efec2db859
FEATURE: Web Share Target Support
...
This adds a **very basic** support for share to Discourse.
Currently, this is only supported in Android + Chrome 71+.
After installing a Discourse site to the Home Screen, you will be
able to share from anywhere in the OS to the Discourse site.
Discourse will use the title and text from the share event.
2018-12-07 13:48:09 -02:00
160d29b18a
REFACTOR: Migrate TwitterAuthenticator to use ManagedAuthenticator ( #6739 )
...
No changes to functionality. TwitterAuthenticator goes from 136 lines to 24, and all twitter-specific logic elsewhere has been deleted 🎉
2018-12-07 15:39:06 +00:00
9e3143445b
DEV:add uploaded_meta option in category for category meta image ( #6724 )
2018-12-07 16:24:07 +01:00
f7ce607e5d
FIX: Return 422 instead of 500 for invalid SSO signature ( #6738 )
2018-12-07 15:01:44 +00:00
5e09398c5b
FIX: Do not serialize user fields unless they are specified for display ( #6736 )
2018-12-07 10:57:28 +00:00
8e307e633e
FIX: posts would not auto rebake unless gravatar download was enabled
2018-12-07 17:03:22 +11:00
031c252cd3
Slight alignment follow-up to db32d29
2018-12-06 20:01:38 -05:00
db32d29eaa
UX: Refactoring topic statuses for consistent icon sizes & colors
2018-12-06 19:22:04 -05:00
06d1b19ca2
FIX: Refactor lightbox mobile icon
...
- Fixes a performance issue on a site with lots of images in posts
- turns out that "filter: invert(100%)" performs very poorly on Safari/iPhone
- also disables transition on the element on mobile
2018-12-06 15:32:26 -05:00
b54b4d05c5
UX: improve code highlighting diffs for dark themes
2018-12-06 10:54:30 -05:00
4300ac0f4a
UX: Show smaller Emojis within some HTML elements
2018-12-06 15:13:16 +01:00
7ec124fc89
FEATURE: Improved deprecation warnings ( #6722 )
...
* FEATURE: Discourse.deprecate can report version
* Ember counterpart for deprecation
2018-12-06 11:38:01 +00:00
1d649e147b
FEATURE: show avatar flair on group, badges and directory pages ( #6732 )
2018-12-06 12:18:52 +01:00
43cfdb1cb9
FIX: Wizard tries harder to find existing Welcome Topic
...
The wizard searches for:
* a topic that with the "is_welcome_topic" custom field
* a topic with the correct slug for the current default locale
* a topic with the correct slug for the English locale
* the oldest globally pinned topic
It gives up if it didn't find any of the above.
2018-12-06 10:27:22 +01:00
27c793a192
FIX: `UserNotificationsHelper#logo_url' to work with S3 based uploads.
...
https://meta.discourse.org/t/digest-logo-not-working/103255
2018-12-06 09:39:08 +08:00
dcf9c6da59
DEV: Don't publish post messages to non-human users.
2018-12-06 08:24:13 +08:00
a88f931d6f
UX: Moving categories under topic title in topic list, removing category column ( #6731 )
...
* Starting to remove category column from topic list
* stacked nav alignment adjustment
* Revert "stacked nav alignment adjustment"
This reverts commit 98800c7058
2018-12-05 16:12:26 -08:00
a8e8473ea5
DEV: Apply code review.
2018-12-05 21:58:55 +01:00
79d987e483
FEATURE: Show autocomplete when enable_inline_emoji_translation is true.
2018-12-05 21:58:55 +01:00
e9bbdef156
FEATURE: Add support for inline emoji translation.
2018-12-05 21:58:55 +01:00
0c88052641
UX: Wrap pre element.
2018-12-05 21:56:18 +01:00
b585f7f336
DEV: Apply code review.
2018-12-05 21:56:18 +01:00
56890efd7a
FEATURE: Add 'Advanced Test' for admin panel.
2018-12-05 21:56:18 +01:00
1a4f592749
FIX: Always allow admins upload selectable avatars.
2018-12-05 21:55:23 +01:00
aea2d8bbeb
FIX: properly secure poll message bus
...
Co-authored-by: Sam <sam.saffron@gmail.com>
2018-12-05 21:27:49 +01:00
8aff99761a
FIX: Ignore query parameters when displaying counter on internal links
...
This matches the server-side behaviour, so that the links display counters correctly
2018-12-05 18:29:54 +00:00
a1d9aeda8b
REFACTOR: split `TopicLink#extract_from` into multiple methods
...
Also rename some confusing variables
2018-12-05 18:54:30 +01:00
37249c9a32
FIX: Do not reset link counts when post is rebaked
...
This was an indentation mistake introduced in 44eba0b
2018-12-05 18:54:30 +01:00
978f0db109
SECURITY: Require groups to be given when inviting to a restricted category. ( #6715 )
2018-12-05 16:43:07 +01:00
57ba4b7cb2
DEV: remove unnecessary safe nav operators ( #6730 )
2018-12-05 20:07:18 +05:30
97e6e3b133
DEV: duplicate and unreachable code after `return`
2018-12-05 09:17:20 -05:00
fb78414229
Add missing safe navigation operator
2018-12-05 16:23:43 +05:30
d33d031742
FEATURE: Filter topic and post web hook events by tags ( #6726 )
...
* FEATURE: Filter topic and post web hook events by tags
* Add a spec test with unmatched tags
2018-12-05 14:44:06 +05:30
82e45f5485
FIX: method extraction caused push notifications to include incorrect post
...
Previously the push notification code path was not tested for notification
collapsing. This happens if you get multiple replies to a topic you are
watching.
2018-12-05 16:40:10 +11:00
ec26a59eac
FIX: variable name typo in subcategory image
2018-12-05 10:41:06 +05:30
e0aac75607
Restrict width of category heading to prevent mobile overflow
2018-12-04 19:01:27 -05:00
28ddaf80d2
Adding max-width to category logos
2018-12-04 13:01:27 -05:00
3c9c95ac83
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
72bd388ff7
UX: truncate long topic tiles to prevent badges and date from wrapping
2018-12-04 15:27:23 +08:00
aa97f6fdba
FEATURE: disable notifications for small actions that are whispers
...
Previously we would notify on small actions if they were whispers
this inconsistently lead to all sorts of problems including
- collapsed "N replies" after assign
- empty push notifications
New behavior adds an api to explicitly send push notifications as well
if needed: create_notification_alert
2018-12-04 17:54:42 +11:00
5c17e46274
FEATURE: allow advanced specification of excerpts for posts
...
Previously users could control excerpt with `<span class='excerpt'>`
in Markdown, this is somewhat limited for plugins that need to define this
across a section. This adds support for DIV as well
2018-12-04 15:13:34 +11:00
9248ad1905
DEV: Enable `Style/SingleLineMethods` and `Style/Semicolon` in Rubocop ( #6717 )
2018-12-04 11:48:13 +08:00
56948896ff
UX: replace FA5 compress/expand icons
...
Adds a new SVG sprite file that contains non-FontAwesome 5 icons to our subset.
Adds the FontAwesome 4.7.0 icons for expand / collapse.
2018-12-03 22:29:20 -05:00
923692d45a
FIX: tooltip regression in admin dashboard
...
- adds registerHoverTooltip in tooltip qunit test
2018-12-03 11:15:31 -05:00
f8e6a37858
FIX: raise exception when getting dimensions of missing image
...
- follow-up on 0eacd45ab1
2018-12-03 10:19:49 -05:00
142361d6da
FIX: don't steal focus when text in editor is replaced ( #6712 )
2018-12-03 09:49:17 +01:00
125bb46052
Remove unused constant in the codebase.
2018-12-03 11:04:47 +08:00
cc04c86859
UX: do not restrict width of category image, only height
...
This was a recent visual regression which caused a fair amount of pain.
Previously we only restricted height
2018-12-03 09:35:16 +11:00
236c755d62
FIX: do not store key tracking last seen time indefinitely
...
UserStat has some special logic to keep adding time read if repeat calls
are made in intervals less than 100 seconds. This is called regularly
when we update read timings on a topic.
We only need to cache this key in redis for 100 seconds, however previously
we would keep it forever, 1 key per user. This has potential of bloating
a very large amount of keys for no longer active users in redis.
2018-12-03 08:35:26 +11:00
26e9b628b8
post-infos alignment fix
2018-11-30 21:31:36 -05:00
a113777003
Extra margin isn't needed on mobile
2018-11-30 19:49:26 -05:00
bbd33de05b
FIX: lightbox expand icon on mobile
2018-11-30 14:35:45 -05:00
488fba3c5f
FEATURE: allow plugins and themes to extend the default CSP ( #6704 )
...
* FEATURE: allow plugins and themes to extend the default CSP
For plugins:
```
extend_content_security_policy(
script_src: ['https://domain.com/script.js ', 'https://your-cdn.com/ '],
style_src: ['https://domain.com/style.css ']
)
```
For themes and components:
```
extend_content_security_policy:
type: list
default: "script_src:https://domain.com/ |style_src:https://domain.com "
```
* clear CSP base url before each test
we have a test that stubs `Rails.env.development?` to true
* Only allow extending directives that core includes, for now
2018-11-30 09:51:45 -05:00
7dec963f2e
FIX: add vkontakte icon alias
2018-11-30 08:50:38 -05:00
208005f9c9
REFACTOR: Migrate FacebookAuthenticator to use ManagedAuthenticator
...
Changes to functionality
- Removed syncing of user metadata including gender, location etc.
These are no longer available to standard Facebook applications.
- Removed the remote 'revoke' functionality. No other providers have
it, and it does not appear to be standard practice in other apps.
- The 'facebook_no_email' event is no longer logged. The system can
cope fine with a missing email address.
Data is migrated to the new user_associated_accounts table.
facebook_user_infos can be dropped once we are confident the data has
been migrated successfully.
2018-11-30 11:18:11 +00:00
534e1b1b18
DEV: Introduce Auth::ManagedAuthenticator
...
A generic implementation of Auth::Authenticator which stores data in the
new UserAssociatedAccount model. This should help significantly reduce the duplicated
logic across different auth providers.
2018-11-30 11:18:11 +00:00
059e36a6ff
FIX: log name changes only when the name is actually updated
2018-11-30 15:30:46 +05:30
eecd1a7d8c
FIX: `Jobs::CleanUpUploads` fails when value of upload data_type is an empty string.
2018-11-30 10:46:39 +08:00
0eacd45ab1
FIX: refactor ImageSizer.resize
...
reverts 140d9c2
2018-11-29 15:28:45 -05:00
140d9c2910
FIX: call ImageSizer only if width/height are available
2018-11-29 15:03:02 -05:00
40f10855c6
FIX: defer flags (only) when handling a flag and deleting replies ( #6702 )
2018-11-29 22:44:18 +05:30
4a8f21d387
FIX: prevent minimum_required_tags on category being set to null ( #6703 )
...
* FIX: prevent minimum_required_tags on category being set to null
* add migration for NOT_NULL constraint for minimum_required_tags
* add specs
2018-11-29 18:10:14 +01:00
5b6c1b1670
SCSS refactoring
...
followup on c388cac
2018-11-29 12:02:11 -05:00
4f24d7dec8
FIX: more resilient whisper state between composer states ( #6687 )
2018-11-29 16:16:34 +01:00
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows ( #6682 )
2018-11-29 15:56:19 +01:00
4c7dfed32e
FIX: error with tags enabled and no tags created ( #6701 )
2018-11-29 10:39:09 +01:00
ffdacba219
Remove extra `apple-touch-icon` link in head.
...
The sizes attribute does not make a difference because both
image provided is of the same size.
2018-11-29 15:24:52 +08:00
5db50d6cdc
UX: Use aspect ratio to calculate width and height precisely
...
Followup on 1da265d
2018-11-29 09:32:03 +05:30
c388cacb81
UX: Style group flair in /groups same as in topic avatars
2018-11-28 16:02:49 -05:00
6568832235
FIX: map discord/patreon FA5 icons for login buttons correctly
2018-11-28 14:36:36 -05:00
6027e7ba3d
FIX: Restrict logo width for small screens
2018-11-28 13:27:56 -05:00
55945ec7c8
FIX: throw error when link in reason for grant badge is an external link ( #6690 )
2018-11-28 18:01:41 +01:00
e7b76b319a
FEATURE: Setting for short title used by Android on homescreen
2018-11-28 14:59:30 +01:00
49c3cf9c75
UX: Topic stats were hard to translate
2018-11-28 14:25:22 +01:00
851ef14096
Revert "FIX: do not agree flags by default when deleting posts"
...
This reverts commit cb6fc8057b
2018-11-28 10:21:11 +05:30
654d7996ae
FIX: title was repeating on about page
2018-11-28 08:06:14 +05:30
912a7105d2
DEV: polyfill Object.values and use where needed
...
We now have polyfills for `values` IE and `entries` IE
This commit uses values where appropriate to eliminate an extra lookup
This simplifies the code a bit.
Followup to: 7f089f07a7
2018-11-28 10:07:05 +11:00
3cb88bc566
DEV: Run file through prettier
...
We only alert on .js.es6 this is a js file so it is bypassed
2018-11-28 10:03:54 +11:00
bdb1268528
FIX: static page title should be consistent on client side and server side
2018-11-27 22:03:52 +05:30
7f089f07a7
FIX: better fix for #ca84c06 ( #6684 )
2018-11-27 16:12:07 +01:00
f993aca363
FIX: Fix editing built-in badges after removing `_.include`
...
We want to send the unprotected fields to the server. Corrects 4c8cfe0f
2018-11-27 15:01:02 +00:00
ca84c06c59
FIX: revert to using _.each ( #6683 )
...
Should be replaced with Object.keys variation when reproducible
2018-11-27 15:55:56 +01:00
964fd983b7
z-index fix for tooltips within posts
2018-11-27 09:49:34 -05:00
a2bff038e8
FIX: set overridden param for customize site text query only when checkbox value changes
2018-11-27 14:29:48 +01:00
a0fca2b6ed
FIX: popular posts font weight in summary email
2018-11-27 12:58:28 +01:00
886ef7251d
REFACTOR: Simplify extraction of mentions
2018-11-27 12:46:02 +01:00
c92c56d986
FIX: Randomly failing QUnit test.
...
The `post` variable can be an actual post object or a `new Placeholder("post-placeholder")` which does not define the function `get`.
* QUNIT_SEED=11414431645131211212599424733847938795
2018-11-27 16:00:46 +08:00
a1e77aa2ed
FEATURE: Reimplement `SiteSetting.max_oneboxes_per_post`. ( #6668 )
...
Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
2018-11-27 16:00:31 +08:00
6cb49cd42c
Merge pull request #6671 from techAPJ/destroy-posts-flags
...
FIX: do not agree flags by default when deleting posts
2018-11-27 11:27:23 +05:30
cb6fc8057b
FIX: do not agree flags by default when deleting posts
2018-11-27 10:57:20 +05:30
38e29d8c94
DEV: Fix coding style.
2018-11-27 13:05:27 +11:00
d657ce844b
DEV: Call onClose for closing modals.
2018-11-27 13:05:27 +11:00
0005bded6c
DEV: Added composer-action-after plugin outlet.
2018-11-27 13:05:27 +11:00
1f9f00a629
DEV: Add data-topic-id to more elements containing titles.
2018-11-27 13:05:27 +11:00
8837fe47d7
DEV: Add app event triggered when composer's reply is reloaded.
2018-11-27 13:05:27 +11:00
b65e5d263e
DEV: Add a plugin outlet for top-side notices.
2018-11-27 13:05:27 +11:00
1da265db11
UX: category images have no sizes ( #6662 )
2018-11-27 08:40:06 +08:00
03deda2147
Upgrade to FontAwesome 5 (take two) ( #6673 )
...
* Add missing icons to set
* Revert FA5 revert
This reverts commit 42572ff
2018-11-26 16:49:57 -05:00
818761c3a4
FIX: uses appropriate z-index for tooltips ( #6674 )
2018-11-26 22:47:12 +01:00
5640166b27
FIX: Notify only invited users about mentions in PMs
2018-11-26 22:42:56 +01:00
593cd831e1
Wrap long lists of admin tabs on large screens
2018-11-26 14:51:45 -05:00
8bca2647ea
FIX: Upwards scrolling occasionally broken
...
This fixes a bug in Chrome where upwards scrolling would occasionally
not work properly.
2018-11-26 13:37:12 -05:00
2e4706b787
FIX: bug and typo in admin user badges
2018-11-26 10:24:46 -05:00
3453707784
FEATURE: allows html tooltips ( #6665 )
2018-11-26 11:15:23 +01:00
e47b478b83
DEV: removes _.toArray from codebase ( #6654 )
2018-11-26 11:15:05 +01:00
0972516abe
FIX: Incorrect "rel" used for apple icons in `<head>`.
...
Nothing on the web I can find suggests that this should have been `rel=icon`.
See https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
2018-11-26 10:40:09 +08:00
d4aaa968bb
Fix linting.
2018-11-26 09:38:22 +08:00
57e2f4990d
PERF: Move processing of inline onebox out of V8 context. ( #6658 )
2018-11-26 09:21:38 +08:00
93d4281706
FIX: alignment issue in PM inbox when bulk selecting
2018-11-25 15:24:26 -05:00
b5bf182ad5
FIX: validate topic deletion when acting on a flag
2018-11-25 23:24:03 +05:30
172b3bf4d3
FIX: Fix broken theme field URLs. ( #6622 )
2018-11-23 16:11:05 +01:00
336436dfb4
UX: better handling of logo size
2018-11-23 22:04:42 +08:00
e2214b50f3
UX: add height attribute to logo on error pages
...
This matches what we do in the home-logo widget. The height is set as an attribute and we use CSS to get a scaled width that preserves the aspect ratio of the image.
2018-11-23 15:04:34 +08:00
a1888b301b
DEV: Don't require login for QUit test path.
2018-11-23 13:50:19 +08:00
98354bd34c
fix the build
2018-11-23 11:27:59 +08:00
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops
...
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels.
Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
2018-11-23 10:14:13 +08:00
f4432648fd
FIX: categories/delete_categories can be undefined ( #6657 )
2018-11-23 00:57:18 +01:00
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
7e20a0b917
DEV: removes _.indexOf from codebase ( #6652 )
2018-11-22 17:38:58 +01:00
0083eec686
FEATURE: Allow logo URLs to be overridden easily using `reopenWidget()`
2018-11-22 16:29:12 +00:00
56478166e5
FIX: broken badge groupings modal UI ( #6653 )
2018-11-22 17:09:45 +01:00
2843944315
FIX: better alignment of badge selector and edit btn ( #6651 )
...
Input located at /admin/badges/new
2018-11-22 16:21:15 +01:00
e77cc44f07
FIX: better alignment of groups header filters ( #6650 )
...
This is located at the top of the /groups page.
2018-11-22 16:18:02 +01:00
80398d0b8f
Extract inline JS on embedded comments ( #6645 )
...
* use the meta refresh tag instead
* extract inline JS in embedded comment
2018-11-22 10:02:58 -05:00
1fd0787dd7
UX: Ensure unstyled `.btn-social` elements have a contrasting background
...
For example, in plugins where the background color is not explicitly set
2018-11-22 15:00:32 +00:00
2ef16e9f4e
FIX: Failed to delete post belonging to non-existent topic
2018-11-22 15:08:37 +01:00
60941f214c
FIX: remove unneeded keys from failed response
2018-11-22 14:59:50 +05:30
3f636b2d19
FIX: Check whether group is mentionable by user when cooking post.
2018-11-22 16:16:33 +08:00
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
6111b285d9
DEV: Remove comment that links to a private topic.
...
Not going to be useful for other developers.
2018-11-22 14:55:02 +08:00
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
ba280f9cf3
FIX: Give up migrating url site setting if endpoint doesn't return data.
2018-11-22 12:16:52 +08:00
a8603e04ab
FIX: Give up migration of URL site settings if there is an SSL error.
2018-11-22 12:14:27 +08:00
8e32aa1483
FEATURE: show post approvals in Moderation History ( #6643 )
2018-11-22 10:22:23 +08:00
ee6c0170ce
FEATURE: Scroll-based logo on mobile ( #6632 )
2018-11-21 21:21:49 -05:00
d984323e23
FEATURE: Show change name of user in staff logs ( #6647 )
...
https://meta.discourse.org/t/admins-changing-users-name-not-username-should-be-logged/99511
2018-11-22 10:13:02 +08:00
0381e99b71
UX: improving theme upload modal alignment, markup
2018-11-21 16:50:49 -05:00
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
61eff22b29
FIX: raise `Discourse::NotFound` unless the user is present
2018-11-21 10:57:42 +05:30
10cc698df3
FIX: respond with proper error message if user not found
2018-11-21 10:47:37 +05:30
539f1c6252
FIX: raise `Discourse::NotFound` unless the topic is present
2018-11-21 09:48:38 +05:30
f4020d9134
UX: Contain site setting uploads within the div.
2018-11-21 10:09:53 +08:00
0a86ef69bb
FIX: browser infinite recursion when editing post
...
This was a result of:
c4ed353faehttp://api.jquery.com/map/
So you need to convert it to an array prior to mapping
2018-11-21 12:51:14 +11:00
20268385a5
FIX: never attempt to log invalid post numbers
...
Previously in some cases we would queue logging of invalid post numbers
The impact would be we would miss logging an incoming link and would leak
an error.
2018-11-21 11:58:47 +11:00
df72674f24
Warn when migrate url site settings job encounters an error.
2018-11-21 07:55:50 +08:00
17bc21abff
trashing an empty wrapper
2018-11-20 15:42:18 -05:00
17f3080d01
UX: More consistent category setting layout
2018-11-20 15:16:17 -05:00
5951e111ad
FIX: handle nil topic value when removing allowed users
2018-11-20 22:55:39 +05:30
22a7f1e7f2
FIX: handle nil user value on password reset
2018-11-20 21:49:47 +05:30
9672c92045
DEV: removes _.each from codebase ( #6629 )
2018-11-20 14:46:58 +01:00
81b3bdaabd
FIX: Remove site settings override for deprecated url site settings.
2018-11-20 11:42:39 +08:00
d1e50b3f8e
Remove condensed suggested topics, hide secondary table head
2018-11-19 11:26:21 -05:00
86dafc1f25
DEV: removes _.reduce from codebase ( #6628 )
2018-11-19 13:04:57 +01:00
0a8227d19c
DEV: removes _.some from codebase ( #6627 )
2018-11-19 12:32:51 +01:00
e860c8b844
FIX: adds support for missing reports from old dashboard ( #6624 )
2018-11-19 12:20:05 +01:00
4c8cfe0f29
DEV: removes _.include from codebase ( #6620 )
2018-11-19 12:08:54 +01:00
b1727537b2
DEV: removes _.find from codebase
2018-11-19 11:46:26 +01:00
30e0d744db
DEV: removes _.delay from codebase ( #6619 )
2018-11-19 10:47:00 +01:00
c4ed353fae
DEV: removes _.map from codebase ( #6616 )
2018-11-19 10:46:46 +01:00
907cf3ee2f
DEV: replaces setTimeout by Ember.run.later ( #6618 )
2018-11-19 10:46:38 +01:00
f2c227432c
FIX: Do not show nested user cards. ( #6621 )
2018-11-19 10:01:22 +01:00
2ac952d7dd
UX: leave room for floated radio input on mobile
2018-11-19 15:10:52 +08:00
fe131c5ea2
Fix missing avatars on topic list page.
...
Introduced in b50fab2d72
2018-11-19 14:55:41 +08:00
94c724fb89
UX: fixes display issues in split to existing topic modal
2018-11-19 13:12:42 +08:00
9fd704735e
Rescue from `SocketError` in migrate url onceoff job.
2018-11-19 13:07:34 +08:00
b50fab2d72
PERF: Fix N+1 for non-staff users when tagging is enabled.
2018-11-19 12:53:58 +08:00
6aea185ab4
FEATURE: plugin outlets on about page
...
Added about-after-admins and about-after-moderators
2018-11-19 10:12:44 +11:00
e37c4a4525
FIX: Don't show the Quote popup if posting is disabled
2018-11-16 11:00:22 -05:00
9e86b425bc
FIX: Job to clean up old URL settings when new setting has been set.
...
Related to 44391ee8ab
2018-11-16 09:33:31 +08:00
9157fdd69c
UX: Better related messages condensed layout
2018-11-15 20:21:22 -05:00
f2afb69f72
Revert "UX: maintain aspect ratio of cropped image thumbnails"
...
This reverts commit e7fa4c5dd1
2018-11-16 11:38:04 +11:00
7cb6082f91
FIX: S3 CDN for markdown it bundle
2018-11-15 16:55:20 -05:00
817135fbbf
Show related messages before suggested
2018-11-15 16:32:35 -05:00
078705bcc0
minor refactoring ( #6615 )
2018-11-15 21:41:05 +01:00
dcc6527dff
FIX: s/save/finish for wizard exit early button ( #6614 )
2018-11-15 21:26:26 +01:00
1730e0bc73
UX: shows a save changes for intermediate steps ( #6612 )
2018-11-15 20:44:19 +01:00
d5df746cc3
UX: Improve category reordering functionality
2018-11-16 00:52:10 +05:30
5f754b43f1
extract inline `onpopstate` handler on 404 page ( #6613 )
2018-11-15 13:35:38 -05:00
f0760908e3
Missing space between class names
2018-11-15 12:17:37 -05:00
5a542327e7
IE11 Fix: Select-kit items shouldn't have flex-grow
2018-11-15 10:09:49 -05:00
9911a41f4c
FIX: improves category/tag drops header shortcuts ( #6610 )
...
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
fdccfcfa59
FIX: Only use blockquote which is immediate child of aside
2018-11-15 18:07:16 +05:30
e7fa4c5dd1
UX: maintain aspect ratio of cropped image thumbnails
2018-11-15 20:24:56 +08:00
901611cb4e
Fix migrate upload url site settings to rescue from invalid URLs.
2018-11-15 15:16:14 +08:00
6556a87629
FIX: only check for conflict on edit drafts
...
In some unknown cases non edit drafts are being checked for conflict
2018-11-15 13:14:07 +11:00
ee60ecc71f
UX: Switch to neutral background color for image uploader in site settings.
2018-11-15 08:24:50 +08:00
761003c8bd
FIX: makes sure an hex is always at 6 chars ( #6608 )
...
eg: #aaa should be converted to #aaaaaa
2018-11-15 00:52:47 +01:00
1c678c8c54
This should not have been removed
2018-11-14 23:23:02 +01:00
0f5aeab003
DEV: enable no-alert & no-console eslint rules
2018-11-14 23:17:56 +01:00
6a990d4f95
Removing overly-specific style
2018-11-14 16:37:46 -05:00
7bc121a065
allow CSP reports to be sent when header isn't set by Discourse ( #6594 )
2018-11-14 16:23:29 -05:00
4bac77800a
DEV: remove 'console.log' (cc @eviltrout)
2018-11-14 21:45:41 +01:00
c701036034
FIX: reset bump date resets bumped_at to the last regular post in topic ( #6605 )
2018-11-14 18:56:22 +01:00
20899654aa
Make code prettier 💅
2018-11-14 17:57:22 +01:00
c78dcde973
FIX: only send originalText when we need to
2018-11-14 17:47:59 +01:00
1e15c16f77
UX: Condense layout when suggested and related messages are available
2018-11-14 11:01:50 -05:00
ea075fa4f7
FIX: Don't hide information from the card that is visible in the topic
...
It doesn't make sense to show less information on the card than already
visible.
2018-11-14 09:56:31 -05:00
5b320e6652
DEV: Don't warn about using deprecated site settings in clean up uploads job.
2018-11-14 20:58:06 +08:00
df111259fe
More URL site settings into a onceoff job.
...
* Doing it in a post migration was a bad idea
because the migration will fail if the site
is down while trying to download uploads
which points to the instance. This mainly
affects self-hosters using `discourse_docker`
where `./launcher rebuild` will take the
existing container down.
2018-11-14 20:29:20 +08:00
fce0a0ccc8
FEATURE: Compute distance between logins to generate login alerts. ( #6562 )
2018-11-14 13:26:47 +01:00
f6fb079129
Disable wizard invites step when local_logins are turned off
2018-11-14 13:05:32 +01:00
34e4d82f1a
FEATURE: Report edit conflicts when saving draft. ( #6585 )
2018-11-14 12:56:25 +01:00
d078808144
UX: Use header top to calculate docking position
2018-11-14 16:31:39 +05:30
2220345a8b
Fix the build.
2018-11-14 17:32:32 +08:00
72370b9c36
Add deprecation warnings for url based site settings.
2018-11-14 16:09:26 +08:00
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
17bc82765b
FEATURE: Log password changes in UserHistory ( #6600 )
2018-11-14 08:32:42 +08:00
38a9bc740d
FIX: change title when primary group changes ( #6602 )
2018-11-14 08:28:41 +08:00
fc9aafaa6a
New outlet above the main container
2018-11-13 14:34:20 -05:00
467be59d75
FEATURE: Allow expanded posts to return user custom fields
2018-11-13 12:44:54 -05:00
1570b01184
IE11 select-kit fix
2018-11-13 11:21:19 -05:00
c09a407f65
composer alignment fixes
2018-11-13 11:12:58 -05:00
af6569c396
Mobile group page flair alignment
2018-11-13 10:29:16 -05:00
7fa21ce199
UX: minor tweaks to theme components selection UI ( #6596 )
2018-11-13 14:57:50 +01:00
c1e82e7442
FIX: category row title ( #6597 )
2018-11-13 13:35:45 +01:00
ac7b058849
UX: take custom markup into account when docking header
2018-11-13 14:47:12 +08:00
80ceb57c76
DEV: add API endpoint to destroy_timings only of last post
...
Previously API only allowed you to nuke all timings from a topic,
new API is less punishing and allows you just to remove 1 post.
2018-11-13 16:07:48 +11:00
7707e42441
DEV: moves print-specific styles from internal style tag to external print sheet ( #6581 )
...
* DEV: removes internal styles from print view
* DEV: adds styles to print sheet
2018-11-13 14:45:55 +11:00
7b44339529
FIX: Prevent uploads used in site settings from being deleted.
2018-11-13 09:15:16 +08:00
27ce8cf851
UX: Improving group directory layout for small screens
2018-11-12 18:13:42 -05:00
d25ae13f0f
FIX: stricter `window.opener` checks ( #6578 )
2018-11-13 09:56:31 +11:00
0cb33d2b52
UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"
2018-11-12 16:23:37 -05:00
dda1824270
Use hijack in inline onebox controller
2018-11-13 02:39:20 +05:30
44d95ad5ab
FIX: Cache url data for failed inline oneboxes
2018-11-13 01:44:20 +05:30
486d7f2e5d
Select-kit dropdown fix
2018-11-12 12:21:54 -05:00
Gerhard Schlager
Vinoth Kannan
Maja Komel
Kris
Bianca Nenciu
Joffrey JAFFEUX
Guo Xiang Tan
Saurabh Patel
Neil Lalonde
David Taylor
Penar Musaraj
Joe
Sam
Kyle Zhao
Robin Ward
Jeff Wong
Rafael dos Santos Silva
Xiao Guan
Bianca Nenciu
Régis Hanol
Guo Xiang Tan
Arpit Jalan
Dan Ungureanu
Leo McArdle