Sam
788ca1f112
FIX: stop adding email to unsubscribe url
...
Instead of adding email to unsubscribe url store it in redis for 1 hour
rate limit calls to unsubscribe endpoint to ensure there is no risk of
bloating redis
Also move controller to request specs
2018-05-22 09:07:03 +10:00
Guo Xiang Tan
ae3a7ca08d
Fix unexpected return error.
2018-05-21 22:28:44 +08:00
Guo Xiang Tan
467d91347a
Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks.
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
bf84037f79
FIX: Payload for webhooks should be current as of the time the event was triggered.
...
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
cba3942850
Refactor `WebHookFlagSerializer`.
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
f0024f5ec7
Inherit from `BasicGroupSerializer` for `WebHookGroupSerializer`.
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
00c6b078e3
Trim `WebHookUserSerializer`.
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
60e7b13f59
Trim `WebHookPostSerializer` further.
2018-05-21 17:29:58 +08:00
Guo Xiang Tan
3ff0074e9d
Trim `WebHookTopicSerializer` further.
2018-05-21 17:29:58 +08:00
Arpit Jalan
1841dd48dc
FIX: revert utf-8 encode changes
2018-05-20 17:50:36 +05:30
Arpit Jalan
9f422c93f6
FIX: restrict updates on `confirm_old_email` email templates
2018-05-19 12:19:59 +05:30
Kris
8b96d9a52d
fixing group filter
2018-05-18 15:18:10 -04:00
Régis Hanol
e209faa6cf
UX: ensure whitespace isn't removed when playing with quotes
2018-05-18 19:32:10 +02:00
Arpit Jalan
290ee312e6
FIX: handle invalid mailto links
2018-05-18 18:02:52 +05:30
Arpit Jalan
9512796ef6
FIX: check for blank response when polling feed
2018-05-18 17:00:44 +05:30
Guo Xiang Tan
2fecb4b46e
FIX: Client not setting `TopicTimer#based_on_last_post`.
...
https://meta.discourse.org/t/incorrect-message-key-in-temporarily-closed-topic/87773
2018-05-18 16:32:12 +08:00
OsamaSayegh
0800098f1a
FIX: don't allow duplicate watched words ( #5844 )
...
We already have logic in place for server side, this'll just display a little message that says the word already exists
2018-05-18 10:11:08 +02:00
David Taylor
c168639be2
Add plugin outlet in admin theme list ( #5837 )
...
This will be used by discourse-theme-creator to add avatars next to each theme.
2018-05-18 10:09:21 +02:00
Guo Xiang Tan
1ff767559d
Fix incorrect param.
2018-05-18 14:05:45 +08:00
Guo Xiang Tan
c42b65df5f
`find` raises an error if the record is missing.
2018-05-18 13:37:07 +08:00
Arpit Jalan
003b7f06ad
FIX: rescue specific error
2018-05-18 09:52:16 +05:30
Guo Xiang Tan
416d19af27
FIX: Wrong target user displayed for user actions in activity stream.
...
https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816
2018-05-18 11:28:13 +08:00
Jeff Wong
04c7dbafa3
FIX: manifest.json better detection at mime type. Find size if uploaded
2018-05-17 14:45:24 -07:00
Joffrey JAFFEUX
4fd17abb76
linting
2018-05-17 23:44:38 +02:00
Kris
c1f13ce6a6
adding icons, updating style
2018-05-17 17:03:56 -04:00
Joffrey JAFFEUX
af548c23c4
new dashboard quality pass (code, tests and UI)
2018-05-17 22:44:33 +02:00
Jeff Wong
41ffafb65e
FIX: best effort at returning correct mime types in manifest.json
2018-05-17 12:14:39 -07:00
Andrew Schleifer
bc89674b58
FIX for bucket name in GlobalSetting with folder
...
When `s3_bucket="bucket/folder` in discourse.conf, absolute_base_url
was bucket/folder.s3-region.amazonaws.com
These names are bad, but this mirrors the s3_bucket/s3_bucket_name in
S3Store
N.B. that nearby s3_upload_bucket _should_ include the folder
2018-05-17 12:59:34 -05:00
Régis Hanol
53f8f6095d
FEATURE: staff action logs when creating/updating/deleting badges
2018-05-17 18:09:27 +02:00
Kris
7ab7696c94
fine-tuning dashboard alignment
2018-05-17 11:41:58 -04:00
Arpit Jalan
9532d9a555
FIX: handle invalid tags
2018-05-17 19:33:12 +05:30
Guo Xiang Tan
b74c108c09
UX: Display group tabs in user's messages tab for non-staff as well.
...
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
2018-05-17 18:10:17 +08:00
Guo Xiang Tan
b3981ddc43
Shorten `User.suggest_name` further.
2018-05-17 16:35:03 +08:00
Guo Xiang Tan
147ea37115
FIX: Missing notification for watching first post users when topic is recategorized.
...
https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld
2018-05-17 16:15:29 +08:00
Arpit Jalan
33899664ce
FIX: handle bad user profile website
2018-05-17 13:21:24 +05:30
Arpit Jalan
238a13643d
FIX: handle missing users when sending push notifications
2018-05-17 12:53:19 +05:30
Arpit Jalan
539cf32f87
FIX: handle encoded mailto links when looking for upload record
2018-05-17 12:44:53 +05:30
Guo Xiang Tan
117763493b
Refactor `User#suggest_name`.
...
* Rename `email` to `string` as variable can be an email, username
or any valid string.
2018-05-17 14:54:14 +08:00
Arpit Jalan
392f184b24
FIX: check for existence of topic before looking for category
2018-05-17 10:49:01 +05:30
Arpit Jalan
aee4045dd0
FIX: suggest name when username/name is provided
2018-05-17 10:36:36 +05:30
Sam
560a16d864
correct resizing in firefox
2018-05-17 14:47:10 +10:00
Barry van Oudtshoorn
b6322a35f2
Fix super-wide tables in Firefox
...
In Firefox (tested in Fx61), the "activity metrics" and related tables can become stupendously wide. Adding a `max-width` resolves this issue.
2018-05-17 14:41:39 +10:00
Sam
cc7ecb8a06
FIX: hyperlinks did not work in category boxes
2018-05-17 12:02:24 +10:00
Sam
f6c35e5abc
FIX: destroy picker if it was loaded
2018-05-17 11:18:04 +10:00
Sam
e0695b02d9
Stabalize order of tables in dashboard
2018-05-17 11:05:01 +10:00
Sam
c381d60471
Replace the "posts" line with message count
2018-05-17 10:26:30 +10:00
Sam
0b14e6b556
Resizing dashboard should not break graphs
2018-05-17 10:26:30 +10:00
Régis Hanol
a9ebde5111
FEATURE: new 'staged' users list for admins
2018-05-17 01:52:49 +02:00
Régis Hanol
bfbdee6a57
UX: show footer on groups pages
2018-05-17 01:34:44 +02:00
Régis Hanol
4f945abba2
FIX: infinite loading was broken on group activity posts/mentions pages
2018-05-17 01:34:13 +02:00
Régis Hanol
674318e127
UX: don't show 'auto delete' option for TL4
2018-05-17 00:42:48 +02:00
Kris
98f8f74f37
dashboard column alignment
2018-05-16 17:18:13 -04:00
Kris
91af7cf46c
dashboard alignment fix
2018-05-16 16:04:22 -04:00
Kris
827ba2d3cf
styling misc section of dashboard
2018-05-16 15:49:02 -04:00
Kris
4b0bf35cd7
dashboard style updates
2018-05-16 15:07:35 -04:00
Régis Hanol
b284464a91
FIX: PostOwnerChange should update 'topic.last_poser'
2018-05-16 19:48:04 +02:00
Jeff Atwood
dcf97ca559
Merge pull request #5834 from riking/admin-users-groups
...
UX: Add link to /groups from Admin>Users
2018-05-16 10:24:21 -07:00
Régis Hanol
39aceed63d
FIX: don't purge unactivated users with a message
2018-05-16 18:24:11 +02:00
Régis Hanol
938934f5e9
FIX: keep '<kbd>' formatting when quoting posts
2018-05-16 17:40:45 +02:00
Régis Hanol
d5ae0a92ef
FIX: puts the datepicker on it's own line on mobile device in the feature topic modal
2018-05-16 17:33:55 +02:00
Gerhard Schlager
ae6236d090
FIX: Changing owner of deleted reply didn't work
2018-05-16 17:03:09 +02:00
Régis Hanol
4103783821
FIX: don't use PMs in Incoming Links reports
2018-05-16 16:55:54 +02:00
Joffrey JAFFEUX
9554d9c56a
UX: tooltips and improvements to new dashboard
...
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Régis Hanol
131b7f5da5
make 🤖 rubocop happy
2018-05-16 16:35:04 +02:00
Joe Buhlig
3cd4c82c49
Allow parameters for group and username filters on directory ( #5815 )
2018-05-16 16:20:17 +02:00
Régis Hanol
489e7f220d
UX: show a message when more than 30 site settings matches the current filter
...
UX: show the counts when displaying only overridden settings
UX: show 30+ count when more than 30 site settings matches the current filter
2018-05-16 15:37:40 +02:00
Régis Hanol
5e97a9bfb7
FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone
2018-05-16 09:48:19 +02:00
Sam
6ee0eae335
=handle chart loading concurrency issues
2018-05-16 17:35:03 +10:00
Arpit Jalan
146f634c8f
FIX: UTF-8 encode feed response body
2018-05-16 12:59:23 +05:30
Sam
ff90881238
DEV: fix live refresh if you have a custom theme selected in dev
2018-05-16 17:25:49 +10:00
Sam
f9d2c69bbe
correct it so we always load Chart just before creating it
2018-05-16 16:44:35 +10:00
Guo Xiang Tan
565fa1f60e
Fix regression introduced in 8cf0f51eb2
.
2018-05-16 14:26:03 +08:00
Sam
21e0b7c818
avoid async report pattern and replace with simpler hijack
2018-05-16 16:05:03 +10:00
Sam
3864091f2d
correct links to admins and moderators
2018-05-16 15:24:52 +10:00
Kris
7dc192a081
improving column alignment
2018-05-16 00:23:02 -04:00
Kris
85425348c5
reducing margin
2018-05-15 22:32:19 -04:00
Sam
5d4502f18b
Split off topics and posts cause they have very different scales
2018-05-16 11:33:22 +10:00
Kris
693650c3a2
Scaling down H-tag size in posts
2018-05-15 21:04:51 -04:00
Kris
b850b2d0d2
Missing title for latest version
2018-05-15 20:58:00 -04:00
Kris
58eb45a560
Improving version section of dashboard
2018-05-15 20:19:31 -04:00
Jeff Wong
74aecdfd9d
Feature: add a 30 seconds grace window for 2-factor token checks
2018-05-15 16:13:21 -07:00
Jeff Wong
82a95164e9
Fix: Safari failing to download backups from email links
...
disable service workers on safari
bypass serviceworker network if this is a URL with a token param
2018-05-15 14:38:31 -07:00
Joshua Rosenfeld
e28a443fc1
Fix What's New Link
2018-05-15 17:04:13 -04:00
Gerhard Schlager
74c4af279a
Improvements to user renaming
...
* don't update search index if post belongs to deleted topic
* log errors instead of crashing when updating post or revision fails
* update mentions even when the href attribute is missing
* run the background job with low priority
* replace username in all notifications
* update `action_code_who` used by small action posts
2018-05-15 21:05:51 +02:00
Gerhard Schlager
3464b05e41
FIX: Allow editing post that belongs to deleted topic
2018-05-15 20:50:31 +02:00
Gerhard Schlager
2e1b5bc8d3
FIX: Transaction in UserAnonymizer prevented avatar from updating
2018-05-15 20:47:58 +02:00
Joffrey JAFFEUX
9947c38e1c
UX: support for multiple datasets in one chart
2018-05-15 20:12:03 +02:00
Arpit Jalan
51ee31b3eb
FIX: changing tag group privacy setting was not consistent ( #5818 )
2018-05-15 18:06:43 +02:00
Régis Hanol
a512b181d9
FIX: automatically in/decrement topic_tags.pm_topic_count
2018-05-15 16:05:48 +02:00
Régis Hanol
93ed8d2522
PERF: defer user notifications ( #5827 )
2018-05-15 09:51:32 +02:00
Joe
02e0426de6
FIX: search icon is rendered outside of tag-selector filter-input
...
Make the selectors from this sheet match the ones from selectors from the select-kit sheet... different states for the filter-input were causing it to expand outside of the tag-selector and push the search icon.
2018-05-15 15:28:27 +08:00
Sam
7dd68e64d9
FEATURE: allow plugins to modify class statics
...
Adds `modifyClassStatic` to plugin api which can be used to amend static
methods on a class
2018-05-15 16:01:51 +10:00
Sam
fe89f441ae
correct reports
2018-05-15 15:12:27 +10:00
Sam
193b6d5651
UX: improve new dashboard
...
- top referred topics
- limit search logs to 8 results
2018-05-15 15:08:36 +10:00
Sam
eb33f6e9b9
correct daily engaged users to look at average
2018-05-15 10:17:17 +10:00
Régis Hanol
a28c58feb1
FIX: automatic group membership when using SSO
2018-05-15 01:48:30 +02:00
riking
cdcb0a396f
FIX: IncomingLink: do not log IP of logged-in users
2018-05-15 09:32:29 +10:00
Joffrey JAFFEUX
e474351ae4
inactive users report is not used anymore
2018-05-14 21:31:14 +02:00
Jeff Wong
e4a33cbc0a
FIX: update cache times for service workers
...
Add a last modified time.
Register newer service workers and claim clients more quickly.
2018-05-14 12:29:24 -07:00
Régis Hanol
e9abdaebbe
UX: show an enveloppe icon when a badge is used in messages
...
- the badge count now includes messages
- only show the message badges to admins
2018-05-14 19:02:00 +02:00
Kris
1e132b4599
Checkbox fix for iOS
2018-05-14 11:11:16 -04:00
Joffrey JAFFEUX
34dbb32df4
FIX: makes report description optional
2018-05-14 16:34:56 +02:00
Joffrey JAFFEUX
83255d94d9
DateGroupable is not used anymore
2018-05-14 16:26:14 +02:00
Joffrey JAFFEUX
94b1a8c841
UX: disables all time col in activity metrics new dashboard
...
This commit also makes it work for old dashboard.
2018-05-14 16:04:54 +02:00
Gerhard Schlager
c67c2dc638
FIX: Username update should ignore revisions without raw
2018-05-14 15:22:42 +02:00
Joffrey JAFFEUX
ba0cec2091
UX: minor fixes to new dashboard UI
...
- adds a link to search log
- display a text if log search queries is disabled
- adds link to trust level and user types
- adds a description for eeach report when browsing a report directly
2018-05-14 14:23:51 +02:00
Gerhard Schlager
8232aba743
FIX: Update search index after renaming user within posts
2018-05-14 13:20:30 +02:00
Gerhard Schlager
02cb84847c
FIX: Update avatar in oneboxed posts when renaming user
2018-05-14 13:20:29 +02:00
Gerhard Schlager
49392fb105
FIX: Anonymizing user didn't replace uploaded avatar in posts
2018-05-14 13:20:29 +02:00
Régis Hanol
3e06598e96
FIX: only unstage staged users
2018-05-14 12:03:15 +02:00
Sam
cb9baaade9
correct localization for dashboard periods
...
previously would fail for non roman numerals
2018-05-14 16:31:50 +10:00
Sam
6332d5040d
UX: switch dashboard to be the new dashboard
...
Also:
- add pageviews
- add problems and version sections
2018-05-14 13:07:59 +10:00
Sam
d6316ac4b9
add some more protection
2018-05-14 12:01:57 +10:00
Sam
bc9e0d46af
PERF: use cached reports for dashboard if available
2018-05-14 12:01:44 +10:00
Sam
5f54b005a1
UX: remove ? from new dashboard
...
Link to actual report
2018-05-14 11:33:36 +10:00
Sam
9d97e1244e
correct it so when we have no dates we still return graphs
2018-05-14 11:12:52 +10:00
Régis Hanol
9d9332d8c9
FIX: allow user quotes in HTML digest emails
2018-05-13 18:23:17 +02:00
Régis Hanol
37232fcb58
FIX: staff members should see all tags
2018-05-13 17:50:21 +02:00
Régis Hanol
2cf6fb7359
FIX: always unstage users when they log in
2018-05-13 17:00:02 +02:00
Régis Hanol
be6404d651
FIX: redirect users after signing up with a social login when using SSO provider
2018-05-13 16:03:11 +02:00
Régis Hanol
81f4da7dd2
FIX: remove unneeded escape when building a Quote
2018-05-12 01:16:05 +02:00
Régis Hanol
09cf35c760
FIX: redirect users after signing up using SSO provider
2018-05-12 00:41:27 +02:00
Régis Hanol
abda21a41f
Revert "FIX: redirect to sso_destination_url after account activation"
...
This reverts commit 0402e97368
.
2018-05-11 22:55:45 +02:00
Régis Hanol
0402e97368
FIX: redirect to sso_destination_url after account activation
2018-05-11 19:57:04 +02:00
Kris
b10c684459
border/alignment fix
2018-05-11 10:23:31 -04:00
Régis Hanol
2958e17cde
remove duplicate code
2018-05-11 12:16:37 +02:00
Alexis Duran
1404294a12
Fix issue for custom image badges urls ( #5814 )
2018-05-11 10:29:24 +02:00
Sam
4f508b2358
correct sorting in dashboard
2018-05-11 16:32:12 +10:00
Sam
e92f9568a4
correct typo
2018-05-11 16:25:41 +10:00
Guo Xiang Tan
bed039aebf
Remove incorrect added code in d31417d3af (diff-655c787458e67d84dc1178f5d2b674f1)
2018-05-11 13:19:20 +08:00
Guo Xiang Tan
a0fc5de5c4
Revert "Static update for htmlHelper method within bound-avatar helper"
...
This reverts commit ba383027e8
.
2018-05-11 13:19:20 +08:00
Sam
67054d524d
correct missing day from async reports
2018-05-11 15:06:23 +10:00
Guo Xiang Tan
1e4abc63d0
Merge pull request #5813 from duranmla/ad/bound-avatar-typo
...
Static update for htmlHelper method within bound-avatar helper
2018-05-11 12:59:00 +08:00
Sam
8a783412b7
UX: improvements to new dashboard
...
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Alexis Duran
ba383027e8
Static update for htmlHelper method within bound-avatar helper
2018-05-10 19:15:34 -04:00
Blake Erickson
bd352a17bf
FIX: Show a json api response when deleting a user with posts
...
A 500 error was actually caused with no response when using the api, so
it wasn't very clear that you need to delete the posts first when using
the api.
2018-05-10 13:04:36 -06:00
Kris
5c7a235c03
minor mobile nav fix
2018-05-10 00:17:15 -04:00
Kris
941b309616
dashboard style adjustments
2018-05-09 21:33:53 -04:00
Guo Xiang Tan
c720bf32c3
UX: Add proper titles to topic navigation links in hamburger menu.
...
https://meta.discourse.org/t/what-is-the-difference-between-latest-and-new/47809/9?u=tgxworld
2018-05-10 09:29:02 +08:00
Kris
a2e2b83415
fix for tag notification dropdown
2018-05-09 19:03:02 -04:00
Kris
7d66e11771
UX: Mobile Nav Cleanup ( #5812 )
2018-05-09 17:48:34 -04:00
Régis Hanol
6a006b3646
FIX: format posts for embedded comments as we do for emails
2018-05-09 19:24:44 +02:00
Régis Hanol
deaf3682e9
FIX: clicking a group mention on mobile was 404ing
...
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol
3483c7bc58
FIX: supports user/group mentions and category hashtags when quoting posts
2018-05-09 12:42:12 +02:00
Régis Hanol
858ac6b61e
FIX: prevent theme uploads from overwriting existing variables
2018-05-09 11:54:43 +02:00
Sam
c475905387
Improvements to new community dashboard
...
- Limit dashboard to yearly,quarterly,monthly,weekly
- Always prefer UTC full days for reporting
2018-05-09 18:06:13 +10:00
Guo Xiang Tan
36d9f7f814
Revert "UX: Don't set width to auto for select kit combo box."
...
This reverts commit c7b526b9e0
.
2018-05-09 14:28:45 +08:00
Guo Xiang Tan
c7b526b9e0
UX: Don't set width to auto for select kit combo box.
2018-05-09 14:21:47 +08:00
Kris
5fc2dd8b8d
group name alignment in user-stream
2018-05-08 21:35:53 -04:00
Guo Xiang Tan
2eb2f273a8
Refactor of `PushSubscriptionPusher`.
2018-05-09 08:14:14 +08:00