72950e051c
Add category breadcrumbs to edit category page ( #13126 )
2021-05-25 13:40:11 -05:00
59097b207f
DEV: Correct typos and spelling mistakes ( #12812 )
...
Over the years we accrued many spelling mistakes in the code base.
This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change
- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
a532e64389
DEV: Some select-box headers don't need a class ( #12992 )
...
* DEV: Some select-box headers don't need a class
* remove duplicate class
2021-05-20 16:00:45 +10:00
582ec198d8
DEV: Update ember-cli across all in-repo addons ( #13048 )
...
…to match the version used in the app.
2021-05-12 21:49:55 +02:00
a7a2887df0
DEV: Remove unnecessary yarn.lock files ( #13001 )
...
All in-repo ember addons share the same yarn.lock in the yarn workspace: `/app/assets/javascripts/yarn.lock`
2021-05-11 11:15:07 +02:00
72648dd576
FIX: Base topic details message on current category and tag tracking state ( #12937 )
...
The user may have changed their category or tag tracking settings since a topic was tracked/watched based on those settings in the past. In that case we need to alter the reason message we show them otherwise it is very confusing for the end user to be told they are tracking a topic because of a category, when they are no longer tracking that category.
For example: "You will see a count of new replies because you are tracking this category." becomes: "You will see a count of new replies because you were tracking this category in the past."
To do this, it was necessary to add tag and category tracking info to current user serializer. I improved the serializer code so it only does 3 SQL queries instead of 9 to get the tracking information for tags and categories for the current user.
2021-05-06 09:14:07 +10:00
e7de943b5d
FIX: hide "Next Week" in future-date-input on Sundays ( #12918 )
2021-05-03 09:22:05 +02:00
2dfa1a267e
FIX: `TagDrop` uses `currentCategory` now ( #12786 )
2021-04-21 21:46:52 +02:00
e3b1f5721b
FIX: Enforce tag group count validation before sending to review queue ( #12728 )
...
There is a category setting that enforces 1 or more tags must be added to a topic from a specific tag group before creating it. This validation was not being run before the topic was being sent to a review queue for categories that have that setting enabled.
There was an existing validation in `TopicCreator` but it was not correct; it was only validating when the tags did _not_ exist and also only happened on `create`. I now run the validation in `TopicCreator.valid?`
I also improved the error message shown to the user when they have not added the tags required (showing the tag names from the tag group), and changed the composer tag selector to not show "optional" if there are N tags required from a certain group.
2021-04-19 09:43:50 +10:00
8c6ea967ae
FEATURE: Show the slow mode indicator in composer ( #12720 )
2021-04-17 23:40:09 +04:00
35f977f8a5
UX: Prevent some composer buttons from receiving focus ( #12719 )
2021-04-16 11:10:02 -04:00
8339b8f412
FEATURE: Make the tag_groups#search endpoint public. ( #12643 )
...
The method uses the "TagGroup#visible" method to respect the tag group visibility settings.
2021-04-08 14:23:13 -03:00
081ada090c
UX: shows a hint when there are more tags than displayed ( #12649 )
2021-04-08 15:51:31 +02:00
c9923a3e3e
UX: Composer actions menu header should display the icon of selected action ( #12449 )
...
See a video of the change in the PR: https://github.com/discourse/discourse/pull/12449 .
2021-03-19 17:48:43 +03:00
83519e7f3a
FEATURE: Always show tag dropdown when tagging is enabled ( #12209 )
2021-03-10 21:13:15 -05:00
0f807ba85b
UX: Allow select-kit to have an autofocus option ( #12183 )
...
On some modals the main/primary input field is a select-kit component (like `{{email-group-user-chooser}}` on the assign modal), so it makes sense to allow select-kit to steal focus on modals like these. This PR adds an `autofocus` option (default false) that allows select-kit to steal focus when it's rendered.
2021-02-23 13:20:32 +03:00
d0d54bbead
A11Y: deselect focused choice when using enter in multi-select ( #12165 )
2021-02-22 14:34:31 +01:00
47835ade9a
UX: implements a new tags-intersection-chooser ( #12139 )
2021-02-19 13:46:02 +01:00
d89c5aedbe
FIX: Fix subcategory, tag drops and none values ( #11934 )
...
* FIX: Generate correct URLs for category and tag drops
* DEV: Remove unused properties
* FIX: No subcategory and tag filter did not work
2021-02-16 17:54:24 +02:00
277eae97e1
FIX: Use autocomplete=discourse in select-kit to disable autocomplete in Chrome ( #12094 )
...
Chrome ignores `autocomplete="off"` on input fields, but as a workaround we can supply a nonsensical value (`discourse` or anything else) to the `autocomplete` attribute and it'll disable autocomplete.
Context: https://meta.discourse.org/t/-/107484/66?u=osama and https://meta.discourse.org/t/-/140884/13?u=osama .
2021-02-16 12:46:46 +03:00
323a5f22e7
A11Y: makes select-kit header a listbox ( #12078 )
...
Note that for now pressing enter doesn’t make anything, this is awaiting another change.
2021-02-15 18:22:10 +01:00
467b075ef7
A11Y: makes aria-owns an ID and not a data attribute ( #12075 )
2021-02-15 12:32:09 +01:00
71e9c2e50b
A11Y: sets has-popup as menu for select-kit components ( #12074 )
2021-02-15 12:31:51 +01:00
834388dbe0
UX: trim `@` char from start of the username string in search. ( #12060 )
...
Currently, we're unable to search users by their username with the `@` symbol in "Posted by" filter on advanced search page.
2021-02-12 19:38:13 +05:30
293fd1f743
DEV: Deprecate {{user-selector}} and replace it with {{email-group-user-chooser}} ( #12042 )
...
`{{user-selector}}` is now deprecated and it will be removed from core in Discourse 2.8. All instances of `{{user-selector}}` has been replaced with `{{email-group-user-chooser}}`.
2021-02-12 13:51:36 +03:00
fcdf7ef019
UX: Remove 2px border from some select-kit buttons ( #12016 )
2021-02-09 16:35:10 +11:00
6d31ead050
A11Y: correctly sets a name on combo-boxes for single selects ( #12009 )
2021-02-08 11:24:42 +01:00
3ed6747bf2
UX: Show caret icon on user notification dropdown ( #11991 )
2021-02-05 10:30:36 -05:00
97b55af9cf
DEV: Use @action decorator ( #11955 )
...
Follow up to db7b7eed9d
2021-02-04 14:41:53 +11:00
2dc48fd6c1
UX: Uniformize styles for focus states ( #11933 )
2021-02-03 11:45:54 -05:00
155ae06f62
DEV: Remove `group-members-dropdown` ( #11948 )
...
It was introduced in c82b2dcc24b76731d72258ee947b35
2021-02-03 17:42:12 +01:00
db7b7eed9d
FIX: Restore support for pasting multiple PM recipients ( #11945 )
...
This is a regression from 98201ecc24https://meta.discourse.org/t/-/178167?u=osama .
Signed-off-by: OsamaSayegh <asooomaasoooma90@gmail.com>
2021-02-03 18:06:16 +03:00
6d72c8ab19
FEATURE: Topic timer UI revamp ( #11912 )
...
This PR revamps the topic timer UI, using the time shortcut selector from the bookmark modal.
* Fixes an issue where the duration of hours/days after last reply or auto delete replies was not enforced to be > 0
* Fixed an issue where the timer dropdown options were not reloaded correctly if the topic status changes in the background (use `MessageBus` to publish topic state in the open/close timer jobs)
* Moved the duration input and the "based on last post" option from the `future-date-input` component, as it was only used for topic timers. Also moved out the notice that is displayed which was also only relevant for topic timers.
2021-02-03 10:13:32 +10:00
12a4fefef6
FIX: ensures rects is present before using it ( #11930 )
...
I don't have a clear reproduction ATM, but I imagine that in fast tests element can get destroyed before we get to use it.
2021-02-02 14:43:13 +01:00
98201ecc24
DEV: {{user-selector}} replacement ( #11726 )
...
This PR is the first step towards replacing our `{{user-selector}}` and eventually deprecating and removing it from our codebase. Some of `{{user-selector}}` problems are:
1. It's called `{{user-selector}}`, but in reality in can also select groups and emails.
2. It's an Ember component, yet it doesn't have a handlebars template and uses jQuery to render itself and modify the DOM. An example of this problem is when you want to clear the selected users programmatically, see [this](6c155dba77/app/assets/javascripts/discourse/app/components/user-selector.js (L179-L185)
2021-02-01 13:07:11 +03:00
ce904dc765
DEV: Remove tabindex property from selected name template ( #11882 )
2021-01-28 13:42:59 -05:00
e031679f99
A11Y: Add aria-label to input clear button ( #11803 )
2021-01-21 21:58:34 -05:00
ff095e7249
A11Y: Update selected name role to button ( #11804 )
2021-01-21 21:58:06 -05:00
a8169e93c2
DEV: implements combobox roles for select-kit ( #11769 )
...
https://www.w3.org/TR/wai-aria-practices-1.1/#wai-aria-roles-states-and-properties-6
2021-01-20 15:50:53 +01:00
ce01f9db46
DEV: adds support for lang attribute in select-kit ( #11741 )
2021-01-18 15:34:18 +01:00
53f9a0883e
UX: allows to copy/paste a list of | separated values in sk ( #11642 )
...
* UX: allows to copy/paste a list of | separated values in sk
* fixes tests
2021-01-06 12:57:13 +01:00
142e0ae062
Revert "Revert "DEV: Wrap `Ember.run.debounce`. ( #11352 )"" ( #11509 )
...
* Revert "Revert "DEV: Wrap `Ember.run.debounce`. (#11352 )" (#11465 )"
This reverts commit aa0d4ea764
2020-12-18 10:18:52 -03:00
aa0d4ea764
Revert "DEV: Wrap `Ember.run.debounce`. ( #11352 )" ( #11465 )
...
This reverts commit 8b426431a4
2020-12-10 16:48:25 -03:00
8b426431a4
DEV: Wrap `Ember.run.debounce`. ( #11352 )
...
We want to wrap the `Ember.run.debounce` function and internally call `Ember.run` instead when running tests.
This commit changes discourseDebounce to work the same way as `Ember.run.debounce`.
Now that `discourseDebounce` works exactly like `Ember.run.debounce`, let's replace it and only use `DiscourseDebounce` from now on.
Move debounce to discourse-common to be able to reuse it in different bundles
Keep old debounce file for backwards-compatibility
2020-12-10 11:01:42 -03:00
3e1b84963d
DEV: Remove duplicate (and deprecated) SK option ( #11435 )
2020-12-08 13:21:02 -05:00
490e1cfbbb
DEV: Use tag renderer in tags filter dropdown ( #11378 )
...
A small change that would allow components to extend the tag
display in the filter dropdown, like they can in other contexts.
Was requested in the tag icons component, see
https://meta.discourse.org/t/tag-icons-component/109757/60?u=pmusaraj
The PR also standardises tag styling in select-kit dropdowns.
2020-12-07 12:10:21 -05:00
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
1c2358ba16
DEV: Tidy up imports. ( #11364 )
...
Only allow one import definition per file and add a new eslint rule to enforce it.
2020-11-27 11:30:16 -03:00
4638c6fc8d
FEATURE: Add 'all subcategories' option in category-selector ( #11099 )
2020-11-23 10:55:32 +02:00
ec4c2a58ea
FIX: Paths with categories and tags were being generated incorrectly ( #11167 )
...
Paths prefixed with /tag/ are exclusively for when the tag name is the
next string in the path. Therefore, when a category is being used as
context, the path should start with /tags/ instead.
2020-11-09 12:34:52 +00:00
2d4455161b
FIX: Correct "no tags" route in tag drop-down ( #11142 )
...
We refactored routes and removed /tags/none... instead is should be /tag/none
2020-11-06 10:28:57 +11:00
7b312b7bc6
FIX: Category drop shows undefined ( #11090 )
...
After 5fc239b535
2020-10-30 14:20:10 -05:00
2d5bb516a6
FIX: keep tag filter value when changing the category dropdown. ( #11065 )
...
Previously, while filtering the topics by tag, selecting a category loses the selected tag value.
2020-10-30 11:56:20 +11:00
5fc239b535
FIX: converts html to text to use it as title attribute ( #11009 )
2020-10-27 11:05:10 +01:00
281bf0b345
FIX: optimizes sk body position in RTL mode ( #10997 )
2020-10-22 16:08:11 +02:00
a73fd4227f
FIX: disabled option for sk was not working correctly ( #10900 )
...
Name was incorrect and it was only removing cursor events and not changing style.
2020-10-13 11:31:07 +02:00
c3e8bc0280
FIX: ensures category chooser is working with non english char ( #10866 )
...
This commit is also moving one test to a component test.
A followup to this commit would be to ensure every dropdowns are using a regex instead of the normalize/lowercase system we have now.
2020-10-08 13:10:09 +02:00
c5a2de99d1
FIX: `mouseEnter` is deprecated in newer Ember releases
...
This is the recommended fix via:
https://deprecations.emberjs.com/v3.x/#toc_component-mouseenter-leave-move
2020-09-23 15:29:41 -04:00
ce3fe2f4c4
REFACTOR: Support bundling our `admin` section as an ember addon
2020-09-22 15:14:29 -04:00
530d9ab071
DEV: enforces eslint’s curly rule to the codebase ( #10720 )
...
eslint --fix is capable of fix it automatically for you, ensure prettier is run after eslint as eslint --fix could leave the code in an invalid prettier state.
2020-09-22 16:28:28 +02:00
1db8315a8b
UX: Remove the post number from a composer label
...
It didn't provide much value to users as it often didn't match the number visible in the topic timeline. That's because `postNumber` is an implementation detail, while the timeline counts only full visible posts (no whispers, topic action notices, etc.)
2020-09-21 14:47:36 +02:00
324aa3eb61
REFACTOR: reworks all the search-advanced-options panel ( #10661 )
...
* REFACTOR: reworks all the search-advanced-options panel
This commit includes the following changes:
- prevents any mutation of external (to the component) values
- get rid of observers
- uses @action
- minor UI tweaks
- dropped the unecessary debounce
- drops all the legacy code for badges/groups which is not being used
- replaces user-selector by user-chooser and improves multi-select to not show `search` if maximum has been reached
Most importantly this refactor should fix multiple bugs due to _update() being called multiple times if searchTerm was empty and other various bugs where some changes in searchTerm was not applied to the sidebar.
2020-09-15 09:39:12 +02:00
9238a9e427
FIX: adds shims for popper in wizard ( #10658 )
2020-09-14 12:33:14 -04:00
24f19e8372
Revert "FIX: Was using a global `Popper` variable"
...
This reverts commit 05831c2b42
2020-09-11 17:30:53 -04:00
05831c2b42
FIX: Was using a global `Popper` variable
2020-09-11 15:02:12 -04:00
ac08dfac45
FIX: Ember has deprecated `isVisible` in newer versions
2020-09-11 14:53:44 -04:00
52672b9eab
DEV: apply new coding standards ( #10592 )
2020-09-04 13:42:47 +02:00
aae97457d2
REFACTOR: Don't use `layoutName` in select-kit ( #10556 )
...
Instead import the templates as modules, the way Ember CLI wants us to.
2020-08-28 15:30:20 -04:00
ff4de97dfd
REFACTOR: Move `bootbox` to an import instead of global variable ( #10533 )
2020-08-26 12:57:13 -04:00
8b2c4b07a4
UX: Tweaks to admin color palette dropdown ( #10502 )
2020-08-21 09:30:11 -04:00
328ad921fb
FIX: display label when theme uses default color scheme
2020-08-18 21:11:15 -04:00
58ee947b35
FIX: Mobile group add dropdown was broken
...
It looks like we removed the bulk add modal but didn't update the mobile
template.
2020-08-14 21:03:41 -04:00
be6a73f654
DEV: Fix package.json issues and reroll yarn.lock
2020-08-14 12:00:35 +02:00
fc5111508f
FIX: allow mods to choose restricted categories as parent category.
...
Currently moderators can't choose a category with only “See” permission as a parent in `edit-category` modal.
2020-08-12 20:58:52 +05:30
af63871d4d
FIX: Missing bottom border in select-kit color list settings
2020-08-06 14:52:17 -04:00
e0d9232259
FIX: use allowlist and blocklist terminology ( #10209 )
...
This is a PR of the renaming whitelist to allowlist and blacklist to the blocklist.
2020-07-27 10:23:54 +10:00
6e94f28cf0
FIX: Error in test mode with missing `topic`
2020-07-17 14:37:08 -04:00
6ba1c64130
FIX: deprecation - `usernames` is now `recipients`
2020-07-16 15:42:51 -04:00
70771e02bb
FIX: Removal of i18nPrefix deprecations
2020-07-16 10:41:11 -04:00
97f581e1df
FIX: add protection just in case topic is not set
...
Under some conditions we may be loading the composer with no topic set.
This code could fail leading to a broken composer.
2020-07-15 11:38:46 +10:00
6705c45156
FEATURE: Add reply_as_new_group_message composer action ( #10168 )
2020-07-07 18:30:48 +03:00
aff9bfd5bc
FIX: Fix select kit size ( #10094 )
2020-06-22 16:48:00 +03:00
52580605d8
FIX: select-kit components not being hidden.
2020-06-17 09:39:51 +08:00
35a157619a
FEATURE: Add "Now" as an option (default hidden) to the future date input selector ( #10047 )
...
Sometimes you need to schedule things from now onward. "Now" in this case is now + 1 minute. this option is hidden by default.
2020-06-15 14:06:03 +10:00
ff6811ceb8
Allow multiple groups which can vote when creating a poll ( #10015 )
...
* FEATURE: Allow multiple groups which can vote when creating a poll
* DEV: Fix select-kit deprecations
* DEV: Fix lint
2020-06-12 14:52:32 +03:00
dd85d44dda
FIX: Show tag count for existing tags ( #9892 )
...
* FIX: Show tag count for existing tags
* Add test
2020-06-11 14:13:48 +03:00
c5b1f028ed
FIX: update minimum required tag when switching categories in composer
2020-06-08 17:10:26 -04:00
3e7f7fdde8
FEATURE: category setting for default list filter. ( #9975 )
2020-06-04 00:56:56 +05:30
ba00cc8ec4
DEV: Move `Discourse.getURL` and related functions to a module ( #9966 )
...
* DEV: Move `Discourse.getURL` and related functions to a module
* DEV: Remove `Discourse.getURL` and `Discourse.getURLWithCDN`
* FIX: `get-url` is required for server side code
* DEV: Deprecate `BaseUri` too.
2020-06-03 12:45:26 -04:00
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eeee62a85cf2660c2e203d26cd6
2020-05-23 00:56:13 -04:00
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f2660c2e21d
2020-05-22 20:25:56 -07:00
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
6c9c8dfefd
FIX: `guidFor` is not part of `Ember.Object`
2020-05-20 11:31:11 -04:00
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
42e5a5bb39
DEV: do not append/prepend if callback returns nothing ( #9778 )
2020-05-14 14:38:03 +02:00
fdea969f14
DEV: Minor follow up to d7e230c1b9
2020-05-14 16:02:54 +08:00
95a80525ae
DEV: Remove erroneous code introduced in d7e230c1b9
2020-05-14 15:58:44 +08:00
d7e230c1b9
UX: Introduce composer-actions when editing a post.
2020-05-14 15:56:08 +08:00
eab560fe2a
DEV: import I18n instead of global usage ( #9768 )
...
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-05-13 16:23:41 -04:00
7cdf41d311
DEV: Remove reference to Discourse.Category
2020-05-11 18:28:45 -04:00
af6e61defd
FIX: sets a title for notifications button ( #9745 )
2020-05-11 20:46:08 +02:00
5a073c6a0a
Revert "FIX: title should attempt to fallback to label before name ( #9739 )"
...
This reverts commit c6bf552ca3
2020-05-11 20:09:11 +02:00
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
5a201082c7
REFACTOR: removes useless conditional ( #9667 )
...
This use of variable 'content' always evaluates to true.
2020-05-07 16:25:44 +02:00
87b1d435d2
FIX: improves positioning of sk in mobile when inside a modal ( #9657 )
2020-05-07 09:10:29 +02:00
c99ecba68f
DEV: improves sk api ( #9653 )
...
- reduces the API to 3 actions for now: appendContent/prependContent/onChange
- well tested
- removes all previous APIS which were only half supported or too dangerous as they could collide with other plugins or core behaviors
- this plugins also puts every sk test helpers in one file
2020-05-06 17:16:20 +02:00
6b14a0f352
FIX: apply sameWidth from 450px screen width
2020-05-05 13:01:02 +02:00
bd0abddf6f
UX: attempts to have a better use of available space with sk ( #9639 )
2020-05-05 12:59:47 +02:00
5e9c96dfed
REFACTOR: minor tweaks to user's notifications-filter ( #9623 )
2020-05-04 09:09:13 +02:00
99abdf51cd
FEATURE: adds a filter for all/unread/read on user's notifications page ( #9535 )
2020-05-04 08:36:59 +02:00
07e6452759
FIX: makes tracking shortcuts working when tracking button is not visible ( #9575 )
2020-04-28 20:12:16 +02:00
a8308e73e7
FIX: improves tag-list setting ( #9574 )
...
- Prevents setting to display an empty tag
- Updates dropdown when selecting/removing tag
2020-04-28 20:05:30 +02:00
d83f39be73
DEV: replaces jquery scrollTop by vanilla js code ( #9543 )
2020-04-24 12:45:47 +02:00
b871e79c5b
FIX: removes rounding correction as it can be in either direction ( #9538 )
2020-04-23 23:10:40 +02:00
3bbd8b1258
UX: rework date time input range ( #9524 )
2020-04-22 22:17:53 +02:00
00f632fb0d
REFACTOR: s/translatedfilterPlaceholder/translatedFilterPlaceholder ( #9521 )
2020-04-22 20:39:55 +02:00
4c248fc5c4
UX: do not attempt to full width sk on mobile ( #9520 )
2020-04-22 20:39:45 +02:00
4889dbde49
FIX: differentiate sk outline handling on single/multi ( #9512 )
2020-04-22 13:02:20 +02:00
5c45363e67
UX: better outline support in sk components ( #9510 )
2020-04-22 10:54:02 +02:00
62459c845f
DEV: allows a sk component to stop click propagation ( #9495 )
2020-04-21 17:11:40 +02:00
79058a6d99
DEV: makes sk scroll to current selection ( #9492 )
2020-04-21 16:48:49 +02:00
4f834f0008
DEV: allows click to propagate outside of header but not outside of sk ( #9491 )
2020-04-21 16:20:05 +02:00
35f51100e1
FEATURE: Users can be ignored for six months. ( #9446 )
2020-04-17 10:27:11 -03:00
5a8a844e4e
FIX: attempts to listen more reliably to scopedCategoryId changes ( #9431 )
2020-04-15 19:59:27 +02:00
c4644c61d9
DEV: enforces double quotes ember-template-lint ( #9416 )
2020-04-14 08:18:49 +02:00
b66b277dc4
DEV: enforces block-indentation of ember-template-lint rules ( #9408 )
2020-04-13 17:17:20 +02:00
a947b7b839
FIX: prevents registering multiple `topic-notifications-button:changed` ( #9356 )
...
A large topic page will always have the bottom tracking button, and will also have the timeline, meaning we already had 2 tracking events.
But it gets even worse when you know that the timeline button is a component connector which will trigger `didInsertElement` very frequently, meaning we were constantly adding more and more appEvents handlers.
2020-04-06 15:06:26 +02:00
883901e4c0
FIX: do not attempt to deselect tags if filter is not empty ( #9345 )
2020-04-03 16:27:56 +02:00
cade4957ae
DEV: don't use _ cause property is observed
...
Followup on fcc5ef96
2020-04-02 10:22:13 +11:00
b8d2261db9
FIX: correctly load drafts based of id
...
Previously we relied on race conditions to correctly open a draft, so this
broke.
New code is deliberate.
Also corrects missing observers on composer action
2020-04-01 14:23:26 +11:00
fcc5ef9625
FIX: when switching reply type update options
...
Previously we were not correctly updating reply types leading to inconsistent
behavior when using drop down in composer (for reply type)
2020-03-31 14:40:57 +11:00
fa5ba6beb8
FIX: ensures mini-tag-chooser display min tags req if no selection ( #9303 )
2020-03-30 19:34:53 +02:00
dbc323e12a
Fix the typo.
2020-03-25 23:32:32 +05:30
07813c4a91
Convert select-kit from es6 to js ( #9246 )
...
* Convert select-kit from es6 to js
* Hide more git blames
2020-03-20 12:40:32 -04:00
aad12822b7
FEATURE: automatically delete replies on a topic after N days. ( #9209 )
2020-03-19 21:06:31 +05:30
b727e39a42
DEV: gives sk components a way to trigger a search manually ( #9199 )
2020-03-13 12:41:08 +01:00
683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ( #9165 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
e848d98782
FIX: ensures category exists for hideParent in categoryBadgeHTML ( #9161 )
2020-03-11 00:58:46 +01:00
f795c1b8e8
Revert "DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )"
...
This reverts commit d436b600fb
2020-03-10 15:00:12 -03:00
3f2c0b42fe
FIX: throttles topic tracking shortcut and enforces topic id ( #9159 )
2020-03-10 17:17:54 +01:00
d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ( #9150 )
...
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.
Also introduces an htmlSafe computed macro:
```
import { htmlSafe } from "discourse/lib/computed";
htmlDescription: htmlSafe("description")
```
Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
020c1b9cf3
FIX: correctly checks if component is in modal ( #9157 )
2020-03-10 12:22:56 +01:00
78a6b76310
FIX: ensures pinned-options header is showing correct state ( #9156 )
2020-03-10 09:56:55 +01:00
5037b80c9c
Merge imports from the same module ( #9144 )
2020-03-09 17:38:37 +01:00
4f37233208
DEV: enforces ember-template-lint: simple-unless ( #9146 )
2020-03-09 13:44:34 +01:00
48ba65f406
DEV: Clean up Ember imports ( #8979 )
...
Includes:
* Import `computed` helpers
* Import `@ember/application`
* Import `isBlank` from `@ember/utils`
* Import `A` from `@ember/array`
* Import `EmberArray` from `@ember/array`
* Import `ArrayProxy` from `@ember/array/proxy`
* Import `warn` from `@ember/debug`
* Import `EmberObject` from `@ember/object`
* Import `Application` from `@ember/application`
* Import `EmberRouter` from `@ember/routing/router`
* Import `isPresent` from `@ember/utils`
* Import `computed` from `@ember/object`
* Import `guidFor` from `@ember/object`
* Import `isArray` from `@ember/array`
* Import `TextField` from `@ember/component`
* Import `TextArea` from `@ember/component`
* Import `Promise` from `rsvp`
* Import `Evented` from `@ember/object/evented`
* Replace deprecated `ember-addons/ember-computed-decorators` imports
2020-03-06 23:49:28 +01:00
bb5990781e
FIX: allows to define placement strategy of select-kit body ( #9109 )
2020-03-06 20:27:33 +01:00
29c9d8a133
FIX: uses only global allow_uncategorized_topics for category drop ( #9130 )
2020-03-06 20:11:21 +01:00
ed85cfe141
FIX: prevents click on sk header to bubble ( #9084 )
2020-03-02 20:06:02 +01:00
2db8ada222
FIX: ensures category url of category drop is built using slug and id ( #9069 )
2020-02-28 17:58:22 +01:00
501936f0da
FIX: prevents loading to show during debouncing ( #9060 )
...
This will also fix a bug in IE11 where click event would not be triggered on row
2020-02-27 15:20:04 +01:00
56345faf9a
FIX: prevents row click event to be caught by filter input event ( #9059 )
...
This was causing some dropdowns to not work under IE11
2020-02-27 14:04:23 +01:00
d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ( #9030 )
...
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
f336aeee6f
FIX: ensures scoped search category is searching in all categories ( #9031 )
2020-02-24 19:19:53 +01:00
0b0290cddb
FIX: muted was not working in topic timeline ( #9021 )
2020-02-21 21:32:58 +01:00
e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic ( #9018 )
2020-02-21 12:16:05 +01:00
9f8a27a132
DEV: Import `makeArray` from `discourse-common` instead using `Ember` global ( #8977 )
2020-02-19 00:57:58 +01:00
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
2020-02-17 13:10:26 +00:00
d33aaa0292
FIX: sk body should follow wrapper width ( #8984 )
2020-02-17 10:39:20 +01:00
9feace3388
FIX: prevents error when loading tag groups ( #8983 )
2020-02-17 10:39:04 +01:00
7d94de6439
FIX: brings back castInteger as a safer migration path for sk2 ( #8966 )
2020-02-14 10:00:39 +01:00
3875785dcc
FIX: ensures shortcuts work correctly with topic-notifications-button ( #8956 )
2020-02-13 10:01:28 +01:00
42bda52486
FIX: ensures select-kit can select a row with 0 as value ( #8955 )
2020-02-13 09:04:32 +01:00
efa9ba4975
UX: Prevent category-drop topic count from wrapping to new line ( #8943 )
2020-02-12 14:34:16 -05:00
adbff5835d
FIX: correctly excludes current user in user-chooser ( #8928 )
2020-02-11 20:41:18 +01:00
9d50e1b40f
DEV: introducing user-chooser ( #8910 )
2020-02-11 15:54:56 +01:00
99ad2e408a
DEV: enforces style-concatenation linting rule ( #8888 )
2020-02-10 08:13:50 +01:00
252989e261
DEV: better detection of new item ( #8889 )
2020-02-07 14:12:17 +01:00
a0bf2ac313
DEV: applies valueAttribute deprecation when null ( #8887 )
2020-02-07 10:39:39 +01:00
d86ed028c7
FIX: ensure s2 is working with wizard ( #8886 )
2020-02-07 10:00:39 +01:00
6bee972a5c
FIX: corrects min/max logic for mini-tag-chooser ( #8871 )
2020-02-05 17:47:20 +01:00
6253ddc74e
DEV: Do not trigger missing icon warning in icon picker
2020-02-05 11:39:46 -05:00
499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage ( #8782 )
2020-02-05 10:14:42 -06:00
98303ee645
FIX: simplify maximum/minimum logic in sk2 to avoid chicken/egg ( #8868 )
2020-02-05 16:01:58 +01:00
Mark VanLandingham
Josh Soref
Kris
Jarek Radosz
Martin Brennan
Andrei Prigorshnev
Penar Musaraj
Roman Rizzi
Joffrey JAFFEUX
Osama Sayegh
Bianca Nenciu
Vinoth Kannan
Dan Ungureanu
Daniel Waterworth
Sam
Justin DiRose
Robin Ward
Vinoth Kannan
Krzysztof Kotlarek
Guo Xiang Tan
Michael Brown
Jeff Atwood
Ahmed Gagan
David Taylor