Commit Graph

16652 Commits

Author SHA1 Message Date
Kris 2aca08b75e Adding data-category-id to category page for mobile 2018-03-26 10:00:43 -04:00
Guo Xiang Tan dcd1d422d1 UX: Allow admins to set users as owners while adding users.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
2018-03-26 17:33:50 +08:00
Guo Xiang Tan 35745166b5 UX: New group membership management workflow.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
2018-03-26 16:15:02 +08:00
Guo Xiang Tan 3d18cd1d9d Raise error when timestamp is invalid when creating topic timers.
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702
2018-03-26 11:33:52 +08:00
Guo Xiang Tan 252e58dfe9 FIX: Could not create topic timers for certain locales.
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702/2
2018-03-26 10:51:49 +08:00
Guo Xiang Tan 2f61780a49 Remove file that is no longer used. 2018-03-26 10:27:28 +08:00
Régis Hanol 9d6d8631ad Revert "FIX: remove scrolling jankiness"
This reverts commit b1a799b526.
Was not working properly on mobile...
2018-03-24 03:53:28 +01:00
Régis Hanol c5c1d8e180 Add support for the '/p/:post_id' route on the client-side 2018-03-24 02:44:39 +01:00
Régis Hanol 3a58dc0858 Add new 'jumpToPostId' plugin API method 2018-03-24 02:43:39 +01:00
Régis Hanol f56a746d71 Add baseUri to site model 2018-03-24 02:43:19 +01:00
Régis Hanol b1a799b526 FIX: remove scrolling jankiness 2018-03-24 02:39:36 +01:00
Blake Erickson 9fdf139235 Add tests for Site Settings import/export
- extracted out site settings rake task to a class
- added tests for import and export of site settings
2018-03-23 14:55:17 -06:00
Kevin Elliott fa0868fc3f Explicit param permit and assignment cleanup. 2018-03-23 09:59:31 -07:00
Robin Ward 5f19ad9507 FIX: allow destination categories to be set if not at first 2018-03-23 11:33:02 -04:00
Robin Ward 38af67eb73 Update the destination category id when a user changes it 2018-03-23 11:12:56 -04:00
Kris 6e4b8901ce Removing extra margin on tag-chooser 2018-03-23 10:32:27 -04:00
Sam 62f09af1c2 UX: occasionally getting scrollbar while loading notifications 2018-03-23 18:19:28 +11:00
Guo Xiang Tan c294798561 Fix alignment of groups filter inputs on FF. 2018-03-23 13:46:02 +08:00
Guo Xiang Tan 3f59ba20ec Align `.control-label`s with input field. 2018-03-23 13:42:17 +08:00
Guo Xiang Tan 7a4b70ef58 UX cleanup changes to 2FA flow. 2018-03-23 11:05:36 +08:00
Sam 0db13f62eb FIX: unable to remove tags from topics in quick save 2018-03-23 13:55:24 +11:00
Kris 803b53f2e3
Adding space before URL click-counter for improved copy & paste-ability (#5698) 2018-03-22 21:27:08 -04:00
Arpit Jalan 9a184b355d
Merge pull request #5696 from techAPJ/instagram-aspect-image
UX: wrap instagram images with aspect ratio
2018-03-23 04:00:52 +05:30
Neil Lalonde ced7e9a691 FEATURE: control which web crawlers can access using a whitelist or blacklist 2018-03-22 15:41:02 -04:00
Joffrey JAFFEUX cbbeedf53b
FIX: fires onExpand/onCollapse when using arrows 2018-03-22 18:35:46 +01:00
Joffrey JAFFEUX 841e2ba723
FIX: prevents multiple search call when destroying multiple tags 2018-03-22 18:11:47 +01:00
Joffrey JAFFEUX 037cc63b91
FIX: minor alignments improvements to select-kit 2018-03-22 17:17:28 +01:00
Arpit Jalan 33c1aeb2ac UX: wrap instagram images with aspect ratio 2018-03-22 21:35:10 +05:30
Arpit Jalan 4a6fb242bd UX: correct styling for Instagram onebox 2018-03-22 21:11:47 +05:30
Joffrey JAFFEUX 4f61f5db27
FIX: event is not present here
TODO: make event accessible everywhere and in a more consitent way.
2018-03-22 16:17:23 +01:00
Guo Xiang Tan 16c6af2ab0 Focus on input when showing 2FA form in login modal. 2018-03-22 21:45:28 +08:00
Guo Xiang Tan 62ee332efa Fix lint. 2018-03-22 21:12:41 +08:00
Guo Xiang Tan 0a567d0176 UX: Add mobile template for group members page. 2018-03-22 20:59:30 +08:00
Joffrey JAFFEUX d48542796e
FIX: select-kit refactoring
- improve mini-tag-chooser keyboard behavior
- all multil select now respond to select all and left/right arrows
- improve events handling
- many minor tweaks
2018-03-22 11:29:55 +01:00
Jeff Atwood d7c2d2edb8 remove extraneous "click to show" copy 2018-03-22 02:19:57 -07:00
Guo Xiang Tan fa95699fde Fix the build. 2018-03-22 14:20:27 +08:00
Arpit Jalan 3a62eba299 bump onebox version 2018-03-22 11:38:01 +05:30
Guo Xiang Tan f3b402ffd5 UX: Allow users to filter members on group page.
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
Guo Xiang Tan 1cc0961566 FEATURE: Allow admin to manage group owners on group page. 2018-03-22 12:33:42 +08:00
Guo Xiang Tan bfe38b2118 FIX: `limit` wasn't correctly applied to `Upload.migrate_to_new_scheme`. 2018-03-22 10:56:06 +08:00
Guo Xiang Tan ae6be6e364 Fix alignment of filter inputs on groups page. 2018-03-22 09:45:24 +08:00
Guo Xiang Tan 0e973ef219 FIX: Group members dropdown not displaying when switching between groups. 2018-03-22 08:01:37 +08:00
Arpit Jalan d96c1058a2 FEATURE: add staff action log for 'restore topic' 2018-03-21 18:04:13 +05:30
Guo Xiang Tan 6381bc6ce1 Improve description for removing a group member. 2018-03-21 18:37:13 +08:00
Guo Xiang Tan be866dbe6e UX: Allow group owners to manage members from group members page. 2018-03-21 18:22:55 +08:00
Guo Xiang Tan a23509cbf3 UX: Limit the number of group names displayed on user page. 2018-03-21 16:38:33 +08:00
Guo Xiang Tan dda78f2fd0 UX: Improve layout of groups filter on groups page. 2018-03-21 14:22:34 +08:00
Guo Xiang Tan 9f216ac182 FIX: Infinite loading more on groups page. 2018-03-21 09:25:42 +08:00
Robin Ward 651015fb9b FIX: Linter 2018-03-20 18:07:33 -04:00
Robin Ward b9abd7dc9e FEATURE: Shared Drafts
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.

* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.

* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.

* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.

* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
scossar f213dea529 Make sure a post has replies before accessing the reply id 2018-03-20 12:13:41 -07:00
Arpit Jalan dcbd9635f4 UX: indicate active tag sorting method 2018-03-21 00:35:16 +05:30
Robin Ward 70c41e067b FIX: Don't apply tags to the plugin outlet in the admin menu pills 2018-03-20 09:54:35 -04:00
Robin Ward b39fbf7187 A staff member can hide another staff's member's post by flagging 2018-03-20 09:38:23 -04:00
Guo Xiang Tan d0e7898fa0 Build `primary_email` association directly in `DiscourseSingleSignOn`. 2018-03-20 19:36:35 +08:00
Guo Xiang Tan 6771df128e Fix the build. 2018-03-20 18:02:48 +08:00
Guo Xiang Tan 15bcfcd182 UX: Allow users to filter by different group types on groups page. 2018-03-20 17:38:11 +08:00
Guo Xiang Tan 69a53210d3 Improve `UserEmail#email` validation to use the index. 2018-03-20 10:22:06 +08:00
Kris 42e49f6c7b Trying a trash icon on mobile composer cancel 2018-03-19 16:35:38 -04:00
Neil Lalonde a9de712eed FIX: not found message when trying to log in with a link, even though the email with the link was successfully sent 2018-03-19 16:08:10 -04:00
Neil Lalonde 4d44024c82 FIX: error when trying to block an IP address. Return a message when IP address matches an existing screened IP address, including ranges. 2018-03-19 14:34:43 -04:00
Neil Lalonde b9b4d9a8f7 FIX: regression in tag group UI which prevented creating new tags 2018-03-19 10:45:27 -04:00
Guo Xiang Tan 19a93b0e95 UX: Improve groups page on mobile. 2018-03-19 18:48:12 +08:00
Guo Xiang Tan 2b7fb43d84 Fix the build. 2018-03-19 18:47:17 +08:00
Guo Xiang Tan 41b0fbe001 UX: Indicate user's group membership on groups page. 2018-03-19 18:29:30 +08:00
Guo Xiang Tan 05ea034490 UX: Allow groups page to be searchable. 2018-03-19 17:16:51 +08:00
Guo Xiang Tan 0522aabaab UX: Allow user_count on groups page to be sortable. 2018-03-19 16:15:13 +08:00
Arpit Jalan 3e32ab1523 UX: css for Instagram onebox 2018-03-19 13:32:36 +05:30
Guo Xiang Tan c1bf707e7d PERF: N+1 queries on badges page. 2018-03-19 14:36:09 +08:00
Guo Xiang Tan 9e8d10f711 Fix the build. 2018-03-19 12:34:21 +08:00
Guo Xiang Tan 52b9af10a1 PERF: PG queries for the `UserEmail#email` column was not using the index. 2018-03-19 11:31:14 +08:00
Arpit Jalan f053e4cf37
Merge pull request #5682 from techAPJ/allowed-tags-page
FIX: show only allowed tags on PM tags page and display correct count
2018-03-17 08:29:00 +05:30
Régis Hanol 89f5c90ce0 FIX: show an error page on click tracking error 2018-03-17 00:33:11 +01:00
Gerhard Schlager 864bdbd9b6 Fix the build 2018-03-16 22:55:42 +01:00
Gerhard Schlager 6c736a1fa4 FIX: Translation overrides for flag types didn't expire cache 2018-03-16 22:10:19 +01:00
Kris 90ab42b9bf Safari uploading progress indicator missing a space 2018-03-16 16:10:01 -04:00
Arpit Jalan e9bc763440 FIX: show only allowed tags on PM tags page and display correct count
FIX: tags page should link to user profile we are browsing
2018-03-17 00:17:48 +05:30
Neil Lalonde cc16a64ad1 UX: on topic list page for a tag, show the Create Topic button to admins too 2018-03-16 13:43:25 -04:00
Joffrey JAFFEUX cb49dc6448
FIX: use right caret for collapse state of tag and category drops 2018-03-16 10:52:15 +01:00
Guo Xiang Tan 215d955e30 UX: Add a back link to groups page on group page. 2018-03-16 16:58:42 +08:00
Guo Xiang Tan 7138f6dd69 Fix incorrect condition while re-routing from group messages. 2018-03-16 16:39:02 +08:00
Guo Xiang Tan 19d6b9cb36 Redirect to group members tab if user cannot see messages tab. 2018-03-16 16:30:08 +08:00
Guo Xiang Tan c85e1fdb50 Revert "PERF: Query for email was not using index."
This reverts commit 65eb046e69.
2018-03-16 15:31:39 +08:00
Guo Xiang Tan 65eb046e69 PERF: Query for email was not using index. 2018-03-16 15:19:35 +08:00
Guo Xiang Tan 7e3e09d0ea Fix group messages style on mobile. 2018-03-16 14:56:10 +08:00
Guo Xiang Tan 5fec9a4dfe Fix incorrect CSS class on group messages. 2018-03-16 13:45:03 +08:00
Guo Xiang Tan fe96ef6ed2 UX: Use topic list for displaying group messages on group page.
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
2018-03-16 11:56:40 +08:00
Guo Xiang Tan 937372df02
Merge pull request #5677 from jjaffeux/fix-ruby-warning-keyword
FIX: prevents ruby warning with circular reference
2018-03-16 09:31:54 +08:00
Sam 5474635361 add more safety 2018-03-16 11:19:06 +11:00
Joffrey JAFFEUX d3943b97df
FIX: align suggested messages 2018-03-15 17:51:19 +01:00
Joffrey JAFFEUX c0a986c181 FIX: prevents ruby warning with circular reference 2018-03-15 15:48:40 +01:00
Sam c589564f6a FIX: color schemes not updating when remote saves 2018-03-15 18:26:54 +11:00
Sam ba15273d3f FEATURE: maintain preview theme, while previewing
This means you can browse around in preview mode without losing the theme.
At any point you can refresh page and maintain the preview theme.
2018-03-15 16:17:22 +11:00
Rafael dos Santos Silva 2097f5330c FIX: Login redirect path was broken in subfolder installs 2018-03-15 11:49:35 +08:00
Guo Xiang Tan a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Blake Erickson d3f5b4e4b0 FIX: envelope link on suggested topics 2018-03-14 16:04:03 -06:00
Neil Lalonde 5ce8177662 FIX: unable to delete user belonging to a group that grants a trust level 2018-03-14 15:12:11 -04:00
Robin Ward 135195363b FIX: Not logging old post contents properly 2018-03-14 15:01:36 -04:00
Robin Ward d31dfe0e84 FIX: Silencing / Suspending a user should not send a hidden message 2018-03-14 14:39:52 -04:00
Arpit Jalan b83ba97675 FIX: explicity set username when creating new message via URL 2018-03-14 23:04:18 +05:30
Robin Ward 23e690d0c2 Add extensiblity point for discourse-tooltips 2018-03-14 12:46:32 -04:00
Joffrey JAFFEUX 19177c89e8
remove unused const 2018-03-14 16:37:48 +01:00
Joffrey JAFFEUX 2d0537b593
FIX: correct messages displayed when reseting password 2018-03-14 16:33:09 +01:00
Joffrey JAFFEUX fd7308e7f6
FIX: share selected tags between tag-chooser in preferences 2018-03-14 16:01:44 +01:00
Joffrey JAFFEUX 3ab58ac881
FEATURE: no category description in category-drop for staff or TL > 0 2018-03-14 11:12:57 +01:00
Joffrey JAFFEUX d2a7a4916a
FIX: do not show emoji menu when `:` has a letter before 2018-03-14 10:28:57 +01:00
Arpit Jalan c5fa452f00 UX: set pmView for PM tags page 2018-03-14 13:37:48 +05:30
Michael Brown 1b5549df58 FIX: my sso_overrides_username assumed username was passed 2018-03-13 18:29:11 -04:00
Kris 16d43e3abc Removing overscroll-y prevention on mobile 2018-03-13 14:40:11 -04:00
Arpit Jalan b18fec4d5d UX: move Impersonate to the bottom of page 2018-03-14 00:06:40 +05:30
Robin Ward 31a0c4a9be FEATURE: Add `quote-modified` class if a quote has been modified 2018-03-13 13:41:06 -04:00
Kyle Zhao f7bd05e534 FEATURE: set 'Retry-After' header for 429 responses (#5659) 2018-03-13 23:12:41 +08:00
Arpit Jalan 7d375690c1
Merge pull request #5667 from techAPJ/pm-tags-page
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:08:21 +05:30
Arpit Jalan 24338fbbe8 FEATURE: replace PM tags dropdown with a dedicated tags page 2018-03-13 13:06:58 +05:30
Sam f11f3f4c5b remove stray console.log 2018-03-13 17:39:53 +11:00
Guo Xiang Tan 1c208ef3f0 FIX: Suspended login error message not showing. 2018-03-13 11:28:59 +08:00
Sam 8c1d145f0e FIX: when visiting post on mobile it is not selected 2018-03-13 14:06:08 +11:00
Kris 64e30d799e UX: Use the full word "cancel" on desktop composer, "X" on mobile. 2018-03-12 22:33:44 -04:00
Guo Xiang Tan d5c828213f FIX: Circular references warning in `TopicTrackingState`. 2018-03-13 08:35:15 +08:00
Neil Lalonde ab2f3e43eb FIX: excerpts in summary email are too short when there are images or links 2018-03-12 18:12:09 -04:00
Varun A 5f133e20f2 FEATURE - Prevent unnecessary refreshes with overscroll-behavior-y (#5662) 2018-03-12 13:59:19 -04:00
Robin Ward 65ac80b014 FEATURE: Log Staff edits in Staff Action Logs
Why? Some edits by staff are not tracked. For example, during the grace
period, or via the flags/silence dialog.

If a staff member is editing someone else's post, it now goes into the
Staff Action Logs so it can be audited by other staff members.
2018-03-12 13:51:40 -04:00
Arpit Jalan 82143a421c FIX: `max topic invitations per day` should apply on PM invites as well
FIX: do not apply `max topic invitations per day` on email invites
2018-03-12 23:17:58 +05:30
Kris 2cb6fcb3d6 Lighter cancel button in composer 2018-03-12 09:34:11 -04:00
Gerhard Schlager 243ee565dc Reset widget decorators after each test 2018-03-12 14:22:50 +01:00
Sam 758b9a7dda FEATURE: prototype of local theme directory watcher
(note this will be documented a bit late)
2018-03-12 18:36:06 +11:00
Guo Xiang Tan 74ce2220a7 Make rubocop happy. 2018-03-12 09:48:41 +08:00
Leo McArdle 89f41f8236 FIX: error when group_in_subject enabled but no group in pm 2018-03-11 12:22:11 +00:00
Arpit Jalan 12706c4b29 FEATURE: support markdown rendering for embedded posts 2018-03-11 08:00:48 +05:30
Kris 257950e8bd UX: Replace composer cancel and upload with icons 2018-03-09 22:29:42 -05:00
Jeff Atwood 9522469f6a
Merge pull request #5664 from dbnicholson/robots-no-uploads
Prevent robots from indexing uploads
2018-03-09 13:33:34 -08:00
Michael Brown 3c3d205180 FIX: sso_overrides_username may inappropriately change the username if the case changed 2018-03-09 16:06:55 -05:00
Kris 0f07999c11 FIX: Safari flexbox bug in header dropdowns 2018-03-09 15:58:53 -05:00
Arpit Jalan aac7796124 FIX: do not show tags with 0 count on /tags page 2018-03-09 20:57:31 +05:30
Dan Nicholson 0fd622e5d1 Prevent robots from indexing uploads
Although most user uploads are probably harmless, it's possible someone
has (either maliciously or not) uploaded sensitive information. Prevent
robots from indexing the uploads route.
2018-03-09 05:51:55 -06:00
Gerhard Schlager dc77cce8d9 FIX: Create notifications for mentions in PMs 2018-03-09 11:04:29 +01:00
Guo Xiang Tan 0e1b896821 Explicitly assign primary_email record when creating a user
* This looks like we're doing the same thing but
  we're debugging a race condition where a user
  can be created without an email record. Therefore,
  we prefer the more obvious method of assigning an
  association.
2018-03-09 15:59:46 +08:00
Sam 7c0e6b820e move key so it does not interfere with other errors 2018-03-09 16:42:11 +11:00
Sam 39e679d3cb FEATURE: allow themes to live in private git repos
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
Neil Lalonde 34a0e79bec FIX: use digest_min_excerpt_length site setting in summary emails 2018-03-08 23:35:10 -05:00
Guo Xiang Tan a89f3160a5 Add new config to ensure backup/restore connects to PG directly.
* In `pg_dump` 10.3+ and 9.5.12+, in
  it does a `SELECT pg_catalog.set_config('search_path', '', false)`
  which changes the state of the current connection. This is known
  to be problematic with Pgbouncer which reuses connections. As such,
  we'll always try to connect directly to PG directly during
  the backup/restore process.
2018-03-09 10:28:03 +08:00
Sam 9a4a7422f5 FIX: not loading more messages when username has a . 2018-03-09 11:01:46 +11:00
Sam 5ff857d770 remove theme yaml from UI, it only causes troubles 2018-03-09 11:01:46 +11:00
Robin Ward 6385c7fcb3 UX: Don't let topic progress widget dangle when preview is disabled 2018-03-08 16:34:19 -05:00
Arpit Jalan 4ad3a258d1 FIX: tag filter was not selected on page load 2018-03-08 20:09:31 +05:30
Arpit Jalan 4b23634092 FIX: converting topic to message for a second time was broken 2018-03-08 17:59:04 +05:30
Arpit Jalan 0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown
FEATURE: filter personal messages by tags
2018-03-08 16:30:38 +05:30
Arpit Jalan a8149f8969 FIX: user should not be able to invite to PM if trust level requirment not met
FIX: when personal messages are disabled let user invite to a public topic
2018-03-08 14:59:04 +05:30
Arpit Jalan c29660c8f1 FEATURE: filter personal messages by tags 2018-03-08 14:42:07 +05:30
Sam 86c00ac6ad stop using deprecated size() 2018-03-08 15:26:29 +11:00
Simon Cossar 88fdc926d1 Move external_id from UserSerializer to CurrentUserSerializer (#5658) 2018-03-07 22:54:31 -05:00
Sam 7a831857fc remove deprecated method 2018-03-08 14:53:09 +11:00
Neil Lalonde 873feb7b7c
Merge pull request #5654 from tshenry/user-profile-avatar-flair-plugin-outlet
FEATURE: Add user-profile-avatar-flair plugin outlet
2018-03-07 17:04:20 -05:00
Régis Hanol b5b5b68972 Add proper error message when SCSS variable name is invalid when uploading a theme file 2018-03-07 21:37:22 +01:00
Neil Lalonde 1093dacc03 FIX: bulk importers need to create category description topics 2018-03-07 12:10:22 -05:00
Joffrey JAFFEUX 90a1b48503
FIX: correctly allow tag creation if `this.site.get("can_create_tag")` 2018-03-07 16:06:56 +01:00
Taylor Henry 8c0369e86f FEATURE: Add user-profile-avatar-flair plugin outlet
Adds a plugin outlet in the user profile for avatar flair.
2018-03-07 02:38:08 -08:00
Guo Xiang Tan e7cc2e6d33 FIX: `loadBefore` should include current params as well. 2018-03-07 16:57:06 +08:00
Guo Xiang Tan c6cb7f6693 UX: Add title to user messages page. 2018-03-07 15:24:11 +08:00
Guo Xiang Tan 3045c589f6 FIX: Publish live messages to both team inbox and archive on update. 2018-03-07 14:01:20 +08:00
Guo Xiang Tan 5169be6080 FIX: User archiving message should also publish to sent section. 2018-03-07 11:39:23 +08:00
Guo Xiang Tan bef35f7be5 FIX: User archive messages should only publish to the user. 2018-03-07 11:28:29 +08:00
Guo Xiang Tan 82619c2445 FIX: Missing messages incoming indicator for mobile. 2018-03-07 10:27:18 +08:00
Neil Lalonde 2e5c18d130
Merge pull request #5652 from majakomel/add-slovenian-locale
Add Slovenian locale files
2018-03-06 15:59:01 -05:00
Joffrey JAFFEUX 187fdb9799
FIX: do not show read-only cursor on mini-tag-chooser (#5653) 2018-03-06 21:21:24 +01:00
Maja Komel e2a441ade9 Add Slovenian translations 2018-03-06 20:51:41 +01:00
Robin Ward 81780d8607 Merge remote-tracking branch 'origin/analyze-code-fix' 2018-03-06 13:16:37 -05:00
Gerhard Schlager 07649cd42d FIX: email_domains_whitelist prevented creation of anonymous users 2018-03-06 18:14:53 +01:00
Robin Ward c74d10cf34 FIX: Consider live links in `<code>` as links when counting 2018-03-06 11:46:12 -05:00
Guo Xiang Tan 8f5349eaa1 FIX: Only unsubscribe channel if it was subscribed. 2018-03-06 21:39:30 +08:00
Guo Xiang Tan e09a4a353e FIX: Incorrectly deleting `channel` preventing us from unsubscribing MB. 2018-03-06 19:52:00 +08:00
Guo Xiang Tan 1365bab0d7 FEATURE: Live updates for user's messages page.
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
2018-03-06 18:15:21 +08:00
Guo Xiang Tan 13764b31ec Remove unnecessary attribute in topic tracking payload. 2018-03-06 17:37:53 +08:00
Guo Xiang Tan d576056cff REFACTOR: Add basic tests for `TopicTrackingState#publish_*`.
* Ensure we don't publish events for PMs.
2018-03-06 17:37:53 +08:00
Guo Xiang Tan 821f3d0c15 REFACTOR: Remove code duplication. 2018-03-06 17:37:53 +08:00
Sam 0134e41286 FEATURE: detect when client thinks user is logged on but is not
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
Sam f0d5f83424 FEATURE: limit assets less that non asset paths
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
2018-03-06 15:20:39 +11:00
Gerhard Schlager 8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
OsamaSayegh adc46ac56c UX: Improvements for theme UI (#5650)
* Don't display "Settings: YAML" in Custom CSS/HTML section

* Don't show the settings tab for remote/imported themes
2018-03-05 17:26:50 -05:00
Robin Ward 0f66a99eb2 Setting to prevent logging details when anonymizing 2018-03-05 14:38:18 -05:00
Arpit Jalan 003b03d939 allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age 2018-03-05 23:31:29 +05:30
Kris 62d1ba4fdb Menu fix for iOS 2018-03-05 11:32:43 -05:00
Joffrey JAFFEUX 057fa049e6
FIX: display keyboard on mobile when focusing mini-tag-chooser 2018-03-05 10:55:20 +01:00
Guo Xiang Tan 2f65393706 REFACTOR: Use `Topic#private_message?` to reduce duplication. 2018-03-05 15:39:22 +08:00
Guo Xiang Tan 07f1d90b88 FIX: Inviting a group that I am part of creates a notification.
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
2018-03-05 13:51:32 +08:00
Guo Xiang Tan 42e0aaed61 FIX: Set first visit PM notification level to group default notification level.
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
2018-03-05 13:39:00 +08:00
Sam 9331b4849d FEATURE: we need access to settings in theme js 2018-03-05 15:35:41 +11:00
Sam 95555b5ec8 If there are no settings do now show section 2018-03-05 11:11:21 +11:00
Sam 2c25b9ae12 annotate 2018-03-05 11:06:45 +11:00
OsamaSayegh 282f53f0cd FEATURE: Theme settings (2) (#5611)
Allows theme authors to specify custom theme settings for the theme. 

Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
Arpit Jalan 322618fc34 FIX: capital bbcode tags were broken 2018-03-04 22:10:54 +05:30
Joffrey JAFFEUX a15b2fdeca
FIX: make it possible to edit tags on topics on mobile 2018-03-04 13:47:25 +01:00
Robin Ward 13eda41ff5 Fix lint errors 2018-03-03 14:34:19 -05:00
Robin Ward 31e3bf6d8d FEATURE: New "Categories and Top" homepage style
Select this option if you want to show top topics on the homepage
instead of latest topics.
2018-03-03 14:26:57 -05:00
Joffrey JAFFEUX 5e323139ae
FIX: makes sure we recompute shouldDisplayCreateRow after request 2018-03-03 11:42:44 +01:00
Kris 6d359ca823 Z-index fix for hidden posts 2018-03-02 22:41:10 -05:00
Robin Ward b11dd21356 FIX: Translate the hover text or emoji categories 2018-03-02 18:28:06 -05:00
Kris c684843c53 Improving title selection on badge pages 2018-03-02 16:15:58 -05:00
Neil Lalonde dda248f5df FIX: tag input in composer was not respecting tag group rules 2018-03-02 15:56:24 -05:00
Kris efb0bf6b16 Categories in hamburger menu were misaligned in Firefox 2018-03-02 15:04:55 -05:00
Kris 5e11bc79ff Fixing some regressions for profile badges 2018-03-02 14:43:54 -05:00
Kris 70acfa47d7 FIX: In some instances expanding hamburger menu broke layout in iOS 2018-03-02 14:13:43 -05:00
Kris 0783f8b9e6 Fixing badge detail positioning 2018-03-02 13:21:36 -05:00
Robin Ward 730201d423 New interface to upsert custom fields 2018-03-02 12:45:52 -05:00
Kris 0ec1dc9237 UX: Improving badge page layout 2018-03-02 12:43:01 -05:00
Neil Lalonde 5833d00739 SECURITY: sanitize topic title when staff is viewing a user's past flagged posts and deleted topics 2018-03-02 11:58:11 -05:00
Arpit Jalan 334ed74346
Merge pull request #5635 from techAPJ/invite-muted
FIX: do not allow invite notifications from muted user/topic
2018-03-02 18:10:17 +04:00
Guo Xiang Tan 6b59a2827d Add more information to SSO user creation logging. 2018-03-02 18:27:15 +08:00
Joffrey JAFFEUX 6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan 642c60c310 Rename variable so that it is clearer which variable is being referred. 2018-03-02 16:41:02 +08:00
Arpit Jalan 2e202495a3 FIX: do not allow invite notifications from muted user/topic 2018-03-02 12:24:51 +05:30
Guo Xiang Tan d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Guo Xiang Tan 50eb582fb2 Remove `cas` oauth login method that is no longer used. 2018-03-02 14:22:52 +08:00
Sam d39d2b9352 FEATURE: whitelist data for themes 2018-03-02 14:52:09 +11:00
Guo Xiang Tan 939180efa8 FIX: Missing 2FA guards when sso is enabled or when local login is disabled. 2018-03-02 10:39:10 +08:00
Sam e19ae6c55e FEATURE: disallow groups from being indexed 2018-03-02 13:38:30 +11:00
Sam 185507d072 UX: remove fast scroll which is leading to bugs 2018-03-02 12:58:38 +11:00
Sam 75172024ca SECURITY: ensure users have permission when moving categories 2018-03-02 12:13:27 +11:00
Régis Hanol 25d80aabce remove 'puts' 2018-03-02 01:50:24 +01:00
Gerhard Schlager 80e85e0d8f FIX: Sidekiq job has wrong data when post owner changes within transaction 2018-03-01 18:00:18 +01:00
Gerhard Schlager 79590e4bec FIX: Merging users shouldn't add more than 1 secondary email 2018-03-01 17:50:13 +01:00
Gerhard Schlager a7c50039de FIX: Allow changing post owner even when topic validations fail 2018-03-01 17:31:58 +01:00
Gerhard Schlager 7a2183e8ab FEATURE: rake task for merging users 2018-03-01 12:28:12 +01:00
Gerhard Schlager fffd1a6602 FIX: Associated Instagram account was missing at some places 2018-03-01 12:26:40 +01:00
Joffrey JAFFEUX 7ae1c5a663
FIX: emoji search was not finding aliases 2018-03-01 12:11:52 +01:00
Joffrey JAFFEUX c9cb6920dc
FIX: category drop header padding when using category box style 2018-03-01 11:59:13 +01:00
Joffrey JAFFEUX 460c905dc6
FIX: improves positioning of select-kit body 2018-03-01 11:53:14 +01:00
Guo Xiang Tan 674239718c UX: Hide social login buttons when requesting for 2FA token. 2018-03-01 15:52:09 +08:00
Guo Xiang Tan fb75f188ba FEATURE: Disallow login via omniauth when user has 2FA enabled. 2018-03-01 15:47:07 +08:00
Guo Xiang Tan 947b6fdf46 FIX: Incorrect rate limit applied to topics invitation flow. 2018-03-01 12:50:00 +08:00
Guo Xiang Tan 5a462b930d REFACTOR: Prefer `exists?` over `present`. 2018-03-01 10:22:41 +08:00
Kris 4b17b39e73 Remove unnedded padding 2018-02-28 15:07:08 -05:00
Kris f375731278 About page layout improvements 2018-02-28 15:03:12 -05:00
Robin Ward b283bb2ba7 FIX: Don't include unlisted topic in groups/posts 2018-02-28 14:40:18 -05:00
Kris 6c50ef9b5d font-sizes on body-pages were too large due to nesting 2018-02-28 13:23:43 -05:00
Guo Xiang Tan e7a7356986 Remove ancient votes code that is no longer used. 2018-02-28 14:37:22 +08:00
Neil Lalonde 764b6c005c FIX: don't show Other Tags on /tags if there aren't any to show 2018-02-27 22:30:46 -05:00
Guo Xiang Tan 902c5d11cf FIX: Don't allow other flag actions after `notify_moderator` has happened.
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
scossar 51544047dc Add external_id to User Serializer 2018-02-28 10:13:27 +08:00
Kris b832c3d885 Glyph wasn't wrapping properly with long categories 2018-02-27 17:10:02 -05:00
Kris be63b08c36 Truncate long category names in subcategory boxes 2018-02-27 16:48:20 -05:00
Joffrey JAFFEUX 8ca1b1ab0b
FIX: load tag_groups and not tags 2018-02-27 21:10:57 +01:00
Kris e32691a3e9 Simplifying category overflow on category pages 2018-02-27 13:11:22 -05:00
Joffrey JAFFEUX 9b680fc45c
FIX: prevents create row to be displayed if term is in displayed list 2018-02-27 18:31:58 +01:00
Joffrey JAFFEUX ba2f01c0bd
FIX: prevents selected value from hiding one item of the list 2018-02-27 18:31:51 +01:00
Kris 96b4617094 Fixing category title with logo image layout 2018-02-27 10:47:05 -05:00
Gerhard Schlager c22e56499a FIX: Allow changing post owner even when validations fail 2018-02-27 15:46:20 +01:00
Arpit Jalan 4010d8d9f9 FEATURE: show "edit message" button on message footer for staff
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
2018-02-27 14:22:03 +05:30
Joffrey JAFFEUX 410b90dde0
FIX: mini-tag-chooser was not returning a correct list of tags
Should also fix an issue where it validates the creation of an existing tag.
2018-02-27 08:47:44 +01:00
Guo Xiang Tan 486bbe9cc2 FIX: Auto re-opened topics should restore category auto close settings.
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
2018-02-27 15:33:31 +08:00
Joffrey JAFFEUX 83e8ab5274
FIX: header icon out of bounds in tag-drop on some browsers 2018-02-27 08:33:06 +01:00
Guo Xiang Tan 519026a31f Trim attributes that are not useful from `WebHookTopicViewSerializer`. 2018-02-27 11:28:31 +08:00
Guo Xiang Tan 66d620f7b1 FEATURE: Trigger topic webhook when topic status is updated. 2018-02-27 11:07:37 +08:00
Guo Xiang Tan 104df3126b UX: Incorrect width for webhook events. Take 2. 2018-02-27 10:34:46 +08:00
Guo Xiang Tan 8d16ca2af2 UX: Incorrect width for webhook events. 2018-02-27 10:32:11 +08:00
Guo Xiang Tan 24f3b78548 Fix incorrect ids for 2FA inputs. 2018-02-27 10:12:22 +08:00
Guo Xiang Tan 70f14da732 UX: Use 'tel' input type for 2FA token inputs. 2018-02-27 09:30:44 +08:00
Robin Ward 8296f493ed add class to easier targetting 2018-02-26 19:03:21 -05:00
Robin Ward c7a37f391a New event when a flag is handled 2018-02-26 18:51:51 -05:00
Kris 382dbfbb8a Fix for categories with icons not wrapping properly 2018-02-26 17:00:03 -05:00
Neil Lalonde 8f27456acb UX: Move 'show words' checkbox close to the words in the Watched Words UI 2018-02-26 16:35:52 -05:00
Kris 436d2b57c9 Fixing categories not wrapping properly 2018-02-26 16:33:24 -05:00
Neil Lalonde 3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Gerhard Schlager 5ca5817902 FIX: Only likes should change the given daily likes 2018-02-26 22:27:18 +01:00
Kris e2a524550c Prevent long category names from breaking topic/category list layouts 2018-02-26 14:21:28 -05:00
Robin Ward f8856f3d7a FIX: Anonymous users shouldn't see the link to new in the footer 2018-02-26 13:46:50 -05:00
Joffrey JAFFEUX ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
2018-02-26 11:42:57 +01:00
Guo Xiang Tan a9699da672 UX: Specify pattern and maxlength for 2FA input fields. 2018-02-26 18:29:46 +08:00
Guo Xiang Tan c1f53e1ece UX: Invited users should watch PM topic once topic has been visited.
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11
2018-02-26 17:58:58 +08:00
Guo Xiang Tan 982e5bae3a Update annotations. 2018-02-26 15:32:04 +08:00
Guo Xiang Tan 6a88f7db61 Notification created for wrong user after invite.
Introduced in c64f09b6b7
2018-02-26 13:21:19 +08:00
Guo Xiang Tan 31242335a6 Revert "Fix the build."
This reverts commit 07f928e05e.
2018-02-26 13:08:10 +08:00
Guo Xiang Tan 07f928e05e Fix the build. 2018-02-26 12:42:55 +08:00
Guo Xiang Tan c64f09b6b7 REFACTOR: Simplify and DRY `Group#invite`. 2018-02-26 11:59:07 +08:00
Guo Xiang Tan 3e1afbedc5 FIX: Missing translation for non-admin when editing a group.
https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
2018-02-26 10:11:18 +08:00
Guo Xiang Tan 616d210911
Merge pull request #5614 from nbianca/fix_period
Try extracting time period only when the filter is 'top'.
2018-02-26 09:38:33 +08:00
Régis Hanol 0559a4736a FIX: don't double request when downloading a file 2018-02-24 12:35:57 +01:00
Kris b731d5d9b5 Removing unneeded and duplicate styles 2018-02-23 21:43:05 -05:00
Kris bd892199e7 Increasing topic-admin menu width to prevent wrapping on mobile 2018-02-23 13:51:06 -05:00
Kris de30f3515b Updating modal headers to flexbox for better alignment 2018-02-23 13:14:32 -05:00
Kris d001183828 Prevent timestamp modal calendar from overflowing container 2018-02-23 11:44:49 -05:00
Vinoth Kannan 43f0884660 PERF: Remove N+1 queries on topic list page. 2018-02-23 20:05:51 +05:30
Arpit Jalan 709f201bd4 FIX: update group user count when bulk adding users 2018-02-23 14:29:56 +05:30
Guo Xiang Tan 4791b39773 UX: Add reset password email button when confirming password before enabling 2FA. 2018-02-23 15:37:17 +08:00
Sam a94dc0c731 Revert "FIX: preview theme not working consistently"
This reverts commit 845cec3ba0.
was not a needed change, but was elsewhere
2018-02-23 17:59:00 +11:00
Sam 6f076963f2 FIX: incorrect caching of theme keys 2018-02-23 17:58:13 +11:00
Guo Xiang Tan 4250ab522a UX: Don't show admin 2FA edit icon on profile of other users. 2018-02-23 13:51:02 +08:00
Sam 845cec3ba0 FIX: preview theme not working consistently
Avoid flash, this makes debugging much simpler as well.

Additionally URL now clearly shows you are previewing a theme.
2018-02-23 15:25:35 +11:00
Guo Xiang Tan 1f74509a75 FIX: 2FA prompt incorrectly displayed on admin login page. 2018-02-23 11:05:39 +08:00
Guo Xiang Tan e137b7f836 UX: Improve indication of 2FA status in user's preferences. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan 5e60f6b533 UX: Don't disable submit button before transitioning in 2FA flow. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan 2e2da3a6e2 Update copy for 2FA. 2018-02-23 10:36:48 +08:00
Robin Ward ee9be65b2c FIX: Show names when available 2018-02-22 20:06:53 -05:00
Guo Xiang Tan 9f5bc7a5ee
Merge pull request #5605 from nbianca/favorites
Added the required hooks for discourse-favorites plugin.
2018-02-23 07:12:09 +08:00
Guo Xiang Tan 18c1d1565c UX: Fix missing css styles on invite modal. 2018-02-23 07:08:19 +08:00
Guo Xiang Tan dd26bbe868
Merge pull request #5610 from discourse/pm-tags
FEATURE: Allow staffs to tag PMs
2018-02-23 07:07:41 +08:00
Bianca Nenciu 184d521fc9 Added the required hooks for discourse-favorites plugin. 2018-02-22 23:58:53 +02:00
Bianca Nenciu 0e3e5f25a6 Try extracting time period only when the filter is 'top'. 2018-02-22 23:56:37 +02:00
Régis Hanol 0210a7f2bf FIX: social login buttons were not working 2018-02-22 18:06:28 +01:00
Vinoth Kannan 7cbda949f1 REFACTOR: New spec tests and code improvement 2018-02-22 20:27:02 +05:30
Guo Xiang Tan 862e83287e
Merge pull request #5575 from featheredtoast/tab-index-composer-actions
tab index composer actions
2018-02-22 15:16:41 +08:00
Maja Komel 76a2fc3d07 UX: Add og metadata for groups.
https://meta.discourse.org/t/onebox-for-groups/79155
2018-02-22 15:03:41 +08:00
Guo Xiang Tan 7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Guo Xiang Tan ae2d7ba857 Partially revert d170c8fccc to bring back 3df0626aa5. 2018-02-22 13:42:04 +08:00
Arpit Jalan d170c8fccc Revert 'Accessibility: focus management in topics'
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
2018-02-22 10:32:37 +05:30
Kane York bfc1301823 UX: Remove default focus styling from posts & topic list items
The styling is superseded by the .selected management
2018-02-22 12:21:23 +08:00
Kane York 59b7760e2e UX: Make the .selected class follow focus 2018-02-22 12:20:47 +08:00
Kane York 3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Kane York 3df0626aa5 UX: Apply hover styling to post actions on focus 2018-02-22 11:55:36 +08:00
Guo Xiang Tan bbb30bedf3 Improve output of SSO verbose logging. 2018-02-22 11:26:13 +08:00
Sam f4418ae884 PERF: fast docking of timeline so it does not overlap
In the past we debounced all dock check this causes situations where
sometimes timeline would not dock in time especially on slow computers

This works around it by performing the dock by hand.

Also there was missing integer casting causing over aggressive re-rendering
2018-02-22 12:52:43 +11:00
Guo Xiang Tan 964624f3ab FIX: No error displayed when 2FA token is invalid on admin login page. 2018-02-22 09:45:57 +08:00
Guo Xiang Tan 412b298f55 UX: Smaller input field for preferences 2FA form. 2018-02-22 09:07:43 +08:00
Guo Xiang Tan 1b04d881c5 UX: Display lock icon in admin user lists when user has 2FA enabled. 2018-02-22 09:00:09 +08:00
Guo Xiang Tan edf326a9a5 Fix incorrect translation. 2018-02-22 08:06:37 +08:00
Joffrey JAFFEUX 6f5acfe783 Login with email/forget password UI refactoring
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Sam 720e1965e3 FEATURE: add category suppress from latest
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.

New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
Jeff Wong d2b518c61c QR code display fix on dark backgrounds (#5613)
https://meta.discourse.org/t/2fa-qr-code-not-visible-on-dark-theme/81152?u=awole20
2018-02-21 23:23:47 +01:00
Robin Ward 83d8fa2892 FIX: Allow customized usernames to work in this route
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
2018-02-21 13:37:14 -05:00
Vinoth Kannan 2b509eaa91
Merge branch 'master' into pm-tags 2018-02-21 23:55:59 +05:30
Neil Lalonde 81e873138f FIX: error when deleting a tag associated with a deleted topic 2018-02-21 12:35:53 -05:00
Régis Hanol 4e7244d8d9 FIX: never open internal links in a new tab when user prefers opening external links in a new tab 2018-02-21 17:51:53 +01:00
Vinoth Kannan d4b2e840cb remove unwanted code 2018-02-21 20:19:19 +05:30
Vinoth Kannan 84ce1acfef FEATURE: Allow staffs to tag PMs 2018-02-21 20:11:46 +05:30
Vinoth Kannan 1446753fd2 FIX: Include deleted topics in the post serializer 2018-02-21 14:31:52 +05:30
Guo Xiang Tan b16471edfb FIX: Invalid token error incorrectly displayed on email login page. 2018-02-21 15:46:53 +08:00
Guo Xiang Tan 8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
Guo Xiang Tan 14f3594f9f Review Changes for f4f8a293e7. 2018-02-21 14:55:49 +08:00
Robin Ward 5c40ae9e63 FIX: Links in quotes should be counted for rate limits 2018-02-20 20:42:01 -05:00
Jeff Wong f4f8a293e7 FEATURE: Implement 2factor login TOTP
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Kris ce97bdb472 Flag badge too wide in header panels 2018-02-20 17:31:02 -05:00
Kris 677e126fbf UX: Implementing a box-shadow system, cleaning up existing shadows 2018-02-20 12:18:20 -05:00
Guo Xiang Tan 226ace1643 Update annotations. 2018-02-20 14:28:58 +08:00
Sam 86d12bd44b FEATURE: search within title using in:title
Also

- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
Régis Hanol 60ec483caa FIX: include title in local onebox when linking to a different topic 2018-02-19 22:40:14 +01:00
Arpit Jalan 614b1c8e68 FIX: admin was not able to unblock screened IP address 2018-02-20 00:36:13 +05:30
Arpit Jalan c419c26f56 FEATURE: new site setting 'max_emojis_in_title' 2018-02-19 18:15:26 +05:30
OsamaSayegh f3815cd785 FEATURE: New site setting for additional allowed filetypes for staff (#5364)
* FEATURE: New site setting for additional allowed filetypes for staff

* Problematic variable name

* feedback

* small issues

* fix indentation

* failing tests

* Remove message bus and fix minor issues

* Missed this message bus
2018-02-19 10:44:24 +01:00
Zach Whitehead afa2b36842 Add class to category link for easy styling (#5606) 2018-02-19 10:22:27 +01:00
Leo McArdle 5d9d0fcb4f FEATURE: add setting which adds group name to PM email subject (#5475) 2018-02-19 10:20:17 +01:00
Joffrey JAFFEUX b3b6373f77
FIX: do not show mail-forward icon if not needed 2018-02-19 09:52:35 +01:00
Arpit Jalan 33df2d6a02 FIX: data export should fill missing dates with zero value 2018-02-18 23:52:09 +05:30
Robin Ward 02093ecbdd Extensibility: Allow plugins to munge user params 2018-02-16 19:12:02 -05:00
Kris a2327b4897 login button alignment fix 2018-02-16 17:13:10 -05:00
Kris 35a49a240a UX: Improving header scalability for large font themes 2018-02-16 15:58:10 -05:00
Kris 67526907cd Tags should wrap on mobile topic-list 2018-02-15 15:15:42 -05:00
Kris 5de78a719b Fixing emoji admin page column 2018-02-15 15:07:26 -05:00
Robin Ward 32e8cef0ad
Merge pull request #5596 from discourse/mobile-landscape-timeline
UX: Make mobile timeline extra short in landscape
2018-02-15 11:34:03 -08:00
Robin Ward 3faeb4f093 Calculate the heights when we need them 2018-02-15 14:33:20 -05:00
Neil Lalonde 991dfadad7 FIX: CategoryTagStat queries need to exclude PMs with tags 2018-02-15 12:13:42 -05:00
Neil Lalonde fdd8ce9722 empty category_tag_stats table before running init job 2018-02-15 11:28:25 -05:00
Joffrey JAFFEUX 2cf40096d1
FIX: makes mini-tag-chooser search more efficient 2018-02-15 15:01:19 +01:00
Arpit Jalan 585fc26f8e FIX: allow discourse app to link directly to upgrade page 2018-02-15 18:20:25 +05:30
Joffrey JAFFEUX e1883ba828
minor select-kit css improvements 2018-02-15 12:56:20 +01:00
Arpit Jalan b43ac801d1 FIX: show create new topic link in advanced search mode 2018-02-15 17:23:34 +05:30
hnb-ku afdc559f4f FEATURE: Whitelist div[data-theme-*] (#5598)
* Whitelist div[data-theme-*]

Whitelisting data attributes on <div> elements that match [data-theme-*] allows theme authors to target elements in posts and not have those attributes sanitized. 

https://meta.discourse.org/t/79520/16

* Update white-lister.js.es6
2018-02-15 04:32:41 -05:00
Guo Xiang Tan 7902296c11 Oops we should register a service worker as long as it is supported. 2018-02-15 15:02:14 +08:00
Kris 5ab44833ab UX: Make mobile timeline extra short in landscape 2018-02-14 23:27:06 -05:00
Guo Xiang Tan 9c7d609575 UX: Restore width of composer user selector.
* This fixes the build as well as a short width
  resulted in the user selector collapsing into
  the compressed display.
2018-02-15 11:49:10 +08:00
Guo Xiang Tan 28365f8ae5 PERF: Have nginx cache and serve the service worker file. 2018-02-15 10:50:39 +08:00
Sam d8b4627fc8 we have to define this for tests to pass 2018-02-15 13:30:34 +11:00
Sam b5b866aab3 oops 2018-02-15 13:13:31 +11:00
Sam c89b42c488 PERF: only require the rss library if used
Before:

Total allocated: 257909321 bytes (2514134 objects)
Total retained:  39681579 bytes (343387 objects)

allocated memory by gem
-----------------------------------
  42875979  rss

retained memory by gem
-----------------------------------
   2080188  rss

retained objects by gem
-----------------------------------
     13052  rss

After:

Total allocated: 210562047 bytes (2252030 objects)
Total retained:  37433816 bytes (328635 objects)

----

So, 2 less megabytes on boot and 13000 objects stuck in ruby heaps forever.
2018-02-15 13:11:33 +11:00
Robin Ward a03e7cee63 FIX: Group posts had the wrong paths in subfolders 2018-02-14 20:33:31 -05:00
Guo Xiang Tan 96e5a7da46 Prefer `success_Json` over custom success JSON payload. 2018-02-15 07:47:35 +08:00
Rafael dos Santos Silva 218c8e8623
Merge pull request #5595 from discourse/new-gfycat-onebox
New gfycat onebox
2018-02-14 19:03:28 -02:00
Robin Ward a3e5a31674 FIX: Allow 404 pages to use the current theme 2018-02-14 15:29:01 -05:00
Kris dffdff91a6 Fix avatar flair alignment on mobile user profiles 2018-02-14 13:39:30 -05:00
Kris e85458e1b9 Removing old bootstrap columns 2018-02-14 12:27:34 -05:00
Joffrey JAFFEUX 3ad0266dd8
FIX: better handling of category badge when displaying sub and parent cat 2018-02-14 16:42:20 +01:00
Arpit Jalan f07b1a5c05 FIX: activate user even if email token is already confirmed 2018-02-14 20:44:48 +05:30
Joffrey JAFFEUX 8ae2c4555a
FIX: do not translate the same string two times when rendering icon label 2018-02-14 12:41:24 +01:00
Joffrey JAFFEUX 23ef5f10e9
FIX: check can_create_tag on create and not on select 2018-02-14 12:20:07 +01:00
Joffrey JAFFEUX e3774c7bed
FEATURE: displays category badge in {{category-chooser}} header 2018-02-14 11:49:23 +01:00
Joffrey JAFFEUX e7761db60f
FIX: improves contrast on period-chooser when using dark-theme 2018-02-14 11:16:57 +01:00
Joffrey JAFFEUX 5d00a97ae9
FIX: regression preventing uncategorized badge to be shown 2018-02-14 11:03:33 +01:00
Joffrey JAFFEUX b0eed424f7
FIX: continue discussion when creating new topic from composer-actions 2018-02-14 10:32:46 +01:00
Joffrey JAFFEUX 480c94d298
minor visual improvements to mini-tag-chooser 2018-02-14 10:26:43 +01:00
Sam 38f4acd55a FIX: rate limiter text is confusing, should not say daily
Also, adds easily parseable JSON so users can figure out
how long to wait when the API is limited. ("extras" "wait_seconds")
2018-02-14 15:29:50 +11:00
Sam f028ffaf29 SECURITY: correct local onebox category checks
Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
Joffrey JAFFEUX 548db91c76
FIX: displays an error when reaching tags limit 2018-02-14 00:30:09 +01:00
Gerhard Schlager 5a56746610 FIX: Embedded topic was not found when URL contained query string 2018-02-14 00:28:30 +01:00
Neil Lalonde 22f0b0096d FEATURE: show avatar flair on user profile page 2018-02-13 17:13:38 -05:00
Robin Ward 556ab8480e FIX: ESlint 2018-02-13 16:06:40 -05:00
Robin Ward 713993d150 UX: Link post ids in staff action logs to the post 2018-02-13 15:59:10 -05:00
Robin Ward 7348513848 FIX: Include post in staff action logs when silencing a user 2018-02-13 15:59:10 -05:00
Joffrey JAFFEUX ed114177e7
Mini tag chooser tweaks 2018-02-13 19:41:03 +01:00
Joffrey JAFFEUX d525a644d2
fix linting 2018-02-13 18:12:30 +01:00
Joffrey JAFFEUX 20123271d2
FIX: override backspaceFromFilter only if defined 2018-02-13 17:48:00 +01:00
Neil Lalonde 20e44b3c14 Revert "FIX: 404 page when clicking a badge notification from before changing username" 2018-02-13 11:39:33 -05:00
Régis Hanol 7d501058d7 FIX: don't grant new user of the month badge to suspended users or based on deleted topics/posts 2018-02-13 17:32:38 +01:00
Joffrey JAFFEUX 6bfc25d895
FEATURE: new {{mini-tag-chooser}} replaces {{tag-chooser}} in composer 2018-02-13 17:23:12 +01:00
Vinoth Kannan 0a95d2a21f FIX: Upload fails silently if it is bigger than max allowed size 2018-02-13 14:39:25 +05:30
Erick Guan 03b3e57a44 FEATURE: login by a link from email
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Guo Xiang Tan f9280617d0 Remove redundant comment. 2018-02-13 15:58:13 +08:00
Maja Komel 1c27d93dcf anonymous shadow users are approved on creation if must_approve_users is enabled (#5569) 2018-02-13 01:58:38 -05:00
Muhlis Cahyono cc3cf6588b FEATURE: Notification API Endpoints for Admins
* create/update/delete notification api with external url
* remove external url feature
* Fix Travis CI build error (add new line)
* Fix Travis CI build error
2018-02-13 01:38:26 -05:00
Sam 14d0450bef FEATURE: Only load service worker for Android
TBD an interface for plugin to enable service workers on desktop if they need them
2018-02-13 16:23:36 +11:00
Sam 074d590abd FIX: stop counting offline page as a page view 2018-02-13 16:19:43 +11:00
Sam b34b1b6fe3 FIX: invite to message was not allowing groups
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
2018-02-13 13:28:46 +11:00
Kris 5f8f691e2b FIX: Border issue with group inputs on high resolution displays 2018-02-12 21:09:40 -05:00
Robin Ward ae15faeb34 FIX: Allow links from one relative uri to another 2018-02-12 18:27:08 -05:00
Robin Ward 4c9959f795 FIX: Don't allow silenced users to reach TL3 2018-02-12 17:20:11 -05:00
Neil Lalonde 1bafbc8c5c
Merge pull request #5576 from discourse/top-tags
PERF: a faster way to count tags used per category
2018-02-12 16:25:18 -05:00
Kris 32116654ec removing duplicate topic-map desktop/mobile styles 2018-02-12 15:20:14 -05:00
Neil Lalonde 76c309fe6b PERF: a faster way to count tags used per category 2018-02-12 15:16:47 -05:00
Vinoth Kannan e700e3e882 FIX: post_destroyed webhook event not fired 2018-02-13 01:36:56 +05:30
Robin Ward d962d6072e FIX: Don't auto select ALL topics, only keyboard chosen ones 2018-02-12 13:54:37 -05:00
Robin Ward 7b7f94d7df FIX: Using cmd-f to search in a topic wasn't restricting to that topic 2018-02-12 13:09:56 -05:00
Kris 44f39ddc86 prevent post-link clicks from being squished by long strings 2018-02-12 11:52:42 -05:00
Rafael dos Santos Silva 4644757785 FEATURE: Style new gfycat onebox 2018-02-12 13:39:52 -02:00
Joffrey JAFFEUX 3d5c4580bd
FIX: makes sure we add ellipsis to action-title 2018-02-12 16:27:24 +01:00
Kris d30c43e8cc usercard overflow fix 2018-02-10 21:27:25 -05:00
Kris 3d22ba35bc usercard website fix 2018-02-09 21:45:38 -05:00
Robin Ward cee3337357 Don't allow users to auto-hide staff posts 2018-02-09 19:53:58 -05:00
Robin Ward b31e6e64fb FIX: After deleting a post, staff can recover it 2018-02-09 19:42:16 -05:00
Robin Ward 569e57f0a9 FIX: Delete the invalid auth cookie even if you hit the rate limit 2018-02-09 19:09:54 -05:00
Robin Ward 2faa4c2f5f FIX: Don't show personal messages if disabled as a composer action 2018-02-09 16:58:35 -05:00
Kris 56352137ca UX: Preventing usercard and profile URLs from overflowing 2018-02-09 16:55:43 -05:00
Kris 88a992014b Default modals were too wide 2018-02-09 15:45:34 -05:00
Kris 597f17bf70 button padding nitpick 2018-02-09 15:41:59 -05:00
Vinoth Kannan 91beedd0ca FEATURE: Composer HTML pasting ul tag support for MS Word 2018-02-10 01:18:56 +05:30
Kris 1e51be923c UX: Improving post-link alignment 2018-02-09 12:43:15 -05:00
Kris 6f094ee27e extra-info-wrapper titles were too short 2018-02-08 20:43:34 -05:00
Robin Ward 5466389f4e FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links` 2018-02-08 18:27:40 -05:00
Kris 69bccb9e32 UX: Better alignment of small topic statuses 2018-02-08 17:04:29 -05:00
Jeff Wong 8e49033ed1 tab index composer actions
add styling for :focus
2018-02-08 12:16:13 -08:00
Kris e17e6d2880 Removing unneeded width 2018-02-08 14:10:04 -05:00
Robin Ward dedeb2deb8 FIX: Don't show the link button in the composer if linking is disabled 2018-02-08 12:56:10 -05:00
Joffrey JAFFEUX 8c89f5704d
FIX: makes sure we display whisper if we don’t have a post 2018-02-08 14:18:53 +01:00
Gerhard Schlager 0ecdf90023 FIX: Validations could prevent moving posts 2018-02-08 13:36:13 +01:00
Gerhard Schlager 8ab6689f43 FIX: Preserve original date when moving first post 2018-02-08 12:55:32 +01:00
Joffrey JAFFEUX 190d208631
FEATURE: improves composer-actions toggle menu
* only toggles
* fix a bug with presence
* more tests
* do not duplicate `continuing discussion...` text
* persist state to allow switching between toggles
2018-02-08 11:46:55 +01:00
Robin Ward 209a6cae2c FIX: Don't show messages setting if messages are disabled 2018-02-07 11:43:22 -05:00
Robin Ward c0ef6ca01c UX: Show the footer on the user summary and preferences pages 2018-02-07 11:35:36 -05:00
Gerhard Schlager 8765279c90 FIX: Customizing site texts ignored current locale for _MF keys 2018-02-07 16:57:08 +01:00
Gerhard Schlager 890ffb1eb5 FIX: overriding _MF translations worked only for English 2018-02-07 12:47:15 +01:00
Neil Lalonde ce26f48f97 FIX: only send up to 100 selected tags in the tag search request to avoid sending a query string that's too long 2018-02-06 17:54:57 -05:00
Joffrey JAFFEUX cdded801c5
FIX: correctly shows link to post number when editing 2018-02-06 22:17:27 +01:00
Kris 900f37e5a9 UX: Allow history modal to scale down on smaller screens 2018-02-06 15:02:51 -05:00
Sam Saffron 884b9d4b78 PERF: optimize performance of new topics query (home page)
This ensures the bypass is always applied to query plan
also, add frozen strings
2018-02-06 12:37:23 -05:00
Joffrey JAFFEUX b1593c0184
FIX: prevents exception when opening new topic on mobile
Repro:

- Visit https://meta.discourse.org/categories, refresh the page
- Navigate to Latest
- Click New Topic
- Error occurs
2018-02-06 14:48:04 +01:00
Kris e7b732ad95 FIX: Desktop/mobile heatmap colors should be the same 2018-02-05 21:36:35 -05:00
Neil Lalonde d7e90edeb5 PERF: Tl3Promotions job can limit the number of TL3 candidates by using some simple requirements in the query 2018-02-05 17:54:36 -05:00
Neil Lalonde 648a11a6a1 FIX: size of tags input field of tag group 2018-02-05 15:05:43 -05:00
Simon Cossar e3de396091 Set text to empty string when null is passed as argument (#5560) 2018-02-06 07:05:32 +11:00
Joffrey JAFFEUX c48761c628
s/select-box-kit/select-kit
Definitely remove legacy naming.
2018-02-05 18:25:39 +01:00
Neil Lalonde 8fe61c68a1 FIX: process_post job should update baked_at and baked_version if it rebakes the post 2018-02-05 11:47:04 -05:00
Régis Hanol 130974d58d FIX: automatically unsilence users 2018-02-05 17:45:47 +01:00
Kris ad8c2c08a4 fixing link alignment in titles 2018-02-05 10:42:37 -05:00
Joffrey JAFFEUX bd0a8ae792
FIX: makes scrollbar always on for small dropdowns 2018-02-05 10:51:06 +01:00
Joffrey JAFFEUX 5cd5d5aca5
FIX: prevents a regression where enter wasn't working in inputs 2018-02-05 09:55:58 +01:00
Robin Ward 0776340b29 SECURITY: Prevent robots from indexing more routes
These routes could contain sensitive material and should never be
indexed for content.
2018-02-04 13:24:36 -05:00
Kris 86bf6babf8 FIX: Prevent long composer overlapping controls 2018-02-02 22:31:55 -05:00
Kris cf623e65e0 tag alignment fix 2018-02-02 21:29:51 -05:00
Kris cd798e49d8 header text wrap fix 2018-02-02 19:33:00 -05:00
Kris 8bac9c7a09 header-extra wrap fix 2018-02-02 19:28:45 -05:00
Kris 9e690bf238
UX: Cleaning up category badge alignment (#5561) 2018-02-02 19:03:25 -05:00
Robin Ward 2f19588311 FIX: If personal messages are disabled, don't show messages for groups 2018-02-02 16:35:54 -05:00
Robin Ward 68d0d39ab7 FIX: Order the homepage box in the same order as the top menu
This is required because "no interface" is the same as showing
the first entry. But when the top menu has changed the first
entry is no longer the same, so it shows the wrong default.
2018-02-02 16:11:28 -05:00
Vinoth Kannan e8559f222c FIX: After moving the posts topic timestamp should be updated with newest post 2018-02-02 19:30:52 +05:30
Joffrey JAFFEUX b4aad15267
FIX: simplify styling of category-name when using category-drop/link 2018-02-02 10:31:20 +01:00
Joffrey JAFFEUX cf592fa35d
remove debugging code 2018-02-02 09:31:47 +01:00
Joshua Rosenfeld e5655f0b6b
UX: Add specific classes to ip address rows on user admin 2018-02-02 00:40:10 -05:00
Joffrey JAFFEUX 85db6cd2d7
FIX: makes sure we have a content to filter 2018-02-02 02:13:06 +01:00
Joffrey JAFFEUX a4445b0c1e
FIX: improve dropdown-select-box on mobile 2018-02-02 00:47:12 +01:00
Robin Ward d31417d3af FIX: Remove unused import 2018-02-01 18:03:22 -05:00
Joffrey JAFFEUX ce507b7957
FEATURE: display search on large category-drop and tag-drop 2018-02-01 23:51:29 +01:00
Robin Ward 8ff4104555 Many enhancements to the flagging / suspending interface. 2018-02-01 17:13:02 -05:00
Joffrey JAFFEUX f7df68c9a3
FIX: makes composer-actions toggling whisper instead of replying 2018-02-01 23:07:37 +01:00
Robin Ward 0156ae486d Apply extra classes to header avatar 2018-02-01 16:59:10 -05:00
Robin Ward 9f96d59a17 FIX: Unused import 2018-02-01 16:31:21 -05:00
Neil Lalonde 9fa71e198e FIX: admin reports charts should use same time of day as dashboard numbers 2018-02-01 15:59:39 -05:00
Neil Lalonde ef2a7ac0f7 FIX: admin reports would sometimes return fewer than 30 days of data, causing current 30 day period counts to be too small and prev30day counts to count the wrong days 2018-02-01 15:50:51 -05:00
Robin Ward 08db10491e Adds a new plugin API for adding classes to be shown on user avatars 2018-02-01 15:24:26 -05:00
Joffrey JAFFEUX 42399261ba
adds margin to avatar in composer-action-title 2018-02-01 18:41:11 +01:00
Joffrey JAFFEUX e3301c4869
FIX: max-height auto is not valid 2018-02-01 18:08:55 +01:00
Robin Ward 64ba876ff4 FIX: Don't show "Grant Badge" if badges are disabled 2018-02-01 11:33:48 -05:00
Joffrey JAFFEUX 97ddaeeae8
FIX: use css instead of js to fix select-kit-collection max-height 2018-02-01 16:56:07 +01:00
Joffrey JAFFEUX 9923829402
FEATURE: Menu toggle for different reply modes
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
2018-02-01 16:42:56 +01:00
Robin Ward 96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support
FEATURE: Mixed text direction support
2018-02-01 07:29:15 -08:00
Joshua Rosenfeld f85055d653 FIX: Remove activation link from account approved email (#5548) 2018-02-01 14:59:37 +01:00
Arpit Jalan f88b8a8945 rename 'default_email_private_messages' to 'default_email_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan 49424fd798 rename private to personal 2018-02-01 13:25:29 +05:30
Arpit Jalan 6be536ca50 rename 'max_private_messages_per_day' to 'max_personal_messages_per_day' 2018-02-01 13:25:29 +05:30
Arpit Jalan 7cda3a37af rename 'private_email_time_window_seconds' to 'personal_email_time_window_seconds' 2018-02-01 13:25:29 +05:30
Arpit Jalan ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan 25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Sam 60ee9a4ccf make tests a bit happier 2018-02-01 15:56:22 +11:00
Sam 41986cdb2f Refactor requires login logic, reduce duplicate code
This also corrects the positioning in the chain of the check
and removes misuse of prepend_before_action
2018-02-01 15:17:59 +11:00
Sam ee0d3f15c1 FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify
New site settings:

enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://

markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
2018-02-01 13:22:38 +11:00
Sam f2e7b74d88 FIX: don't return 200s when login is required to paths
When running `ensure_login_required` it should always happen prior to
`check_xhr` cause check xhr will trigger a 200 response
2018-02-01 12:26:45 +11:00
Régis Hanol 4bcf9c5bf3 FIX: only count 'human' users in group.user_count 2018-01-31 21:55:01 +01:00
Régis Hanol 826584b9c1 UX: prevent anons from clearing pins in topic view 2018-01-31 20:34:53 +01:00
Régis Hanol 8c91d418dd UX: improve semantic of login button for better password managers compatibility 2018-01-31 20:09:59 +01:00
Kris add641cbbc
UX: Input and search cleanup (#5546)
* Cleaning up input sizes

* alignment

* more alignment adjustments
2018-01-31 11:44:51 -05:00
Régis Hanol 48f8d9f8a4 UX: prevent anons from clearing pins 📌 2018-01-31 17:13:52 +01:00
Régis Hanol d233ecbe34 push updates to backups list to client 2018-01-31 12:05:06 +01:00
Régis Hanol c6fac68ccd FIX: don't blow up on badly encoding incoming email body 2018-01-30 23:47:58 +01:00
Neil Lalonde aab2d102ff FIX: 404 page when clicking a badge notification from before changing username 2018-01-30 15:56:44 -05:00