Robin Ward
33f483a47e
Add `home` class to dropdown for categories
2014-03-10 11:43:24 -04:00
Robin Ward
6626a6c3ea
FIX: Don't increase link counts when they are in the thousands
2014-03-10 11:21:48 -04:00
Robin Ward
d200e68bab
FIX: Link counter was broken for some https links
2014-03-10 11:16:21 -04:00
Benjamin Kampmann
680197200e
Add support for arrays to PluginStore
2014-03-10 14:59:59 +01:00
Régis Hanol
c5beb3852f
Merge pull request #2092 from nschonni/jshinting
...
Jshinting during CI build
2014-03-10 09:51:11 +01:00
Jeff Atwood
3186ca8c99
Merge pull request #2094 from vikhyat/firefox-paste-image
...
Fix Firefox image paste contenteditable hack
2014-03-09 22:48:56 -07:00
Vikhyat Korrapati
3b1ed996e7
Firefox: Reuse same contenteditable <div> instead of creating a new one on paste.
...
This fixes the issue where every alternate paste from a different source
would not work because the content wasn't getting pasted into the
contenteditable div randomly.
2014-03-10 10:50:52 +05:30
Kris Aubuchon
ef0e636307
making the mobile composer opaque, may fix clicks from falling through
2014-03-10 00:55:12 -04:00
Sam
e49ad34bfc
Revert "Hack for supporting pasting images into the composer in Firefox."
...
Reverted cause it broke https://meta.discourse.org/t/when-creating-a-reply-pasting-only-works-once/13587
This reverts commit c8c150dfbe
.
2014-03-10 13:43:28 +11:00
Sam
e68e106be7
UI: we only intended to add the word "new" for new topics
2014-03-10 13:40:49 +11:00
Sam
bf23c7a0c4
Merge pull request #2066 from riking/red-popup
...
Style 'urgent' composer popups differently
2014-03-10 10:46:15 +11:00
Sam
0de759e734
UI: remove usercard hacks, specify width explictly
2014-03-10 10:27:58 +11:00
Sam
68630af718
Merge pull request #2083 from vikhyat/firefox-paste-image
...
Hack for supporting pasting images into the composer in Firefox
2014-03-10 10:06:31 +11:00
Sam
5e83778fc1
PERF: remove ember renderspeed until we make it optional (disabled by default in prd)
2014-03-10 09:50:23 +11:00
Sam
c1d998cd4b
Merge pull request #2086 from vikhyat/new-unread-i18n
...
i18n of new/unread text next to topics
2014-03-10 09:27:04 +11:00
Vikhyat Korrapati
b0d1d7a3e8
i18n of new/unread text next to topics.
2014-03-09 16:31:44 +05:30
Kris Aubuchon
c751567c04
fixing mobile notificaiton badge
2014-03-08 23:08:32 -05:00
Vikhyat Korrapati
c8c150dfbe
Hack for supporting pasting images into the composer in Firefox.
2014-03-09 04:24:05 +05:30
Kris Aubuchon
10858d3c87
some incremental style enhancements, as discussed here https://meta.discourse.org/t/discourse-design-experiments/13479
2014-03-08 00:55:02 -05:00
Nick Schonning
96bf38757d
Update indexOf polyfill
...
Updated from the same source as the original comment. If IE8 isn’t
supported then this can be removed.
2014-03-08 00:37:28 -05:00
Jeff Atwood
4efabef8f2
add btn-primary class to PM in usercard
2014-03-07 14:27:13 -08:00
Robin Ward
145b2931c6
FIX: Forward button would break on some topics
2014-03-07 16:28:53 -05:00
Jeff Atwood
1403d303b6
Merge pull request #2074 from awesomerobot/master
...
fixing close topic/footer button/suggested topics alignment
2014-03-07 12:13:30 -08:00
Kris Aubuchon
3be1b0decf
fixing close topic/footer button/suggested topics alignment
2014-03-07 15:04:18 -05:00
Robin Ward
055b367e2b
Add link counts to `alt` tags of their badges.
2014-03-07 14:43:29 -05:00
Robin Ward
f5c3199b38
FIX: Do not consider hidden elements when wanting to load more
2014-03-07 14:23:13 -05:00
Régis Hanol
8214536614
BUGFIX: don't show redirect reason if you aren't redirected
...
Move the redirect to top page logic server-side and make sure the reason
is not shown when top is not in the navigation menu (top_menu).
2014-03-07 18:58:53 +01:00
Nick Schonning
8b3f2a8685
Remove unused variable
...
It is only set to empty then passed
2014-03-07 12:23:23 -05:00
Nick Schonning
db5ff5f311
Combine single path conditional
2014-03-07 12:23:22 -05:00
Nick Schonning
8961a2ee28
Simplify characterCode lookup
...
Reduce String.fromCharCode that can’t be optimized by the minifier.
2014-03-07 12:23:16 -05:00
Robin Ward
78889163bf
BUGFIX: We were tring to delete the mail string, not the mail itself.
2014-03-07 11:28:55 -05:00
Kris Aubuchon
ba52091330
fixing the profile page that I broke
2014-03-07 09:36:28 -05:00
Régis Hanol
87c5c59257
Revert "Fix unmatched braces of "nav.post-controls button""
...
This reverts commit c43e86d7c6
.
2014-03-07 12:43:50 +01:00
Régis Hanol
084f51b013
FEATURE: do not show category definition topic on top pages
2014-03-07 12:02:52 +01:00
Régis Hanol
dbb383497c
Merge pull request #2072 from ligthyear/fix-edit-body-too-similar-issue
...
Be more liberal when users wants to change their own body to a previous version
2014-03-07 11:38:59 +01:00
Régis Hanol
f25bcc5067
couple of bugfixes identified while importing from VB
2014-03-07 10:44:04 +01:00
Régis Hanol
7670598658
Merge pull request #2070 from nschonni/fix-mailformed-rule
...
Fix unmatched braces of "nav.post-controls button"
2014-03-07 10:37:25 +01:00
Sam
e9fe8f6063
Revert "BUGFIX: if uploads is in a symlinked directory stuff breaks"
...
This reverts commit 894bb0716c
.
The issue here was that docker was not mounting stuff properly post
reboot, then we had a broken symlink that "exists"
2014-03-07 19:22:40 +11:00
Sam
894bb0716c
BUGFIX: if uploads is in a symlinked directory stuff breaks
2014-03-07 19:17:11 +11:00
Jeff Atwood
b91eb8ed38
fix user page primary width
2014-03-07 00:01:42 -08:00
Sam
73ef91cf27
junk code removed
2014-03-07 19:00:36 +11:00
Sam
b19400726f
BUGFIX/FEATURE: store topic changes in post revisions
...
History + edit notifications for title and category changes
2014-03-07 19:00:36 +11:00
Benjamin Kampmann
d956ca9cf7
Be more liberal when the similar content of the post to be saved turns out to be the same post
...
- instead of setting a random number, we actually store the post id in redis now
- and when checking for matching recent post and it is the same, we allow it still
Fixes the issue that we prevent a user from reverting to a previous state within the unique_posts_min time window.
2014-03-07 08:23:15 +01:00
Nick Schonning
c43e86d7c6
Fix unmatched braces of "nav.post-controls button"
...
Spacing changes made so that the other braces could be compared
2014-03-07 00:29:58 -05:00
Jeff Atwood
0d84ec4d58
Merge pull request #2069 from nschonni/remove-tabs
...
Remove IE7< star hacks
2014-03-06 21:04:32 -08:00
Nick Schonning
3b881f3215
Remove IE7< star hacks
2014-03-06 23:55:57 -05:00
riking
e0063920b7
Style 'urgent' composer popups differently
...
The two "bad behavior" composer popups get the 'urgent' class, which colors them red.
2014-03-06 15:35:47 -08:00
Robin Ward
49a1733d97
FIX: We should use partials when rendering but keeping the same context.
2014-03-06 15:56:33 -05:00
Robin Ward
102242c9d5
Add Dismiss Read to mobile view
2014-03-06 15:32:49 -05:00
Robin Ward
e2ea148e38
FEATURE: Allow `customHTML` helper to resolve to a template if it
...
exists.
2014-03-06 13:32:32 -05:00
Régis Hanol
11d91328ab
Merge pull request #2056 from vikhyat/pm-likes
...
Don't suppress like notifications in private messages
2014-03-06 14:53:27 +01:00
Vikhyat Korrapati
944246f4af
Add test to ensure creation of like notification in a PM.
2014-03-06 19:07:26 +05:30
Régis Hanol
ac99947979
BUGFIX: topic specs were dependent on Time.now
...
which would fail when DST was around
2014-03-06 12:44:52 +01:00
Nick Schonning
bbe2d3cfe9
Strip tabs from sheets
2014-03-06 01:51:39 -05:00
Nick Schonning
978c120279
Use for loop to shrink bbcode
...
Dry out the long set of similar selectors
2014-03-06 01:45:31 -05:00
Nick Schonning
4f1a517490
Remove units for zero values
...
Units are ignored for zero values in CSS except for a few edge cases.
2014-03-06 01:14:51 -05:00
Nick Schonning
f43072135d
Remove empty SCSS rules
2014-03-06 01:02:00 -05:00
Kris Aubuchon
699692168d
modifying user profile to better support image backgrounds
2014-03-05 23:22:24 -05:00
Kris Aubuchon
899a5a87cd
adding basic :focus style in for buttons in Firefox
2014-03-05 22:18:42 -05:00
Robin Ward
2b0151afe9
BUGFIX: Editing a category would break categories for the current user
...
session.
2014-03-05 17:33:14 -05:00
Régis Hanol
ca12ea42a7
FEATURE: only redirect new users to top page for a limited period
...
That period is defined by the `redirect_new_users_to_top_page_duration`
site setting and defaults to 7 days.
2014-03-05 22:11:01 +01:00
Robin Ward
b0f3061113
It doesn't make sense to redirect when not logged in on a non-GET
...
request. We should report a failure then. They likely logged out or
in another tab or timed out.
2014-03-05 12:12:53 -05:00
Régis Hanol
2a99f1b15e
BUGFIX: HOME/END keyboard shortcuts on non-topic pages
...
This make sure both HOME/END keyboard shortcuts are only applied when viewing a topic
2014-03-05 16:08:45 +01:00
Régis Hanol
bce4130d39
Merge pull request #2036 from ArmedGuy/profile-backgrounds
...
FEATURE: Profile Backgrounds
2014-03-05 16:00:49 +01:00
Johan Jatko
98c479c3c4
FEATURE: Profile Backgrounds
...
Shares a modified codebase with avatars called "user_image"
2014-03-05 15:10:44 +01:00
Sam
adb6541635
FEATURE: mailing list mode always available
2014-03-05 14:21:53 +11:00
Sam
69b498da24
Merge pull request #2034 from birarda/custom_username_length
...
allow for custom username length via site setting
2014-03-05 12:06:23 +11:00
Stephen Birarda
4a2dab9c5e
allow for custom min_username_length
...
change constant in user to be global range and not default
2014-03-04 16:37:05 -08:00
Sam
ea553202f0
Merge pull request #2033 from birarda/master
...
add option to override user attributes from SSO payload
2014-03-05 11:33:32 +11:00
Sam
eb3a535c38
Merge pull request #2038 from fantasticfears/poster_expansion
...
poster_expansion will only slide down now.
2014-03-05 11:27:03 +11:00
Sam
24356cd807
Merge pull request #2050 from verg/unify_scroll_to_first_post
...
Scroll to Top of Topic instead of Reloading
2014-03-05 11:22:54 +11:00
Sam
b0fc834e09
Merge pull request #2054 from ligthyear/fix-broken-cats
...
BugFix: email-in on categories wasn't null-ed properly
2014-03-05 11:16:20 +11:00
Benjamin Kampmann
bf77c84095
BugFix: email-in on categories wasn't null-ed properly
...
Causing a problem if two categories got saved with an empty string because the corresponding Database constraint on the index would complain about dublicate values
2014-03-05 00:42:05 +01:00
Robin Ward
aa3f7f764d
You can only reuse email tokens within 24 hours.
2014-03-04 14:03:04 -05:00
Robin Ward
15c9c90533
When links have thousands of clicks, display them like 3.3K
2014-03-04 13:44:53 -05:00
Robin Ward
e276045112
TRIVIAL: Change some variables to `self`
2014-03-04 13:09:11 -05:00
Robin Ward
90a1cb5bec
Change email token expiry to 24 hours instead of 1 week
2014-03-04 13:02:48 -05:00
Stephen Birarda
c3eb2025d8
add option to override user attributes from SSO payload
...
add an external_username attribute for username from SSO payload
repair the field name in SingleSignOnRecord migration
move setting of external_username for sso to controller
add settings toggle to override username/email from SSO payload
fix changing of external username after override toggle
complete tests and logic for sso override
add some extra context to username override option
add external_email and external_name to single sign on record
add setting for name override from SSO payload
complete override with stored external_email and external_name
add missing checks to tests
remove an unneeded describe block
break up a monster method for single sign on
fixes for sso attribute override after failed tests
2014-03-04 09:52:21 -08:00
verg
7f440532a7
Jump to First Post instead of Reloading Topic
2014-03-03 19:09:42 -05:00
Robin Ward
28f84ef0e1
TEXT: Change to "Dismiss New"
2014-03-03 17:15:53 -05:00
Robin Ward
4b61d6af28
BUGFIX: new date was incorrect
2014-03-03 16:11:59 -05:00
Robin Ward
f9cd354a2c
FEATURE: Button to reset new
2014-03-03 15:47:01 -05:00
Robin Ward
3abe84941f
FEATURE: Add `new_since` column to `UserStat` so we can reset the "New"
...
date.
2014-03-03 15:47:00 -05:00
Kris Aubuchon
3d39dd3137
fixing an issue where a horiztonal scrollbar appears
2014-03-03 13:53:07 -05:00
Robin Ward
158487dfc2
FIX: Clean up next/prev rel links
2014-03-03 12:56:37 -05:00
Robin Ward
6143753fef
Support uppercase bbcode too.
2014-03-03 11:59:57 -05:00
Erick Guan
b5ca30bf56
poster_expansion will only slide down now.
2014-03-03 09:32:45 +00:00
Jeff Atwood
13f82f856f
Merge pull request #2045 from awesomerobot/master
...
changed some topic page widths so the gutter fills the availible space...
2014-03-02 23:52:48 -08:00
Kris Aubuchon
dd4a01896b
changed some topic page widths so the gutter fills the availible space, also right-aligning user-dropdown
2014-03-03 01:16:30 -05:00
Sam
ceb80611d6
PERF: defer last_ip_address and last_seen updates
2014-03-03 15:16:38 +11:00
Sam
172e517b31
Merge pull request #2012 from ligthyear/incoming-emails
...
Advanced New-Topic via Email Feature
2014-03-03 10:58:10 +11:00
Sam
7004b3f3b9
Merge pull request #2037 from infogulch/abandon-button-text
...
Explicit button text in abandon dialog in all lang
2014-03-03 10:37:32 +11:00
Jeff Atwood
66ae439ded
rel="prev" and rel="next" for topic also
2014-03-01 02:16:40 -08:00
infogulch
bf21a55571
Explicit button text in abandon dialog in all lang
...
The current post abandon dialog displays typical yes/no buttons and should
instead show more informative button text.
This commit updates all `config/locales/client.*.yml` files and *alters the
structure* of the `post.abandon` node, and *adds three new nodes* under it:
`confirm`, `yes_value`, and `no_value`. The current value of the
`post.abandon` node is moved into `post.abandon.confirm` for all languages.
For English language text, the nodes `post.abandon.yes_value` and
`.no_value` are changed to `"Yes, abandon"` and `"No, keep"`, respectively.
For other languages, the standard yes/no values are copied, allowing simple
copyedits to make them more explicit in the future.
I also make the necessary changes to the `composer_controller.js` file so
the new values are used correctly.
2014-02-28 23:42:14 -06:00
Neil Lalonde
b40313559b
FIX: moderators should not be able to see site setting changes in the staff action logs. Fixes #2027
2014-02-28 16:30:54 -05:00
Robin Ward
7d6984a915
Make the back button less awkward when leaving a topic.
2014-02-28 15:35:45 -05:00
Robin Ward
61ff04d68b
Upgrade ember-cloaking to not trigger scroll events when the back button
...
is hit.
2014-02-28 15:35:45 -05:00
Régis Hanol
6b83ed0347
OPTIM: change Top Topic's score computation algorithm
...
New algorithm will not wipe the entire table anymore and will only remove
invisible topics and add new visible topics.
2014-02-28 20:33:52 +01:00
Régis Hanol
5e1019adba
FEATURE: better UX when backing-up the site
...
Users won't be prompted whenever the site goes into read-only mode.
Instead, a banner will be shown at the top of every pages.
Also, the browser won't automatically reload whenever read-only mode is
disabled. This really was bad UX.
2014-02-28 18:09:48 +01:00
Robin Ward
67463af4f4
BUGFIX: Don't include deleted topics in activity. Deleted posts are OK.
2014-02-28 11:15:05 -05:00
Benjamin Kampmann
024597e643
Switch to proper exception handling system for better user feedback
...
- Replace implicit return code-system in Email::Receiver with proper exception system
- Update tests to check for exceptions instead
- Test the PollMailbox for expected failures
- Add proper email-handling of problematic emails
"
2014-02-28 17:02:58 +01:00
Benjamin Kampmann
d32cb55837
Add public-inbox to Email-In-Feature
...
- Adds the advanced option to accept email from non-users per category email-address
- Adds tests covering the new feature
- Adds UI to configure this feature in the frontend
2014-02-28 16:53:58 +01:00
Benjamin Kampmann
37cea49459
Add Email-In-Per-Category
...
- allow the configuration of an inbox-email-address per category
- post emails to that email into that category instead of global
- Adds UI for configuration
- Adds Documentation for configuration
- Adds Tests for new feature
2014-02-28 16:53:58 +01:00
Allen Hancock
dad43b9853
Optionally allow discourse to create new topics from email.
2014-02-28 16:53:58 +01:00
Régis Hanol
ca9f6e9137
BUGFIX: couldn't upload backup on OSX
...
--B is not a valid df option on OSX
2014-02-28 15:43:50 +01:00
Sam
560b5356d5
Revert "Use symbols instead of strings in order clause"
...
Breaks 1.9.3 compat
This reverts commit 09a2d9e12c
.
2014-02-28 15:08:50 +11:00
Neil Lalonde
3ddd71ffd1
Don't tell you that you successfully flagged a topic.
2014-02-27 18:31:37 -05:00
Sam
6e0e628ff5
BUGFIX: don't force load drafts when composing.
...
It will still be there after post is made.
2014-02-28 10:30:05 +11:00
Robin Ward
4d798abe50
BUGFIX: this fixes a chrome bug... I would laugh if I wasn't already
...
crying.
2014-02-27 16:56:03 -05:00
Régis Hanol
e5a4dc6eac
FEATURE: add a banner when read-only mode is enabled
2014-02-27 19:50:20 +01:00
Robin Ward
fee9870427
FIX: New counts were taking into account muted categories
2014-02-27 12:35:33 -05:00
Régis Hanol
70ca6171d1
BUGFIX: fix math & unit when checking disk space
2014-02-27 16:55:12 +01:00
Nick Borromeo
09a2d9e12c
Use symbols instead of strings in order clause
...
This simply changes the strings in the order clauses in the model. The
reason of the change is because the SQL generated when using symbols
automatically name spaces the column with the table name.
Topic.order(:title).to_sql
=> SELECT "topics".* FROM "topics" ORDER BY "topics"."title" ASC
This also changes the scopes using lamba to use stabby lambas for
consistency with other scopes.
2014-02-26 22:43:03 -08:00
Sam
1992271bf9
FEATURE: white_listed_spam_host_domains for domains that are not blocked for spam
...
BUGFIX: bypass host spam detection for current host
2014-02-27 15:43:57 +11:00
Kris Aubuchon
adde163447
fixing width of poster section of topic-list
2014-02-26 22:23:48 -05:00
Kris Aubuchon
190f075fae
small logos should always be proportionate
2014-02-26 22:00:22 -05:00
Sam
1b0c567729
OOPS
2014-02-27 12:43:44 +11:00
Sam
a4d7942dbd
BUGFIX: Don't blow up on junk referers
2014-02-27 12:03:38 +11:00
Sam
9551f4aeea
PERF: calculate scores for topics/posts faster
...
Only look at topics that changed in last day for 15 minuted schedule
Do a full recalc weekly, just in case
2014-02-27 11:45:40 +11:00
Sam
e4909c017c
PERF: only rebuild entire top topic table daily
2014-02-27 11:45:40 +11:00
Jeff Atwood
cceed615a3
make sure onebox h3,h4 suppress topmargin
2014-02-26 16:13:36 -08:00
Neil Lalonde
d15d5e2525
Also put the envelope glyph beside topic title edit form for private messages
2014-02-26 18:01:59 -05:00
Neil Lalonde
7322345039
FIX: when shown 403 error page and logging in, it will take you to the same page
2014-02-26 17:53:53 -05:00
Jeff Atwood
534dadf1be
Merge pull request #2016 from awesomerobot/master
...
removing background gap on topic closures
2014-02-26 14:37:26 -08:00
Kris Aubuchon
1f8fa09846
removing background gap on topic closures
2014-02-26 17:34:15 -05:00
Jeff Atwood
78188cd713
Merge pull request #2015 from awesomerobot/master
...
small design tweaks
2014-02-26 14:22:32 -08:00
Kris Aubuchon
9e4181dbe5
small design tweaks
2014-02-26 17:15:57 -05:00
Régis Hanol
9571eb07a4
BUGFIX: you should not be able to edit the category on a PM
2014-02-26 22:45:19 +01:00
Robin Ward
9267c162a1
FIX: Showing Unread(1) when you weren't tracking the topic. Also
...
includes performance fix when having MANY new or unread topics.
2014-02-26 15:39:45 -05:00
Neil Lalonde
ed201b1b5b
FIX: on mobile, don't scroll background when showing a modal. iOS goes bananas. Thanks shobhit007
2014-02-26 13:46:15 -05:00
Neil Lalonde
1165aa2dae
Don't show description text on Create Category modal
2014-02-26 13:45:01 -05:00
Régis Hanol
043901ef46
FEATURE: warn the user when there is not enough space on disk to upload a backup
2014-02-26 19:38:06 +01:00
Régis Hanol
c6bc324259
CLEANUP: remove unused pseudo locale
2014-02-26 19:03:04 +01:00
Neil Lalonde
8167cefe36
Add envelope glyph to private message topic titles
2014-02-26 12:24:21 -05:00
Robin Ward
cae7af4b07
BUGFIX: Do not scroll to top / show spinner when leaving a topic.
2014-02-26 12:04:55 -05:00
Robin Ward
c668d49822
REFACTOR: Use the `ScrollTop` mixin instead of custom scrolling code.
2014-02-26 11:54:15 -05:00
Sam
50a8d3caae
BUGFIX: sso to send welcome emails
2014-02-26 10:28:03 +11:00
Sam
74a1145a0b
BUGFIX: sso to respect must_approve_users
2014-02-26 10:27:39 +11:00
Sam
440435f023
FEATURE: SSO to handle return_path automatically
2014-02-26 09:58:30 +11:00
Neil Lalonde
8cbff3672f
Fixes on mobile signup form
2014-02-25 16:40:30 -05:00
Neil Lalonde
0b1d1ffcba
FIX: problems with mobile login modal
2014-02-25 16:40:30 -05:00
Robin Ward
4e1a628ff9
Hooks for extra nav items.
2014-02-25 16:02:27 -05:00
Robin Ward
d079538a6d
Allow the `customHTML` helper to look up fragments outside of the
...
preloadStore, so plugins can stuff HTML in there when overriding a whole
template doesn't make sense.
2014-02-25 16:02:27 -05:00
Robin Ward
8a96f1a7b6
FIX: Margin in onebox
2014-02-25 14:50:21 -05:00
Jeff Atwood
0e6325d172
unnecessary CSS suppression of li paras
2014-02-25 10:28:48 -08:00
Neil Lalonde
b15e771d67
Oops, I meant 1
2014-02-25 12:19:22 -05:00
Neil Lalonde
7288bf1f31
Add previous page link for crawlers
2014-02-25 12:15:48 -05:00
Robin Ward
9ebcdfba1f
Merge pull request #2005 from eriko/plugin_store_delete
...
clean up plugin store when removing data instead of setting the value to...
2014-02-25 11:36:05 -05:00
Erik Ordway
dfa6960799
clean up plugin store when removing data instead of setting the value to nil and do it a reasonable way.
2014-02-25 08:26:35 -08:00
Neil Lalonde
8134113b22
Add rel=next to next page link for crawlers
2014-02-25 10:18:07 -05:00