21e9315416
FIX: Use user account email instead of auth email when totp is enabled.
...
https://meta.discourse.org/t/github-2fa-flow-broken/88674
2018-05-30 12:15:12 +08:00
543b7cddfb
FIX: Extra comma resulted in Github auth email result being an array.
...
https://meta.discourse.org/t/github-2fa-flow-broken/88674
2018-05-30 12:15:12 +08:00
e26a14dc29
FIX: error when flagging to notify moderators because message title is too long
2018-05-29 12:21:47 -04:00
df815d6c0e
DEV: prefer using ordering in relation over default scope
2018-05-29 09:34:12 +10:00
c8bc942333
FIX: do not add invited user to automatic groups
2018-05-28 17:17:48 +05:30
81b5d61fa7
FIX: `topic_destroyed` web hook couldn't find topic.
2018-05-28 17:38:02 +08:00
ed2ae3cb0a
FIX: Load post revisions in correct order
2018-05-28 11:25:24 +02:00
123a22e6d8
DEV: Clean up omniauth after mocking.
2018-05-28 15:12:54 +08:00
a081771950
Merge pull request #5872 from OsamaSayegh/users-controller-specs-to-request
...
REFACTOR: users contollers specs => request specs
2018-05-28 13:32:37 +08:00
e501936405
FIX: search server side error in rare condition
2018-05-28 15:28:18 +10:00
0347c97520
tgxworld feedback
2018-05-28 06:20:47 +03:00
5a32a70d6c
FIX: ColorScheme color missing was returning "nil"
2018-05-28 11:46:00 +10:00
4195c7c9ea
FEATURE: Ability to clear a user's penalty history
...
You can do this manually if you want to allow them to reach TL3 without
their penalty history counting against them.
2018-05-25 12:54:22 -04:00
20b94bc714
FIX: Extraction of quoted posts failed in some cases
...
* It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed.
* Revising a post didn't add or remove records from the quoted_posts table.
2018-05-25 12:00:17 +02:00
12e4dd59b7
Style fix for test
2018-05-25 15:54:14 +10:00
501bc0e9af
FIX: UserProfileView: Do not log IP of logged-in users
2018-05-25 15:54:14 +10:00
9c91c2509e
improve spec stability
2018-05-25 15:16:40 +10:00
610bfec73e
DEV: correct fragile spec
2018-05-25 14:29:11 +10:00
720a12ce76
correct time dependent spec
2018-05-25 14:26:05 +10:00
be1b8fc3a8
DEV: ensure specs run in consistent times
2018-05-25 14:22:43 +10:00
755b511b5c
PERF: Destroy collapsed notifications in 1 query instead of 3.
2018-05-25 12:01:36 +08:00
80adc1ee80
DEV: stabilize site setting spec
...
side effects could cause specs to fail in rare conditions
2018-05-25 12:16:00 +10:00
bac0482061
REFACTOR: users contollers specs => request specs
2018-05-25 05:04:25 +03:00
58fbe74b6f
Remove assertion `to_not raise_error`.
...
If an error is raised the test would fail anyway.
2018-05-25 09:57:08 +08:00
1f27c91924
DEV: Better diagnostic when topic tracking state tests fail.
2018-05-24 15:36:41 +08:00
43f7cb05c9
FIX: Broken ping event for web hooks due to missing payload.
2018-05-24 15:16:52 +08:00
d366f8d888
remove hack that destabliazed tese suite
2018-05-24 10:48:16 +10:00
3db1032bfd
FIX: not found page shouldn't include the Google search form for sites with login_required enabled
2018-05-23 16:59:02 -04:00
4be0e31459
fix s3_cdn_url when the s3 bucket contains a folder
2018-05-23 15:51:02 -05:00
fac4bf2f85
ignore emails that are from the reply by email addresses ( #5843 )
2018-05-23 10:04:45 +02:00
ad9e0d6bea
Merge pull request #5848 from OsamaSayegh/fix-social-login-groups
...
FIX: apply automatic group rules when using social login providers
2018-05-23 08:17:42 +08:00
f6d412465b
FIX: apply automatic group rules when using social login providers
2018-05-23 02:26:07 +03:00
3edca8b104
Return a 403 instead of 200 when trying to delete a user with posts
...
See [this commit][1] for more info
[1]: bd352a17bf
2018-05-22 17:02:02 -06:00
609804f5ef
REFACTOR: merge posts controller specs into request specs
2018-05-23 08:53:46 +10:00
45f65859c9
improve erraticly failing spec
2018-05-23 08:39:15 +10:00
beed676b04
FIX: Check group names when checking username availability
2018-05-22 21:55:54 +02:00
95db5f0c8c
FIX: Do not replace wrong avatars when renaming user
2018-05-22 13:41:51 +02:00
1ac1ee4287
FEATURE: allow registration of an array custom field
2018-05-22 16:48:39 +10:00
bcfd9cf8b5
attempt to stabilize spec
2018-05-22 16:15:24 +10:00
d4639bc734
TEST: Add TopicLinkClick spec for ip logging
2018-05-22 16:05:38 +10:00
450a600721
REFACTOR: about & badge controllers => requests
2018-05-22 13:45:13 +10:00
661d89f489
skip erratic spec
2018-05-22 09:42:50 +10:00
788ca1f112
FIX: stop adding email to unsubscribe url
...
Instead of adding email to unsubscribe url store it in redis for 1 hour
rate limit calls to unsubscribe endpoint to ensure there is no risk of
bloating redis
Also move controller to request specs
2018-05-22 09:07:03 +10:00
37ad2dd936
Fix the build.
2018-05-21 17:59:47 +08:00
aae5575d33
Remove spec file that was accidentally added.
2018-05-21 17:35:55 +08:00
467d91347a
Missing specs for `Group`, `Tag`, `Category` and `Flag` web hooks.
2018-05-21 17:29:58 +08:00
bf84037f79
FIX: Payload for webhooks should be current as of the time the event was triggered.
...
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
2018-05-21 17:29:58 +08:00
00c6b078e3
Trim `WebHookUserSerializer`.
2018-05-21 17:29:58 +08:00
60e7b13f59
Trim `WebHookPostSerializer` further.
2018-05-21 17:29:58 +08:00
3ff0074e9d
Trim `WebHookTopicSerializer` further.
2018-05-21 17:29:58 +08:00
ec337bbcb3
DEV: attempt to report last exception as the "cause" for failures
...
This allows our request specs to report exceptions so we can debug
May have a few false positives but generally should be quiet
TODO only wire magic in for request specs, currently happens for all
2018-05-21 17:01:50 +10:00
b7b08b4173
Fix regression introduced in 2ceb107074.
2018-05-21 13:26:23 +08:00
2ceb107074
Refactor tests to use the json extension instead of headers.
2018-05-21 09:49:46 +08:00
9f422c93f6
FIX: restrict updates on `confirm_old_email` email templates
2018-05-19 12:19:59 +05:30
290ee312e6
FIX: handle invalid mailto links
2018-05-18 18:02:52 +05:30
b9dfb0ba10
Partially revert 531baec5b5.
2018-05-18 15:01:36 +08:00
531baec5b5
Remove unused fabricator.
2018-05-18 13:37:39 +08:00
416d19af27
FIX: Wrong target user displayed for user actions in activity stream.
...
https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816
2018-05-18 11:28:13 +08:00
417bcc5f2a
Remove blank test.
2018-05-18 11:07:57 +08:00
04c7dbafa3
FIX: manifest.json better detection at mime type. Find size if uploaded
2018-05-17 14:45:24 -07:00
41ffafb65e
FIX: best effort at returning correct mime types in manifest.json
2018-05-17 12:14:39 -07:00
53f8f6095d
FEATURE: staff action logs when creating/updating/deleting badges
2018-05-17 18:09:27 +02:00
9532d9a555
FIX: handle invalid tags
2018-05-17 19:33:12 +05:30
b74c108c09
UX: Display group tabs in user's messages tab for non-staff as well.
...
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
2018-05-17 18:10:17 +08:00
147ea37115
FIX: Missing notification for watching first post users when topic is recategorized.
...
https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld
2018-05-17 16:15:29 +08:00
33899664ce
FIX: handle bad user profile website
2018-05-17 13:21:24 +05:30
539cf32f87
FIX: handle encoded mailto links when looking for upload record
2018-05-17 12:44:53 +05:30
aee4045dd0
FIX: suggest name when username/name is provided
2018-05-17 10:36:36 +05:30
f21a47eadd
Improve specs to assert for the right record instead of just a count.
2018-05-17 08:47:24 +08:00
a9ebde5111
FEATURE: new 'staged' users list for admins
2018-05-17 01:52:49 +02:00
39aceed63d
FIX: don't purge unactivated users with a message
2018-05-16 18:24:11 +02:00
ae6236d090
FIX: Changing owner of deleted reply didn't work
2018-05-16 17:03:09 +02:00
4103783821
FIX: don't use PMs in Incoming Links reports
2018-05-16 16:55:54 +02:00
131b7f5da5
make 🤖 rubocop happy
2018-05-16 16:35:04 +02:00
3cd4c82c49
Allow parameters for group and username filters on directory ( #5815 )
2018-05-16 16:20:17 +02:00
5e97a9bfb7
FIX: tags in a 'visible by everyone but usable only by staff' group weren't visible by everyone
2018-05-16 09:48:19 +02:00
565fa1f60e
Fix regression introduced in 8cf0f51eb2.
2018-05-16 14:26:03 +08:00
21e0b7c818
avoid async report pattern and replace with simpler hijack
2018-05-16 16:05:03 +10:00
74c4af279a
Improvements to user renaming
...
* don't update search index if post belongs to deleted topic
* log errors instead of crashing when updating post or revision fails
* update mentions even when the href attribute is missing
* run the background job with low priority
* replace username in all notifications
* update `action_code_who` used by small action posts
2018-05-15 21:05:51 +02:00
2e1b5bc8d3
FIX: Transaction in UserAnonymizer prevented avatar from updating
2018-05-15 20:47:58 +02:00
b9c6821261
correct spec
2018-05-15 15:20:36 +10:00
abcb6af8f9
FIX: scrub secret setting values from logs
2018-05-15 09:19:26 +05:30
a28c58feb1
FIX: automatic group membership when using SSO
2018-05-15 01:48:30 +02:00
d2347474a5
Tests for IncomingLink IP logging
2018-05-15 09:32:29 +10:00
e474351ae4
inactive users report is not used anymore
2018-05-14 21:31:14 +02:00
c67c2dc638
FIX: Username update should ignore revisions without raw
2018-05-14 15:22:42 +02:00
8232aba743
FIX: Update search index after renaming user within posts
2018-05-14 13:20:30 +02:00
02cb84847c
FIX: Update avatar in oneboxed posts when renaming user
2018-05-14 13:20:29 +02:00
49392fb105
FIX: Anonymizing user didn't replace uploaded avatar in posts
2018-05-14 13:20:29 +02:00
9d9332d8c9
FIX: allow user quotes in HTML digest emails
2018-05-13 18:23:17 +02:00
37232fcb58
FIX: staff members should see all tags
2018-05-13 17:50:21 +02:00
2cf6fb7359
FIX: always unstage users when they log in
2018-05-13 17:00:02 +02:00
67054d524d
correct missing day from async reports
2018-05-11 15:06:23 +10:00
8a783412b7
UX: improvements to new dashboard
...
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
bd352a17bf
FIX: Show a json api response when deleting a user with posts
...
A 500 error was actually caused with no response when using the api, so
it wasn't very clear that you need to delete the posts first when using
the api.
2018-05-10 13:04:36 -06:00
86eb3528ec
FEATURE: clearer error message when receiving a reply to an old notification
2018-05-09 18:51:01 +02:00
6b1ff0edd3
FIX: always update bounce score (instead of doing it once per day)
2018-05-09 16:40:52 +02:00
2eb2f273a8
Refactor of `PushSubscriptionPusher`.
2018-05-09 08:14:14 +08:00
7f1f697e97
FIX: de-duplicate push subscriptions - ensure unique user/key
2018-05-08 15:20:39 -07:00
52db0b31c1
FIX: Automatically add user to groups after updating email address
2018-05-08 21:27:22 +02:00
Guo Xiang Tan
Neil Lalonde
Sam
Arpit Jalan
Gerhard Schlager
Guo Xiang Tan
OsamaSayegh
Robin Ward
riking
Andrew Schleifer
Ryan Mulligan
Blake Erickson
Jeff Wong
Régis Hanol
Joe Buhlig
Joffrey JAFFEUX