fadcd36f92
FIX: do not treat ignore_redirects domains as blacklisted
...
This fix prevents domains present in `ignore_redirects` to be treated as
blacklisted domains and makes sure that onboxing happens for those domains.
Issue reported here: https://meta.discourse.org/t/steam-store-oneboxing-no-longer-works/97266
2018-09-18 10:38:02 +05:30
ce6a0a5e9e
FIX: Moving upload to tombstone should update modification time.
...
A upload created a long time ago will be nuked from the tombstone
immediately if it gets deleted.
2018-09-18 10:48:29 +08:00
0e9841b995
SECURITY: remove admin memory diagnostics routes
2018-09-18 08:35:09 +10:00
4481836de2
FEATURE: new 'search_ignore_accents' site setting
2018-09-17 10:42:30 +02:00
b71af05d62
Backward compatibility for dropping functions in `ColumnDropper`.
...
https://meta.discourse.org/t/launcher-rebuild-error-pg-error-schema-discourse-functions-does-not-exist/96209
2018-09-17 14:46:05 +08:00
4f46aa1ba3
FEATURE: Add SiteSetting for s3_configure_tombstone_policy
...
Add SiteSetting for s3_configure_tombstone_policy, skip policy generation if turned off (default on)
2018-09-17 10:57:50 +10:00
c7d81e2682
FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard
2018-09-17 09:49:53 +10:00
526ffc4966
FIX: error in response body to blocked crawlers, showing 500 Internal Server Error with status of 403
2018-09-14 15:40:20 -04:00
b87a089822
FIX: don't block api requests when whitelisted_crawler_user_agents is set
2018-09-14 15:40:20 -04:00
81dc36ba16
Version bump to v2.2.0.beta2
2018-09-14 11:43:35 -04:00
f2363650c9
Merge pull request #6395 from discourse/plugin-migrations
...
DEV: apply plugin migrations when testing in Travis and Docker
2018-09-13 06:51:30 -07:00
b8c0e77908
DEV: apply plugin migrations when testing in Travis and Docker
...
In `RAILS_ENV=test`, plugins are not loaded by default. Therefore we need to explicitly specify `LOAD_PLUGINS=1` when we want to apply plugin migrations.
2018-09-13 12:39:54 +01:00
529e4018f0
DEV: Avoid using `send` and make the method public instead.
2018-09-13 16:34:32 +08:00
0a06b3d977
Accept custom AR relation for `UploadRecovery`.
2018-09-13 16:33:14 +08:00
6c65718301
Include response body when raising an error in `FileHelper#download`.
2018-09-13 15:43:58 +08:00
5eb65ad612
FIX: Do not try to recover invalid `Upload#short_url` in `UploadRecovery`.
2018-09-13 13:59:17 +08:00
d99dd840e4
Add basic test case for `UploadRecovery`.
2018-09-13 13:26:23 +08:00
a3b3b0810d
Rescue errors when running dry run for `UploadRecovery`.
2018-09-13 11:57:51 +08:00
4dc25ad201
Fix s3 recovery from tombstone in `UploadRecovery`.
2018-09-13 09:19:45 +08:00
9461c99210
DEV: Add travis_fold to termination stage
2018-09-12 18:59:48 +01:00
26bd67a865
DEV: Add travis_fold statements to docker_test
2018-09-12 17:52:58 +01:00
24c55bd613
Add dry run option to `UploadRecovery`.
2018-09-12 21:53:01 +08:00
2cc48cfd06
Fix incorrect variable.
2018-09-12 02:06:14 -07:00
c053f8ccf6
New rake task `uploads:recover`.
2018-09-12 01:52:30 -07:00
6d01e0aa04
DEV: Print the error class in `uploads:list_posts_with_broken_images`.
2018-09-12 01:06:51 -07:00
71185c13b5
Merge pull request #6377 from tgxworld/remove_tif_tiff
...
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
2018-09-12 09:32:32 +08:00
71caf7521d
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
...
https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld
2018-09-12 09:29:54 +08:00
e1b16e445e
Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.
2018-09-12 09:22:28 +08:00
d59e635a77
Rename `FileHelper.images` to `FileHelper.supported_images`.
2018-09-12 09:22:28 +08:00
f1cb431968
FIX: rescue ActiveRecord::RecordInvalid in find_or_create_by_safe! ( #6385 )
...
AR uniqueness validation could raise ActiveRecord::RecordInvalid
2018-09-12 11:03:12 +10:00
1a01385e88
FIX: "false" didn't work as locale_default
2018-09-11 13:42:10 +02:00
b3b9ac3b19
Version bump to v2.2.0.beta1
2018-09-10 19:43:15 -04:00
80eace4268
Merge pull request #6383 from discourse/fix_username_suggester
...
FIX: don't raise an error on integer usernames in user_name_suggester
2018-09-11 00:30:29 +05:30
81c87df18a
FIX: don't raise an error on integer usernames
2018-09-10 22:17:56 +05:30
1d41f3c3fb
Merge pull request #6380 from discourse/rake-destroy-sub-category
...
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 10:26:04 -06:00
94ff428571
Pass the right value to rake task.
2018-09-10 20:07:28 +08:00
84fc7abb73
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
4a966c639d
DEV: Update `uploads:list_posts_with_broken_images` to recover from tombstone.
2018-09-10 17:01:41 +08:00
df04e69cde
FIX: `S3Helper#list` creates incorrect prefix.
2018-09-10 16:34:40 +08:00
68572b8afc
Print error messages on why upload fails to save.
2018-09-10 16:02:13 +08:00
0aca80e92a
Fixes to `uploads:list_posts_with_broken_images`.
2018-09-10 15:16:29 +08:00
8496537590
Add `RECOVER_FROM_S3` to `uploads:list_posts_with_broken_images` rake task.
2018-09-10 15:14:30 +08:00
afaa722c32
sort official plugin list, remove duplicate entry
...
`discourse-sitemap` was listed twice, sorted list to help avoid duplication
2018-09-09 13:41:26 -04:00
879067d000
FIX: check admin theme cookie against user selectable
...
previously admin got a free pass and could set theme via cookie to anything
including themes that are not selectable
this refactor ensures that only "preview" gets a free pass, all the rest
goes through the same pipeline
2018-09-07 10:47:28 +10:00
3dea48f1d9
Resetting miniracer context results in segfault
2018-09-07 00:19:23 +02:00
f13c34aaed
Adds a check for invalid message formats to rake i18n:check
2018-09-06 17:27:17 +02:00
3c09026fe4
Minor improvements to rake i18n:check
2018-09-06 16:54:30 +02:00
d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
434035f167
FIX: Link post to uploads in `PostCreator`.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
26082688d1
FIX: Zero is a valid value for the page parameter
2018-09-05 20:43:05 +02:00
f3aef2cc83
FIX: Incorrect/missing extension in short_url fails to map to upload.
...
`Hash#invert` causes us to lose keys if the hash contains similar
values.
2018-09-05 21:48:58 +08:00
72834f19ff
DEV: Add rake tasks to list posts with broken images.
2018-09-05 16:54:15 +08:00
f4956f79a5
Make Rubocop happy
2018-09-05 01:04:43 +02:00
6658a6601c
Remove unused rake task
2018-09-05 00:47:39 +02:00
0d8c72d8c4
DEV: Add rake task to check locale files for errors
2018-09-05 00:47:39 +02:00
b8fc699164
FIX: Detect {{foo}} as interpolation key
2018-09-05 00:47:39 +02:00
d8b543bb67
FIX: redirect to original URL after social signup
2018-09-05 01:44:23 +05:30
4382fb5fac
DEV: Allow plugins to whitelist specific user custom_fields for editing ( #6358 )
2018-09-04 20:45:36 +10:00
d1af89e3b3
DEV: Extract global admin api rate limiting into a dedicated method.
...
* We have a use case for overriding the rate limiting logic in a
plugin.
2018-09-04 16:37:54 +08:00
3b337bfc6b
Revert "FIX: Don't rate limit admin and staff constraints when matching routes."
...
This reverts commit 651b50b1a1
2018-09-04 14:27:21 +08:00
651b50b1a1
FIX: Don't rate limit admin and staff constraints when matching routes.
...
* When an error is raised when checking route constraints, we
can only return true/false which either lets the request
through or return a 404 error. Therefore, we just skip
rate limiting here and let the controller handle the
rate limiting.
2018-09-04 13:52:58 +08:00
08b268c5bc
Be more forceful in disconnecting connections during failover.
2018-09-04 10:32:43 +08:00
8dc1463ab3
Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.
2018-09-04 10:16:42 +08:00
eeedc3901e
FIX: Replying to deleted post via email should create new reply to topic
2018-09-03 23:06:40 +02:00
24a14af15a
FIX: Respect invalidate_oneboxes option for inline oneboxes
2018-09-03 22:33:43 +05:30
f33433bf9e
Validation of params should restrict to max int ( #6331 )
...
* FIX: Validation of params should restrict to max int
* FIX: Send status 400 when "page" param isn't between 1 and max int
2018-09-03 14:45:32 +10:00
747c9bb47f
Merge pull request #6317 from nbianca/ignore_blacklisted_domains
...
FIX: Ignore OneBox blacklisted domains.
2018-09-03 11:10:52 +08:00
45f092a49d
Extract `badge_posts` view management logic into a service object.
...
* Avoid defininig a global constant and method.
Fixes https://github.com/discourse/discourse/pull/6318
2018-09-03 09:51:35 +08:00
182d9a4666
FIX: escape regex chars when searching site texts
2018-09-02 17:25:57 +10:00
60eff9421a
FIX: precompile `desktop_theme` and `mobile_theme` stylesheets
...
required for environments that pre stage docker images and keep old image running during the deploy
2018-08-31 21:23:55 +10:00
9b7cab589a
FIX: revert diacritic stripping
...
See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam
2018-08-31 11:46:55 +10:00
297e8aaf2e
FIX: Escape regex pattern variable before using it
2018-08-31 03:02:24 +05:30
4b6381367e
add support for Excon connection options in hub requests
2018-08-30 15:57:11 -04:00
415201e1b4
Version bump to v2.1.0.beta6
2018-08-30 10:53:20 -04:00
2dfb097dd9
DEV: plugin generator support for spec/test/controller/routes ( #6344 )
2018-08-30 16:38:25 +02:00
90e67b671b
DEV: support for settings/locales in plugin generator ( #6341 )
2018-08-30 14:12:06 +02:00
9efbf2c49f
FIX: changing component settings should trigger refresh for parent theme CSS ( #6340 )
2018-08-30 20:53:03 +10:00
d40d241e72
DEV: adds --help --no-help options to plugin generator ( #6338 )
...
help will add helpful comments in the various generated files
2018-08-30 12:16:37 +02:00
acc96abe1a
DEV: plugin generator will now ask for github username ( #6337 )
2018-08-30 12:03:30 +02:00
492b6dc306
DEV: `yarn exec` doesn't do what I think it does.
2018-08-30 15:55:36 +08:00
e6970151a6
FEATURE: allow specifying locale via SSO
...
Use:
locale
locale_force_update
To force user locale on users where SiteSetting.allow_user_locale is enabled
Note: If an invalid locale is specified no action will occur
2018-08-30 09:58:03 +10:00
06f18b0e9f
typo
2018-08-29 13:51:16 +02:00
ef36fdfb64
DEV: rails generator to create plugin skeleton ( #6332 )
...
rails g plugin --help
rails g plugin DiscourseRacoon --author joffrey
2018-08-29 13:32:41 +02:00
5f51ef27e7
Added sitemap plugin in the official list
2018-08-29 10:58:26 +02:00
720726ea68
Use `yarn exec` when running eslint and prettier.
2018-08-29 11:03:42 +08:00
44cf3cf975
FIX: queue heartbeats in readonly modes
...
If sidekiq is paused or Discourse is in readonly continue to queue
heartbeats
If we do not do that then a master process can end up reaping sidekiq
workers and causing various badness
This also impacts restore which can do weird stuff TM in cases like this
2018-08-29 12:36:59 +10:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
ebe7835316
FIX: links in rss feeds are sometimes wrong on subfolder installs
2018-08-27 18:05:15 -04:00
b6963b8ffb
FIX: Ignore OneBox blacklisted domains.
2018-08-27 20:40:55 +02:00
4205c528d0
FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages
...
These site settings are very hard to explain and only applicable for very
specific Discourse setups.
If an admin "enables staged users" which is used in support scenarios then
all staff can send "messages" directly to an "email".
The setting allows you to extend this to TL4 or any trust level.
Actual use case would be a support type setup with restricted staff. It is
quite rare so hiding this for now and re-evaluate keeping the setting in
2019
2018-08-27 11:38:22 +10:00
020eba4623
FIX: find tags with non-latin names ( #6312 )
2018-08-27 11:05:28 +10:00
47e6b8b318
discourse etiquette is an official plugin
2018-08-27 10:03:49 +10:00
ac11f8df52
correct regression searching with diacritics
2018-08-24 10:00:51 +10:00
6588a45880
Make Rubocop happy
2018-08-23 15:09:20 +02:00
409ee66839
Add optional "ignore_case" parameter to posts:remap rake task
2018-08-23 14:49:17 +02:00
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
dd810b8b05
Merge pull request #6304 from tgxworld/create_functions_in_different_schema
...
FIX: Create `BaseDropper` functions in a different schema.
2018-08-23 15:01:41 +08:00
6ee352510a
Correctly handle exception
2018-08-23 16:27:00 +10:00
cbd9045c6b
FIX: avoid race condition creating posts
...
in some cases the distributed mutex was not protecting us
and transactions would fail
2018-08-23 15:11:06 +10:00
212ee15804
FIX: Create `BaseDropper` functions in a different schema.
...
https://meta.discourse.org/t/error-when-restore-db-backup/93145/25?u=tgxworld
2018-08-23 12:52:21 +08:00
2711f173dc
FIX: don't allow inviting more than `max_allowed_message_recipients`
...
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows
* add specs for guardian
* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)
Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences
* groups take only 1 slot in PM
* just return if topic is a PM
2018-08-23 14:36:49 +10:00
36a7028f19
FEATURE: Clean up `PostReplyKey` records.
...
* Default retention of 90 days.
2018-08-23 10:40:02 +08:00
f01169d6ff
FIX: don't send email when the post was deleted
2018-08-22 13:13:58 +02:00
d3b4f24ced
DEV: correct watcher for controller specs
2018-08-22 14:35:57 +10:00
272de95175
FIX: client duplicate registration should be cleaned up
...
If for any reason we are unable to correct client id on a user api key
invalidate old keys for client/user
2018-08-22 12:56:49 +10:00
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
f5142861e5
Revert "Revert "FIX: upload URLs from S3 on subfolder installs""
...
This reverts commit 26c96e97e5
2018-08-22 11:31:33 +10:00
26c96e97e5
Revert "FIX: upload URLs from S3 on subfolder installs"
...
This reverts commit 357df2ff4f
2018-08-22 10:51:40 +10:00
410b0f591f
FIX: Flagged Post custom fields were not respecting type
2018-08-21 15:33:15 -04:00
357df2ff4f
FIX: upload URLs from S3 on subfolder installs
2018-08-21 14:58:55 -04:00
d1607a387a
FIX: only allow printable characters in uploads filename
2018-08-21 18:11:01 +02:00
e94b5b4d78
Version bump to v2.1.0.beta5
2018-08-21 11:54:23 -04:00
0f07494b12
Merge pull request #6259 from pfaffman/patch-2
...
FIX: disable_2fa fix method selection
2018-08-21 17:29:42 +08:00
791ddb8630
PERF: Memoize `EmailReceiver#sent_to_mailinglist_mirror?`.
2018-08-21 15:44:47 +08:00
7dcc69aef4
DEV: Refactor test to not call private method.
2018-08-21 14:29:58 +08:00
57d04200a1
Add Rails 6 note here
2018-08-21 11:09:10 +10:00
ca5a6f0a9d
FIX: handle concurrently creating post reply keys
...
In some very rare conditions this would be called concurrently and fail
2018-08-21 10:59:18 +10:00
8fa5dd4a1f
FEATURE: discourse-checklist is now an official plugin
2018-08-21 10:44:40 +10:00
860c1c3dcd
FEATURE: Automatically expire keys if not used for a configurable amount of time. ( #6264 )
2018-08-20 17:36:14 +02:00
ac40fede66
Revert "FIX: subfolder support for S3 CDN"
2018-08-20 10:30:44 -04:00
0b8f6d3637
FIX: subfolder support for S3 CDN
2018-08-20 10:22:03 -04:00
f5fe58384f
correct regression around file renaming
2018-08-20 16:08:05 +10:00
d7b1919ead
correct specs
2018-08-20 12:46:14 +10:00
8b5e42ea16
FIX: always test and coerce to image on upload
...
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.
We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
a83f662492
FIX: Allow silenced users to like / bookmark, just not flag.
2018-08-17 11:06:18 -04:00
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
a26ef7738f
FIX: `FileHelper#download` should return nil if max size is exceeded.
2018-08-17 16:19:59 +08:00
be89f593f9
DEV: Include caller in error message for `Discourse#execute_command`.
2018-08-17 16:17:07 +08:00
fae8757cd4
FIX: `Guardian#post_can_act?` shouldn't raise an error if user of post has been deleted.
2018-08-17 15:11:30 +08:00
70155f0923
DEV: decrease log level of compile failures
...
We do not need to report his in logs, our failure mode is fine here.
2018-08-17 17:10:02 +10:00
a9e502936f
FIX: Converting PNG to JPEG does not set the correct extension.
2018-08-17 13:09:48 +08:00
802ad0dc61
Add rake task for updating static pages
2018-08-16 19:51:20 +02:00
98898ff4b3
FIX: raise an exception when 'downsize'git st fails
2018-08-16 19:20:07 +02:00
3fbf7b164d
FEATURE: emoji 11.0 "recently added" update ( #6275 )
...
Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list
2018-08-16 11:59:45 +02:00
937ab3f213
FIX: Validation of min_posts and max_posts didn't work
2018-08-16 10:36:53 +02:00
8e3b685aa4
make rubocop happy
2018-08-16 14:03:46 +05:30
df55e5bac4
optimize categories:create_definition task
2018-08-16 14:00:07 +05:30
78e14abb32
new rake task to bulk tag all topics in a category
2018-08-16 13:56:57 +05:30
777055f960
new rake task to create category definition
2018-08-16 13:50:52 +05:30
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
33f4aa2835
Fix `migrate_to_s3` rake task, `File#close!` is not a valid method.
2018-08-16 13:26:58 +08:00
ac3b0f0164
REFACTOR: move remap out of script into a class
2018-08-15 12:37:52 -04:00
7b089f7af4
FIX: Don't throw exception if welcome topic cannot be found
2018-08-15 15:50:55 +01:00
38c10a3dc2
correct the validator
2018-08-15 14:56:24 +10:00
91e0a77a60
FEATURE: silenced users should not be allowed to edit posts
2018-08-15 14:29:36 +10:00
06f82a7d72
correct exception handling, always do to_i in array
2018-08-15 11:31:42 +10:00
bc47148d35
add validation to exclude_category_ids
2018-08-15 09:53:28 +10:00
12bab65167
FIX: going from /categories to /latest on mobile might break infinite scrolling
2018-08-15 01:22:03 +02:00
ba0e322fd0
FIX: Validation of topic params broke discourse-assign
2018-08-14 18:45:46 +02:00
Arpit Jalan
Guo Xiang Tan
Sam
Régis Hanol
Rishabh
OsamaSayegh
Neil Lalonde
Guo Xiang Tan
David Taylor
Kyle Zhao
Gerhard Schlager
Blake Erickson
Joshua Rosenfeld
Vinoth Kannan
Maja Komel
Joffrey JAFFEUX
Dax74
Bianca Nenciu
Robin Ward
Bianca Nenciu