f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
2019-02-15 10:24:29 +11:00
0472bd4adc
FIX: Remove 'backfill_etags' keyword argument from 'uploads:missing' rake task
...
And etags backfilling code is optimized
2019-02-15 00:34:35 +05:30
e2b8fbee12
DEV: Improve test.
2019-02-14 17:53:26 +02:00
7003ea96be
FIX: Fix failing test.
2019-02-14 16:56:06 +02:00
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
b5fbd7385f
FIX: run the rake task only for uploads created before a day from inventory date
2019-02-14 17:53:08 +05:30
f7d03b2406
Stop the automatic creation of inventory 'gz' file in fixtures
2019-02-14 14:25:45 +05:30
f52378ca5f
Make rubocop happy
...
oops I forgot a newline
2019-02-14 18:06:06 +11:00
ebd4140492
FIX: logspam due to 404s on CSS files
...
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.
Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
74d2d4f658
FEATURE: add APIS for unpausing all sites
...
This adjusts 53d592ad
2019-02-14 13:34:20 +11:00
53d592ad3b
FIX: Add multisite support to Sidekiq::Pausable. ( #6960 )
...
Having a global Sidekiq pause switch is problematic because a site in
the cluster can pause Sidekiq for the entire cluster.
2019-02-14 12:22:40 +11:00
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
7b5931013a
Update rake task to backfill etags from s3 inventory
2019-02-14 05:18:06 +05:30
1045bbc35b
FIX: S3 inventory data can be splitted into multiple csv files
2019-02-14 03:41:52 +05:30
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
5cef5b34ef
DEV: Yarn-manage moment and moment-timezone libraries
2019-02-12 13:57:52 -05:00
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
12d061a45b
Remove stubbing of `auto_close_threshold_reached?`
2019-02-11 15:41:03 -05:00
705c898c21
FEATURE: Calculate CSP based on active themes ( #6976 )
2019-02-11 12:32:04 +00:00
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
84a10f8212
Fix failing spec
...
The Report class created its own BackupStore without a stubbed S3 client
2019-02-08 21:38:10 +01:00
b75a3e391a
Use `skip` not `pending`
2019-02-08 13:48:29 -05:00
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
fb18c57372
For now, make spec pending since it is broken.
2019-02-08 12:46:19 -05:00
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
cc496de10e
FIX: Remove double quotes from etag value in API response
...
https://github.com/aws/aws-sdk-ruby/issues/1134
2019-02-08 14:31:19 +05:30
2a007bafa2
FEAT: Allow image resize by width or height
...
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.
Resize value can be from 1 to 999 (incl. for percentages).
2019-02-07 15:04:39 -05:00
c256121833
FIX: add support for style element in SVGs
2019-02-07 12:09:06 +01:00
ab2c2ea605
FIX: validate Invite email against `EmailValidator.email_regex` ( #6975 )
2019-02-06 22:38:06 +05:30
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes ( #6973 )
...
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
ba9cc83d4c
FIX: Destination prefix in S3 inventory configuration is incorrect
2019-02-06 20:51:28 +05:30
381793243e
FIX: include error message if the "accept invite" process fails
2019-02-06 19:20:25 +05:30
ff12c4b2d4
FIX: Bucket name is missing in S3 inventory data path
2019-02-06 19:16:08 +05:30
e7821a63e7
FIX: Users should able check the emails for self
2019-02-05 23:31:19 +05:30
a3b47c1dd1
FEATURE: Allow string theme settings to display with multiple lines
...
To use, add `textarea: true` to the theme settings.yml. For example:
```
my_setting:
default: "some string"
textarea: true
```
2019-02-05 14:14:53 +00:00
7b7bc3db39
FIX: Rescue and display import errors when updating theme via git
2019-02-05 13:49:16 +00:00
4f3ee86bbd
FIX: in:title should work irrespective of the order. ( #6968 )
2019-02-05 10:54:52 +01:00
edcdbe1946
DEV: Restore textarea type for site settings
...
Currenty, no settings in core use this, but textareas will be useful in theme settings and plugins.
2019-02-04 15:41:58 -05:00
e5a81aeb6e
REFACTOR: Remove stubbed methods in tests
2019-02-04 15:06:00 -05:00
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
a1b4d9b061
DEV: Fix specs using deprecated site settings.
2019-02-01 12:31:03 +08:00
a84aaf197a
DEV: correct heisentest testing for avatars
...
If for some reason we created andupload with id 1 in the test then the
test would fail. This can happen if this is the absolute first test to
run on the db.
Fix sets the upload to a legitimate which in turn means the last upload
will not be upload id 1 and stops using id hard coding for the testing.
2019-02-01 13:27:06 +11:00
720e896e17
FIX: `PostActionCreator` was not checking the guardian properly
...
It also exposed a bug in the EmailReceiver spec, where a test had a user
liking their own post and was not failing.
2019-01-31 14:48:42 -05:00
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
886ba9dff9
DEV: Correct spec for theme export change
2019-01-31 17:52:03 +00:00
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
f83533e1cb
FIX: use absolute url for `/images/example.png` links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
421d47da1e
FIX: user and group mentions in subfolder installs
2019-01-29 21:54:29 -05:00
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00
51fdf7a11d
FIX: don't duplicate attachments
2019-01-28 18:40:52 +01:00
fb5c94246c
DEV: Remove underscore from `learn_more` key in theme export
...
Follow up from 033cd4f3
2019-01-28 16:00:33 +00:00
033cd4f31d
DEV: Include "_learn_more" key in theme `about.json`
...
This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.
2019-01-28 11:34:11 +00:00
99e0820c0b
UX: Do not prepend `discourse` to theme filename if it's already there
2019-01-28 11:29:29 +00:00
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
0f73026c21
FIX: Heisentest
...
These tests were failing for the same reason as:
bee68bba2e
2019-01-25 15:25:48 -05:00
db76e5a368
FIX: properly handle attachments in received emails
...
This regressed in 1ac3e547
2019-01-25 19:13:34 +01:00
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
0947fa2bad
Fix specs
...
Follow-up to 7e9da812ea
2019-01-24 22:54:03 +01:00
45b056b615
FIX: Do not show backups stored in subfolder of bucket
2019-01-24 22:28:03 +01:00
7e9da812ea
DEV: Multisite tests didn't fail anymore
...
The change in 9ba8bfb1aa
2019-01-24 22:28:00 +01:00
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
fabeba788d
FIX: allow sending PMs to staff via flag even when PMs are disabled ( #6938 )
...
* FIX: allow sending PMs to staff via flag even when PMs are disabled
FIX: allow sending PMs to staff via flag even if the user trust level is insufficient
* Update lib/topic_creator.rb
Co-Authored-By: techAPJ <arpit@techapj.com>
2019-01-24 16:56:59 +05:30
afd449089f
FEATURE: Import and export themes in a .tar.gz format ( #6916 )
2019-01-23 14:40:21 +00:00
70b56c8332
FIX: 'anon' css class is missing for anonymous users
2019-01-23 10:13:36 +05:30
f32de88dfc
FIX: Don't notify of pending flags if min_flags_staff_visibility not met
2019-01-22 11:01:18 -05:00
2fe9617dc1
Fix rubocop.
2019-01-22 18:37:55 +08:00
d32900292d
FIX: Don't update `User#last_seen_at` when PG is in readonly take 3.
2019-01-22 18:07:48 +08:00
4dee7ed6d9
DEV: Fix randomlly failing spec.
2019-01-22 15:19:31 +08:00
f6f2c38183
FIX: Fallback Redis by checking status on master instead of slave.
2019-01-22 12:38:12 +08:00
b0adffdef5
FIX: Clear anon cache when clearing recently readonly.
2019-01-22 09:53:04 +08:00
3359b3baca
FEATURE: Do not autoclose topics due to user flagging that are authored by staff
2019-01-21 15:50:53 -08:00
a123aafdad
Fix random build error
...
Follow-up to b95165b838
2019-01-21 22:00:45 +01:00
0cf8f10158
SPEC: Use I18n translation instead of using raw text
2019-01-21 20:21:09 +05:30
b95165b838
FEATURE: adds a new chart report to track pageviews ( #6913 )
2019-01-21 15:17:04 +01:00
426907cb88
FIX: Incorrect subscription in `PostgreSQLFallbackHandler`.
2019-01-21 17:39:31 +08:00
c5dd4bf5dc
fix the build
...
Use whitespace after code block start for single word languages
2019-01-21 15:04:18 +05:30
3c6a8a2bb1
Partially revert 4466fcf1bc.
2019-01-21 15:41:01 +08:00
9cf4013073
Add raw post content in "flagged post removed by staff" PM
2019-01-21 12:27:23 +05:30
4466fcf1bc
FIX: Don't update `User#last_seen_at` when PG is readonly take 2.
2019-01-21 13:49:08 +08:00
c732ae9ca9
FIX: Don't update `User#last_seen_at` when PG is in readonly.
2019-01-21 13:29:29 +08:00
f8ded9cec9
FIX: Changing owner of small action post failed
...
Small action posts for invites (CC from email) have a blank raw and revising of posts with blank raw didn't work anymore.
2019-01-19 13:38:45 +01:00
David Taylor
Arpit Jalan
Sam
Vinoth Kannan
Bianca Nenciu
Bianca Nenciu
Maja Komel
Guo Xiang Tan
Penar Musaraj
Robin Ward
Dan Ungureanu
Gerhard Schlager
Régis Hanol
Vinoth Kannan
Guo Xiang Tan
Blake Erickson
Jeff Wong
Joffrey JAFFEUX