5969a31d73
DEV: Use equal method instead of deepEqual
2018-11-23 01:53:13 +05:30
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
9672c92045
DEV: removes _.each from codebase ( #6629 )
2018-11-20 14:46:58 +01:00
c4ed353fae
DEV: removes _.map from codebase ( #6616 )
2018-11-19 10:46:46 +01:00
f2c227432c
FIX: Do not show nested user cards. ( #6621 )
2018-11-19 10:01:22 +01:00
9911a41f4c
FIX: improves category/tag drops header shortcuts ( #6610 )
...
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
7fa21ce199
UX: minor tweaks to theme components selection UI ( #6596 )
2018-11-13 14:57:50 +01:00
9c616e0679
FIX: handles not found reports in bulk loading ( #6582 )
2018-11-12 13:47:24 +01:00
c7377e2f2d
UX: Trash icon displaying when there is no upload take 2.
2018-11-12 16:19:17 +08:00
10c6211cdf
UX: Trash icon displaying when there is no upload.
2018-11-12 16:06:32 +08:00
12da912c73
DEV: Avoid Discourse specific code in fixtures.
2018-11-09 17:15:37 +08:00
7a53e0b186
DEV: Remove fields from fixtures that are no longer valid.
2018-11-09 13:52:40 +08:00
42572ff138
Revert font awesome 5 changes
...
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
09dc922b3b
Fix several FontAwesome 5 issues
...
add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues
2018-11-07 22:20:53 -05:00
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ( #6557 )
...
* First take on subsetting svg icons
* FontAwesome 5 svg subset WIP
* Include icons from plugins/badges into svg sprite subset
* add svg icon support to themes
* Add spec for SvgSprite
* Misc. SVG icon fixes
* Use FA5 svgs in local-dates plugin
* CSS adjustments, fix SVG icons in group flair
* Use SVG icons in poll plugin
* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
afbdf9c2d2
Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post
...
FIX: disable flagging hidden posts
2018-11-05 11:05:32 -08:00
ae9eddb002
FIX: don't allow adding a value containing vertical bar char to the secret list
2018-11-05 12:14:56 +01:00
94f628fb4c
FIX: disable flagging hidden posts
2018-11-02 13:54:45 -04:00
398f98c568
FIX: ensures reports links are correct on subfolder installs
2018-10-26 12:32:02 +02:00
2a77550f8c
FIX: Do not track right clicks. ( #6530 )
2018-10-25 09:46:04 +00:00
0ead513fb0
PERF: remove total unread notifications from message bus ( #6529 )
2018-10-25 12:14:34 +11:00
05438d99a8
FIX: Ensure the like button always has a title, for accessibility ( #6525 )
...
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
37b7afa522
FIX: Sanitize tags before creation
2018-10-22 10:53:42 +01:00
0dd717e641
Revert "FIX: Sanitize tags before creation"
...
This reverts commit 18ae8de9e5
2018-10-19 15:49:05 +01:00
18ae8de9e5
FIX: Sanitize tags before creation
2018-10-19 15:43:31 +01:00
22ada32d4d
FIX: Strip @ when searching for users and groups. ( #6506 )
2018-10-19 11:56:10 +11:00
287e780f22
DEV: Skip tests instead of commenting out.
2018-10-18 11:06:03 +08:00
69dbd9b069
DEV: Comment test causing issues.
2018-10-17 20:29:21 +03:00
21d804fc92
DEV: Fix build. ( #6500 )
2018-10-17 17:39:25 +02:00
f60b10d090
UX: Warn users if the post that's currently edited has changed. ( #6498 )
2018-10-17 15:35:32 +02:00
27e732a58d
FEATURE: allow multiple secrets for Discourse SSO provider
...
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.
This allows for better auditing of the SSO provider feature
2018-10-15 16:03:53 +11:00
57b52cd1de
FIX: keep emoji syntax for custom emojis in quotes ( #6488 )
2018-10-15 10:57:15 +08:00
84d4c81a26
FEATURE: Support backup uploads/downloads directly to/from S3.
...
This reverts commit 3c59106bac
2018-10-15 09:43:31 +08:00
ded5ff90aa
FIX: Groups list does not refresh when query changes. ( #6481 )
2018-10-11 21:20:17 +08:00
6275e745a7
FIX: Fix open quote links in new window. ( #6477 )
2018-10-11 15:51:14 +08:00
3c59106bac
Revert "FEATURE: Support backup uploads/downloads directly to/from S3."
...
This reverts commit c29a4dddc1
2018-10-11 11:08:23 +08:00
c29a4dddc1
FEATURE: Support backup uploads/downloads directly to/from S3.
2018-10-11 10:38:43 +08:00
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
...
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
75488257c5
FIX: Redirect users to top when `latest` is the homepage
2018-10-05 12:14:57 +01:00
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
9554d657c5
DEV: Remove underscore from tags-test
2018-10-04 21:14:52 +01:00
4ae9cb28e4
remove probes.js, highlight.pack.js
2018-10-04 13:50:54 -04:00
cd82107976
use yarn to manage test vendor dependencies, upgrade sinon to v6.3.5
2018-10-04 11:06:14 -04:00
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters ( #6445 )
2018-10-04 15:15:10 +01:00
6ad13e5ae9
FIX: Avoid redirection when not leaving forum. ( #6419 )
...
* FIX: Avoid redirection when not leaving forum.
* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
41eacd859e
temporarily comment out test
2018-10-03 14:07:30 +10:00
73443d889c
FIX: keep files in order when adding multiple uploads ( #6306 )
...
* FIX: keep files in order when adding multiple uploads
* use filename in the placeholder when uploading files
* add tests
* add consecutive nr to the placeholder when multiple uploads with the same filename
2018-10-03 11:12:36 +10:00
cb519a3bec
Fix test
2018-10-02 15:20:11 -04:00
719a433c03
FIX: Sync client & server rules regarding tag names. ( #6400 )
2018-10-01 21:45:44 -07:00
4b517d460d
FIX: dashboard test depended on the last month has 31 days
2018-10-01 12:31:27 +08:00
373d6e3fe6
always `loadScript` with a script tag ( #6411 )
...
to avoid Content Security Policy unsafe-line violations
2018-10-01 10:06:01 +08:00
a713c0d366
FIX: ensures onSelect/onDeselect are called
...
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
2ff2c49908
Revert "FIX: ensures onSelect/onDeselect are called"
...
This reverts commit 52eed73294
2018-09-17 22:14:41 +02:00
52eed73294
FIX: ensures onSelect/onDeselect are called
2018-09-17 10:36:14 +02:00
e15a1e7c38
lint code
2018-09-17 11:10:09 +10:00
03edb31a4d
add tag-drop component test
2018-09-17 10:40:47 +10:00
bc4e2aa07c
correct prettier offence
2018-09-17 10:30:36 +10:00
8f39cf6bfc
FIX: Permit unpinning an unlisted topic.
2018-09-17 10:03:06 +10:00
ca28548762
feedback (see commit description for details)
...
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
a4f057a589
UX: improvements to admin theme UI
2018-09-17 09:49:53 +10:00
754d5b62a8
makes mini-tag-chooser test use can_create_tag ( #6402 )
2018-09-14 13:30:55 +02:00
d2ea618af1
adds a test for mini-tag-chooser
2018-09-14 12:13:00 +02:00
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
a033327b93
Manage qunit via yarn.
2018-09-11 15:07:28 +08:00
4ee8e77073
Apply prettier.
2018-09-11 09:16:03 +08:00
d788555994
DEV: Manage pretender with yarn.
2018-09-07 16:01:49 +08:00
039afe0d2c
Apply prettier.
2018-09-07 15:19:34 +08:00
6c1e70d554
FIX: do no reset tags selection on category selection ( #6369 )
...
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
fcae21c4fc
remove test that is no longer relevant
2018-09-04 10:52:12 +10:00
3748d3e281
UX: hide associate accounts if second factor is enabled
...
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
f5e0356fb2
correct miscellaneous issues with user login history
2018-09-02 17:24:54 +10:00
16974df1e9
FIX: Resetting site setting didn't remove "overriden" state
2018-09-01 02:09:23 +02:00
ceae3d0a93
fix js tests ( #6343 )
2018-08-30 15:09:08 +02:00
f39c38d281
DEV: Support stable branch tests for `discourse-spoiler`.
2018-08-30 17:20:42 +08:00
0f812aa768
Make prettier happy.
2018-08-30 15:56:30 +08:00
092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
...
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
c1a5a7504e
FIX: Reset email preferences controller. ( #6316 )
2018-08-29 23:10:56 +02:00
4c99acea1b
FIX: Use tight list format for GDocs html to markdown
2018-08-29 16:21:31 +00:00
afec673c2b
Fixing test
2018-08-29 11:44:04 -04:00
26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
...
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
fb35b0b3c3
FIX: Keep emojis and remove clicks count
2018-08-29 07:26:25 +00:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
faf09bb8c8
Replacing default brown category color
2018-08-24 14:18:14 -04:00
82dcc5cbfa
FEATURE: makes reports loadable in bulk ( #6309 )
2018-08-24 15:28:01 +02:00
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
bd66fbef7f
FIX: Post time query filter not set correctly when loaded from params.
...
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
b2ce33be26
FIX: tag intersection not populating ( #6296 )
...
* Fix for tag intersection not populating
* Fix prettier
* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
87d443f070
FIX: counters were showing future instead of past ( #6299 )
2018-08-22 12:37:05 +02:00
599cebf8ad
FIX: better message if request for report is rate limited ( #6298 )
2018-08-22 11:25:12 +02:00
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
de2243319e
Fix the build.
2018-08-20 16:25:59 +08:00
658b55c406
FIX: Search does not retrigger when context has changed. Take 2.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
9c3ba98ef1
FIX: User can't save gravatar as profile picture after refresh.
...
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
37d4f27c44
FIX: quality/bugfix dashboard/reports pass ( #6283 )
2018-08-17 16:19:25 +02:00
edf26a0931
uses emoji version for tests ( #6277 )
2018-08-16 14:06:56 +02:00
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
b6939093eb
Fix JS tests.
2018-08-01 11:21:46 +08:00
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
ece3cb73df
Rename humburger_menu_categories_count site setting to header_dropdown_category_count
2018-07-31 09:12:30 +05:30
b852275ced
Test method for site categories random order fix
2018-07-31 01:36:37 +05:30
c54b5824d4
REFACTOR: Prioritize unread categories in hamburger menu
2018-07-30 20:20:10 +05:30
c7c84606d9
fix prettier offense
2018-07-30 12:43:10 +02:00
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
249b16e8e3
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:37:41 +05:30
78d91b1daf
UX: Changes in top categories of hamburger menu ( #6200 )
2018-07-30 14:13:00 +05:30
fc3b904e1f
remove "track external right clicks" feature
2018-07-29 15:01:33 +05:30
dac29b5ebc
UX: Display only top categories in hamburger menu ( #6146 )
2018-07-27 12:11:07 +05:30
330cf78c83
FIX: don’t break browser history on dashboard visit ( #6186 )
2018-07-26 14:59:28 -04:00
a89dd51cae
DEV: migrate acceptance tests to async/await
2018-07-26 12:51:16 +02:00
1ed3a89ac9
UX: clear topic timer text when manually closing/opening ( #6123 )
...
* UX: clear topic timer text when manually closing/opening
* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
ad95c24307
FEATURE: displays a notice if report has no data ( #6178 )
2018-07-25 14:28:41 -04:00
637850d867
REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal
2018-07-25 12:38:15 +02:00
44a5c29d42
Clear old text and URL when showing up the "Insert Hyperink" modal. ( #6138 )
2018-07-25 17:12:49 +10:00
3a52c2fa64
DEV: migrate widgets tests to async/await
2018-07-24 23:22:03 +02:00
d16a2c776a
DEV: migrate components tests to async/await
2018-07-24 22:41:14 +02:00
95720e3873
lint files
2018-07-24 10:57:16 +10:00
c9d4288214
UX: auto fix order when reordering categories ( #6149 )
...
* set correct position number when moving up/down
* UX: drop 'fix order' and auto re-order subcategory
- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 ( #6099 )
...
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
9ed4071713
fixes dashboard next spec ( #6132 )
2018-07-21 10:29:58 -04:00
863de8cb76
Make prettier happy.
2018-07-21 18:03:39 +08:00
096e8ee21c
Disable broken JS test for now.
2018-07-21 17:48:20 +08:00
44e7f63d65
temporarily disable test for new-topic page
2018-07-20 17:49:16 +05:30
194844fc66
fixes tests
2018-07-19 14:44:42 -04:00
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
73739060f3
DEV: migrate acceptance tests to async await - plugin, reports, user, topic
2018-07-19 16:40:12 +02:00
2e96646659
DEV: migrate acceptance tests to async await - invite, login, mobile
2018-07-19 16:38:37 +02:00
a2281fbb19
FEATURE: allows to jump to a date in a topic
2018-07-19 16:00:13 +02:00
7f7944bc3a
DEV: migrate acceptance tests to async await - dashboard, emoji, group
2018-07-19 14:00:03 +02:00
e36d1c72f1
DEV: migrate acceptance tests to async await - badges, category, composer, customHTML
2018-07-19 13:52:48 +02:00
6aa2eb19d4
DEV: migrate acceptance tests to async await - admin, about, account created ( #6111 )
2018-07-19 17:35:10 +08:00
fa38891a98
FEATURE: show modal when user without permissions tries to delete their own topic ( #6086 )
2018-07-18 23:31:37 +02:00
Vinoth Kannan
David Taylor
Guo Xiang Tan
Joffrey JAFFEUX
Bianca Nenciu
Guo Xiang Tan
Sam
Penar Musaraj
Jeff Atwood
Maja Komel
Jeff Wong
Matthew Campbell
Bianca Nenciu
Gerhard Schlager
Kris
Kyle Zhao
OsamaSayegh
Vinoth Kannan
Arpit Jalan
James Kiesel
Neil Lalonde
Régis Hanol
Dan Ungureanu