5 Commits

Author	SHA1	Message	Date
Daniel Waterworth	1352a5b5fa	DEV: undo pluck_first changes to micro benchmark ... and add pluck_first benchmark	2019-10-21 12:21:24 +01:00
Daniel Waterworth	55a1394342	DEV: pluck_first ... Doing .pluck(:column).first is a very common pattern in Discourse and in most cases, a limit cause isn't being added. Instead of adding a limit clause to all these callsites, this commit adds two new methods to ActiveRecord::Relation: pluck_first, equivalent to limit(1).pluck(*columns).first and pluck_first! which, like other finder methods, raises an exception when no record is found	2019-10-21 12:08:20 +01:00
Sam Saffron	30990006a9	DEV: enable frozen string literal on all files ... This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging	2019-05-13 09:31:32 +08:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Sam	6d1321192a	micro bench template	2014-12-04 09:31:04 +11:00