Commit Graph

25 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 110f6ec6dd
DEV: fixes eslint/prettier on github actions (#10601) 2020-09-04 20:01:14 +02:00
Joffrey JAFFEUX 34c2dfccb7
DEV: specific ext and remove I18n global 2020-09-04 18:59:53 +02:00
Robin Ward e08545cf99 Add a pull request template to remind people to add tests. 2020-08-25 09:03:38 -04:00
Jarek Radosz d684d5fba4
DEV: Don't lint core files when target == plugins (#10259)
* DEV: Don't lint core files when target == plugins
* Prettier the plugin/*.js files
* Update eslintignore/prettierignore
* Add eslint-plugin-ember and eslint-plugin-node
* Properly lint all js files in all plugins
* LINT: run prettier on test/*.js files
* DEV: Run prettier checks on test/*.js files
* ESLint plugins' assets/javascripts and test/javascripts directories only
2020-08-25 11:40:40 +02:00
Gerhard Schlager 208d85aaff DEV: Ensure prettier uses the same patterns everywhere 2020-08-20 16:27:32 +02:00
Penar Musaraj 29dc2058c5
DEV: Update ImageMagick version in CI (#10080) 2020-06-19 09:26:50 -04:00
Jarek Radosz 70e50a2255
DEV: Use postgres 12 in GitHub Actions CI (#10043)
12 is now the recommended and widely deployed version.
2020-06-15 13:41:24 +02:00
Guo Xiang Tan e7af83e1fd
DEV: Run `apt-get update` before installing packages on CI.
```
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/universe/libj/libjpeg-turbo/libjpeg-turbo-progs_1.5.2-0ubuntu5.18.04.3_amd64.deb  404  Not Found [IP: 52.177.174.250 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
```
2020-06-11 11:53:38 +08:00
Gerhard Schlager 6b7a2d6d4d DEV: Remove non-existent option from setup-ruby Github action 2020-06-09 15:50:09 +02:00
Gerhard Schlager f683c5d0e0 DEV: Check English locale for errors in CI
Moves the most important checks into a linter. It gets executed by Lefthook as well as the docker rake task and Github actions. Doing those checks in rspec takes too long and it produces errors when the discourse:test Docker image contains old, invalid locale files.
2020-06-03 21:54:58 +02:00
Robin Ward 42b300b9be DEV: Skip I18n in plugins until they can be updated 2020-05-14 10:40:53 -04:00
Jarek Radosz b7d6eb3986
DEV: Various GitHub Actions CI tweaks (#9724)
* DEV: Update bundler in GitHub Actions CI

* DEV: Fix bundler deprecation warning

Fixes the following two deprecation warnings:

```
[DEPRECATED] The `--deployment` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set deployment 'true'`, and stop using this flag
```

```
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set without 'development'`, and stop using this flag
```

* DEV: The default `retry` value is already `3`

See https://bundler.io/v2.0/man/bundle-config.1.html:

> retry (BUNDLE_RETRY): The number of times to retry failed network requests. Defaults to 3.

* DEV: `&& \` isn't required in multiline `step.run`

Steps use the fail-fast strategy.

* DEV: Use multiline `step.run` where possible
2020-05-11 17:04:33 +02:00
Robin Ward 032205e202 Rename many `.js.es6` files to `.js` 2020-03-12 13:29:55 -04:00
Jarek Radosz 23b9da6b1c
DEV: Fix the CI workflow
See: https://github.com/actions/setup-ruby/pull/52
2020-01-20 18:51:55 +01:00
Gerhard Schlager e474cda321 REFACTOR: Restoring of backups and migration of uploads to S3 2020-01-14 11:41:35 +01:00
David Taylor 007c44ec56 Revert "DEV: Add smoke test to github actions (#8580)"
This is proving unreliable, so removing for now

This reverts commit 38b4e3b5a7.
2020-01-08 23:38:11 +00:00
David Taylor 38b4e3b5a7
DEV: Add smoke test to github actions (#8580) 2020-01-07 12:54:01 +00:00
Rafael dos Santos Silva b445e0e76a
DEV: Update Bundler (#8583)
* DEV: Update Bundler

Latest RubyGems 3.1.1 vendors bundler 2.1.0 *again*. And our base
image build system even updates it to 2.1.1.

After that it is unable to run a simple `bundle install` because of
version mismatch.

Updating bundler to the one that comes with our enforced Ruby version
solves this.

* DEV: Update bundler in CI too
2019-12-19 16:25:33 -03:00
Joffrey JAFFEUX df78a22b79
DEV: shows prettier version on CI run 2019-12-13 20:33:55 +01:00
David Taylor e5ce2d97f6 DEV: Simplify Rubocop runner for GitHub actions
Once we are happy with basic behavior, we can try adding annotations again
2019-12-11 11:49:27 +00:00
Joffrey JAFFEUX bc05d3bcdd
DEV: triggers github actions on pull_request (#8527) 2019-12-11 00:24:30 +01:00
David Taylor 424cda1433 DEV: Add timeouts to GitHub actions 2019-12-10 20:44:33 +00:00
David Taylor de69c3c921 DEV: Use push trigger for github actions, but ignore tests-passed
The pull_request trigger causes the rubocop annotations to fail
2019-12-10 16:25:45 +00:00
David Taylor d2d7bed21d
DEV: Restrict branches for github actions
This avoids running duplicate checks when a commit lands in tests-passed
2019-12-10 14:41:55 +00:00
Joffrey JAFFEUX bd17a3a8e7
DEV: introduces Github Actions for CI (#8441)
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-12-10 14:45:47 +01:00