Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Penar Musaraj
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
Gerhard Schlager
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
Joffrey JAFFEUX
59e84e8e05
DEV: skip tests instead of commenting them ( #7774 )
2019-06-17 10:24:20 +02:00
Robin Ward
a8793d0d9a
REFACTOR: Test Memory Usage Fixes ( #7769 )
...
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.
* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.
* `updateCurrentUser` is more accurate than `replaceCurrentUser`
2019-06-14 14:54:20 +02:00
Maja Komel
621b6493f7
DEV: test badge titles presence on badge page
...
follow-up on 2863e7c
2019-06-12 15:04:21 +02:00
Joffrey JAFFEUX
5da91fa8f8
DEV: disable emoji-picker test to attempt to fix timeouts ( #7754 )
2019-06-12 00:11:21 +02:00
Joffrey JAFFEUX
1feaacaecb
DEV: skip emoji picker opening test to attempt to fix timeouts ( #7753 )
2019-06-11 23:54:20 +02:00
Guo Xiang Tan
d20ea38f02
Fix the build.
...
Follow up to bd538f7437
.
2019-06-11 10:05:57 +08:00
Joffrey JAFFEUX
b339d67401
DEV: refactors select-kit helper to prevent it to leak into global state ( #7708 )
2019-06-06 10:47:10 +02:00
Régis Hanol
b792db9d92
FIX: redirect to top was always redirecting to 'All'
2019-06-03 20:18:14 +02:00
Guo Xiang Tan
f0620e7118
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
...
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
Penar Musaraj
7c9fb95c15
Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )"
...
This reverts commit b1d3c678ca
.
We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
Joffrey JAFFEUX
7a7d612b23
DEV: skips tests being the possible source of timeouts ( #7623 )
2019-05-28 20:16:42 +02:00
Guo Xiang Tan
b1d3c678ca
FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
Guo Xiang Tan
909ec47ada
DEV: Close modal so other JS tests don't randomly failed.
2019-05-28 11:40:21 +08:00
Guo Xiang Tan
c80ab08e48
DEV: Fix pretenders leaking across acceptance test.
2019-05-28 10:41:22 +08:00
Joffrey JAFFEUX
6c6a6771af
FIX: adds groupBy to lodash available functions list ( #7579 )
2019-05-21 08:58:57 +02:00
romanrizzi
b716439c3e
DEV: Improve component test skip option and skipped new tests
2019-05-16 15:15:37 -03:00
Régis Hanol
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
Bianca Nenciu
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
Bianca Nenciu
39260c841e
DEV: Add test for click-track and mention links.
...
Follow-up to b81d169e
.
2019-05-06 19:29:51 +03:00
Arpit Jalan
8bedb6a4a3
fix the build
2019-05-01 23:12:50 +05:30
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons ( #7372 )
...
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.
## Core
- Adds an SiteIconManager module which manages automatic resizing and fallback
- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon).
- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.
- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations
## Wizard
- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload
- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"
- Various copy updates to support the changes
- Remove the "upload-time" resizing for `large_icon`. This is no longer required.
## Site Settings UX
- Move logo/icon settings under a new "Branding" tab
- Various copy changes to support the changes
- Adds placeholder support to the `image-uploader` component
- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings
- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name
## Dashboard Warnings
- Remove PWA icon and PWA title warnings. Both are now handled automatically.
## Bonus
- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Tim Lange
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
Tim Lange
1d0816b2cf
UX: Changed error draft status to icon ( #7369 )
2019-04-19 09:18:01 +02:00
Maja Komel
1f17d52f55
UX: new layout for groups page, allow changes to automatic group bio ( #7350 )
2019-04-17 22:44:30 -04:00
Roman Rizzi
d2ea602bdd
DEV: Mark flaky tests as pending until we fix them. ( #7386 )
2019-04-16 13:35:54 -03:00
Robin Ward
a5d9afe397
FEATURE: Include a user's pending posts in the topic view
...
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
Tim Lange
9a428acce4
UX: Switched composer draft saving to animations ( #7356 )
2019-04-11 10:03:36 -04:00
Tim Lange
fe9c271d44
FIX: Fixed deleted posts layout ( #7348 )
2019-04-10 19:00:39 +02:00
Robin Ward
4552d86605
FIX: Broken tests
2019-04-09 08:33:10 -04:00
Arpit Jalan
55d62471a5
Fix the build
...
Skipping failing tests for now.
2019-04-09 11:30:32 +05:30
Guo Xiang Tan
33fa249fa5
SECURITY: Remove XSS in composer preview when applying image scale buttons.
2019-04-08 11:22:14 +08:00
Robin Ward
62956003c3
FEATURE: Allow users to customize bonuses for reviewable types
...
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
Guo Xiang Tan
d1fa2b71cf
FIX: Letters between words incorrectly highlighted within post.
2019-04-03 15:57:51 +08:00
Tim Lange
a9a35d2c19
FIX: Uncategorized pm not allowing edit ( #7276 )
2019-04-02 12:54:53 +08:00
Joffrey JAFFEUX
e986e96227
DEV: removes old dashboard ( #7295 )
2019-04-01 12:39:49 +02:00
Tim Lange
2c4b3c21a9
UX: Unified emoji escape regex
2019-03-29 12:17:11 -04:00
Guo Xiang Tan
947495e70d
Follow up to 8c2fa99f78
.
...
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
Guo Xiang Tan
c836d67cac
UX: Collapse advanced search on mobile when searching.
...
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
Robin Ward
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Tim Lange
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
Bianca Nenciu
a9798f0c47
FEATURE: Add page for all group membership requests. ( #6909 )
2019-03-27 13:30:59 +02:00
Penar Musaraj
528a7c577a
Remove flaky test
2019-03-25 15:31:25 -04:00
Penar Musaraj
e89cec7550
Fix Prettier
2019-03-25 15:03:28 -04:00
Penar Musaraj
47a0e4b906
UX: improve mobile search
...
Improves usability of header search icon while user is already in full page search in mobile.
Currently, hitting search icon a second time empties input and does not scroll up to show search form.
This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris
df279251b7
REFACTOR: More consistent user/group page layouts
2019-03-25 14:40:22 -04:00
Joe
ec2123809f
FEATURE: user and group cards on mobile ( #7246 )
2019-03-25 13:37:17 +01:00
Tim Lange
dcd56cf593
FIX: Fixed changing composer mode escaping title ( #7191 )
2019-03-25 13:14:26 +05:30
Tim Lange
da187f0967
FIX: Clear unsaved groups when switching user ( #7236 )
2019-03-22 12:46:36 +01:00
Guo Xiang Tan
7aab7e9062
Revert "UX: Don't reload page after saving settings when editing category."
...
This reverts commit dd142eec03
.
We need a fully reload when reordering.
2019-03-22 13:10:30 +08:00
Sam Saffron
2f8f801970
DEV: use Qunit.skip to skip a test
...
commented out code tends to get forgotten, at least with skip we can alert
on it.
2019-03-22 10:09:11 +11:00
Joffrey JAFFEUX
5b465ce053
fix tests ( #7234 )
2019-03-21 13:16:55 +01:00
Tim Lange
d16a0db4e1
UX: Enabled sorting for more columns in admin user list ( #7208 )
2019-03-21 17:16:58 +08:00
Tim Lange
f7b156ffbd
UX: Better emoji escaping for topic title ( #7218 )
...
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Régis Hanol
6fb49e74a1
Revert "UX: Better emoji escaping for topic title ( #7176 )" ( #7201 )
...
This reverts commit 0d9bc0aaa6
.
2019-03-19 12:02:47 +01:00
Tim Lange
0d9bc0aaa6
UX: Better emoji escaping for topic title ( #7176 )
2019-03-19 09:33:10 +01:00
Guo Xiang Tan
dd142eec03
UX: Don't reload page after saving settings when editing category.
2019-03-19 16:08:32 +08:00
Gerhard Schlager
3fd04df781
FEATURE: Locale support for seeded categories and topics ( #7110 )
2019-03-18 21:09:13 +01:00
David Taylor
e2d6edd5ff
DEV: Correct email disabled banner tests
...
Followup to acc121fd27
2019-03-18 17:06:29 +00:00
David Taylor
acc121fd27
FIX: Show 'emails disabled' to staff users when disabled for non-staff ( #7187 )
2019-03-18 16:26:18 +01:00
Tim Lange
22c75e1c04
FIX: Fixed edit category description redirecting without saving ( #7192 )
2019-03-18 16:14:17 +01:00
Guo Xiang Tan
5e410dc5e0
FEATURE: Ability to exclude category from search results. ( #7194 )
...
This commit also adds `Category#search_priority` which sets the ground
work to enable prioritizing of posts for certain categories when searching.
2019-03-18 15:25:45 +08:00
Joffrey JAFFEUX
de6a7e32bd
FIX: brings back [+ New Topic] btn from share-popup post action ( #7182 )
2019-03-18 07:30:10 +01:00
Joffrey JAFFEUX
e57138354d
fix emoji tests ( #7181 )
2019-03-15 17:15:36 +01:00
Bianca Nenciu
d352baa1a2
FEATURE: Enforce two-factor authentication. ( #6348 )
2019-03-15 13:09:37 +02:00
Tim Lange
37c613dde2
FIX: Outsourced erb part from emoji.js.es6 ( #7168 )
2019-03-15 15:44:49 +11:00
Joffrey JAFFEUX
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6
.
2019-03-13 13:02:56 +01:00
Tim Lange
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Bianca Nenciu
e6c2faf186
FIX: Disable 'Create Topic' button if tag is staff-only. ( #6984 )
...
* FIX: Disable 'Create Topic' button if tag is staff-only.
* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
Bianca Nenciu
733deba585
FIX: Loading draft also replaces the recipients ( #7122 )
2019-03-07 08:14:55 +11:00
Joffrey JAFFEUX
aaf106fc2d
DEV: simplify test to avoid time related failures ( #7092 )
2019-03-03 12:13:02 +01:00
Sam
63cba2055f
DEV: workaround test value changing due time marching forward
...
This is a quick fix to get the tests to pass we will follow up with a commit
to stabalize this.
2019-03-01 13:26:36 +11:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons ( #7080 )
2019-02-28 14:56:22 +01:00
Maja Komel
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code ( #7076 )
2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions ( #7066 )
2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5
FIX: do not update tag name on /tags/intersection
2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params ( #7058 )
...
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.
Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
2019-02-26 10:43:24 +01:00
Joffrey JAFFEUX
70aec8d02a
simpler post-date test to avoid tz differences ( #7050 )
2019-02-21 14:39:51 +01:00
Joffrey JAFFEUX
81c31b331d
DEV: adds tests to verify post date sharing modal behaviour ( #7049 )
2019-02-21 14:04:56 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to `/g` instead of `/groups`. ( #7042 )
2019-02-21 13:44:25 +08:00
Penar Musaraj
3cb676bf42
Fix Prettier offense
2019-02-20 17:07:32 -05:00
Penar Musaraj
cc1f9e7be6
Fix share button in post menu
2019-02-20 16:27:59 -05:00
Penar Musaraj
bbd00a3488
Fix desktop test too
2019-02-20 16:08:36 -05:00
Joffrey JAFFEUX
b7953af5a1
fix tests ( #7040 )
2019-02-20 21:41:03 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ( #7021 )
...
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
David Taylor
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
Dan Ungureanu
6c2fe7eaec
DEV: Fix lint.
2019-02-06 23:55:05 +02:00
Dan Ungureanu
fc4c015bee
FEATURE: Shortcut 'g s' goes to first suggested topic
2019-02-07 08:43:07 +11:00
Bianca Nenciu
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
Penar Musaraj
ee437ef53b
Fix prettier offence
2019-01-28 22:47:11 -05:00
Penar Musaraj
530eeba855
Add test for user drafts stream
...
Followup to 84a3da4b18
2019-01-28 22:30:01 -05:00
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
David Taylor
337545f4f6
DEV: Restore skipped JS test
...
This works for me locally, so the issue has likely been fixed since the test was skipped
2019-01-24 16:58:23 +00:00