Commit Graph

57 Commits

Author SHA1 Message Date
Joffrey JAFFEUX cb59681d86
DEV: select-kit third major update with focus on accessibility (#13303)
Major changes included:
- better support for screen readers
- trapping focus in modals
- better tabbing order in composer
- alerts on no content found/number of items found
- better autofocus in modals
- mini-tag-chooser is now a multi-select component
- each multi-select-component will now display selection on one row
2021-08-23 10:44:19 +02:00
Penar Musaraj 1270c7ad15
UX: Twitter onebox layout adjustments (#13181) 2021-05-27 15:35:32 +10:00
Josh Soref 59097b207f
DEV: Correct typos and spelling mistakes (#12812)
Over the years we accrued many spelling mistakes in the code base. 

This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change 

- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
Penar Musaraj 2dc48fd6c1
UX: Uniformize styles for focus states (#11933) 2021-02-03 11:45:54 -05:00
Kris 363170513e
UX: Allow some overflow in composer preview (#11902) 2021-01-29 20:28:56 -05:00
Kris f1d5d2b134
REFACTOR: Convert buttons to flexbox (#11785) 2021-01-27 16:17:08 -05:00
Kris 8be04ff7f7
UX: Give furigana and other top-overflowing elements a little space (#11154) 2020-11-09 16:03:36 +11:00
Penar Musaraj c937afc75e
FEATURE: automatic dark mode (#10341)
A first step to adding automatic dark mode color scheme switching. Adds a new SCSS file at `color_definitions.scss` that serves to output all SCSS color variables as CSS custom properties. And replaces all SCSS color variables with the new CSS custom properties throughout the stylesheets. 

This is an alpha feature at this point, can only be enabled via console using the `default_dark_mode_color_scheme_id` site setting.
2020-08-03 22:57:10 -04:00
Penar Musaraj e6349685d3
UX: Uniform focus styles for composer inputs/textarea (#10296)
Uses a thin border as indicator that element is in focus for all editable items in the composer (inputs, select kit, textarea).

 Disables a default iOS style that has a blinking background color on inputs/textareas
2020-08-03 10:01:04 -04:00
Kris 150e83d2a6 Add color definition so bold/italic btn localization matches icon color 2020-07-28 18:24:25 -04:00
Kris 1f5cecaf28 Minor follow up fix to 4f12768 for mobile 2020-07-06 19:17:30 -04:00
Kris 4f12768d10 UX: Remove extra space added by img resize controls in composer preview 2020-07-06 19:11:58 -04:00
Bianca Nenciu 7952cbb9a2
FIX: Perform crop using user-specified image sizes (#9224)
* FIX: Perform crop using user-specified image sizes

It used to resize the images to max width and height first and then
perform the crop operation. This is wrong because it ignored the user
specified image sizes from the Markdown.

* DEV: Use real images in test
2020-03-26 16:40:00 +02:00
Joffrey JAFFEUX a5c7f0c98d
UX: hides emoji picker from edit category tab topic template (#9036) 2020-02-25 00:49:41 +01:00
Joffrey JAFFEUX e303b4d181
UX: hides local-date picker when used outside of main composer 2020-02-25 00:17:43 +01:00
Penar Musaraj 30cda1761d
UX: Better composer hyperlink modal (#8160) 2019-10-08 16:19:07 -04:00
Joe fd4557a9ef UX: Mobile editor style fixes (#7878) 2019-07-11 09:57:53 -04:00
Kris 9cb656250d FIX: Allow tall tables to scroll vertically on iOS 2019-06-14 14:26:59 -04:00
Kris 8e9d0ceb67 UX: Mobile - fix editor button space, divider, extra upload icon 2019-04-09 13:15:31 -04:00
Kris cd94ac9453 FIX: remove padding from onebox site icon in composer preview 2019-03-07 22:32:27 -05:00
Kris 86f9ace0ea UX: Previous positioning was better for the image resizer 2019-03-05 22:10:12 -05:00
Kris 73e4204d20 UX: Image preview resizer style 2019-03-04 21:59:58 -05:00
Maja Komel 612a0be085 FIX: don't add bottom padding for avatars in composer preview 2019-02-28 18:03:38 +01:00
Vinoth Kannan 0cc636f648 UX: Don't add padding bottom for emojis in composer preview 2019-02-28 15:53:21 +05:30
Maja Komel 97c0fd0909 FIX: styling for resizable image wrapper in editor preview 2019-02-28 10:24:43 +01:00
Maja Komel 7d2ea2d4dd FEATURE: image resizing discoverability (#6804) 2019-02-27 11:46:16 +01:00
Kris 94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Kris e4c593f1e7 removing some dupe styles, adding button class 2019-01-11 15:41:51 -05:00
Joffrey JAFFEUX 9a8db2748a
FIX: composer css fixes for ie11 (#6827) 2018-12-28 20:52:21 +01:00
Joffrey JAFFEUX 608abd4c08
FIX: uses `flex: 1 0 0;` instead of `flex: 1;` for better browser compat (#6826) 2018-12-28 20:21:32 +01:00
Kris b39d949a8e fix d-editor height for user profile input 2018-11-08 11:28:58 -05:00
Kris 0140844eb0 Remove whitespace in template so we can use :empty psuedo 2018-10-24 16:00:22 -04:00
tshenry 03010571f5 Remove unnecessary code (#6262)
"border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.
2018-08-13 15:43:03 +10:00
Joffrey JAFFEUX 174d392e5a
DEV: adds prettier (#5956)
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Neil Lalonde 0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Neil Lalonde 6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Guo Xiang Tan 4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Kris 56987e2290 Profile textarea too short in iOS10 2018-01-30 09:31:18 -05:00
Kris 0c01e0b2fe
UX: Implementing a z-index system (#5507) 2018-01-16 19:05:12 -05:00
Kris 674013129a
UX: Type system rebuild (#5492) 2018-01-12 17:27:38 -05:00
Kris 60cd28d5b9
UX: Cleaning up user profiles on mobile 2017-12-11 15:40:04 -05:00
Kris 4d9f26879b FIX: Composer preview-area plugin layout 2017-12-06 16:12:52 -05:00
Kris f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Kris e7725e23ad FIX: Flexbox composer issue in IE11, bad flex-shrink default 2017-12-01 13:12:25 -05:00
Kris 03eb278034
FIX: Increased composer width to match preview, border width fix (#5379) 2017-11-28 21:57:27 -05:00
Kris ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Régis Hanol 5135f73933 actually use -very-low color 2017-11-10 17:57:02 +01:00
Régis Hanol 482982dce8 UX: fix user bio & category topic template editors 2017-11-10 17:52:08 +01:00
Régis Hanol 0bb07d395a REFACTOR: composer to use flexbox 2017-11-08 10:39:26 +01:00
awesomerobot c29b7aa65d initial pass at color simplification 2017-07-14 21:43:35 -04:00