Commit Graph

376 Commits

Author SHA1 Message Date
Neil Lalonde 9be481f035 Merge pull request #1846 from velesin/admin_site_settings_controller_test_fix
fixes unit test broken (and commented out) after adding debounce behavio...
2014-01-20 14:26:24 -08:00
Robin Ward 6b9b2d3d6a New API for replacing elements in the final JsonML. Also changes spoiler
tag handling to be more robust with repsect to HTML content.
2014-01-20 15:15:50 -05:00
Wojciech Zawistowski 8812196b81 fixes unit test broken (and commented out) after adding debounce behavior to a method 2014-01-20 17:30:12 +01:00
Robin Ward 4981525047 REFACTOR: Fixes poor class hierarchy for listing topics
- Upgrades Ember to latest
- Fixes a bunch of bugs with page titles and missing "active" states
2014-01-18 19:26:24 +01:00
Régis Hanol ad8755aa70 BUGFIX: inline spoiler for text, block spoiler for images 2014-01-15 00:53:06 +01:00
Robin Ward 71aed34e64 FIX: Allow click tracking to work with different origins 2014-01-14 15:20:46 -05:00
Régis Hanol 3a6bffa05d FEATURE: better top pages 2014-01-14 01:09:12 +01:00
Régis Hanol 70161498b6 BUGFIX: spoiler tag on lightboxed images wasn't working 2014-01-12 19:38:46 +01:00
Neil Lalonde 52580f09af Rename favorite to starred everywhere 2014-01-10 14:54:19 -05:00
Robin Ward 456a213904 FIX: Broken qunit test 2014-01-09 13:48:58 -05:00
Robin Ward b28a8e262f FIX: Categories are ordered by `topic_count`. 2014-01-09 13:05:32 -05:00
Sam e0284dfef0 update fixture 2014-01-07 11:40:28 +11:00
Régis Hanol 87217d940e Merge pull request #1457 from skisulli/keyboard-shortcuts
Global Gmail style keyboard shortcuts
2014-01-06 06:40:55 -08:00
Régis Hanol 0dc0740408 BUGFIX: clicking on the Logo generates a javascript error 2014-01-06 11:46:19 +01:00
Robin Ward 6c4417e0f0 Use the standard .jshintrc file for JSHint options. 2013-12-31 12:41:40 -05:00
Régis Hanol 7fd88a52c9 FEATURE: allow plugins to overwrite handlebars templates 2013-12-31 16:43:29 +01:00
Régis Hanol 54686388fb FEATURE: display the Top tab by default for long-time-no-see users 2013-12-30 19:42:45 +01:00
Robin Ward a502266c42 Enable JSHINT's `unused` option. It caught a bunch of suspicious stuff which is fixed in this commit. 2013-12-30 13:30:22 -05:00
Régis Hanol 8685e4079f FEATURE: the top tab is the default for new users 2013-12-30 18:49:16 +01:00
Sam d8c43f7b58 BUGFIX: fix username breakup so it works with IE
FEATURE: breakup username based on name as well
2013-12-30 16:07:35 +11:00
Régis Hanol 34cbea64d1 Merge pull request #1749 from velesin/has_current_user_test_improvement
adds small HasCurrentUser mixin test improvements
2013-12-23 05:47:46 -08:00
Régis Hanol 9ee404b0e6 Merge pull request #1750 from velesin/header_controller_test_fix
fixes HeaderController test
2013-12-23 05:47:22 -08:00
Régis Hanol 2f9c81cd75 Merge pull request #1751 from velesin/text_field_tests
adds unit tests for Discourse.TextField
2013-12-23 05:46:48 -08:00
Régis Hanol ef8625caaa Merge pull request #1753 from velesin/search_text_field_tests
adds unit tests for SearchTextField
2013-12-23 05:46:12 -08:00
Sam d4819c3a65 Got rid of crazy user name split
instead decorate with <wbr> to hint on best
spot to split
2013-12-23 11:11:41 +11:00
Sam 90077ae98d fix tests, clean up include logic 2013-12-23 10:41:10 +11:00
Ryan Sullivan 5100c2bbd2 Add Global Keyboard Shortcuts
Not all of these have been fully implemented yet.

**Jump To**
* `g` then `h` - Home (Latest)
* `g` then `l` - Latest
* `g` then `n` - New
* `g` then `u` - Unread
* `g` then `f` - Favorited
* `g` then `c` - Categories List

**Navigation**
* `u` - Back to topic list
* `k` / `j` - Newer/Older conversation or post
* `o` or `Enter` - Open selected conversation
* <code>`</code> - Go to next section
* `~` - Go to previous section

**Application**
* `c` - Create a new topic
* `n` - Open notifications menu
* `/` - Search
* `?` - Open keyboard shortcut help

**Actions**
* `f` - Favorite topic
* `s` - Share topic
* `<Shift>` + `s` - Share selected post
* `r` - Reply to topic
* `<Shift>` + `r` - Reply to selected post
* `l` - Like selected post
* `!` - Flag selected post
* `b` - Bookmark selected post
* `e` - Edit selected post
* `d` - Delete selected post
* `m` then `m` - Mark topic as muted
* `m` then `r` - Mark topic as regular
* `m` then `t` - Mark topic as tracking
* `m` then `w` - Mark topic as watching
2013-12-22 12:16:42 -07:00
Wojciech Zawistowski 965fb78b06 adds unit tests for SearchTextField 2013-12-20 21:00:48 +01:00
Neil Lalonde 854d9c8fc6 Minimum password length is configurable with the min_password_length site setting. FIX: reset password needs to validate password length. 2013-12-19 16:15:47 -05:00
Wojciech Zawistowski c2e590b343 adds unit tests for Discourse.TextField 2013-12-19 19:29:15 +01:00
Wojciech Zawistowski 89bdebac3c fixes HeaderController test 2013-12-19 18:59:30 +01:00
Wojciech Zawistowski e5269ab3e0 adds small HasCurrentUser mixin test improvements 2013-12-19 18:54:24 +01:00
Neil Lalonde 47c6bb4cf2 Improve how category stats are rendered 2013-12-17 17:43:04 -05:00
Sam 29ba471db6 missing site setting, this should be auto generated 2013-12-17 12:35:09 +11:00
Neil Lalonde 49c3482464 Show topic and post counts by day/week/month/year on categories page 2013-12-13 15:37:45 -05:00
Robin Ward a7a7387da1 Automatically convert some quotes to blockquotes 2013-12-13 15:31:25 -05:00
Neil Lalonde 6fa2e68742 Show more than one topic per category on the wide categories page. Disable support for the 2-column categories page. The category_featured_topics site setting controls how many topics to show. 2013-12-12 15:52:30 -05:00
Neil Lalonde ed3d3ae1e1 Upgrade font-awesome to version 4 2013-12-11 10:31:09 -05:00
Wojciech Zawistowski 9dbc2f1039 adds unit tests for the search dropdown template 2013-12-09 18:15:38 +01:00
Robin Ward 8cc6cd933a Don't allow filtering by user in summary mode and vice versa. It's just confusing. 2013-12-06 13:53:19 -05:00
Robin Ward 19987c1cbf Merge pull request #1704 from velesin/site_map_integration_tests_clean_up
cleans up site map integration tests
2013-12-06 08:31:18 -08:00
Robin Ward 79427732b2 Show Gaps in the post stream when filters are active
Conflicts:
	app/assets/javascripts/discourse/templates/topic.js.handlebars
2013-12-05 16:46:59 -05:00
Robin Ward 0ece195723 Blacklist <center> 2013-12-04 11:43:20 -05:00
Robin Ward cb9fb2acfa FIX: A post via the message bus wasn't updating `highest_post_number` properly. 2013-12-03 16:25:51 -05:00
Robin Ward 274743b877 Refactor: Move initialization code into separate initializers that use the API we
developed for plugins.
2013-12-03 14:22:32 -05:00
Robin Ward de78ee302a - Extract Browser capabilities from Discourse namespace into a Singleton.
- Change Scrolling slack based on Android / Touch / Desktop
2013-12-03 13:03:19 -05:00
Robin Ward 48bfcfadd9 Upgrade Ember.js, fix swallowing of template errors, report unresolved promises in development mode. 2013-12-02 13:15:58 -05:00
Wojciech Zawistowski 66de19790e cleans up site map integration tests 2013-11-29 21:01:46 +01:00
Régis Hanol 9b6538832d whitelist google.com/maps iframes 2013-11-29 18:08:53 +01:00
Wojciech Zawistowski 8eef779d38 refactors site map 2013-11-27 21:58:36 +01:00
Robin Ward 40f86829f7 Post Cloaking:
* We now use a new custom view, {{cloaked-collection}} to display posts in a topic.

* Posts are removed and inserted (cloaked/uncloaked) into the DOM dynamically based on whether they
  are visible in the current browser viewport.

* There's been a lot of refactoring to ensure the relationship between the post views and the topic
  controller is sane.

* Lots of fixes involving jumping to a post, including a new LockOn component to that tries to stay
  focused on an element even if stuff is loading before it in the DOM that would normally push it
  down.
2013-11-27 12:53:32 -05:00
Sam 2eee7433f0 update message bus for .stop() support, stop the message bus during test 2013-11-25 18:01:03 +11:00
Sam 95c968d7b7 fix js specs 2013-11-25 17:50:48 +11:00
Wojciech Zawistowski 1d3097245c header sitemap integration tests 2013-11-21 20:38:56 +01:00
Robin Ward 0bab3f9b4e Revert "Revert "FIX: Markdown bug", breaks build"
This reverts commit 08ad5d479e.
2013-11-20 11:53:06 -05:00
Sam 08ad5d479e Revert "FIX: Markdown bug", breaks build
This reverts commit 4a32cddf80.
2013-11-20 10:41:21 +11:00
Robin Ward 4a32cddf80 FIX: Markdown bug 2013-11-19 16:23:04 -05:00
Neil Lalonde 981d8f6aea Signup form: prefill username if Discourse Hub has a match for the email address. Also, fix some bad specs in username_checker_service_spec that were passing... 2013-11-19 14:15:28 -05:00
Robin Ward 20e4a2ef80 Renamed components so they don't all have the annoying discourse- prefix 2013-11-19 11:59:50 -05:00
Robin Ward 4ce81e1b01 Rename "Best Of" to "Summary" 2013-11-18 12:48:26 -05:00
Neil Lalonde 674887dafc Debouncing broke my js tests. Fix them later. 2013-11-15 17:14:25 -05:00
Neil Lalonde e01ce546e8 When you click Quote Reply, and then cancel the reply, don't ask if you're sure. 2013-11-15 13:13:58 -05:00
Neil Lalonde df213d7b23 Filter on site settings across all categories 2013-11-14 16:02:14 -05:00
Robin Ward df568df9dc Controls for sorting topic columns 2013-11-13 11:48:38 -05:00
Régis Hanol 9165769da2 Merge pull request #1647 from velesin/notifications_controller_test_fix
fixes Ember's deprecation errors in NotificationsController unit tests
2013-11-13 00:27:27 -08:00
Régis Hanol 758a31e524 Merge pull request #1646 from velesin/logo_component_test_fix
fixes missing imege url errors in logo component tests
2013-11-13 00:27:06 -08:00
Wojciech Zawistowski e41774a0ea fixes Ember's deprecation errors in NotificationsController unit tests 2013-11-12 21:52:07 +01:00
Wojciech Zawistowski a957a23b66 fixes missing imege url errors in logo component tests 2013-11-12 21:21:02 +01:00
Wojciech Zawistowski a2dd197256 fixes the problem with perceived not mocked xhr call in tests 2013-11-12 20:40:46 +01:00
Wojciech Zawistowski 3359813624 cleans up header notifications integration tests 2013-11-11 21:51:49 +01:00
Régis Hanol ed5eb469d5 Merge pull request #1635 from velesin/header_notifications_refactoring
refactors header notifications (renders them via separate controller)
2013-11-09 01:33:40 -08:00
Régis Hanol 345960e194 Merge pull request #1634 from velesin/click_track_tests_fixture_helper
refactors click track tests to use fixture helper
2013-11-09 01:31:41 -08:00
Wojciech Zawistowski 67a1da7af4 refactors header notifications (renders them via separate controller / template) 2013-11-08 21:06:27 +01:00
Wojciech Zawistowski e31559b05f refactors click track tests to use fixture helper 2013-11-08 20:30:20 +01:00
Wojciech Zawistowski db002e9294 refactors logo component unit tests to use fixture helper 2013-11-08 20:23:29 +01:00
Robin Ward cabde46fe4 Merge pull request #1631 from velesin/fixture_jshint_fix
FIX: adds fixture test helper to JSHint config
2013-11-08 09:53:36 -08:00
Wojciech Zawistowski bdbddddbdd cleans up setup of header integration test 2013-11-08 17:38:35 +01:00
Wojciech Zawistowski e3e2d66ae4 FIX: adds fixture test helper to JSHint config 2013-11-08 17:28:57 +01:00
Robin Ward ac9a763ab3 FIX: Extra space before tags in blockquotes 2013-11-07 16:06:50 -05:00
Robin Ward 35d4229847 Merge pull request #1624 from velesin/qunit_fixture_helpers
adds QUnit test helper simplifying usage of #qunit-fixture
2013-11-07 12:34:42 -08:00
Robin Ward 43c577adf5 Merge pull request #1623 from velesin/remove_qunit_scratch
removes redundant #qunit-scratch (use standard #qunit-fixture instead)
2013-11-07 12:33:58 -08:00
Robin Ward 0a692d00da Merge pull request #1615 from velesin/header_notifications_tests
adds integration tests for notifications dropdown in header
2013-11-07 12:33:38 -08:00
Wojciech Zawistowski 89d33c5f3f adds QUnit test helper simplifying usage of #qunit-fixture 2013-11-07 19:46:38 +01:00
Wojciech Zawistowski 74cbb18f67 removes redundant #qunit-scratch (replaces it with standard #qunit-fixture) 2013-11-07 18:18:07 +01:00
Wojciech Zawistowski 52208b4eb7 adds integration tests for notifications dropdown in header 2013-11-05 17:56:13 +01:00
Wojciech Zawistowski 1dcd2d903b enhances integration test helper with the ability to invoke additional setup / teardown code 2013-11-05 17:42:37 +01:00
Robin Ward b8e63719f8 FIX: Don't autolink within a markdown link. 2013-11-04 14:24:40 -05:00
Neil Lalonde ede59a4386 FIX: issue 1538. After upgrading and before a new version check request has been made, dashboard might still say that an update is available. 2013-11-04 12:51:09 -05:00
Wojciech Zawistowski 2bd3cc4e16 cleans up logo integration tests 2013-10-31 17:27:28 +01:00
Wojciech Zawistowski 489dab333a extracts logo component from header 2013-10-30 21:56:48 +01:00
Robin Ward 49abdbaaf7 Merge pull request #1587 from velesin/logo_tests
integration tests for the logo part of header
2013-10-29 12:39:02 -07:00
Robin Ward 5689e314c5 Upgrade Ember to 1.1.2 2013-10-29 13:01:57 -04:00
Wojciech Zawistowski 97b907e309 integration tests for the logo part of header 2013-10-29 17:33:53 +01:00
Robin Ward 84d531cff7 Merge pull request #1583 from velesin/header_test_fix
fixes wrong placement of expect in header integration test
2013-10-29 08:04:19 -07:00
Wojciech Zawistowski 37e56249be fixes wrong placement of expect in View Topic integration test 2013-10-28 19:15:40 +01:00
Wojciech Zawistowski 76602f6353 fixes wrong placement of expect in header integration test 2013-10-28 19:01:36 +01:00
Robin Ward e9c4465ec7 FIX: Various bugs with Category breadcrumbs 2013-10-25 15:24:03 -04:00
Sam 8ad103abb0 correct fixture 2013-10-25 14:59:57 +11:00
Sam e57967c6c3 better exception when discourse.ajax is called, still need to figure out how to fix it though :) 2013-10-25 14:30:45 +11:00
Robin Ward 9adcd1579d Renamed `components` to `lib` in the JS project, as Ember has components and they mean something different. 2013-10-24 12:36:46 -04:00
Robin Ward 541620c115 Routes and support for sub-categories 2013-10-23 15:22:49 -04:00
Robin Ward 49a11e51df Ember support for parent categories 2013-10-23 15:22:49 -04:00
Régis Hanol a12a1bcc66 bring back attachment icons 2013-10-23 09:52:15 +02:00
Robin Ward e94a8cf62e Remove some autogenerated stuff we don't use. 2013-10-22 17:38:32 -04:00
Robin Ward 348e2e3ef2 Support for per-user API keys 2013-10-22 17:34:39 -04:00
Robin Ward e2845f7f16 Restrict SIZE= to numbers 2013-10-22 11:08:13 -04:00
Robin Ward e527cbf884 FIX: Link reference-style text without a url 2013-10-21 14:16:49 -04:00
Robin Ward d9a16079a5 FIX: Do not allow users to create tables 2013-10-21 13:32:15 -04:00
Robin Ward 7a5c3bfcd8 whitelist acceptable syntax highlighting classes 2013-10-21 13:11:10 -04:00
Robin Ward d10f9f756f FIX: `[code]` blocks with `#` headers within 2013-10-21 12:12:58 -04:00
Robin Ward 1783089d64 FIX: [quote] without params was failing. 2013-10-21 11:12:47 -04:00
Robin Ward 4d9ca99929 Merge pull request #1542 from velesin/debounce_refactoring
refactors Discourse.debounce
2013-10-21 07:50:26 -07:00
Robin Ward c5f14cdd0e Merge pull request #1549 from velesin/debounce_promise_refactoring
refactors Discourse.debouncePromise
2013-10-21 07:49:47 -07:00
Régis Hanol 533006a5ec Merge pull request #1536 from velesin/computed_tests_refactoring
Discourse.Computed tests refactoring
2013-10-20 07:01:26 -07:00
Wojciech Zawistowski 4c4a2f220e refactors Discourse.debouncePromise 2013-10-20 10:38:26 +02:00
Wojciech Zawistowski d0f3765967 refactors Discourse.debounce 2013-10-19 09:13:00 +02:00
Robin Ward 1113b8d7a8 FIX: Don't double sanitize values, allow blockquotes with leading text 2013-10-18 17:34:54 -04:00
Robin Ward d7182d0b14 FIX: Only wrap inline html tags in <p> 2013-10-18 15:21:05 -04:00
Wojciech Zawistowski 42c12206c3 Discourse.Computed tests refactoring 2013-10-17 18:52:24 +02:00
Neil Lalonde 71571b9316 Never show preview pane in composer on mobile. 2013-10-17 12:19:28 -04:00
Robin Ward 665a07f004 Merge pull request #1532 from velesin/container_view_tests
unit tests for Discourse.ContainerView
2013-10-17 06:55:23 -07:00
Robin Ward 5126ed757e Merge pull request #1530 from velesin/view_tests
adds unit tests for Discourse.View
2013-10-17 06:55:00 -07:00
Robin Ward dd63e6d28f Two Column User View 2013-10-16 15:51:01 -04:00
Wojciech Zawistowski 07ec58a89d unit tests for Discourse.ContainerView 2013-10-16 17:47:51 +02:00
Robin Ward 8d016092cd FIX: Heading with style 2013-10-16 10:39:06 -04:00
Robin Ward 67771d6bdf FIX: New line after blockquote 2013-10-16 10:28:48 -04:00
Robin Ward f27413219e Support for MDTest 2013-10-16 10:28:42 -04:00
Wojciech Zawistowski 349588630f adds unit tests for Discourse.View 2013-10-15 18:00:10 +02:00
Robin Ward 5281b7f80c Upgraded and refactored Sanitizing. Much less crap should get through now!
Conflicts:
	app/assets/javascripts/discourse/components/syntax_highlighting.js
2013-10-15 10:53:11 -04:00
Robin Ward af931f0444 Reverting the Sanitizer commit in case we have to do something urgent
before we deploy it early next week. It's in the branch `sanitizer` for
now.

This reverts commit 9e93d8ed52.
2013-10-11 16:44:26 -04:00
Robin Ward 9e93d8ed52 Upgraded and refactored Sanitizing. Much less crap should get through now!
Conflicts:
	app/assets/javascripts/discourse/components/syntax_highlighting.js
2013-10-11 16:25:40 -04:00
Wojciech Zawistowski 708a55cb38 refactors Discourse.Computed to bind context to self 2013-10-09 18:24:33 +02:00
Neil Lalonde bccb37b6f3 When creating a topic, don't select a category by default when allow_uncategorized_topics is false. Also, added category validation on the server to enforce allow_uncategorized_topics. 2013-10-08 14:41:20 -04:00
Robin Ward e7935d4263 Merge pull request #1501 from velesin/debounce_promise_tests
adds unit tests for Discourse.debouncePromise
2013-10-08 07:56:07 -07:00
Wojciech Zawistowski 034d00b83a adds unit tests for Discourse.debouncePromise 2013-10-07 17:45:09 +02:00
Wojciech Zawistowski 7106b27860 refactors asyncTestDiscourse to bind context as self 2013-10-07 17:36:20 +02:00
Robin Ward fc00269b7f Pop up with user information when clicking avatar on topic page 2013-10-03 13:06:30 -04:00
Wojciech Zawistowski 4fc4831efc adds unit tests for Discourse.debounce 2013-10-02 20:03:04 +02:00
Régis Hanol af96ef2994 FIX: deleting a flagged post issue
cf. http://meta.discourse.org/t/deleting-a-flagged-post-issue/10061

The bug was only happening when you were about the delete the first post, which means deleting the entire topic.
2013-10-02 16:59:57 +02:00
Robin Ward 0b5df524c7 Merge pull request #1487 from velesin/has_current_user_tests
adds unit tests for Discourse.HasCurrentUser
2013-10-02 07:27:06 -07:00
Robin Ward be0ce08cc2 Ember Upgrade: 1.0 2013-10-01 11:16:27 -04:00
Wojciech Zawistowski 363a8d6e4f adds unit tests for Discourse.HasCurrentUser 2013-09-30 21:46:42 +02:00
Wojciech Zawistowski 2f9a467453 adds unit tests for Discourse.Controller 2013-09-30 18:12:12 +02:00
Robin Ward 37304b7eba FIX: Too many new lines in long quotes 2013-09-27 15:08:56 -04:00
Robin Ward 19d94f3576 Merge pull request #1467 from velesin/resolver_tests
adds unit tests for Discourse.Resolver
2013-09-27 09:19:11 -07:00
Sam 191dc77482 Merge pull request #1451 from velesin/remove_return_from_router_map
remove unnecessary return statement inside Discourse.Router.map
2013-09-26 14:39:47 -07:00
Wojciech Zawistowski 95d8014931 adds unit tests for Discourse.Model 2013-09-26 19:03:43 +02:00
Wojciech Zawistowski 9b7b70920a adds unit tests for Discourse.Resolver 2013-09-25 18:30:22 +02:00
Wojciech Zawistowski cd3a2143d2 remove unnecessary return statement inside Discourse.Router.map
Ember's Router.map(callback) method doesn't expect any value to be
returned by callback function. Therefore, return statements present
inside Discourse.Router.map are unnecessary (and are silently ignored by
Ember).
2013-09-19 17:26:43 +02:00
Wojciech Zawistowski 7da10c0149 Remove duplicate mixing in of Discourse.Presence
AdminEmailIndexController and AdminEmailPreviewDigestController explicitely mix in Discourse.Presence, but they extend base classes Discourse.Controller and Discourse.ObjectController that already mix in Discourse.Presence, so this explicit inclusion is redundant.
2013-09-18 18:40:57 +02:00