84ff96bd07
FIX: Do not validate email in TL promotion ( #20892 )
...
There is no need to validate the user's emails when
promoting/demoting their trust level, this can cause
issues in things like Jobs::Tl3Promotions, we don't
need to fail in that case when all we are doing is changing
trust level.
2023-03-30 13:52:10 +10:00
71be74ffd3
FIX: recalculating trust levels was not working ( #20492 )
...
The recalculate code was never firing cause TrustLevel.calculate unconditionally
returned a trust level. (albeit a wrong one)
New code ensures we only bypass promotion checks for cases where trust level
is locked.
see: https://meta.discourse.org/t/user-trust-level-resets-to-zero-when-unlocked/255444
2023-03-01 15:35:21 +11:00
cb932d6ee1
DEV: Apply syntax_tree formatting to `spec/*`
2023-01-09 11:49:28 +00:00
3eaac56797
DEV: Use proper wording for contexts in specs
2022-08-04 11:05:02 +02:00
493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
45cc16098d
DEV: Move spec/components to spec/lib ( #15987 )
...
Lib specs were inexplicably split into two directories (`lib` and `components`)
This moves them all into `lib`.
2022-02-18 19:41:54 +01:00
Martin Brennan
Sam
David Taylor
Loïc Guitaut
Phil Pirozhkov
Jarek Radosz