Commit Graph

602 Commits

Author SHA1 Message Date
Sam 7c5a448f63 PERF: remove 10-20ms of work from every page view
<%  s=Time.now;

main_app.categories_path
main_app.guidelines_path
main_app.tos_path
main_app.privacy_path

p (Time.now-s)*1000%>

Returns 10-20ms consistently on i7-4770k, on shared hosts the cost
could easily reach 40ms

This code simply calculates the strings

/categories
/guidelines
/tos
/privacy

It is ludicrous to spend this enormous amount of work just to calculate
4 strings.

I do not know if this is something specific about Discourse or a bug in
Rails (I tried without the main_app prefix and got similar results),
regardless we can got to avoid these _path APIs for now

Discovered this when running a flamegraph on our home page.
2016-01-21 22:43:56 +11:00
Régis Hanol f61537bc16 Merge pull request #3952 from gdpelican/unsubscribe-via-email
Unsubscribe via email
2016-01-20 14:38:14 +01:00
James Kiesel c7283751a3 Unsubscribe via email 2016-01-20 22:25:25 +13:00
Neil Lalonde 9ad226aaa8 FEATURE: add email query param to login, signup, and password-reset URLs to prefill form 2016-01-19 16:53:46 -05:00
scossar 08801b835c put avatar in nested table 2016-01-17 12:36:15 -08:00
strikki cbd2fbf9a8 FIX: Incorrect subfolder authors urls when embedding 2016-01-13 12:24:03 +03:00
Robin Ward 1f8586168b FIX: Incorrect subfolder urls when embedding 2016-01-12 12:38:49 -05:00
Régis Hanol cf0558cd33 FEATURE: properly style whisper email notifications 2016-01-11 17:47:17 +01:00
Neil Lalonde c7df6783a9 FIX: only invalidate password reset links using javascript 2016-01-04 11:48:54 -05:00
Jeff Atwood e1f90d12f1 formally remove IE9 support 2016-01-02 23:49:52 -08:00
Arpit Jalan 6ef1537ee0 FEATURE: better unfurling of Discourse topics on Slack 2015-12-28 19:10:19 +05:30
Neil Lalonde 2d7c3067ba FIX: automatic redirect after activating account on subfolder installs 2015-12-15 14:46:35 -05:00
Robin Ward 6c2dee29a8 UX: Upgrade Font Awesome to 4.5.0 2015-12-10 17:19:23 -05:00
Robin Ward b781b6aea3 Add `header_instructions` overridable translation for email headers. 2015-12-07 16:52:33 -05:00
Robin Ward 222fd00724 FIX: Another missing translation replacement 2015-11-27 17:41:03 -05:00
Robin Ward 5e93140f85 FEATURE: Can override any translation via an admin interface 2015-11-27 11:35:19 -05:00
Sam d6932e4ac4 add missing include 2015-11-25 22:47:50 +11:00
Sam 24be285bf2 PERF: add one more asset for ember and jQuery
at the moment Ember initialization is a bottleneck, to minimize impact
on initial load we download an evaluate it as early as possible
2015-11-25 13:17:57 +11:00
Robin Ward 5056de1d8a FIX: Never show less than 0 replies when embedding 2015-11-20 13:06:00 -05:00
Arpit Jalan 06c11a3235 FIX: do not include word 'Topics' in title of category pages for Googlebot 2015-11-12 12:36:32 +05:30
Sam 9f56381b0b PERF: Shrink mobile payload, don't render for noscript on mobile 2015-11-09 14:55:17 +11:00
Robin Ward 8ba7c06b7d Merge pull request #3735 from riking/patch-4
FIX: Discourse.BaseUri should not default to /
2015-11-06 14:52:19 -05:00
Régis Hanol 06b799bfbf Merge pull request #3857 from gdpelican/fix-for-untopiced-posts
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:59:36 +02:00
James Kiesel 695b366a03 Don't error on posts#latest if a post does not have a topic 2015-10-16 14:44:48 +03:00
Régis Hanol 37c5909a31 FIX: use the first image in the first post in the topic as opengraph image
FEATURE: new 'default_opengraph_image_url' setting
2015-10-15 11:00:47 +02:00
Régis Hanol 73e345fe8f FIX: unescape emojis in digests 2015-10-15 09:59:29 +02:00
Sam b6c2aa13e6 clean up implementation of non frame login / registration 2015-10-13 14:49:09 +11:00
Sam fab51496cb correct full screen login feature 2015-10-13 13:11:49 +11:00
Sam b3aebca406 FEATURE: allow auto provider to specify "full screen login"
this feature means we attempt to log in without opening a frame.
2015-10-13 12:23:34 +11:00
Sam 57e3323663 redirect back to base uri if there is no window opener. 2015-10-13 12:03:43 +11:00
Sam 38f50d3bcc FIX: stop rendering blank urls for icons
You get an instant double request if you allow rendering of "" as
a favicon or apple touch icon.
2015-10-02 10:12:58 +10:00
Régis Hanol ed717ccb6e Merge pull request #3794 from tgxworld/add_web_manifes
FEATURE: Add web manifest for Chrome users.
2015-09-23 11:35:14 +02:00
Sam 45ab42dea9 UX: upgrade font awesome to 4.4 2015-09-21 12:46:58 +10:00
Guo Xiang Tan 71eab8f4df FEATURE: Add web manifest for Chrome users. 2015-09-21 10:34:03 +08:00
Robin Ward 71bac0c342 Add page title and charset to embedded HTML 2015-09-18 16:12:56 -04:00
Robin Ward 8489118811 FIX: Cropped embedding footer 2015-09-18 15:36:40 -04:00
Jeff Atwood 32fd5bc696 minor fixes to embed HTML 2015-09-18 12:18:54 -07:00
Arpit Jalan 1e6bf67b5b FIX: show category links if category has sub-categories in nojs view 2015-09-13 01:02:00 +05:30
Kane York aca70805f1 FIX: Discourse.BaseUri should not default to / 2015-09-10 17:34:08 -07:00
Robin Ward 707c493e3c FIX: When changing colors, refresh the admin stylesheet 2015-08-18 14:13:40 -04:00
Kane York 7b5dea6481 FEATURE: Take advantage of Android browser features
Declare a theme-color, provide high-resolution icon.
2015-08-17 14:30:20 -07:00
Arpit Jalan 62fce63952 FIX: do not load custom header in admin section 2015-08-15 17:39:07 +05:30
Sam 71fb065133 Merge pull request #3653 from gdpelican/latest-rss-fix
Skip latest posts with no topic in rss
2015-08-14 16:48:04 +10:00
James Kiesel 9068f9f9bf Skip latest posts with no topic in rss 2015-08-13 23:39:19 -07:00
Robin Ward 22844b9e46 Ember 1.12 support 2015-08-13 11:14:16 -04:00
Régis Hanol 6669a2d94d FEATURE: per-topic unsubscribe option in emails 2015-08-12 23:00:16 +02:00
Arpit Jalan 56abd247e1 UX: better twitter onebox in embedded comments 2015-08-13 01:11:15 +05:30
Robin Ward bd631e343a FEATURE: Can create stylesheets for embedded comments 2015-08-10 10:21:04 -04:00
Régis Hanol 35e6e5ff67 FIX: footer was missing in some pages
- error pages
- search results pages
- list of all tags
- topics list of a specific tag
- user leaderboard
2015-08-05 16:14:26 +02:00
Robin Ward 59cdde330f Raise errors in development mode on deprecation
We've had quite some time to find the deprecation errors in Ember and
most should be fixed. It is time to turn up the difficulty, which will
raise exceptions in development/test mode if a deprecation is present.
This will force developers to fix them as they encounter them.
2015-08-04 13:23:42 -04:00
Arpit Jalan 09c281f705 UX: show only top 10 categories in email digest 2015-08-04 11:06:04 +05:30
Robin Ward 9911e92e24 Merge pull request #3609 from riking/patch-7
FEATURE: Localization fallbacks
2015-07-30 10:44:29 -04:00
Arpit Jalan 10c40775e5 FEATURE: add Open Graph tags on category pages 2015-07-30 19:29:56 +05:30
Arpit Jalan d6069e8c90 UX: fix container layout 2015-07-28 13:58:30 +05:30
Arpit Jalan c5ec6a6f89 UX: show flag counts in new line 2015-07-27 19:54:17 +05:30
Sam 41ceff8430 UX: move search to its own route
previously search was bundled with discovery, something that makes stuff confusing internally
2015-07-27 16:47:06 +10:00
Sam 90b85e5b23 FIX: missing category from title in non-js view 2015-07-22 10:26:58 +10:00
Sam 6d9674278e UX: remove zocial and use font awesome instead
UX: use github logo for github login
2015-07-21 15:47:58 +10:00
Kane York 728845d008 FEATURE: Localization fallbacks (client)
This patch sets I18n.defaultLocale in the Discourse.start() script block (it
was formerly always 'en') to SiteSetting.default_locale, and patches
translate() to perform fallback to defaultLocale followed by english.
Additionally, when enable_verbose_localization() is called, no fallbacks will
be performed.

It also memoizes the file loading operations in JsLocaleHelper and strips out
translations from the fallbacks that are also present in a prefered language,
to minimize file size.
2015-07-15 10:17:28 -07:00
Arpit Jalan d07adc9d72 UX: fix login button 2015-07-06 18:12:37 +05:30
Robin Ward b4960d48b4 Better support for passing up errors when OmniAuth fails after auth 2015-06-24 12:12:43 -04:00
Arpit Jalan 7a9baa6c89 FIX: fix category badge and link in email digest 2015-06-11 19:22:22 +05:30
dfabulich 195cdaec11 Convert author tag to dc:creator
RSS spec says the author tag should be an email address, forcing us to put in a junk no-reply@example.com email. Instead, we should use dc:creator, which allows us to use any name we want for the user.
2015-06-09 13:57:10 -07:00
Arpit Jalan 9049f31456 add posts.rss rel alternate 2015-06-10 00:52:11 +05:30
Arpit Jalan 71ee84f848 FEATURE: latest posts RSS feed 2015-06-09 21:45:06 +05:30
Sam Saffron 5db768b69f FEATURE: improve no-js topic list information
- Provide links to pages
- Provied link to last topic
2015-06-10 00:28:20 +10:00
Sam Saffron 64c0c968e4 Attempt micro data using old vocubulary
Seeing weird results on Google
2015-06-09 18:48:06 +10:00
Robin Ward 5da5269652 FIX: Bad page title for categories view by google crawler 2015-06-08 12:07:35 -04:00
Sam Saffron 89b475e538 FEATURE: clean up microdata breadcrumb
* do not include any breadcrumb for uncategorized
* do not include the work "Categories" as a breadcrumb
2015-06-03 18:17:45 +10:00
Robin Ward 92cddfa598 Basic support for server side plugin outlets 2015-06-02 14:28:12 -04:00
Jeff Atwood 728a530d2d remove extra "posts" text from digest 2015-05-31 23:13:00 -07:00
Sam c1a18f91ef FEATURE: Add parent category link to nojs view 2015-06-01 15:25:57 +10:00
Sam 24102f2636 FIX: apply s3 cdn to client side assets 2015-05-27 12:59:51 +10:00
Sam 45bdd23689 FEATURE: support user local switching to RTL correctly
FEATURE: support RTL in multisite
2015-05-20 15:56:54 +10:00
Erick Guan 3be1098cc5 FIX: also inline category badge styles to digest email 2015-05-18 00:45:26 +08:00
Robin Ward 8294205f7c Ember 1.11 broken WIP 2015-05-11 11:18:37 -04:00
Arpit Jalan 7a20ed0617 FIX: rss feed should be valid 2015-05-11 10:50:24 +05:30
Arpit Jalan f3687b6e56 UX: show caps lock warning on password reset page 2015-05-04 13:01:35 +05:30
Arpit Jalan 23fd16850a FIX: include youtube link in embedded comments 2015-05-01 18:34:45 +05:30
Neil Lalonde 1b250f1e01 FIX: crawler pages and RSS had broken links for sites deployed to a subfolder with relative_url_root 2015-04-30 12:46:26 -04:00
Arpit Jalan 2932284293 FEATURE: magic login route for admin when SSO is enabled 2015-04-27 22:54:48 +05:30
Robin Ward 9bce812c8f Merge pull request #3388 from Mooash/Adding_ViewActions
Adding ViewAction into email notifications
2015-04-23 10:18:57 -04:00
Mooash b65313d3b9 Adding ViewAction into email notifications
See: https://meta.discourse.org/t/integrate-viewactions-one-click-actions-schemas-into-discourse-emails/27056
2015-04-23 08:40:22 +10:00
Robin Ward 5c7d6e0a3c FIX: Don't display names on emails if `display_name_on_posts` is false
Note that `enable_names` was always respected.
2015-04-22 16:15:23 -04:00
Arpit Jalan c3f163ca73 FIX: about tab was not showing on Privacy / ToS / FAQ topnav 2015-04-17 12:29:28 +05:30
Robin Ward 5c49c6b581 FIX: Crawler layout from within plugin routes 2015-04-15 22:41:09 -04:00
Robin Ward 0d90b495a8 FIX: Plugins were broken for initial payloads
Our plugins use rails engines which are mounted against the main
application's `ApplicationController`. This works great but path helpers
need to reference `main_app` in order for it not to blow up.
2015-04-09 12:26:24 -04:00
Robin Ward 65bfa574ce Add `userId` to GA tracking 2015-04-07 13:10:33 -04:00
Sam 5d31290dbc FIX: cleanup old letter avatars if needed
FEATURE: use image magick version as a key for letter avatars
2015-04-07 13:03:43 +10:00
Régis Hanol 33879e1311 Merge pull request #3199 from fantasticfears/seo
FEATURE: add microdata prop and more links for crawler
2015-04-06 11:18:34 +02:00
Sam 54645261aa better disallow search ... this could get ugly 2015-04-02 17:08:00 +11:00
Régis Hanol 9633cfeae1 bump font cache 2015-03-27 16:33:15 +01:00
Régis Hanol 4d58db2b09 also remove zocial svg font 2015-03-27 15:33:03 +01:00
Régis Hanol 8bbc742247 remove svg version of font-awesome 2015-03-27 13:42:30 +01:00
Régis Hanol d9606bef9d update font-awesome to 4.3.0 2015-03-27 13:08:58 +01:00
Robin Ward 4aa2039238 Add full name in emails, tweak styles a bit. 2015-03-24 11:25:47 -04:00
Neil Lalonde 55f293d062 FEATURE: add a route to show the password reset dialog: /password-reset 2015-03-23 15:14:50 -04:00
Robin Ward 8513045381 Include user title in email notifications 2015-03-23 14:12:11 -04:00
Erick Guan c955907f60 FEATURE: add microdata prop and more links for crawler
- add microdata based on schema.org
- add breadcrumb on the top of topic
- add navigations link on the bottom of every pages
- add category description on the category list
2015-03-16 22:52:10 +08:00
Sam a82530012a FEATURE: Allow selection of highlight js languages
PERF: stop loading highlight js on load

To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00