30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
bac1bcc79f
PERF: Add `index_reply_id_on_post_replies`.
...
Speeds up the reference posts query in `Email::Sender#send`.
2019-04-10 13:58:29 +08:00
4f04ae5692
FIX: Failed to show details about some bounced emails
...
Bounces sent to reply_by_email_address could not be found.
2019-03-26 18:00:27 +01:00
a9d5ffbe3d
FIX: Prevent critical emails bypassing disable, and improve email test logic
...
- The test_email job is removed, because it was always being run synchronously (not in sidekiq)
- 34b29f6272ffabf6c2797921
2019-03-22 17:28:43 +08:00
3f9e7eb326
FIX: Respect the disable_emails=non-staff site setting correctly
...
This reverts commit c279792130https://meta.discourse.org/t/112231/5
2019-03-21 21:44:14 +00:00
420c6f8102
FEATURE: Skip sending emails to domains on the `.invalid` TLD ( #7162 )
...
This is a reserved TLD which we use when importing users without an email address. https://tools.ietf.org/html/rfc2606
2019-03-13 16:17:59 +00:00
34b29f62db
DEV: Remove the use of stubs and mocks in `Jobs::UserEmail` tests.
...
We can only be sure that an email is sent when we get a mailer in
`ActionMailer::Deliveries`. A couple of tests were actually incorrect
because it didn't flow through our email sender where there are more
conditions in determining whether an email is sent or not.
2019-03-12 09:39:16 +08:00
c279792130
FIX: Allow sending test e-mails to any email address when disable_email is set to non-staff ( #6792 )
2018-12-18 16:12:05 +01:00
8dc1463ab3
Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.
2018-09-04 10:16:42 +08:00
f01169d6ff
FIX: don't send email when the post was deleted
2018-08-22 13:13:58 +02:00
ca5a6f0a9d
FIX: handle concurrently creating post reply keys
...
In some very rare conditions this would be called concurrently and fail
2018-08-21 10:59:18 +10:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
fad9c2b971
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 13:51:53 +08:00
ae8b0a517f
PERF: Split skipped email logs into a seperate table.
2018-07-24 13:14:37 +08:00
3874d40910
Prepare to drop `EmailLog#topic_id`.
2018-07-18 10:22:24 +08:00
f9ab3848ed
FEATURE: support disabling emails for non-staff users
2018-06-07 18:31:08 +05:30
bae7203f42
FIX: proper category > subcategory order in List-Id description header
2018-05-05 01:51:53 +02:00
7d223c0e55
FEATURE: add description in 'List-Id' mail headers
...
https://meta.discourse.org/t/minor-feature-request-descriptions-in-list-id-headers/86681
2018-05-03 16:39:25 +02:00
c302c28a7d
Switch ids in References-Header field of mails. ( #5567 )
...
This change allows email-clients to show threaded views of mails as
expected. Apparently most algorithms expect the message ids of mails
in the Reference-header-field to be sorted such that they build a
traversal through the thread, so the oldest (original) message being
first, then its child, grandchild and so on until it arrives at the
message id that the "new" mail (that is to be sent) is the reply to.
MSGA [1]
+- Re: MSGA [1-1]
| +- Re: Re: MSGA [1-2-1]
| +- Re: Re: MSGA [1-2-2]
+- Re: MSGA [1-1]
If the stuff in brackets would be the message ID, the References-Header
field of a message that is a reply to [1-2-1] should look like:
References: 1, 1-1, 1-2-1
Discussion took place in:
https://meta.discourse.org/t/e-mail-threading-in-ml-mode-does-not-work-in-thunderbird
Main information taken from:
https://www.jwz.org/doc/threading.html
2018-02-22 10:48:23 +01:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
5be7a2dad4
FIX: invalid html in notification emails when template has been customized
2017-05-10 14:01:26 -04:00
bf9c4a7828
FEATURE: secure_email site setting to prevent data going out in email
2017-04-26 13:05:56 -04:00
521c88fe58
FIX: enqueue activation email for invited user that has password set
2017-03-20 17:13:21 +05:30
82555ca761
FIX: mail threading wasn't working properly in Mac Mail
2017-02-01 23:02:41 +01:00
a03287f2ee
FIX: 'In-Reply-To' header should default to topic_message_id
2016-11-28 14:18:02 +01:00
74b6fe8739
FIX: respect RFCs when setting 'In-Reply-To' and 'References' email headers
2016-11-25 23:25:39 +01:00
17169b3037
FIX: issues with 'X-MSYS-API' custom header
2016-11-03 02:26:12 +01:00
f8caae0be7
FIX: don't overwrite custom email headers when using mandrill/sparkpost
2016-10-30 11:38:55 +01:00
71f940d478
FIX: use metadata to hold the message_id with sparkpost
2016-10-27 19:35:50 +02:00
3949c24f80
FIX: sparkpost webhooks support
2016-10-17 11:26:49 +02:00
34af73c7cb
FEATURE: sparkpost webhook
2016-09-26 22:13:34 -07:00
49f8a2baa7
FEATURE: support for mandrill webhooks
2016-06-13 12:32:14 +02:00
c0e25b5a9a
Replace certain uses of 'gsub' with 'tr' or 'chomp' for a speed
...
improvement
2016-06-10 22:08:37 -05:00
fe595f1653
FEATURE: mailjet webhook
2016-06-06 19:47:45 +02:00
9704603fab
FEATURE: sendgrid webhooks
2016-06-01 21:48:06 +02:00
d224966a0e
FIX: retry sending an email in 1 hour when SMTP server is busy
2016-05-09 20:37:33 +02:00
84d4ebd910
use 'reply_by_email_address' setting for handling bounce emails using VERP
2016-04-25 20:06:45 +02:00
fad017d842
FEATURE: add support for bounce emails
...
We now optionally add a Variable Email Return Path to every email we send.
This allows us to cleanly handle email bounces, which in turn will improve
deliverability.
2016-04-18 17:14:01 +10:00
c5794ab0f6
allow magic login route emails even when emails are disabled
2016-04-08 11:20:09 +05:30
2c508f205a
FEATURE: properly set 'In-Reply-To' header when sending an email that is a reply to an incoming email
2016-04-06 21:05:10 +02:00
52a6682690
FIX: don't create an EmailLog when we can't send a digest
2016-02-17 17:31:46 +01:00
4ad5660615
add slightly more logs when skipping email notifications
2016-02-15 17:53:07 +01:00
96380bfd38
FIX: only create 1 email_log when an email is sent
2016-01-29 16:49:49 +01:00
1821ba8d93
optimize string replacment
2015-10-21 13:44:59 +05:30
897563a309
FIX: List-ID should not contain space
2015-10-21 00:00:06 +05:30
e97755ab5d
FIX: remove custom Discourse headers in email
2015-01-29 17:25:50 +05:30
b0369061e2
FIX: always set a default Message ID in email
2015-01-28 14:49:38 +05:30
db5f2ae88c
Fix relative URLs in plain text emails
2015-01-17 02:08:03 -08:00
f918d3e89b
FEATURE: add Message-ID header to emails
...
when topic present for email of course
2014-11-26 16:36:02 -08:00
b1a0cd417d
Avoid a deprecation warning by poly-filling #deliver_now and #deliver_now
2014-11-10 01:05:46 -08:00
Sam Saffron
Guo Xiang Tan
Gerhard Schlager
David Taylor
Rishabh
Régis Hanol
Arpit Jalan
Felix Wolfsteller
Guo Xiang Tan
Neil Lalonde
Robin Ward
Vibol Hou
James Cook
Jeff Atwood
Godfrey Chan