1b04d881c5
UX: Display lock icon in admin user lists when user has 2FA enabled.
2018-02-22 09:00:09 +08:00
720e1965e3
FEATURE: add category suppress from latest
...
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.
New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
2b509eaa91
Merge branch 'master' into pm-tags
2018-02-21 23:55:59 +05:30
776ab73a8d
FIX: can_tag method called without guardian variable
2018-02-21 21:22:56 +05:30
84ce1acfef
FEATURE: Allow staffs to tag PMs
2018-02-21 20:11:46 +05:30
8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
...
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
26450f7587
allow for no lograge
...
(fixes tests)
2018-02-21 15:40:37 +11:00
ca1a3f37e3
FEATURE: add instrumentation for all external net calls
2018-02-21 15:20:29 +11:00
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
3ea272f4f1
New setting: minimum trust level to embed images in a post
2018-02-20 20:00:06 -05:00
0799831dbe
FIX: use the avatar of the post rather than the topic in local oneboxes
2018-02-20 19:49:39 +01:00
a4bc54a686
FIX: strip zero width spaces from topic title
2018-02-21 00:12:39 +05:30
de5418a905
correct search in topic list
2018-02-20 20:47:44 +11:00
86d12bd44b
FEATURE: search within title using in:title
...
Also
- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
e5cec28eae
FIX: `Stylesheet::Manager.stylesheet_link_tag` cache should account for `Discourse.current_hostname`.
2018-02-20 09:53:15 +08:00
60ec483caa
FIX: include title in local onebox when linking to a different topic
2018-02-19 22:40:14 +01:00
c419c26f56
FEATURE: new site setting 'max_emojis_in_title'
2018-02-19 18:15:26 +05:30
b6277e208b
FIX: Cookies header didn't have the right format
2018-02-19 12:46:57 +01:00
f3815cd785
FEATURE: New site setting for additional allowed filetypes for staff ( #5364 )
...
* FEATURE: New site setting for additional allowed filetypes for staff
* Problematic variable name
* feedback
* small issues
* fix indentation
* failing tests
* Remove message bus and fix minor issues
* Missed this message bus
2018-02-19 10:44:24 +01:00
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
a3c7ee09b6
FIX: ruby bench not working properly
...
- Remove thin which is no longer supported
- Bypass admin api rate limiting in profile environment
- Admin password was too short
- Run by default in concurrency 1 mode
- A skip bundle assets flag to speed up local testing
2018-02-19 11:37:16 +11:00
61930e092a
FIX: support incoming emails with just an attachment
2018-02-16 18:14:56 +01:00
93b1829f04
tiny refactor
2018-02-16 11:21:11 +01:00
49ad983050
fix extra blank line
2018-02-15 16:54:22 -07:00
925d1a7869
FEATURE: add rake task for import/export of site settings
2018-02-15 16:23:42 -07:00
322aa9ed85
Version bump to v2.0.0.beta3
2018-02-15 17:48:34 -05:00
cda3f72ab8
SECURITY: don't onebox whispers
2018-02-16 08:57:20 +11:00
57e140dc07
FIX: oneboxing to private messages
2018-02-16 08:00:22 +11:00
8e0da35857
FIX: allow local oneboxes to public topics/posts in PM
2018-02-15 18:14:41 +01:00
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
b4aa0b096e
FIX: Couldn't like staff when `allow_flagging_staff` was set
2018-02-14 15:46:04 -05:00
f028ffaf29
SECURITY: correct local onebox category checks
...
Also removes ugly "source_topic_id" from cooked posts
Patch was authored by @zogstrip
Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
3e835047da
Remove "already initialized" constant warning.
2018-02-13 08:55:15 +08:00
4dfe659189
Rename `allow staff flags` to `allow flagging staff`
2018-02-12 15:27:26 -05:00
6287631745
FEATURE: New site setting, `allow staff flags`, false by default
...
For some large communities, it makes sense to disable flagging of
staff posts.
2018-02-12 14:56:21 -05:00
932a1a1187
Remove use of deprecated site setting.
2018-02-12 14:26:22 +08:00
569e57f0a9
FIX: Delete the invalid auth cookie even if you hit the rate limit
2018-02-09 19:09:54 -05:00
5466389f4e
FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links`
2018-02-08 18:27:40 -05:00
dedeb2deb8
FIX: Don't show the link button in the composer if linking is disabled
2018-02-08 12:56:10 -05:00
6a5dad0b86
FIX: Too much Javascript :)
2018-02-07 11:46:05 -05:00
8c04893a04
FIX: Don't throttle local lookups
2018-02-07 00:31:05 -05:00
016b9cd0e9
FIX: Count the links in the post
2018-02-06 20:16:48 -05:00
1bab15c757
FEATURE: A site setting for a minimum TL to post links
2018-02-06 18:07:58 -05:00
b2b6dc68a6
FEATURE: a setting to customize the minimum TL to flag a post
2018-02-06 17:12:27 -05:00
df8e43abdd
use lazy & instead of try
...
unregister ip skipper in test
raise if called when a skipper is in play
2018-02-06 10:38:15 +11:00
eefd226611
Add extensibility point to `request_tracker` to skip IP addresses
...
This is useful if you want to run a per IP rate limiter but want to be
able to skip some IPs with custom logic.
2018-02-05 17:49:40 -05:00
2f19588311
FIX: If personal messages are disabled, don't show messages for groups
2018-02-02 16:35:54 -05:00
0edd386b48
FEATURE: Vanilla bulk importer
2018-02-02 16:28:51 -05:00
8ff4104555
Many enhancements to the flagging / suspending interface.
2018-02-01 17:13:02 -05:00
350cbb1700
deprecate existing site settings
2018-02-01 13:25:29 +05:30
9bbfad1081
rename private to personal
2018-02-01 13:25:29 +05:30
7e48c47d37
rename 'enable_private_email_messages' to 'enable_personal_email_messages'
2018-02-01 13:25:29 +05:30
ff0376a80b
rename 'enable_private_messages' to 'enable_personal_messages'
2018-02-01 13:25:29 +05:30
25ec077eca
rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'
2018-02-01 13:25:29 +05:30
ee0d3f15c1
FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify
...
New site settings:
enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://
markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
2018-02-01 13:22:38 +11:00
7d2283167a
UX: only crops images taller than 18:9 instead of 16:9
2018-01-31 22:31:16 +01:00
c598db28e7
Version bump to v2.0.0.beta2
2018-01-31 12:18:35 -05:00
361030d8ad
Also try popular Windows-1252 encoding when decoding incoming email
2018-01-30 23:45:04 +01:00
b2f18fc98f
FIX: system user edits should not generate notifications
2018-01-30 22:21:07 +01:00
018cb7f36b
add a custom user onebox ( #5542 )
...
* add custom user onebox
* add specs
2018-01-30 11:03:08 +01:00
f946db4afe
FIX: inline oneboxer min title length of 2
...
also: cache mini onebox misses as well to cut down traffic
2018-01-30 08:40:04 +11:00
2eef9b3295
UX: Adding a sticky footer to the post history modal, removing bootstrap columns
2018-01-29 15:15:50 -05:00
fa5880e04f
PERF: ability to crawl for titles without extra HEAD req
...
Also, introduces a much more aggressive timeout for title crawling
and introduces gzip to body that is crawled
2018-01-29 15:40:12 +11:00
1f6adbea5c
FEATURE: log private message views
2018-01-29 08:08:08 +05:30
9721fb7573
Linting
2018-01-26 14:35:04 -05:00
44e2038b53
Setting to automatically lock posts when edited by staff
2018-01-26 14:01:30 -05:00
6b04967e2f
FEATURE: Staff members can lock posts
...
Locking a post prevents it from being edited. This is useful if the user
has posted something which has been edited out, and the staff members don't
want them to be able to edit it back in again.
2018-01-26 14:01:30 -05:00
e2d82b882e
FIX: redirect to original URL after social login
2018-01-26 18:52:27 +01:00
feec968801
Add extensibility to admin constraints
2018-01-25 13:56:08 -05:00
7b4e6d508b
improve reviving_old_topic education message
2018-01-26 00:06:53 +05:30
eb52c5469e
FEATURE: Allow plugins to register a new locale
2018-01-25 14:57:41 +01:00
ce060e2b86
FIX: Server didn't use default_locale as fallback locale
2018-01-25 14:57:41 +01:00
1fac2ecb56
FIX: uploads not working on themes admin page
2018-01-25 21:13:06 +11:00
adae963751
ensure we do not override charset for content type
2018-01-25 18:43:42 +11:00
594efa37b6
add some output to category and topic importer
2018-01-24 12:33:47 -05:00
cbf4204ecc
FIX: uploads:migrate_from_s3 wasn't destroying records before creating new ones
2018-01-24 13:22:07 +01:00
782d75069e
FIX: UX improvements for system messages when PMs are disabled
2018-01-23 13:12:11 -05:00
28d432263e
rework the uploads:migrate_from_s3 rake task
2018-01-23 18:48:06 +01:00
17ebfd1715
FIX: Don't show suggested messages if private messages are disabled
2018-01-23 12:05:44 -05:00
2437b0d531
FIX: regression, missing 404 page
2018-01-23 09:00:28 +11:00
cbb321658f
FIX: support for generating excerpt when nesting <details> blocks
2018-01-22 19:17:35 +01:00
f26ff290c3
FEATURE: Shorten setting name to max_reqs
...
So it is consistent with other settings
2018-01-22 13:18:30 +11:00
83a346cd68
FIX: migrate_from_s3 rake task not working
2018-01-22 11:42:09 +11:00
fc36f095a7
FIX: ensure proper header transfer (except for cache control)
...
allows discourse special headers to be visible on hijacked reqs
2018-01-21 14:26:42 +11:00
b68799e081
FIX: Allow plugins to register importers
2018-01-19 16:24:41 -05:00
24dcfc2db5
remove constant warning in base62 file
2018-01-19 19:52:42 +01:00
b6c9d7a9d2
move requires to top of file
2018-01-19 17:51:42 +01:00
9009cb5963
OOPS: Deleted file
2018-01-19 11:43:09 -05:00
a8b46df4bd
More extensibility for custom silence/suspend messages
2018-01-19 11:35:19 -05:00
2d49250107
FIX: support recovering images using 'upload://' scheme
2018-01-19 15:40:17 +01:00
8bf91b8dca
correct tracking of x runtime
2018-01-19 17:51:19 +11:00
8ad43f01c2
FIX: correctly log topic timings as background
2018-01-19 10:37:43 +11:00
4f946319b4
improve warning text
2018-01-19 08:32:15 +11:00
12872d03be
PERF: run post timings in background
...
This means that if a very large amount of registered users hit
a single topic we will handle it gracefully, even if db gets slow.
2018-01-19 08:27:29 +11:00
5f4f617689
FIX: cache_file storage cleanup logic was wrong
...
https://meta.discourse.org/t/68296
2018-01-18 17:00:04 +01:00
2a22b90538
SECURITY: email domain whitelist could be bypassed
2018-01-17 21:45:32 +01:00
34ed6088b9
FEATURE: New modal to show flags received for a user
2018-01-17 15:08:08 -05:00
bb54eb1192
Improvements to mbox importer
...
* store time it took to index message in DB (to find performance issues)
* ignore listserv specific files
* better examples for split_regex
* first email in mbox shouldn't contain the split string
* always lock the DB in exclusive mode
* save email within transaction
* messages can be grouped by subject and use original order (for Listserv)
* adds option to index emails without running the import
2018-01-17 12:04:57 +01:00
79eb9d7086
FEATURE: show header search results on search log term details page
2018-01-17 12:47:16 +05:30
650ec9c73f
minor test the developer cache first before digging into email
2018-01-17 15:50:41 +11:00
1208254961
FIX: validate presence of 'top menu' setting
2018-01-17 01:43:53 +05:30
f274a5234f
FIX: topic and category exporters were only exporting users who created the first post
2018-01-16 12:51:53 -05:00
d7657d8e47
correct specs, ensure crawler layout only applies to html
2018-01-16 16:28:11 +11:00
7b562d2f46
FEATURE: much improved and simplified crawler detection
...
- phase one does it match 'trident|webkit|gecko|chrome|safari|msie|opera'
yes- well it is possibly a browser
- phase two does it match 'rss|bot|spider|crawler|facebook|archive|wayback|ping|monitor'
probably a crawler then
Based off: https://gist.github.com/SamSaffron/6cfad7ea3e6df321ffb7a84f93720a53
2018-01-16 15:41:45 +11:00
fcfce3e426
PERF: avoid expensive OR clause query info more efficiently
2018-01-15 16:38:58 +11:00
38c018a84b
FIX: invalid cache for parent category with limit_suggested_to_category
2018-01-15 16:13:29 +11:00
41a604a764
PERF: improve perf of topic suggested query with limit_suggested_to_category
2018-01-15 15:32:25 +11:00
442a17bfb2
PERF: bypass omniauth unless in an auth path
2018-01-15 12:44:54 +11:00
234aa68bf8
Correct Arabic month names
...
Correct Arabic month names. It's not right to concatenate month names from two different calendars [Assyrian calendar](https://en.wikipedia.org/wiki/Assyrian_calendar ) and [Gregorian calendar](https://en.wikipedia.org/wiki/Gregorian_calendar )
2018-01-14 20:01:45 +01:00
215c0d5569
FEATURE: allow system api to target users via external id or user id
...
usage ?api_key=XYZ&api_user_external_id=ABC
usage ?api_key=XYZ&api_user_id=123
2018-01-12 17:40:18 +11:00
988b13ac77
FIX: GitHub auth always asking to verify email for new users ( #5487 )
2018-01-12 15:17:29 +11:00
49ed382c2a
FIX: return 429 when admin api key is limited on admin route
...
This also handles a general case where exceptions leak out prior to being handled by the application controller
2018-01-12 14:15:26 +11:00
7fea15ca4d
FIX: rescue login required / broken images
2018-01-11 22:18:56 +05:30
fc05164667
demo script for demonizing using fork exec
...
minor refinements to demon
2018-01-11 13:51:52 +11:00
cc819539b0
FIX: makes rake qunit:test task work on macOS
2018-01-10 14:51:08 +01:00
8ff5f5f2ef
FIX: cache admin locale file for 24 hours
2018-01-09 10:23:49 +11:00
cecd7d0d07
FEATURE: global rate limiter can bypass local IPs
2018-01-08 08:39:17 +11:00
e0d73a957d
FEATURE: Allow posting via email to read-only mailing list mirror category
2018-01-05 11:21:53 +01:00
d7cd7e4dc7
FIX: Never mark emails sent to mailing list mirror as auto-generated
2018-01-05 11:21:53 +01:00
754fa3d2f5
FIX: facebook deprecated facebook messenger emojis
2018-01-05 11:01:23 +01:00
e7d1d4eddf
FIX: correct shushing_face name
2018-01-05 11:01:23 +01:00
715cb98e95
add better diagnostics for rate limits
2018-01-05 12:14:28 +11:00
25f4d98307
improve error logging for warn_exception
2018-01-05 09:54:42 +11:00
c2c0a81a4f
Version bump to v2.0.0.beta1
2018-01-03 16:54:55 -05:00
ceb7590bcb
FIX: bounced email can contain multiple status codes
2018-01-03 17:59:20 +01:00
ad02437358
FIX: Missing post/topic created web hooks due to race condition.
2018-01-03 17:24:01 +08:00
81427e26ea
Ignore errors when remapping posts
2017-12-28 15:13:01 +01:00
f5e170c6b5
FIX: catch all server-side error when uploading a file
...
UX: always show a message to the user whenever an error happens on the server when uploading a file
2017-12-27 16:33:25 +01:00
805d1c25d3
Merge pull request #5451 from tgxworld/treat_non_ascii_urls_as_valid
...
Treat non-ascii URLs in `UrlValidator`.
2017-12-27 14:14:20 +08:00
0514ac4ee2
FIX: verify presence of 'sso url' before enabling 'enable sso'
2017-12-23 13:30:49 +05:30
d6b22e6cc1
FIX: whitelist oneboxed iframes
2017-12-23 01:56:33 +01:00
364e6fdd53
FIX: pluralization rules for Serbian language ( #5453 )
...
Updated SR pluralization to use 3 keys: one, few, other (as by Transifex)
2017-12-22 12:20:19 +01:00
cedfd6b68c
Merge pull request #5449 from Supermathie/google_fix
...
FIX: google oauth flow should automatically update the google account used for login when appropriate
2017-12-21 17:46:43 -08:00
6f89db4c24
Re-enable check for yarn when running qunit:test rake task.
2017-12-22 09:11:49 +08:00
aed37770e3
FIX: Load the route format before discourse
2017-12-21 16:29:11 -05:00
063e449ce5
FIX: `RouteFormat` is a better class name than `RouteFormats`
2017-12-21 15:30:32 -05:00
2908aab0da
Allow extensibility on username route format (non-english usernames)
2017-12-21 14:32:51 -05:00
4b51871f6a
Treat non-ascii URLs in `UrlValidator`.
2017-12-21 14:22:55 +08:00
6ecf37c482
Improve URL validation to check for a valid host.
...
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:
URI.parse("http://https://google.com ")
=> #<URI::HTTP http://https//google.com >
2017-12-21 13:50:15 +08:00
081959227d
FIX: unicode titles missing when visiting topic from topic list
2017-12-21 15:20:47 +11:00
aabac55edd
Better ENV name for QUnit's seed.
2017-12-21 09:47:32 +08:00
e17ce65aab
Version bump to v1.9.0.beta17
2017-12-20 18:50:35 -05:00
105cf61ed9
Implements https://meta.discourse.org/t/issue-user-changed-google-account-and-cant-connect-thru-his-profile/35028/18?u=supermathie
2017-12-20 17:59:36 -05:00
88a4ec5f1b
FIX: stop forking regular backup jobs
2017-12-21 09:00:48 +11:00
21e1b05c7e
FIX: Don't disable details when below truncate limit
2017-12-20 15:45:00 -05:00
4986132e1b
Fix missing variable in smoke test rake task.
2017-12-20 14:49:41 +08:00
bbc606988f
improve message
2017-12-20 10:12:33 +11:00
b3fda0ea86
FIX: details tags broke excerpts
2017-12-19 17:28:55 -05:00
ca8e4dfb43
Allow seed to be passed via ENV.
2017-12-19 21:35:51 +08:00
Guo Xiang Tan
Sam
Vinoth Kannan
Guo Xiang Tan
Jeff Wong
Robin Ward
Régis Hanol
Arpit Jalan
Gerhard Schlager
OsamaSayegh
Leo McArdle
Blake Erickson
Neil Lalonde
Erick Guan
Maja Komel
Kris
Mohammad AlTawil
Joffrey JAFFEUX
blokovi
Jeff Atwood
Michael Brown