427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
2019-05-08 17:27:09 +02:00
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
b409dab77f
Rename `flags_default_topics` to `reviewable_default_topics`
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
2019-05-08 15:58:08 +08:00
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
451f7842ff
DEV: More `send` -> `public_send`.
2019-05-07 10:05:58 +08:00
cac80cdc3b
DEV: more send -> public_send changes
...
This is a work in progress commit for more send to public_send conversions
Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
152238b4cf
DEV: Prefer `public_send` over `send`.
2019-05-07 09:33:21 +08:00
9be70a22cd
DEV: introduce new API to look up dynamic site setting
...
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup
This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class
It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
5e546ba7d1
Standardize viewport rules for mobile and desktop
...
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
e2e72f4e8e
DEV: rename ReadOnly module to ReadOnlyHeader
2019-05-06 16:07:49 +02:00
33e06dd796
FIX: Make select all and below skip small actions. ( #7425 )
2019-05-06 16:22:11 +03:00
a40dcbde9b
FIX: Do not move hidden post actions. ( #7424 )
...
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
2019-05-06 16:21:42 +03:00
8217d5be78
UX: Switch mobile header back for 5s when notification comes in.
2019-05-06 16:58:25 +08:00
f8eddd40ad
PERF: remove avg_time calculations and regular jobs from posts and topics
...
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.
We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.
Column removal will follow once we decide on a new replacement metric.
2019-05-06 15:59:01 +10:00
ba3cf7109c
DEV: Remove unused lines of code.
2019-05-06 13:48:51 +08:00
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
e8fafbc123
List and restore missing post uploads from S3 inventory.
2019-05-04 01:16:20 +05:30
d82da69c2c
FIX: Fail gracefully if username parameter is missing when creating user
2019-05-03 17:17:06 +01:00
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
0d41d58d27
FIX: add ReadOnly hear to /srv/status
2019-05-03 12:21:07 +02:00
16ef060a76
DEV: correct Rails 6 deprecation
...
render template is backwards compatible with Rails 5, code is simpler.
Thanks @jhawthorn, this is our last Rails 6 deprecation
2019-05-03 16:20:18 +10:00
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme ( #7443 )
2019-05-02 21:43:54 -04:00
3dc4ab905c
DEV: annotate models
...
(also looks like renaming of bigint(8) -> bigint in annotate
which seems fine)
2019-05-03 08:34:12 +10:00
3cb0d27d38
DEV: Upgrade our widget handlebars compiler
...
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn ( #7472 )
2019-05-02 20:56:27 +02:00
35212036f2
FIX: ensures click on topic link has link for target and not children ( #7471 )
2019-05-02 13:43:02 +02:00
d252dad4f0
FIX: Can't remove user profile uploads.
...
Follow up to 24347ace10
2019-05-02 16:54:10 +08:00
ebca588fd0
DEV: Remove unused line of code.
2019-05-02 16:54:10 +08:00
75591664e7
FIX: better handling of category filter deselection ( #7468 )
2019-05-02 10:03:12 +02:00
d5c9ac7196
PERF: Use cdn when serving site settings upload.
2019-05-02 15:35:07 +08:00
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
96360a779f
DEV: add a few frozen string literals
2019-05-02 16:57:12 +10:00
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
5a834a05ea
FIX: crawler layout CSS adjustments ( #7469 )
...
* Fix header size to fit the viewport
Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.
* prevent code in posts from causing horizontal overflow
We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
2019-05-02 13:00:29 +08:00
157dc5e298
FEATURE: disable native share API on non tablets/phones
...
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
885f1e7e5f
FIX: Allow category group reviewers to edit queued posts
...
They can edit title, body and tags. Category is disabled for now as it
could lead to some odd security issues.
2019-05-01 14:48:49 -04:00
0f01c9d25f
FIX: Posts in the approval queue were sometimes dropping category
2019-05-01 14:40:38 -04:00
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
7869a10d18
Revert "FEATURE: Added unlisted topics option to advanced search ( #7447 )"
...
This reverts commit 539723f8ff
2019-05-01 21:06:20 +05:30
ae493f4722
UX: fills picker with emoji autocomplete state on `more` click ( #7466 )
2019-05-01 16:19:45 +02:00
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons ( #7372 )
...
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.
## Core
- Adds an SiteIconManager module which manages automatic resizing and fallback
- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon).
- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.
- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations
## Wizard
- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload
- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"
- Various copy updates to support the changes
- Remove the "upload-time" resizing for `large_icon`. This is no longer required.
## Site Settings UX
- Move logo/icon settings under a new "Branding" tab
- Various copy changes to support the changes
- Adds placeholder support to the `image-uploader` component
- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings
- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name
## Dashboard Warnings
- Remove PWA icon and PWA title warnings. Both are now handled automatically.
## Bonus
- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
9c78c18256
Check both site and global setting for s3 enabled value.
2019-05-01 10:49:53 +05:30
c6409fd2cc
FIX: pass correct date arguments to server when exporting CSV
2019-05-01 10:46:30 +05:30
002e1f560a
FIX: initialize empty object if no custom filters are present
2019-05-01 10:27:19 +05:30
539723f8ff
FEATURE: Added unlisted topics option to advanced search ( #7447 )
2019-05-01 12:31:13 +10:00
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
dd29af4475
REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
...
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin ( #7433 )
2019-04-30 15:36:54 -03:00
812905cbb6
FIX: Recursively delete nested replies
...
Previously we were only deleting top level replies
2019-04-30 12:54:53 -04:00
5edb5c8b03
FIX: Mark invited admins as 'approved' ( #7459 )
...
This prevents invited admins appearing as no-op reviewables in the queue when invite_only or require_approval is enabled.
2019-04-30 17:26:39 +01:00
583226d295
FIX: Linking to `/new-topic` from `/latest`
...
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.
This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.
Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
8e68244eea
FIX: prevents google to track certain pages ( #7463 )
2019-04-30 15:57:51 +02:00
726dd0fe37
Revert "FIX: prevents google to track certain pages ( #7455 )"
...
This reverts commit c863e62998
2019-04-30 10:17:12 +02:00
587cfd4545
DEV: Use `frozen_string_literal: true` on `models/theme.rb`.
2019-04-30 16:02:55 +08:00
c863e62998
FIX: prevents google to track certain pages ( #7455 )
2019-04-30 13:59:55 +08:00
1fdeec564b
PERF: Move `where` clause up to speed up CalculateAvgTime daily job ( #7462 )
...
Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.
https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
2019-04-30 13:34:46 +10:00
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
2019-04-30 10:35:17 +08:00
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
526e76ced2
FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition
...
On busy sites, concurrent requests to insert into post_timings can
occur, which was dealt with using Ruby exceptions.
This moves the handling to PostgreSQL which makes it a bit faster,
and prevents a spam of ERROR in the database logs.
2019-04-29 16:34:42 -03:00
bfadb1fabc
FIX: use more specific target for ".tag-box"
...
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
f8f7091e57
FIX: staff-only tags visible on /tags page when restricted to a category
...
If a tag group is set to only be visible to staff, and is restricted
to a category that is visible by everyone, the tags in the group were
being shown on the /tags page. They weren't visible anywhere else.
This commit fixes it so they don't show on the /tags page.
2019-04-29 12:38:28 -04:00
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
876c4f20b3
FIX: Remove duplicate Emoji names from blurb
...
The blurb contained the value of the alt and title attribute of Emojis. Both values are always the same.
2019-04-29 17:26:39 +02:00
71d19f6e1f
FIX: Reduce mentions in blurbs to @username or @groupname
...
The link to the user profile or group is useless and the URL encoded username or group name looks awful for Unicode names
2019-04-29 17:26:39 +02:00
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
7a27c93c03
FIX: URL encode username and first letter in avatar URL
...
And it adds specs as a follow-up to aadb7da7
2019-04-29 15:08:14 +02:00
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
ac3dab93f5
DEV: lint the files
2019-04-29 17:40:53 +10:00
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
1b1cfd4507
add no_subcategories query param in url only if its true ( #7439 )
2019-04-29 15:10:59 +08:00
fe86941cb6
FIX: prevents exception when search q params is a hash ( #7437 )
...
* FIX: prevents exception when searh q params is a hash
* raise when invalid format
2019-04-29 15:09:25 +08:00
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
de79313f62
FIX: ensures file extension doesnt have a leading point ( #7449 )
2019-04-27 14:00:51 +02:00
6952510fc4
FIX: restores skipHeader computed property
2019-04-26 23:43:49 +02:00
1486328756
UX: Changed post stream placeholder to animation ( #7434 )
2019-04-26 17:29:48 +01:00
8fc2b0124f
PERF: destroy users in batches of 50 users
...
This speeds up the process as we no longer need to commit a transaction
per user deleted
2019-04-26 22:51:33 +10:00
b8c65cc6cf
PERF: add index on user auth tokens (for user lookups)
...
This speeds up user destroy cause we cascade looking up all the tokens
for a user
2019-04-26 22:38:54 +10:00
378fe1c1cf
PERF: allow looking up incoming email by user_id
...
This speeds up the ability to remove users from the system
2019-04-26 22:33:01 +10:00
26b4dbde41
PERF: use delete_all to remove notifications and topic_users
...
Previously we used destroy here which could be extremely expensive
2019-04-26 22:26:48 +10:00
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
4b455e741e
DEV: Ember 3.8.0
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
c617e512ad
annotate new indexes
2019-04-26 18:23:27 +10:00
c009a6ae36
PERF: speed up user deletion logic
...
Previously any user deletion would scan a very large number of tables
This avoids scans on 6 tables/indexes on delete
2019-04-26 18:11:39 +10:00
be0ae2e487
FIX: plain text table detection should work even if html content not found.
2019-04-26 11:16:41 +05:30
dc2ee78f7a
UX: Only do plain text table detection in outside code if HTML pasting enabled
...
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
abecb3aea8
Update annotations.
2019-04-26 10:36:21 +08:00
34b772575e
FIX: Return 'failed' attribute when catching an ajax error and the attribute is present
2019-04-25 14:49:52 -03:00
761e1e25f7
Remove tables incorrectly excluded in `Upload.migrate_to_new_scheme`.
...
Follow up to 4a03b21f80
2019-04-25 20:27:52 +08:00
7cbc4c1e46
FIX: uses no tags label for tag-drop header ( #7438 )
2019-04-25 13:16:06 +02:00
6d77156a94
FIX: Don't try to delete inactive admins
2019-04-25 11:59:50 +02:00
422237391e
FIX: fix notifications for flag PMs and show topics with moderator posts in inbox ( #7331 )
...
Some old moderator posts that were not correctly processed before this change and 993d8f34
2019-04-25 11:15:13 +02:00
996e5e5dfa
FIX: category list order using category featured topics ( #7283 )
2019-04-25 11:07:19 +02:00
e386fa7674
FIX: ensures we have touches when starting pan event ( #7435 )
2019-04-25 10:36:41 +02:00
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way ( #7289 )
...
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
84cfe30c1f
Use update_all instead of save to select and update particular columns
...
9ec6ef85b6
2019-04-25 11:56:57 +05:30
4a03b21f80
Exclude large tables when remapping in `Upload.migrate_to_new_scheme`.
...
Those tables do not carry any information about uploads.
2019-04-25 11:55:48 +08:00
aadb7da7d3
FIX: Use first grapheme cluster for letter avatar
2019-04-24 23:20:46 +02:00
03f9564804
FIX: Handle missing letter avatar
2019-04-24 23:20:46 +02:00
3aa143a52c
SECURITY: Fix tab nabbing.
2019-04-25 00:11:28 +03:00
505c5addca
Allow signup form width to increase when no external logins are present
2019-04-24 13:08:39 -04:00
6df8c4b8f0
FIX: Fall back to large logo on mobile no_ember pages
2019-04-24 11:39:11 -04:00
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user ( #7428 )
2019-04-24 16:00:20 +01:00
1a8c6577e0
FIX: refactor padding when exiting composer
...
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.
The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts ( #7422 )
2019-04-24 13:54:46 +01:00
a452933071
FIX: disable input zoom on search in iOS
2019-04-24 08:41:20 -04:00
be88ac8b7e
Additional old `Upload#url` format for `Upload.migrate_to_new_scheme`.
2019-04-24 18:19:25 +08:00
9ec6ef85b6
Don't validate post when saving in `Upload.migrate_to_new_scheme`.
2019-04-24 17:17:31 +08:00
3c9495b989
DEV: Put a mutex around `Upload.migrate_to_new_scheme`.
...
This ensures that only one migration is running at any given point in
time across the instances.
2019-04-24 17:07:10 +08:00
55f406bb79
Follow up to 845b68f9ab.
2019-04-24 16:57:45 +08:00
104a9e79f9
UX: User card loading ( #7404 )
2019-04-24 11:55:09 +03:00
7334362b77
FEATURE: generic theme component bbcode wrapper ( #7400 )
...
Usage:
```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
845b68f9ab
Update possible upload url format for `Upload.migrate_to_new_scheme`.
2019-04-24 16:26:54 +08:00
c811e59898
Avoid hardcoding db name in `Upload.migrate_to_new_scheme`.
2019-04-24 15:25:24 +08:00
8673bd832a
FEATURE: use failed_to_login for SSO error ( #7394 )
...
The error displayed when logging into suspended accounts via SSO never includes
the suspension reason, unlike non-SSO logins. By re-using the failed_to_login
method when generating the error message for SSO we can ensure the message is
consistent between the SSO and non-SSO paths.
2019-04-24 16:38:56 +10:00
d4bec7fdfb
use description_text instead of description to show correct sanitized description ( #7420 )
2019-04-24 16:33:58 +10:00
e351b2ee26
Revert "FEATURE: stop running migrate to new scheme once done"
...
This reverts commit 2e346e6ea2573ddcbbd0
2019-04-24 14:03:31 +08:00
573ddcbbd0
Disable migrate_to_new_scheme once there is nothing to migrate.
2019-04-24 14:00:00 +08:00
2e346e6ea2
FEATURE: stop running migrate to new scheme once done
...
This setting will automatically disable itself when there are no longer any
problem uploads
2019-04-24 14:32:39 +10:00
3094a603b7
Follow up to 149411ec90.
2019-04-24 12:20:53 +08:00
149411ec90
PERF: Speed up `Upload.migrate_to_new_scheme` by limiting remap scope.
...
Doing a `LIKE` on `Post#raw` and `Post#cooked` takes forever on large
sites.
2019-04-24 11:56:48 +08:00
a8baa6d9e7
FIX: Old `Upload#url` scheme support for `Upload.get_from_url`.
...
This is for backwards compatibility purposes. Even if `Upload#url` has a
format that we don't recognize, we should still return the upload object
as long as the upload record is present.
2019-04-24 10:15:47 +08:00
646cdfa449
FIX: Approved posts were not enqueueing alerts
2019-04-23 17:30:12 -04:00
b9339e15a1
FIX: Do not track a elements with no href.
2019-04-23 23:13:23 +03:00
b81d169e2a
FIX: Do not track user mentions.
2019-04-23 23:08:00 +03:00
fca3f53e9c
FIX: Safer scoring with concurrency
2019-04-23 15:53:37 -04:00
70097966ed
FIX: Don't add the reviewable score twice
2019-04-23 15:46:18 -04:00
6f56fba016
UX: Update post actions to "Approve Post" and "Reject Post"
...
This should be more clear.
2019-04-23 12:19:11 -04:00
c99faa6b25
FIX: improves locale support in tag-drop ( #7418 )
2019-04-23 17:53:59 +02:00
d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS ( #7416 )
2019-04-23 17:07:31 +02:00
dc60128355
FIX: Hide ignoring users in preference for users with TL less than a member ( #7415 )
...
* FIX: Hide ignoring users in preference for users with TL less than a member
2019-04-23 14:47:37 +01:00
a2ddb6cf2d
DEV: Increase max length of theme_field name column
...
Now that we have custom SCSS files with arbitrary names, it's easy to exceed 30 characters
2019-04-23 12:34:32 +01:00
a7bc1ecbae
FEATURE: Add support for Unicode usernames and group names
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
d07605d885
DEV: Fix failing spec.
2019-04-23 18:25:28 +08:00
1867f2dda0
FEATURE: Always track clicks using AJAX. ( #7373 )
2019-04-23 12:41:36 +03:00
c048b71b29
UX: Replace staff notice icon with user-shield.
2019-04-23 10:37:33 +03:00
87cca0fb80
FIX: Return the right response code for invalid theme id.
2019-04-23 14:57:14 +08:00
3ac18b92b3
UX: Editing theme name stays active when switching themes.
...
* Also fix length of input field.
2019-04-23 14:57:14 +08:00
3658be42f5
FIX: remove like_count and <hr> tag from post crawler layout ( #7413 )
...
* show likes value in crawler view if count is > 0
* remove <hr> since horizontal line is already provided by css - this removes one of 2 horizontal lines in post crawler view
2019-04-23 15:35:57 +10:00
8f7cfc29db
FIX: Detect SNS notifications for SES correctly ( #7284 )
...
* Fix handling SNS notifications for AWS SES
This fixes detection of email bounce by:
- removing hard requirement for email ID, ID in webhook msg never equals this in email_log
- gets bounce_score from user stats instead of nonexistent field in webhook msg
* Remove empty line
* Prettify access to EmailLog for parsing SNS notification
Co-Authored-By: SystemZ <SystemZ@users.noreply.github.com>
2019-04-23 13:03:31 +10:00
58fe45ffd9
UX: Do not close login modal and search menu on outside mouse up event. ( #7366 )
2019-04-23 13:01:44 +10:00
9050b1bf5a
FIX: Add unique index on group_requests(group_id, user_id). ( #7399 )
2019-04-23 12:51:30 +10:00
a8e3ac90a0
FIX: `nil` error in list, incorrect count in reviewable pending
2019-04-22 12:18:57 -04:00
3f9ec197e7
FIX: use last_activity_date instead of created_at for crawler view
2019-04-22 11:38:48 -04:00
a63ef4cfc8
FEATURE: better wizard privacy controls ( #7391 )
2019-04-22 19:47:29 +05:30
f112f279ae
UX: Reorder post admin actions for greater consistency.
2019-04-22 10:57:14 +03:00
caeb035b61
FIX: Automatic scrolling in PM not working.
...
See https://stackoverflow.com/questions/18779708/scrolltop-with-animate-not-working
2019-04-22 10:52:46 +08:00
0210b0aabc
REFACTOR: Prefer accessing instance variables directly.
...
* No need to wrap instance variables with another method to read it.
* Remove memoization that wasn't really memozing anything.
2019-04-20 09:39:25 +08:00
151da50e7c
FIX: prevents exception when the node doesnt exist anymore ( #7408 )
2019-04-19 18:27:23 +02:00
57d1dea8a2
FEATURE: Let staff add custom post notices. ( #7377 )
2019-04-19 17:53:58 +03:00
5de483a1b9
PERF: Very post upload's existence by preloaded upload sha1s array
2019-04-19 17:27:16 +05:30
b150a57383
UX: don't clip staff shield in user cards ( #7398 )
2019-04-19 01:53:23 -07:00
19905e587b
Revert "UX: Show user card on load ( #7380 )" ( #7403 )
...
This reverts commit 66789d73c9
2019-04-19 10:45:25 +02:00
66789d73c9
UX: Show user card on load ( #7380 )
2019-04-19 09:20:03 +02:00
1d0816b2cf
UX: Changed error draft status to icon ( #7369 )
2019-04-19 09:18:01 +02:00
cbe7166d87
UX: Move total user count
2019-04-19 00:35:50 -04:00
f62828f14d
Break long group names, don't truncate
2019-04-18 14:10:52 -04:00
85d8d5d092
FIX: Lint
2019-04-18 13:49:28 -04:00
8e77b4d58e
FIX: Replace references to flags in the header with review
2019-04-18 13:25:23 -04:00
6e46197bc8
FIX: Disable webhooks on 410 and 404 HTTP responses ( #7392 )
...
FIX: Disable webhooks on 410 and 404 HTTP responses (#7392 )
2019-04-18 12:36:37 +01:00
7068b58e85
PERF: flush topic timings less frequently
...
This is a first step of a performance optimisation, more will follow
Previously we did not properly account for previously read topics while
"rushing" marking times on posts.
The new mechanism now avoids "rushing" sending timings to server if all
the posts were read.
Also to alleviate some server load we only "ping" the server with old timings
once a minute (it used to be every 20 seconds)
2019-04-18 17:31:08 +10:00
1f17d52f55
UX: new layout for groups page, allow changes to automatic group bio ( #7350 )
2019-04-17 22:44:30 -04:00
bf712a8598
break long words/urls to prevent overflow
2019-04-17 21:11:02 -04:00
ec4cd09210
UX: Improve review queue layout on small screens
2019-04-17 16:17:54 -04:00
cd2e93b598
FIX: Show when a post has been deleted in the flag review queue
2019-04-17 16:14:36 -04:00
ee808dc682
UX: replace lightbox loading text with spinner ( #7393 )
2019-04-17 10:24:03 -07:00
7cd621778d
FEATURE: Native app banner improvements
...
This commit adds some improvements to native app banners for iOS and Android
- iOS and Android now have separate settings for native app banners
- app banners will now only show for users on TL1 and up
- app ids are now in a hidden site setting to allow sites to switch to their own app, if desired
- iOS only: the site URL is passed to the app arguments
2019-04-17 12:25:13 -04:00
14f9d40e48
FEATURE: Clarify Reviewable User Actions
...
"Approve" is now "Approve User" and "Delete" is a dropdown with a choice
that allows you to block.
2019-04-17 11:44:17 -04:00
12a5c69abd
FEATURE: Allow users to tone down digest emails ( #7353 )
...
* FEATURE: Allow user to tone down email digest insteand of only unsubscribing
* Reordered options and select the next slowest frequency by default
2019-04-17 12:14:40 -03:00
a58091e352
Mobile alert padding too broad
2019-04-17 09:37:42 -04:00
02a9429c38
REFACTOR: Quick refactor of the webhook event emitter job ( #7385 )
...
* REFACTOR: Quick refactor of the webhook event emitter job
2019-04-17 10:03:23 +01:00
16bfc29164
Move the trend icons on the admin dashboard inside the span ( #7367 )
...
so that it will have the tooltip as well
2019-04-17 18:11:01 +10:00
5c795bc480
FIX: prevent anonymous users from changing their email/username/name ( #7311 )
2019-04-17 18:05:02 +10:00
ba6d4b2a8d
FIX: Better handling for toggling `must_approve_users`
...
If you turn it on now, default all users to approved since they were
previously. Also support approving a user that doesn't have a reviewable
record (it will be created first.)
This also includes a refactor to move class method calls to
`DiscourseEvent` into an initializer. Otherwise the load order of
classes makes a difference in the test environment and some settings
might be triggered and others not, randomly.
2019-04-16 15:56:35 -04:00
7e8579b8aa
UX: Add translations for lightbox
2019-04-16 17:03:01 +02:00
5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable ( #7383 )
2019-04-16 12:31:33 +02:00
784940bea0
Fix the build.
2019-04-16 15:47:16 +08:00
1056dd16d3
FIX: Publish web hooks when topic archetype is converted.
2019-04-16 15:18:39 +08:00
347663e852
UX: Switch ellipsis direction when expanding web hook event details.
2019-04-16 14:28:23 +08:00
8cb1890245
FIX: Missing topic edited web hook when publishing a topic.
2019-04-16 14:28:23 +08:00
d6e45864ce
Fix failing spec.
2019-04-16 09:59:35 +08:00
ce4c8e957b
PERF: Avoid looking up the same group multiple times during bulk invite.
...
Also cache the guardian check because it does a query to check if the
user is an owner of the group.
2019-04-16 09:42:25 +08:00
25514550f0
FIX: Bulk invite should skip invite and add existing users to groups.
2019-04-16 09:42:25 +08:00
6e6cdfaf80
FIX: Bulk invite should not add users to automatic groups.
...
* Also checks that the user creating the bulk invite has permission.
2019-04-16 09:42:25 +08:00
74c4ef6b50
Fix draft position in iOS webview
2019-04-15 19:10:18 -04:00
e23c87c442
FIX: Prevent exception in rescue block.
...
> Job exception: undefined method `id' for nil:NilClass
> clean_up_inactive_users.rb:25:in `rescue in block in execute'
2019-04-16 01:27:39 +03:00
3ceff0a92a
FEATURE: Send the user a notification when their post is approved
2019-04-15 16:20:16 -04:00
de10bd7fb4
UI: Footer nav fixes
...
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
fca3044b10
UX: When editing a reviewable, show created_by
2019-04-15 15:11:34 -04:00
d859e1594e
UX: Add a description for scores
2019-04-15 14:21:25 -04:00
4b74525446
FIX: Group requests page missing wrapper
2019-04-15 14:16:02 -04:00
14eb8eea01
FIX: Prevent input zooming in iOS
...
Since enabling pinch-to-zoom in iOS (eae22548de
2019-04-15 13:05:43 -04:00
a37181ab30
Move footer nav z-index below header menus
2019-04-15 12:03:42 -04:00
428536788c
FIX: Do not error when importing a theme with empty files
2019-04-15 15:46:47 +01:00
6bbdf5b56e
DEV: add "pre_notification_alert" event
...
Allows plugins to modify payload before sending a notification alert
2019-04-15 10:17:15 -04:00
24fd710f04
Revert "FIX: strip spoilers in notification excerpts"
...
This reverts commit 55942224ed
2019-04-15 10:15:17 -04:00
594674703c
FIX: properly log webhook errors in UI on rescue ( #7376 )
2019-04-15 12:19:48 +05:30
fd0de64e0d
UX: Render wizard previews for high-DPI displays ( #7371 )
...
* UX: Render wizard previews for high-DPI displays
Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.
* Use window.devicePixelRatio to determine scale factor
2019-04-15 16:16:05 +10:00
00ee68f799
FIX: Fixed category reordering using arrow icons ( #7374 )
2019-04-15 10:56:21 +10:00
8e40c35eb8
FIX: 'have_uploads' scope should include all uploads without multisite 'upload_path' prefix
2019-04-15 01:54:55 +05:30
95ada3f190
FIX: save registration IP address for invited users
2019-04-13 13:04:25 +05:30
b71f19d394
UX: Responsive reviewables down to tablet width
2019-04-12 22:26:24 -04:00
ef1af53e05
FIX: If creating an active user via the API, create reviewables
2019-04-12 15:25:02 -04:00
f7ebfb1acc
FIX: Only consider pending queued posts for cleaning up uploads
2019-04-12 14:39:32 -04:00
534d75310f
FIX: Linting
2019-04-12 14:34:14 -04:00
a5d9afe397
FEATURE: Include a user's pending posts in the topic view
...
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
51630b5187
Footer nav tweaks
2019-04-12 12:29:54 -04:00
55942224ed
FIX: strip spoilers in notification excerpts
2019-04-12 12:00:49 -04:00
7b5913344e
UX: tone down user card email color
2019-04-12 04:55:01 -07:00
268d4d4c82
FEATURE: Multiple SCSS file support for themes ( #7351 )
...
Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.
2019-04-12 11:36:08 +01:00
0e9a0a31f5
FIX: Show email for staged users in user cards. ( #7354 )
2019-04-12 12:50:43 +03:00
2fea29a355
Simplify animation used to denote draft is saved
...
The original implementation felt a bit too short, went with
a much simpler animation which sticks around for 5 seconds.
5 seconds seems to be the standard and the same timing gmail use
2019-04-12 10:28:29 +10:00
9bd3afda5d
FIX: display conextual count on favicon if selected
...
This also corrects the test suite and moves the two notification counts
so they are closer together.
2019-04-12 10:04:23 +10:00
dcec256b9d
Make 1gb warning a little less than 1gb ( #7368 )
...
When you have '1gb' RAM, this might be a little less than 1,000,000.
Let's not warn unless it's well under 1gb.
2019-04-11 16:44:29 -07:00
24ef4f7b2b
Remove support for disable_jump_reply user setting ( #7359 )
2019-04-12 09:03:06 +10:00
dc703adad7
FEATURE: Add user preference for title counter mode ( #7364 )
2019-04-12 09:02:18 +10:00
c0c236f36e
FIX: Better to put a ReviewableUser back into pending than silently fail
2019-04-11 16:36:47 -04:00
6f7b6a3333
FIX: Disagree and Restore should not revert edits
2019-04-11 16:21:18 -04:00
60db57acc0
Make Prettier happy
2019-04-11 14:15:47 -04:00
f060c9b3ff
UI: improvements to footer nav for app and PWAs
...
Adds support for iPad and Chrome PWAs
Better scroll direction logic when reaching bottom of the page
2019-04-11 14:11:26 -04:00
d21dd521d2
FIX: Don't try to create a reviewable user twice
2019-04-11 12:30:54 -04:00
331a809738
FEATURE: Display the reason for many reviewable items
...
Queued Posts and Users will now display a reason why they are in the
review queue.
2019-04-11 12:04:45 -04:00
7143572e0c
FIX: correctly retrieve 'login required' setting value on wizard ( #7355 )
...
* FIX: correctly retrieve 'login required' setting value on wizard
FEATURE: extract 'invite only' setting in a separate checkbox control
* Update invite_only checkbox locale on wizard.
Co-Authored-By: techAPJ <arpit@techapj.com>
2019-04-11 20:25:08 +05:30
9a428acce4
UX: Switched composer draft saving to animations ( #7356 )
2019-04-11 10:03:36 -04:00
7226240df3
UX: full revamp of local-dates form ( #7357 )
2019-04-11 11:14:34 +02:00
54daa92c2d
Fix progress wrapper margin on Safari/iOS
2019-04-11 00:42:26 -04:00
d705dd8bb8
Update annotations.
2019-04-11 12:37:24 +08:00
723feea832
Bump textarea font size on mobile
...
As of eae2254
2019-04-11 00:03:29 -04:00
9291ffaac0
email-in alignment fix
2019-04-10 23:49:26 -04:00
abd34882d5
UX: Better organization of category settings
2019-04-10 23:00:31 -04:00
baa7a9836c
FEATURE: remove "COMPRESS_BROTLI" optional behavior
...
The compress brotli functionality is no longer optional, this has worked
well for years. The name of the ENV var is also confusing cause it does
not have a `DISCOURSE_` prefix which caused issues with the web upgrader
Brotli support is now unconditionally on
2019-04-11 12:36:18 +10:00
7a7c6af21e
FIX: Fallback to last post when the in-view post cannot be detected.
...
In certain situations the detection method fails. For example, it fails
for a topic containing: a long post (~1600px height), gap, small action
(focus on this), hidden reply.
2019-04-11 01:14:59 +03:00
47c50d9a95
DEV: Add test for post notices. ( #7352 )
2019-04-10 22:06:27 +03:00
689c7f5410
Minor reviewable alignment fixes
2019-04-10 14:22:46 -04:00
1b6f18396b
UX: Simplify merged reviewable table
2019-04-10 13:22:28 -04:00
fe9c271d44
FIX: Fixed deleted posts layout ( #7348 )
2019-04-10 19:00:39 +02:00
cab83596ec
FIX: Sites with SSO that required approval were not creating reviewables
2019-04-10 12:53:50 -04:00
eae22548de
Footer navigation for iOS PWAs and DiscourseHub app ( #7347 )
2019-04-10 12:23:18 -04:00
ab79060468
FIX: don't send activation reminder to staged users
2019-04-10 17:29:08 +02:00
5d99346740
FIX: Always allow us to reject users, even if they are deleted
2019-04-10 11:00:39 -04:00
3d545d66df
FEATURE: Send user activation reminders. ( #7280 )
2019-04-10 16:53:52 +02:00
b0600e52b6
FIX: use 'freeze' method again to fix 'cant modify frozen string' error
...
8d5c900142
2019-04-10 18:30:59 +05:30
536b90e0ef
FEATURE: Support searching custom staff actions ( #7346 )
2019-04-10 09:53:17 -03:00
8d5c900142
DEV: add unique missing uploads index in post custom fields
...
https://review.discourse.org/t/feature-send-missing-post-uploads-stat-to-prometheus/2609/6?u=vinothkannans
2019-04-10 18:09:35 +05:30
442fb2facb
FEATURE: Remove ignore feature SiteSetting and enable ignore by default ( #7349 )
2019-04-10 12:54:59 +02:00
82e051077d
Show link to the original topic when it was deleted ( #7319 )
...
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted
* Use link-to since it's more idiomatic
2019-04-10 11:25:45 +02:00
b5008586c5
DEV: Remove HTML parser from Tautologistics. ( #7344 )
2019-04-10 11:21:22 +02:00
d0fe42e2ef
FIX: should look through posts for image markdown
...
Downloaded onebox images only included in the cooked HTML content. So we have to check 'post.cooked' instead of 'raw'. bfdd0fe64c
2019-04-10 13:52:35 +05:30
9c1d1777db
Bump onebox version
...
- adds support for oneboxing google drive files
- add styling for google drive onebox favicon
2019-04-10 13:37:24 +05:30
88f8c9f43e
FIX: when banner is removed update all clients
...
Previously removing a banner raised a null "banner" in the message bus
channel.
Then Ember.Object.create would fail cause it always expects an object in
constructor.
2019-04-10 15:59:29 +10:00
df85d4593e
UX: Unify admin intro styles for badges/customize, improve mobile
2019-04-09 20:32:24 -04:00
9ebfdaa356
UX: Unify reviewable scores + history
2019-04-09 16:43:08 -04:00
8e9d0ceb67
UX: Mobile - fix editor button space, divider, extra upload icon
2019-04-09 13:15:31 -04:00
307499e48b
FIX: Keep highlighted text for quoted replies by ignored users ( #7345 )
2019-04-09 17:33:12 +02:00
9bcd7aacc8
Remove deprecation, the admin controller can approve just fine
2019-04-09 11:19:19 -04:00
692e09d813
FIX: Only show "Approve" button for the admin user if reviewable
2019-04-09 11:14:52 -04:00
73663c2fdb
FIX: should find records by sha1 only in Upload model
2019-04-09 18:48:49 +05:30
4552d86605
FIX: Broken tests
2019-04-09 08:33:10 -04:00
ec1c3559da
PERF: correct clean up inactive so it does not clog scheduler
...
also add a hard limit of 1000 users per job run so we do not clog the
scheduler
destroyer.destroy has a transaction and this can have some serious complications
with the open record set find_each has going
2019-04-09 22:25:05 +10:00
6d0e8821f8
FIX: Optimize query and avoid bloating memory in `Jobs::MigrateUploadScheme`.
2019-04-09 15:45:30 +08:00
df7f37f10a
FIX: web_crawlers had been mistakenly removed ( #7342 )
2019-04-09 09:26:22 +02:00
a89c90ed5d
FIX: removes link to old dashboard ( #7341 )
2019-04-09 09:24:41 +02:00
f0f659286f
UX: move up profile picture field next to the username
2019-04-09 11:46:03 +05:30
c82a929025
PERF: Add `index_for_rebake_old` to `posts`.
...
The index becomes smaller over time and is much faster.
Follow up to 4791d992dc
2019-04-09 13:59:46 +08:00
28d117898f
Update annotations.
2019-04-09 13:27:32 +08:00
f6db30a5da
FEATURE: mark last notification unread when removing timings
...
This calls a bit more attention to the deferred topic by amending the "read"
state of the last notification on the topic.
2019-04-09 12:42:21 +10:00
f0bb492d24
Fix regression due to 914ada1c74.
2019-04-09 09:47:11 +08:00
f5ac01253a
FIX: use new changed method name and remove whitespaces
2019-04-09 02:25:26 +05:30
bc949cf684
FIX: Display the username instead of {{username}}
2019-04-08 16:46:05 -04:00
32a0346069
UX: Don't show the username of the first user in the conversation
2019-04-08 16:39:53 -04:00
914ada1c74
DEV: convert scheduled job EnsurePostUploadsExistence into a rake task
2019-04-09 02:07:35 +05:30
cc53f902c6
FIX: Missing translation key for Reviewable -> Deleted
2019-04-08 16:12:41 -04:00
0fc798c2ef
UX: Show the score status
...
If a review review score has been Approved/Rejected/Ignored then show it
2019-04-08 12:08:18 -04:00
5957991340
FIX: Remove quoted post text and block realtime replies from ignored users ( #7336 )
2019-04-08 17:44:42 +02:00
02394e9170
FIX: assign `decoratorHelper` ( #7338 )
2019-04-08 16:17:09 +01:00
9d2e2867cc
s/fa-icon/d-icon ( #7337 )
2019-04-08 15:51:38 +02:00
0d2a1fce51
REFACTOR: Pass down `currentUser` to `post-cooked` widget ( #7333 )
...
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
2019-04-08 14:50:53 +01:00
2ae87a27fa
make rubocop happy
2019-04-08 17:03:26 +05:30
f0f3deb32b
PERF: Simplify query of `UserStat#update_topic_reply_count`.
...
For a user with alot of posts, we get a 25% speed up.
2019-04-08 17:48:19 +08:00
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 ( #7310 )
...
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0
- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632
For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
108c231d1c
FIX: Clean up `topic_search_data` of trashed topics.
...
This keeps the index and table smaller.
2019-04-08 16:53:39 +08:00
c4997ce85f
FIX: Don't try and reindex posts that have been trashed.
2019-04-08 16:38:43 +08:00
ca57e18f42
UX: display signup cta even if 'must_approve_users' setting enabled.
2019-04-08 12:27:56 +05:30
33fa249fa5
SECURITY: Remove XSS in composer preview when applying image scale buttons.
2019-04-08 11:22:14 +08:00
6525613b89
PERF: Use joins for `Post.for_mailing_list` instead of `NOT IN`.
...
Joining on the topics table and then filtering the topics against a large set of
ids is so much slower than doing a join on a sub query.
2019-04-06 07:58:55 +08:00
84eb9bc1c9
UX: Only highlight close icon on hover, not lock
2019-04-05 17:43:14 -04:00
a1c2181232
UX: Better close button positioning in alerts, some cleanup
2019-04-05 16:21:16 -04:00
a6f283da30
UX: Show tags on flags too
2019-04-05 14:22:45 -04:00
06e3b25d04
FIX: 'currentUser' is a property of the 'widget'
2019-04-05 18:43:04 +02:00
b005a84530
FIX: `decoratorHelper.widget` is not always present
2019-04-05 12:07:24 -04:00
acce7330a3
Typo fix
2019-04-05 11:23:22 -04:00
43a905279f
FIX: Layout was off in single-page user-preferences
2019-04-05 10:59:52 -04:00
cbc311e4ed
UX: Update the reviewable count before the message bus
...
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.
This patch synchronizes the review count every time:
1. The user visits the "Needs Review" page
2. Every time the user performs an action
2019-04-05 10:35:38 -04:00
19a1d35f66
fix linting ( #7329 )
2019-04-05 15:28:41 +01:00
131eba0366
FIX: Hide post replies content for ignored users ( #7320 )
2019-04-05 16:13:36 +02:00
ca33d091b3
FIX: don't trigger notifications when changing category/tags of unlisted topics ( #7323 )
2019-04-05 15:06:38 +02:00
a7a5f90e20
Annotate models.
2019-04-05 17:13:12 +08:00
0bd480c600
UX: displays exact date on title attribute of topic timer info ( #7326 )
2019-04-05 09:44:10 +02:00
9b288613ae
DEV: remove span from inside <tr> and move meta info to a td ( #7324 )
2019-04-05 09:32:11 +02:00
6f1652bb53
add header cloak after all panels are added ( #7325 )
2019-04-04 22:54:05 -07:00
81a1bafe54
PERF: Speed up home page unread+new query
...
restructure query so it avoids ORs
It appears postgres is picking suboptimal indexes if too many ORs exist
despite how trivial the condition is.
This bypasses conditional in the query and evals them upfront.
On meta for my user this made a 10x perf difference.
This boils down to either having `OR u.admin` or not having `OR u.admin` in
the query.
2019-04-05 15:25:19 +11:00
5b837f620b
correct unread resetting to handle nulls
...
Note, to avoid race conditions we are setting last_unread to 10 minutes ago
if there is nothing unread.
This is safer in case of in progress transactions
we don't want to lose unread for any window of time.
2019-04-05 13:42:41 +11:00
5f896ae8f7
PERF: Keep track of when a users first unread is
...
This optimisation avoids large scans joining the topics table with the
topic_users table.
Previously when a user carried a lot of read state we would have to join
the entire read state with the topics table. This operation would slow down
home page and every topic page. The more read state you accumulated the
larger the impact.
The optimisation helps people who clean up unread, however if you carry
unread from years ago it will only have minimal impact.
2019-04-05 12:44:45 +11:00
c9ddc6ce30
FIX: Make sure the site setting works and fix build
2019-04-04 17:44:10 -04:00
aa4a38b08a
FIX: computed is not used
2019-04-04 17:38:27 -04:00
8af7237092
FIX: Only perform logic on `create` commits
2019-04-04 17:01:47 -04:00
2c7a50860f
DEV: disable missing post uploads check by default.
2019-04-05 02:29:10 +05:30
83996fc8ea
FEATURE: ability to restrict some tags to a category while allowing all others
...
A new checkbox has been added to the Tags tab of the category settings modal
which is used when some tags and/or tag groups are restricted to the category,
and all other unrestricted tags should also be allowed.
Default is the same as the previous behaviour: only allow the specified set of
tags and tag groups in the category.
2019-04-04 16:40:15 -04:00
9faebfcfe0
UX: Adjust layout, allow additional responsiveness
2019-04-04 16:20:25 -04:00
df48c657fd
FIX: Reviewable counts were not updating properly
...
Sometimes sidekiq is so fast that it starts jobs before transactions
have comitted. This patch moves the message bus stuff until after things
have comitted.
2019-04-04 16:07:34 -04:00
2055804e95
FIX: The option to delete replies was missing from the new review queue
2019-04-04 15:51:36 -04:00
dd5b8bd85e
FIX: Show replies to the post, not the topic
...
This makes more sense when reviewing. How many people replied to this
objectionable thing?
2019-04-04 15:13:59 -04:00
9c8cc73c39
UX: Show user fields when reviewing a user
2019-04-04 14:45:40 -04:00
a385f6c48a
REFACTOR: create custom field even when missing post uploads not found
2019-04-04 21:49:44 +05:30
44e87372da
FEATURE: Add scheduled job to ensure s3 uploads existence
2019-04-04 20:37:44 +05:30
a5182b0d6c
FIX: Rewrite old `/admin/flags` links to use the review queue
...
Such links might be in present in old PMs. For example, a notification of
outstanding flags.
New PMs should receive the correct link but this prevents 404s in the
other case.
2019-04-04 10:15:23 -04:00
90fc2d15c4
FEATURE: change layout when default page is category to tabular for _… ( #7270 )
2019-04-04 15:57:18 +02:00
f87b35e6f4
FIX: do not raise exception if the file is missing
2019-04-04 15:36:51 +05:30
63fcd445f4
FIX: Use unfiltered URL when viewing all badges.
2019-04-04 12:35:03 +03:00
b0053f3a1c
FEATURE: bump onebox version, add styling for new reddit image onebox
2019-04-04 11:24:30 +02:00
6815f777f9
DEV: Remove unused method.
2019-04-04 14:19:39 +08:00
588f61f717
FIX: Linting
2019-04-03 18:08:07 -04:00
a4ff593506
UX: Slightly improved reviewable user display, plus link to admin if possible
2019-04-03 17:07:48 -04:00
3b581de3b8
remove unrelated code
...
already added in a separate job
2019-04-04 02:26:28 +05:30
b3fb0a7039
FEATURE: ensure consistency of post uploads in cooked content
2019-04-04 02:23:28 +05:30
14952a9cbc
UX: Reduce specificity of reviewable item styles
2019-04-03 16:49:57 -04:00
111a502231
FIX: Deleting Users should work nicely with Reviewable Users
...
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.
Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
2019-04-03 16:42:39 -04:00
88a46981a8
UX: Remove extra border on old mobile post notices
2019-04-03 16:10:54 -04:00
828cdf3fea
FIX: Protected method called, I'll fire myself now
2019-04-03 16:10:36 -04:00
82bddcbe51
FIX: Don't create two reviewable scores for a user
2019-04-03 16:03:32 -04:00
c1ea63bdc1
FIX: Reviewables should not be created for users until they are active
...
Conversely, if a user is deactivated the reviewable should automatically
be rejected.
Before this fix, if a user was not active they'd still show in the
review queue but without an "Approve" button which was confusing.
2019-04-03 15:25:00 -04:00
974007a3cc
FIX: reverts href removal from user/group cards links ( #7318 )
2019-04-03 19:16:48 +02:00
1bce97a596
FIX: Allow queued posts from deleted users to be rejected
2019-04-03 11:40:46 -04:00
bb2005d466
FIX: Add more links to bandge cards.
2019-04-03 18:37:11 +03:00
62956003c3
FEATURE: Allow users to customize bonuses for reviewable types
...
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
da2f659635
UX: Improve posts layout for crawler ( #7286 )
2019-04-03 11:58:00 +02:00
1e1adb1afa
FIX: Links in badge summary were not clickable. ( #7303 )
2019-04-03 11:35:27 +02:00
d32aaf374e
UX: add awaiting-approval class to login modal
...
when local logins are disabled and account is awaiting approval
2019-04-03 11:30:43 +02:00
7b194743d7
FIX: clean up user export csv upload records in scheduled job ( #7309 )
2019-04-03 13:31:19 +05:30
d1fa2b71cf
FIX: Letters between words incorrectly highlighted within post.
2019-04-03 15:57:51 +08:00
b2dc65f953
FIX: on rebakes should not recreate quoted_posts records
...
Previously every rebake would remove and recreate records in this table
This caused created_at and updated_at to keep changing
Yes, I know the SQL is somewhat complex, but this makes quote extraction
more efficient cause we do everything in 2 round trips.
This also removes some concurrency protection we should no longer need
2019-04-03 16:17:15 +11:00
52c4711e80
DEV: Fix method that was incorrectly made private.
2019-04-03 12:37:50 +08:00
4037a2fd0b
FIX: Restrict scope of old scheme upload migration.
...
Some sites have external URLs that don't even match `%/uploads/%' and
some sites surprise me with URLs that contains the default path when it
is a site in a multisite cluster. We can't do anything about those.
2019-04-03 11:56:41 +08:00
d151425353
PERF: Delete search data of posts from trashed topics periodically. ( #7302 )
...
This keeps both the index and table smaller.
2019-04-03 10:10:41 +08:00
feb731bffd
FIX: Regenerate optimized images instead of migrating from old scheme.
...
`OptimizedImage.migrate_to_new_scheme` was optimizing optimized images
which we don't need to do. Regnerating the optimized image is way easier.
2019-04-03 09:45:02 +08:00
c3047a903d
UX: Reviewable spacing adjustments
2019-04-02 17:22:22 -04:00
14cbbc5e13
UX: Reviewables fixes
2019-04-02 16:25:53 -04:00
44fe2eec03
Better fix for Safari user card position
...
Better than a2c6683e3b
2019-04-02 15:36:47 -04:00
ba727b2875
UX: Restructure queued posts to match flags, fix text
2019-04-02 14:54:55 -04:00
2ab6eb58c5
UX: Reviewable layout improvements
2019-04-02 13:51:03 -04:00
15e27d9e2c
Prettier fix
2019-04-02 11:56:21 -04:00
40e1ba9d9a
FIX: ensures click on emoji in picker doesnt propagate ( #7308 )
2019-04-02 17:40:13 +02:00
d8dd130477
UX: gives aria-label to topics count in category-row ( #7307 )
2019-04-02 17:38:21 +02:00
e77b1cf7ff
UX: ensures only <li> are used as top level in breadcrumb ( #7306 )
2019-04-02 17:37:53 +02:00
c185109380
FIX: Restricted site text better error
2019-04-02 11:16:27 -04:00
a2c6683e3b
FIX: inconsistent user card position in Safari
...
User cards triggered in header were incorrectly positioned in Safari desktop.
Using `position()` instead of `offset()` is more consistent, since header is a fixed element in this scenario.
2019-04-02 10:32:50 -04:00
af04318aff
FIX: Allow us to serialize reviewables with deleted topics
2019-04-02 09:36:49 -04:00
02d8931425
UX: more compact local-dates preview ( #7305 )
2019-04-02 14:39:20 +02:00
d68d29f37a
FIX: only staff can banner topics
2019-04-02 12:46:55 +05:30
d85240335b
Annotate models.
2019-04-02 13:19:14 +08:00
a9a35d2c19
FIX: Uncategorized pm not allowing edit ( #7276 )
2019-04-02 12:54:53 +08:00
Arpit Jalan
Guo Xiang Tan
Vinoth Kannan
Joffrey JAFFEUX
Maja Komel
David Taylor
Robin Ward
Bianca Nenciu
Blake Erickson
Roman Rizzi
Saurabh Patel
Penar Musaraj
Bianca Nenciu
Joe
Sam Saffron
Régis Hanol
Dan Ungureanu
Tim Lange
Rafael dos Santos Silva
Neil Lalonde
Gerhard Schlager
Tim Lange
Tarek Khalil
Kris
Chris Butler
Michał Frąckiewicz
Dannii Willis
Joe
James Haggerty
Angus McLeod
Guo Xiang Tan