Commit Graph

8771 Commits

Author SHA1 Message Date
Régis Hanol 85d4d3223c FIX: crop avatars on the server instead of the client
FIX: support for dots in S3 bucket names
2015-05-26 15:54:25 +02:00
Arpit Jalan d21944a0b6 FIX: add missing translation keys 2015-05-26 19:11:37 +05:30
Paul Kaplan bbe200e3cf Fix missing bracket in name selector in url anchor jumping 2015-05-26 07:49:45 -05:00
Régis Hanol 033c2e7140 FIX: respect the allow_animated_avatars site setting 2015-05-26 12:22:02 +02:00
Régis Hanol a797f7c664 FIX: properly handle images when using 's3_cdn_url' 2015-05-26 11:47:33 +02:00
Sam 147ea002f7 FIX: allow handling for avatars that are not in the set of "resized sizes" 2015-05-26 15:41:50 +10:00
Sam eeda367e70 FIX: should be able to serve optimized image from local if its ... local... 2015-05-26 12:32:52 +10:00
Neil Lalonde b9c7e3b74a FIX: categories page counts were very wrong for categories with sub-categories 2015-05-25 17:42:16 -04:00
Neil Lalonde eaa1afeaf5 remove Google OpenID auth, since Google doesn't support it anymore 2015-05-25 15:13:44 -04:00
Robin Ward 3437513025 FIX: Back button mobile from user activity stream 2015-05-25 13:40:46 -04:00
Robin Ward ee129edf25 FIX: mentions were not working in PMs 2015-05-25 13:15:00 -04:00
Robin Ward 78abf85087 FIX: IE9 issues with latest discourse 2015-05-25 12:32:42 -04:00
Régis Hanol bb0c2813ac FEATURE: generate (avatar) thumbnails in a background task
FIX: keep the "uploading..." indicator until the server replies via the MessageBus
FIX: text was disapearing when uploading an avatar

PERF: always use a region for S3 (defaults to 'us-east-1')
FEATURE: ApplyCDN middleware when using S3
FIX: use the same pattern to store files on S3 and locally
PERF: keep a local cache of uploads when generating thumbnails
FEATURE: migrate_to_s3 rake task
2015-05-25 17:59:00 +02:00
Erick Guan 54adf72582 FIX: rare user card exception
- trigger the shown logic in user card view
- some tweaks to user card show logic
2015-05-25 22:37:00 +08:00
Erick Guan 5ad878ca40 FIX: add missing username properties to usercard 2015-05-25 01:32:11 +08:00
Jeff Atwood 815e17b17b missed a spot for lightened onebox colors 2015-05-24 03:45:30 -07:00
Sam bcaed90744 fix missing rtl stylesheets 2015-05-23 15:25:05 +10:00
Jeff Atwood 2f850510d7 fix cat page alignment for new/unread badges 2015-05-22 16:14:47 -07:00
Jeff Atwood 025d310c9c lighten onebox backgrounds 2015-05-22 15:05:46 -07:00
Jeff Atwood a2b76a670f reduce darkness of @name mentions in quotes 2015-05-22 14:40:39 -07:00
Jeff Atwood 2bd0fcb9fd UX: use lighter grey for code blocks too 2015-05-22 13:49:40 -07:00
Régis Hanol 41cd438f0b FIX: 'clean up uploads' job
Only 1 query was needed.
2015-05-22 20:28:52 +02:00
Jeff Atwood 8a63596cbd use arrows glyph instead of "vs" in compare dialog 2015-05-22 03:03:04 -07:00
Jeff Atwood 4b1eaa567e add missing .title bgcolor 2015-05-22 02:31:27 -07:00
Jeff Atwood 42a8e742f8 UX: switch to lighter grey for all quotes 2015-05-22 02:11:18 -07:00
Jeff Atwood 9e74f232e0 clean up topic summary / map CSS a bit 2015-05-22 01:28:34 -07:00
Jeff Atwood 83e404fce9 fix btn alignment in "post on which topic?" dialog 2015-05-22 01:08:31 -07:00
Sam fe46d1dd3b PERF: avoid cookies for all static, public, cached forever assets 2015-05-22 16:15:46 +10:00
Sam ada7b4a4e8 FIX: guard against concurrent loading of deferred assets 2015-05-22 15:07:04 +10:00
Sam 96dbeb8608 fix stylesheet cache to recover if file is on disk 2015-05-22 11:22:12 +10:00
Jeff Atwood b12eaf39c0 slightly lighter topic map 2015-05-21 17:03:18 -07:00
Jeff Atwood f5c9246168 try topic map borders 2015-05-21 16:40:39 -07:00
Jeff Atwood 664add01f9 try lighter topic map background 2015-05-21 16:18:41 -07:00
Jeff Atwood e7fc5abe5b UX: larger numbers for topic summary, 2015-05-21 15:54:38 -07:00
Jeff Atwood ffc6a206e6 UX: add headings to topic summary 2015-05-21 15:30:10 -07:00
Robin Ward b0238dc0ce Some vars are consts 2015-05-21 16:16:27 -04:00
Robin Ward 381784ea62 FIX: Display proper error on badge create 2015-05-21 16:06:21 -04:00
Neil Lalonde 91588bed8b FIX: some admin actions redirect to wrong path when deployed to subdirectory 2015-05-21 15:03:00 -04:00
Robin Ward 1a4a2f5fc0 FIX: Group validation errors were not being displayed 2015-05-21 14:57:45 -04:00
Robin Ward 0ed1c8011c FIX: About page error when `login_required` 2015-05-21 14:37:49 -04:00
Régis Hanol 358f5cacf9 Merge pull request #3495 from techAPJ/patch-2
FIX: send category-id if present when deleting category
2015-05-21 11:00:16 +02:00
Régis Hanol 664d2e11d7 Merge pull request #3494 from fantasticfears/esc-user-card
FIX: press ESC can close user card
2015-05-21 10:58:26 +02:00
Sam a0090a4585 fix incorrect handling of date on "globally enabled" stylesheet. 2015-05-21 17:23:54 +10:00
Sam 44fc8e42dc nginx is stripping ETags, just use last modified instead 2015-05-21 17:05:22 +10:00
Sam 4fbfc6ddbc PERF: missing caching on CSS and Site Customizations 2015-05-21 16:09:23 +10:00
Erick Guan 7d8cf2eb3d FIX: press ESC can close user card 2015-05-21 13:54:34 +08:00
Arpit Jalan 836c7b4251 FIX: send category-id if present when deleting category 2015-05-21 11:15:08 +05:30
Régis Hanol b7f8680618 fix build (:fired:) 2015-05-20 17:51:33 +02:00
Régis Hanol bcd98c8f0f FIX: API can provide a URL to create an upload 2015-05-20 17:38:06 +02:00
Régis Hanol c91634c09a FIX: support for async uploads of emojis 2015-05-20 16:45:48 +02:00
Régis Hanol 566b267981 FIX: cropAvatar 2015-05-20 16:45:48 +02:00
Régis Hanol 8d967d9065 FEATURE: move all uploads to a single endpoint + defer upload creation in a background thread 2015-05-20 16:45:48 +02:00
Robin Ward 7d23826cee FIX: Keep around the page when redirecting 2015-05-20 10:16:17 -04:00
Régis Hanol 7d3b7a5657 fix the build 2015-05-20 15:32:31 +02:00
Régis Hanol b44488b618 FIX: keep to old attachment route 2015-05-20 14:55:42 +02:00
Jeff Atwood 0bd6d79459 finalize color scheme for mobile progress bar 2015-05-20 01:25:36 -07:00
Jeff Atwood 643f770996 add new color scheme to mobile progress bar 2015-05-20 01:07:16 -07:00
Jeff Atwood d7692ba6fd add width and style to mobile category borders 2015-05-20 00:46:37 -07:00
Sam e5888cf090 PERF: avoid preloading json in cases where it is not needed
(uploads / avatars / non GET requests)
2015-05-20 17:12:16 +10:00
Sam 45bdd23689 FEATURE: support user local switching to RTL correctly
FEATURE: support RTL in multisite
2015-05-20 15:56:54 +10:00
Sam 8013b6a511 FIX: clean html before sending it to jquery for collapsing 2015-05-20 14:42:54 +10:00
Sam 14ab9c45b6 Merge pull request #3470 from ahuling13/expired-nonce-return-status
In the case of an expired nonce, return a 400 status code instead of 500
2015-05-20 12:08:17 +10:00
Sam d1d703718a Merge pull request #3476 from paulkaplan/sso-distrust-email
Add SSO setting to not trust emails automatically
2015-05-20 12:07:14 +10:00
riking d112f39031 Change extension back to .dcstyle.json 2015-05-19 18:35:16 -07:00
awesomerobot 0ba88d2355 changing color of progress bar 2015-05-19 21:19:28 -04:00
Sam bd63699d63 FIX: rescue even more errors in case avatar has issues downloading 2015-05-20 10:43:53 +10:00
Jeff Atwood cf90550cf1 remove tiger striping from category page 2015-05-19 16:48:27 -07:00
Jeff Atwood c29fce142a remove tiger striping from mobile categories page 2015-05-19 16:28:01 -07:00
Jeff Atwood 7c5c4166db fix mobile issue with alternate login button 2015-05-19 16:23:26 -07:00
Robin Ward 4c373be190 FIX: Broken link on admin dashboard 2015-05-19 13:13:31 -04:00
Andrew Huling e44ddff9bb Change the expired nonce return status code from 400 to 419. 2015-05-19 13:13:14 -04:00
Robin Ward 20cd5b8c0b FIX: Don't reset scrolling when subcategory_list is enabled 2015-05-19 12:56:04 -04:00
Robin Ward 0a35b20933 Convert `Discourse.ScrollTop` to ES6 2015-05-19 12:51:03 -04:00
Robin Ward 8f0cd18d4b Only show delete user button on post approvals for TL0 2015-05-19 12:19:25 -04:00
Paul Kaplan 1c34341f31 Replace site setting with a payload attribute 2015-05-19 11:16:02 -05:00
Robin Ward f496982e79 UX: Always show reply as new topic if the user can. 2015-05-19 12:13:30 -04:00
Robin Ward 1f95ef31cc Remove deprecations in TopicProgressController 2015-05-19 12:10:18 -04:00
Robin Ward c18bc59808 Increase limit on user fields 2015-05-19 11:34:54 -04:00
Neil Lalonde e5fd50aa1e FIX: delete my own account button was always disabled 2015-05-19 11:23:04 -04:00
Robin Ward 4e0d7683ab Better error messages on admin for granting moderation
Also fixes up Ember deprecations.
2015-05-19 10:56:32 -04:00
Régis Hanol 9ded21e4c6 FIX: consistent and future-proof upload storage pattern 2015-05-19 12:31:12 +02:00
Arpit Jalan c2510e610d UX: fix blockquote in firefox 2015-05-19 15:10:19 +05:30
Sam 15a59dcde7 EXTENSIBILITY: topic-after-cooked plugin outlet 2015-05-19 15:34:54 +10:00
Sam 8002c46c21 FEATURE: g b to take you to your bookmarks 2015-05-19 15:34:16 +10:00
Sam f26fef4340 silence ar not found 2015-05-19 09:32:27 +10:00
Erick Guan 4ac40145d8 user card animation when there is an active user card 2015-05-19 00:19:06 +08:00
Régis Hanol 3f7d693786 Merge pull request #3454 from fantasticfears/group-page
FIX: show user card on group page and fix styles
2015-05-18 14:28:43 +02:00
Régis Hanol b2f50c154a Merge pull request #3486 from techAPJ/patch-2
FIX: handle user export failure when post is not linked to a topic
2015-05-18 09:21:58 +02:00
Arpit Jalan c5a57a9f94 UX: add space between location icon and text 2015-05-18 12:13:42 +05:30
Arpit Jalan b3314ea801 FIX: handle user export failure when post is not linked to a topic 2015-05-18 09:07:12 +05:30
Erick Guan 3be1098cc5 FIX: also inline category badge styles to digest email 2015-05-18 00:45:26 +08:00
Régis Hanol ac74f2a1d3 Merge pull request #3483 from techAPJ/patch-1
FIX: show meaningful error message in case of site setting error
2015-05-17 11:11:13 +02:00
Arpit Jalan ac13238127 UX: do not show last post label in user card if user never posted 2015-05-17 14:37:26 +05:30
Arpit Jalan e287046d32 FIX: show meaningful error message in case of site setting error 2015-05-17 14:15:27 +05:30
riking d0b61ed23e Filter files to only plain-text 2015-05-16 21:19:00 -07:00
riking 30abc91a5c this just in: drag events are very broken 2015-05-16 21:04:57 -07:00
riking fbc06d044f Use .dcstylejson instead of .dcstyle.json 2015-05-16 20:41:35 -07:00
riking 291d9fc65e FEATURE: Import customizations from a JSON file 2015-05-16 20:24:19 -07:00
riking 1e53c179a3 FEATURE: Export customizations as JSON files 2015-05-16 20:24:13 -07:00
Arpit Jalan 896ea8e177 FIX: trim leading/trailing spaces from invite email 2015-05-16 15:21:31 +05:30
Ryan Fox 14d2b76354 Merge branch 'master' into fix-by-external
Conflicts:
	app/controllers/users_controller.rb
2015-05-15 19:54:11 -04:00
Paul Kaplan b8a43e153c Use session controller to prevent inactive SSO users 2015-05-15 12:15:06 -05:00
Paul Kaplan 4c26c4d9bc Add a SiteSetting to not trust sso emails by default 2015-05-15 12:15:06 -05:00
Robin Ward 94ca9ed11f FIX: Rate limits weren't being showing for action summary errors 2015-05-15 12:16:05 -04:00
Robin Ward 5148c48170 FIX: Image uploading component was missing a class 2015-05-15 11:12:41 -04:00
Robin Ward 0362c50698 Remove deprecations from edit-category and add skeleton acceptance test 2015-05-15 11:12:41 -04:00
Régis Hanol 764f9b42fe Merge pull request #3458 from Qasem-h/Bosnian
Add Bosnian langage for discourse
2015-05-15 14:34:16 +02:00
Régis Hanol 93273cd17a Merge pull request #3451 from ossobv/sso_login_unapproved_account
Stop sso login processing after rendering error
2015-05-15 14:33:19 +02:00
Régis Hanol d40d308e45 Merge pull request #3445 from lukegb/bug/anonymous-emails
Don't send emails to anonymous users
2015-05-15 14:28:37 +02:00
Régis Hanol d4974b7093 FIX: anonymous mode don't work when names are required 2015-05-15 14:20:15 +02:00
Régis Hanol 48f4fe7e7a Merge pull request #3473 from binaryage/hipchat-plugin
Add missing events for discourse-hipchat-plugin
2015-05-15 14:10:05 +02:00
Régis Hanol 0d5fdd25c9 Merge pull request #3474 from Qasem-h/Css
fix emoji autocomplete in RTL
2015-05-15 14:08:45 +02:00
Qasem Hajizadeh 1b7c616159 Update rtl.scss 2015-05-15 14:33:00 +04:30
Antonin Hildebrand 11852056a8 Add missing events for discourse-hipchat-plugin
https://github.com/binaryage/discourse-hipchat-plugin
2015-05-15 15:52:12 +08:00
Sam fdbcc31a9c Merge pull request #3461 from fantasticfears/slug
FIX: category custom slug can't be set when generation method is none
2015-05-15 14:59:35 +10:00
Sam 36ee85f3bc Merge pull request #3462 from fantasticfears/category-badge
FIX: ensure not found page's category badge consistent with style
2015-05-15 14:58:15 +10:00
Sam 2955507a57 FEATURE: badges for inviting users
First invite = Promoter
3 TL2 = Campaigner
10 TL3 = Champion
2015-05-15 12:04:41 +10:00
Robin Ward 8e395a94d4 FIX: Modal asking where to post was missing 2015-05-14 18:18:28 -04:00
Andrew Huling e1d2ecef10 In the case of an expired nonce, return a 400 status code instead of a 500.
500 status codes are for unexpected server-side error scenarios. When an expired nonce is used by the client, a 4XX-level error is more appropriate because the client has submitted a bad request (by using an expired nonce). A 500 also causes Internet Explorer to show its default 500 page which does not show the error message and leads to a bad end user experience. I am choosing 400 for the new status rather than 401 or 403 because 401 requires a WWW-Authenticate header which would be difficult to generate in an SSO scenario and a 403 implies that no re-authentication will address the failure.
2015-05-14 16:03:02 -04:00
Neil Lalonde 4451c8802a FIX: post gutter links are broken when using a subfolder 2015-05-14 14:26:18 -04:00
Robin Ward 32606f82f6 FIX: `replaceWith` on leaf routes changed behavior in latest ember 2015-05-14 13:44:57 -04:00
Robin Ward f1b9a389d9 Merge pull request #3468 from fantasticfears/fix-dashboard
FIX: unhandle show report action
2015-05-14 13:19:40 -04:00
Erick Guan 2c09e97ca0 FIX: unhandle show report action 2015-05-15 00:59:31 +08:00
Robin Ward 6a3086843d OOPS, left debugging stuff in last push. 2015-05-14 12:48:12 -04:00
Robin Ward cd27ba3478 FIX: Properly add no-conflict to ace editor 2015-05-14 12:46:51 -04:00
Arpit Jalan 750a275dcb FIX: user archive export was failing in some cases 2015-05-14 20:35:25 +05:30
Régis Hanol 0b62730382 Merge pull request #3465 from riking/patch-2
FEATURE: Multiple notifications at once (1/topic)
2015-05-14 10:05:48 +02:00
Sam 4a48f983fd PERF: hit all index conditions to speed up anon ip tracking 2015-05-14 17:21:02 +10:00
Sam e074651fdc PERF: refactor user search so works more efficiently
Stop scanning entire user table
2015-05-14 14:38:47 +10:00
Sam e6f73a1c80 PERF: optimise front page category security lookup query 2015-05-14 12:19:22 +10:00
riking 28f32aff66 FEATURE: Multiple notifications at once (1/topic) 2015-05-13 18:23:42 -07:00
Régis Hanol 82cc467d93 FIX: move to new/another topic 2015-05-13 23:42:45 +02:00
Robin Ward 8fa109638b FIX: Double load if left a topic and came back into it. 2015-05-13 16:54:06 -04:00
Robin Ward d90063fc59 FIX: Error with ace editor and new ember.
Fix upgrades ace editor, which was a huge headache due to AMD.
2015-05-13 16:25:33 -04:00
Robin Ward 29631f65f1 Include the template compiler in production mode.
Some people use this for customizations.
2015-05-13 12:23:11 -04:00
Robin Ward 882dc8132d FIX: Invalid HTML on plugins page 2015-05-13 12:13:25 -04:00
Neil Lalonde 76a95e4aaf FIX: profile background inputs always appear disabled 2015-05-13 11:27:54 -04:00
Robin Ward bbef5fb3c7 FIX: Ember deprecations on user preferences 2015-05-13 11:18:35 -04:00
Robin Ward ea51095ef9 Adds acceptance test for user preferences 2015-05-13 11:15:41 -04:00
Erick Guan 54ce66fc62 FIX: ensure not found category badge consistent with style 2015-05-13 19:30:19 +08:00
Régis Hanol d90e0fe66b Merge pull request #3460 from techAPJ/patch-3
FIX: rate limit topic invitations
2015-05-13 12:55:20 +02:00
Arpit Jalan 4324a157e0 FIX: rate limit topic invitations 2015-05-13 14:44:37 +05:30
Erick Guan 4c00eef8b5 FIX: category custom slug can't be set when generation method is none 2015-05-13 16:54:19 +08:00
Sam e81f122a3f EXTENSIBILITY: allow registration of custom post menu items 2015-05-13 16:46:17 +10:00
Jeff Atwood 08f87e837d minor topic list gridline tweak 2015-05-12 14:31:29 -07:00
Régis Hanol d7b3f9bfe2 FIX: properly handle errors when creating a topic 2015-05-12 22:02:06 +02:00
Robin Ward 5754bb3654 FIX: Load order of applyFlaggedProperties 2015-05-12 11:15:45 -04:00
Robin Ward 7a6aab24f1 Merge pull request #3453 from techAPJ/patch-1
UX: show lock icon in user stream if topic is closed/archived
2015-05-12 10:53:49 -04:00
Régis Hanol 6ae9bcab56 add DistributedMutex around uploads/optimized_images creation 2015-05-12 16:45:33 +02:00
Robin Ward 440331e36e FIX: Missing translations in reviewing users 2015-05-12 10:41:31 -04:00
Qasem Hajizadeh ac6e66e0b2 Create bs_BA.js.erb 2015-05-12 16:16:10 +04:30
Régis Hanol ff227eabe6 FIX: select posts 2015-05-12 12:54:28 +02:00
Régis Hanol ab80240900 FIX: Presence mixin was missing sometimes 2015-05-12 10:49:05 +02:00
Régis Hanol f4cb96ff9a FIX: add border-top on the first tr in topic-list 2015-05-12 09:26:35 +02:00
Sam 09075468d5 Merge pull request #3436 from YesThatAllen/patch-1
A red meh icon is less ambiguous than a red-smile
2015-05-12 14:06:46 +10:00
Jeff Atwood 6eec354f17 missed a } 2015-05-11 16:21:21 -07:00
Jeff Atwood ce1fe8c8c2 remove topic list striping, use bottom border 2015-05-11 16:09:46 -07:00
Sam 5ef641126f remove s3 deprecation warning, we will continue to support it 2015-05-12 08:27:25 +10:00
Robin Ward 6b299d4c81 FIX: User fields disappeared on user profile 2015-05-11 17:06:41 -04:00
Arpit Jalan 6b816f445d UX: show lock icon in user stream if topic is closed/archived 2015-05-11 23:09:53 +05:30
Erick Guan b7094c6f5d FIX: show user card on group page and fix styles 2015-05-12 01:24:17 +08:00
Robin Ward 0d51c1f0a0 FIX: List views in admin were broken 2015-05-11 13:17:12 -04:00
Robin Ward a74689932e FIX: Invalid HTMLBars for staff action logs 2015-05-11 13:17:12 -04:00
Robin Ward a7e6148d40 FIX: Some low activity users were being restricted from the directory. 2015-05-11 11:24:34 -04:00
Robin Ward 2933be69d5 FIX: Anonymous mode was broken 2015-05-11 11:20:47 -04:00
Robin Ward e9895d4de2 FIX: Deleted posts weren't red. 2015-05-11 11:20:47 -04:00
Robin Ward a93dfece70 FIX: Incorrect error message when post isn't long enough 2015-05-11 11:20:46 -04:00
Robin Ward 3830bb7d78 FIX: Flags weren't showing on the header 2015-05-11 11:20:46 -04:00
Robin Ward e1f9f6d02a UX: Improve user directory on mobile 2015-05-11 11:20:46 -04:00
Robin Ward fa69d4cec5 FIX: Missing `colspan` on raw topic list 2015-05-11 11:20:46 -04:00
Robin Ward 0a189a4e52 FIX: Message bus callback was pointed at the wrong object. 2015-05-11 11:20:46 -04:00
Robin Ward fd58bd570e FIX: Translation key was showing as undefined 2015-05-11 11:20:46 -04:00
Robin Ward d9e5302a16 FIX: HTMLBars compilation was broken in production mode 2015-05-11 11:20:46 -04:00
Robin Ward 098556c78d Assorted Ember 1.11 fixes 2015-05-11 11:20:45 -04:00
Robin Ward 2e4d43364a Server side quote templates don't seem to be used? 2015-05-11 11:20:45 -04:00
Robin Ward d34334ecbe Use HTMLBars API for inserting partials and views 2015-05-11 11:20:45 -04:00
Robin Ward 39a1444838 Fixes deprecations on various discovery routes 2015-05-11 11:20:45 -04:00
Robin Ward 0b65c88003 Upgrade Notifications to fix deprecations and use store 2015-05-11 11:20:45 -04:00
Robin Ward aab9706b7a Fixes deprecations on user routes 2015-05-11 11:20:45 -04:00
Robin Ward 72b6c86564 Fix banner breaking on reentry. 2015-05-11 11:18:38 -04:00
Robin Ward 82a4066993 HTMLBars support for `plugin-outlet` 2015-05-11 11:18:38 -04:00
Robin Ward df3c19705f Fix deprecations on SiteMap 2015-05-11 11:18:38 -04:00
Robin Ward c6d99bd141 Fixes routing in tests 2015-05-11 11:18:38 -04:00
Robin Ward ed398e65e0 Fixes issues with composer 2015-05-11 11:18:38 -04:00
Robin Ward 14fa033288 Update cloaking code for HTMLBars 2015-05-11 11:18:37 -04:00
Robin Ward aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
Robin Ward 690b579a96 Fixes some deprecations 2015-05-11 11:18:37 -04:00
Robin Ward 8294205f7c Ember 1.11 broken WIP 2015-05-11 11:18:37 -04:00
Robin Ward b3b4fd21ed Broken WIP 2015-05-11 11:18:37 -04:00
Harm Geerts d9a3e82516 Stop sso login processing after rendering error
This prevents a DoubleRenderError triggered on the redirect_to.
2015-05-11 14:17:32 +02:00
Régis Hanol 1b3f3fa437 Merge pull request #3450 from techAPJ/patch-3
FIX: reply count is off by one
2015-05-11 10:31:25 +02:00
Arpit Jalan fc30b771cf FIX: reply count is off by one 2015-05-11 13:58:53 +05:30
Régis Hanol 4c02be0fb0 Merge pull request #3447 from techAPJ/patch-1
FIX: rss feed should be valid
2015-05-11 10:27:24 +02:00
Régis Hanol 97cc1bf279 Merge pull request #3448 from techAPJ/patch-2
FEATURE: check nofollow setting when showing website
2015-05-11 10:26:07 +02:00
Sam 3d6cfc6421 fix typo 2015-05-11 18:05:18 +10:00
Qasem Hajizadeh 6bd15dd86d Add .rtl for css tags
Im added .rtl to front of tags @SamSaffron
2015-05-11 12:22:30 +04:30
Sam f180aba492 stop random hostname for anon 2015-05-11 17:48:54 +10:00
Arpit Jalan 8366b71176 FEATURE: check nofollow setting when showing website 2015-05-11 13:16:21 +05:30
Arpit Jalan 7a20ed0617 FIX: rss feed should be valid 2015-05-11 10:50:24 +05:30
Sam 2282869f30 fix rtl changing general styles 2015-05-11 12:12:37 +10:00
Luke Granger-Brown 9f9825bb6b FIX: don't send emails to anonymous users
Also changes behaviour of real to not return anonymous users.

This means user counts will no longer include them, and the
mailing list system will ignore them even if they somehow end up
with the feature turned on.
2015-05-11 00:56:34 +01:00
Qasem Hajizadeh b99c3c85aa Update rtl.scss 2015-05-09 18:26:00 +04:30
Jeff Atwood f355579e60 remove transparent outline on topic-progress-wrapper 2015-05-08 15:47:27 -07:00
Arpit Jalan 8b876a3c21 convert open-composer mixin to es6 2015-05-09 01:01:50 +05:30
Robin Ward 4b1145dbb0 Merge pull request #3434 from techAPJ/patch-1
FEATURE: support category/subcategory name in new-topic route
2015-05-08 14:14:20 -04:00
Arpit Jalan 6cc092d54c FEATURE: support category/subcategory name in new-topic route 2015-05-08 23:33:06 +05:30
Neil Lalonde 46606cd818 FIX: missing aria-label on X of share modal 2015-05-07 17:31:36 -04:00
Neil Lalonde ffeab82947 FIX: reset message field of flag form after submitting flag 2015-05-07 17:08:07 -04:00
Allen Hancock 53c85662c6 A red meh icon is less ambiguous than a red-smile
Builds on https://meta.discourse.org/t/why-a-frowny-face-on-admin-version/27895/
2015-05-07 13:44:27 -07:00
Sam b7897d24b1 keep working even if username is blank 2015-05-07 13:52:26 +10:00
Sam 4191d97d48 FIX: missing titles and aria-labels on sharing links 2015-05-07 12:14:12 +10:00
Sam 4f53b85ee2 add aria-label to composer buttons 2015-05-07 12:03:20 +10:00
Sam 0b3ad8a3fd Merge branch 'master' of github.com:discourse/discourse 2015-05-07 11:51:09 +10:00
Sam d676bbc349 handle invalid param gracefully 2015-05-07 11:06:42 +10:00
Sam 8277a586bb usage of raise corrected 2015-05-07 11:00:51 +10:00
Sam 77cc087b13 FIX: proper error message when account created is hit with no session 2015-05-07 11:00:22 +10:00
Régis Hanol 9a96cd9f3b CRUSHED: duplicate key value violates unique constraint 'index_uploads_on_sha1' 2015-05-07 01:00:13 +02:00
Régis Hanol 52c19d74f8 FIX: error when user name was nil 2015-05-06 23:56:34 +02:00
Régis Hanol 033761d2f6 FIX: reset all votes when the # of options changes 2015-05-06 18:52:09 +02:00
Robin Ward edae9d7ad9 FIX: Sometimes `contents` is nil, don't break in that case. 2015-05-06 12:40:24 -04:00
Neil Lalonde a0afaf6d48 tweak subcategories position on mobile categories page 2015-05-06 10:58:30 -04:00
Sam 8dd4aa145c FIX: don't fail if dupe timings are sent in 2015-05-06 17:33:03 +10:00
Sam cd9e499b77 Don't try loading embeds on deleted topics 2015-05-06 16:53:28 +10:00
Sam 46aa7dab80 FEATURE: add aria-label for accessibility 2015-05-06 15:33:50 +10:00
Sam bbd5452b8d Do not alert if we have no topic (eg topic deleted) 2015-05-06 13:25:23 +10:00
Sam c6fe90006e correcly grap name, omit needless query 2015-05-06 12:55:33 +10:00
Sam 376b28b0ed FIX: raise a 404 if click tracker gets no url 2015-05-06 11:27:41 +10:00
Sam 0bbf6354eb FIX: in some cases link was not followable due to click tracker 2015-05-06 11:22:53 +10:00
Sam 6fab03b777 do not alert on deleted posts 2015-05-06 10:44:45 +10:00
Sam 0f53fc8328 correct emergency regeneration in the controller 2015-05-06 07:33:32 +10:00
Sam 2625c3bb9a avoid work if nothing there 2015-05-06 07:12:38 +10:00
Neil Lalonde 72cb784eae UX: mobile categories page is more like desktop categories page 2015-05-05 12:04:18 -04:00
Sam ea670118c1 Add better error handling, correct the location on disk of stylesheet 2015-05-05 23:28:40 +10:00
Erick Guan a48dd1cc28 store the slug as the title is, only sanitize the slug
and prettify code
2015-05-05 18:33:16 +08:00
Erick Guan b772ff6e13 FEATURE: add slug geneartion options 2015-05-05 18:08:30 +08:00
Sam f58d85edea FEATURE: move stylesheet cache out of the uploads directory 2015-05-05 15:50:13 +10:00
Sam 8e372f3616 FEATURE: add op-bookmark class for op-bookmarks 2015-05-05 10:23:17 +10:00
Sam 66423e62dc FIX: don't strip / mangle full quotes 2015-05-05 10:06:48 +10:00
Michael Downey 41a0b16cc6 Fixing map-marker FontAwesome typo
The correct icon is map-marker, not map-maker.
2015-05-04 15:53:10 -04:00
Neil Lalonde 963ebf5963 FIX: if approving a user when must_approve_users is false, don't send an email 2015-05-04 15:30:25 -04:00
Robin Ward 4745eca4ad FIX: Don't abort PurgeInactive if they have posts. Just skip. 2015-05-04 11:37:49 -04:00
Régis Hanol e9ade9c0e1 Merge pull request #3428 from techAPJ/patch-2
UX: show caps lock warning on password reset page
2015-05-04 09:38:02 +02:00
Arpit Jalan f3687b6e56 UX: show caps lock warning on password reset page 2015-05-04 13:01:35 +05:30
Jeff Atwood 9a2d999d5a Merge pull request #3427 from techAPJ/patch-3
FIX: allow site_name to be present in rejection email subject
2015-05-03 23:23:54 -07:00
Sam 539ca73668 avoid N+1 query even if no custom fields exist 2015-05-04 16:12:03 +10:00
Arpit Jalan d9ec6888e1 FIX: allow site_name to be present in rejection email subject 2015-05-04 11:22:54 +05:30
Sam 4dfc1907ac Simplify desktop notifications, only include if mention/reply/pm/link
Include post excerpt in the notification
2015-05-04 13:49:32 +10:00
Sam 803feefd54 MessageBus handles readonly redis now, no need to wrap it 2015-05-04 12:21:00 +10:00
Sam 1c7fa956dc Improve Notification probing 2015-05-04 11:14:03 +10:00
Sam 5623827433 careful checking for a global that is not there 2015-05-04 11:08:52 +10:00
Sam fe34a6acbd Merge pull request #3420 from techAPJ/patch-2
FEATURE: accept category_id as new-topic param to better support subcategory
2015-05-04 10:13:06 +10:00
Sam 9723b77b6d Merge pull request #3422 from riking/notifications-patches
FIX: Don't ask for notification permission until first one
2015-05-04 10:10:23 +10:00
Jens Maier 23cde96a1b Fix: @mention dialect matches too often 2015-05-03 18:30:53 +02:00
riking 6ea2051c4e FIX: Don't ask for notification permission until first one 2015-05-02 12:53:30 -07:00
Jeff Atwood 83b7620cb2 use pencil glyph on edit history dialog 2015-05-02 03:48:37 -07:00
Jeff Atwood 2ead293098 Merge pull request #3419 from techAPJ/patch-1
FIX: include youtube link in embedded comments
2015-05-01 14:54:13 -07:00
Arpit Jalan 480cea7284 FEATURE: accept category_id as new-topic param to better support subcategory 2015-05-01 21:40:28 +05:30
Neil Lalonde 8521ee24b1 FIX: /password-reset route now works when login_required is enabled 2015-05-01 11:14:09 -04:00
Arpit Jalan 23fd16850a FIX: include youtube link in embedded comments 2015-05-01 18:34:45 +05:30
Jens Maier 1a692bee0c Apply fix against nested SUP tags to preview 2015-04-30 23:05:04 +02:00
Arpit Jalan bb99bd8a03 FIX: flagging topic was giving error message 2015-05-01 02:15:06 +05:30
Neil Lalonde 1b250f1e01 FIX: crawler pages and RSS had broken links for sites deployed to a subfolder with relative_url_root 2015-04-30 12:46:26 -04:00
Sam 9e16e03198 FIX: text was impossible to quote on Windows Phone 2015-04-30 15:43:39 +10:00
Robin Ward 16408cee06 Allow Postgres to trigger readonly mode for the site. 2015-04-29 11:49:58 -04:00
Sam d7d93c20d7 Merge pull request #3406 from techAPJ/patch-2
FEATURE: prefill topic title, body and category via URL
2015-04-29 13:46:26 +10:00
Neil Lalonde b2fd69a675 FIX: avatar_template when using relative_url_root 2015-04-28 20:58:46 -04:00
Robin Ward 3252bf1252 FIX: Desktop Notifications break Qunit tests
We should figure out why they can't run without the conditional in a
browser.
2015-04-28 19:24:32 -04:00
Robin Ward 15ea0c4789 Merge pull request #3304 from riking/desktop-notifications
Desktop notifications!
2015-04-28 16:24:02 -04:00
Robin Ward c2f7676370 Support for custom reasons for things being queued for approval 2015-04-28 15:06:47 -04:00
Arpit Jalan cff6e49eb7 FEATURE: prefill topic title, body and category via URL 2015-04-29 00:01:10 +05:30
Régis Hanol 5783e908ea FIX: Erratic behaviour when clicking an attachment link - Take 2 2015-04-28 20:05:41 +02:00
Robin Ward 1e36400021 FIX: Enter to change username was broken 2015-04-28 11:39:10 -04:00
Sam 4eaee8f611 Merge pull request #3377 from scossar/auto-rtl
Auto rtl
2015-04-28 07:58:35 +10:00
Sam 729aaa826b Merge pull request #3404 from techAPJ/patch-1
FEATURE: magic login route for admin when SSO is enabled
2015-04-28 07:47:50 +10:00
Régis Hanol ad3d2269b2 FIX: erratic behaviour when clicking an attachment link 2015-04-27 22:18:52 +02:00
Robin Ward 8c930c97e0 If there are pending posts in a topic, display a message at the bottom 2015-04-27 15:55:10 -04:00
Robin Ward ecafbb0a63 Can delete users via the moderation queue 2015-04-27 15:06:20 -04:00
Robin Ward 3cb4554bbb Can refresh queued posts via button 2015-04-27 13:52:54 -04:00
Neil Lalonde cce8693354 FIX: canonical link tag when using relative_url_root 2015-04-27 13:34:22 -04:00
Arpit Jalan 2932284293 FEATURE: magic login route for admin when SSO is enabled 2015-04-27 22:54:48 +05:30
Robin Ward 19a89bb501 Small hooks for Queued Post version of discourse-akismet 2015-04-27 11:56:07 -04:00
Régis Hanol 151dea4088 FIX: editing a poll/post with a poll wasn't working properly 2015-04-26 00:12:19 +02:00
Robin Ward 151b559e4c FIX: If you delete a user, delete their queued posts as well. 2015-04-24 16:04:44 -04:00
Robin Ward 15dbce5886 Show pending posts count in modal when your posts are enqueued 2015-04-24 15:44:59 -04:00
Robin Ward 3660fe4f60 FIX: When approving/rejecting a post it should delete the user action 2015-04-24 15:25:47 -04:00
Robin Ward 3a6efa25f0 Allow ReadOnly to propogate up to the Ember app via Response Header 2015-04-24 14:37:16 -04:00
Robin Ward 5b3f99aa50 Don't blow up if Redis switches to READONLY 2015-04-24 14:37:16 -04:00
Robin Ward eff921d1ec FIX: Turn that frown upside down! 2015-04-24 11:14:06 -04:00
Robin Ward 2562b61448 `normalize_name` is a better name for this. 2015-04-24 10:35:18 -04:00
Régis Hanol be5a76fbc8 Merge pull request #3394 from scossar/fix-height-on-onebox-image
Fix: size on onebox-avatar
2015-04-24 11:18:26 +02:00
Régis Hanol 80b2935e11 FIX: prevent DOS when fixing avatar in quotes 2015-04-24 11:14:10 +02:00
Simon Cossar def9740d5d Fix size on onebox-avatar 2015-04-23 20:42:27 -07:00
riking 21b915f209 Suggested changes 2015-04-23 18:39:48 -07:00
Neil Lalonde ae028a5bb1 FIX: support for redirects to external url in permalinks table was broken 2015-04-23 16:45:28 -04:00
Robin Ward e17ea2e787 UX: Show a dash if a version string is missing 2015-04-23 14:50:37 -04:00
Régis Hanol a737090442 - FEATURE: revamped poll plugin
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
Robin Ward 9bce812c8f Merge pull request #3388 from Mooash/Adding_ViewActions
Adding ViewAction into email notifications
2015-04-23 10:18:57 -04:00
Will Jordan bbfa5c7df1 Fix `NoMethodError` in TopicEmbed#find_remote
Stop TopicEmbed#find_remote from generating `NoMethodError: undefined method `empty?' for nil:NilClass` exceptions
2015-04-22 16:52:02 -07:00
Mooash b65313d3b9 Adding ViewAction into email notifications
See: https://meta.discourse.org/t/integrate-viewactions-one-click-actions-schemas-into-discourse-emails/27056
2015-04-23 08:40:22 +10:00
Robin Ward 388f51eed7 FIX: Bring email username logic in line with front end 2015-04-22 16:26:57 -04:00
Robin Ward 5c7d6e0a3c FIX: Don't display names on emails if `display_name_on_posts` is false
Note that `enable_names` was always respected.
2015-04-22 16:15:23 -04:00
Robin Ward 839416212e FIX: Category badge was showing before topic loaded 2015-04-22 13:39:04 -04:00
Robin Ward 56cd381ff8 FIX: Loading more was broken on topic list after changing sort order 2015-04-22 12:52:12 -04:00
Robin Ward 53ca51654d FIX: Avoid cookie overflows by truncating the referer we store in flash 2015-04-22 12:41:49 -04:00
Neil Lalonde 85320f919b FEATURE: user list csv includes approved, suspended_at, suspended_till, blocked 2015-04-22 12:40:12 -04:00
Robin Ward afc12da2f9 Merge pull request #3387 from riking/fix-uploaded-onebox
FIX: Local files never oneboxed, onebox requests cache-busted
2015-04-22 10:37:09 -04:00
Sam Saffron 40b22bf367 PERF: improve performance for featured user calculation 2015-04-22 23:54:54 +10:00
riking 3681674ec4 FIX: Don't cache-bust onebox requests 2015-04-21 23:11:25 -07:00
riking a616d9ed1c Fix jshint 2 2015-04-21 21:23:05 -07:00
riking f5630b9791 Fix JSHint errors 2015-04-21 21:10:07 -07:00
riking fdf86143b3 fixup NotificationController 2015-04-21 20:23:30 -07:00
riking f4b0f1dbef a few fixups 2015-04-21 20:23:30 -07:00
riking 8bbead315d Add idle checking, use localStorage for seen notifications 2015-04-21 20:23:30 -07:00
riking da9913359c Convert to file in lib/, rough active tracking 2015-04-21 20:23:29 -07:00
riking 41819838ef Prevent "0 new notifications" 2015-04-21 20:21:56 -07:00
riking 59bdff348c Use Discourse.URL.routeTo 2015-04-21 20:21:56 -07:00
riking 84896bdccf Close the notification after 10 seconds 2015-04-21 20:21:56 -07:00
riking c1528e598f Use unreadCount in title 2015-04-21 20:21:55 -07:00
riking f5e27fe2c8 FEATURE: Desktop notifications 2015-04-21 20:21:52 -07:00
Jeff Atwood 706183f886 hide editor button bar overflow 2015-04-21 17:35:10 -07:00
Robin Ward 5bf8c31af4 Users can see their pending posts 2015-04-21 16:44:47 -04:00
Robin Ward 26693c16ac Don't show the link to "Needs Approval" unless approval is enabled.
Note that any plugin that extends the NewPostMananger to support
enqueuing will enable it.
2015-04-21 13:59:57 -04:00
Robin Ward b2ab95f9c2 Fix an issue with the store hydrating embedded objects 2015-04-21 13:15:40 -04:00
Robin Ward f600ead587 FIX: Don't validate approved posts.
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
Robin Ward 2cdd967188 Adds support for invisible approval queues, which we'll need for Akismet 2015-04-20 17:19:05 -04:00
Robin Ward 66be9147a0 FIX: You can edit two queued posts simultaneously 2015-04-20 16:49:11 -04:00
Robin Ward 5476723906 Add post date to moderator queue 2015-04-20 16:34:36 -04:00
Robin Ward 2c53a8b7bc Link queued post avatar and username to user profile 2015-04-20 16:18:00 -04:00
Robin Ward 5990ab855b PERF: Move post alerting into async 2015-04-20 13:34:57 -04:00
Robin Ward 6ae58d41a7 PERF: Only refresh the Daily stats hourly, do the others daily. 2015-04-20 12:11:36 -04:00
Neil Lalonde 3071650eb3 FEATURE: when post is too short, suggest using the like button instead 2015-04-20 11:10:56 -04:00
Neil Lalonde a3b6e3cb97 FIX: permalinks redirects with relative_url_root 2015-04-19 23:36:09 -04:00
Sam Saffron 296add56e6 correct letter avatar template 2015-04-20 13:07:12 +10:00
Sam Saffron 6d2e651862 Revert "FIX: Missing letter avatars"
This reverts commit 03943554c6.
2015-04-20 06:41:08 +10:00
Sam 72ab1b9714 Merge pull request #3385 from tancnle/each-key-refactor
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-20 06:17:27 +10:00
Neil Lalonde c2e3c86883 FIX: broken header links when using relative_url_root 2015-04-19 13:52:10 -04:00
Robin Ward 03943554c6 FIX: Missing letter avatars
cc @zogstrip

It seems that the version string was ammended to return the ImageMagick
version. This caused the guard in the user avatars method to fail as the
versions weren't the same.

I changed it so it is comparing the right version, but I wonder if this
is bad as the controller is no longer using the ImageMagick version. Can
you please review?
2015-04-19 10:48:53 -04:00
Tan Le 9fbc763902 Replace Hash#keys.each with Hash#each_key for some perf boost 2015-04-18 21:53:53 +10:00
Robin Ward 13de577568 FIX: Error alerting tracking users of PM when replying in general 2015-04-17 15:38:44 -04:00
Robin Ward bed7781fe2 FIX: Broken build 2015-04-17 14:45:17 -04:00
Robin Ward 2f7b241087 FIX: Keyboard shortcuts broke in the composer 2015-04-17 14:01:45 -04:00
Robin Ward 952b345883 FIX: Focus was being lost on error message popup when composing failed 2015-04-17 13:24:02 -04:00
Robin Ward 32365fbc58 Composer Messages can be dismissed by Esc 2015-04-17 12:41:31 -04:00
Robin Ward a61c202ac4 Rewrite `/private-messages` to `/messages` 2015-04-17 12:01:50 -04:00
Robin Ward 0660a905b8 FIX: Back button broken navigating from one topic back to another 2015-04-17 11:52:30 -04:00
Neil Lalonde ccce27d1b8 add plugin outlets for adsense plugin 2015-04-17 11:13:52 -04:00
Arpit Jalan c3f163ca73 FIX: about tab was not showing on Privacy / ToS / FAQ topnav 2015-04-17 12:29:28 +05:30
Sam 51b747346e PREF: speed up grabbing unread counts 2015-04-17 16:01:20 +10:00
Sam 832cb9fdc3 FIX: admin check missing from topic tracking state
FIX: handle muted categories correctly
2015-04-17 14:03:08 +10:00
Robin Ward e83bf7dc07 FIX: Restrict editing queued posts to one at a time 2015-04-16 15:50:47 -04:00