Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
48,314 Commits 225 Branches 500 Tags 898 MiB
Commit Graph

179 Commits

Author SHA1 Message Date
Jarek Radosz de79f19947
Revert "UX: Style video elements, show descriptions (#10040)" (#10258) 
This reverts commit 7d289a4f3e.

Now that 36bad0c31f is in and we have video previews on all platforms, the commit that's being reverted is no longer needed. In the worst case scenario, the video description is clipped under the video poster if the video aspect ratio is other than 16:9. This commit removes descriptions and the custom style for the video elements.

# Conflicts:
#	app/assets/javascripts/pretty-text/addon/engines/discourse-markdown-it.js
#	test/javascripts/lib/pretty-text-test.js
 2020-07-17 23:31:01 +02:00
Jarek Radosz 7d289a4f3e
UX: Style video elements, show descriptions (#10040) 
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
 2020-06-17 12:38:00 +02:00
Arpit Jalan 7052e6f4a1 UX: remove top padding from reddit onebox description 2020-05-07 07:13:37 +05:30
Arpit Jalan 10ca6968af Bump onebox version 
- reuse existing video icon class
- CSS changes for reddit video onebox
 2020-05-06 19:34:03 +05:30
Arpit Jalan 5121708814 Add styling for Reddit video onebox. 
0d49811aac
 2020-05-06 15:58:30 +05:30
Joffrey JAFFEUX a863d8eecb
UX: applies default background color to onebox (#9407) 2020-04-12 21:21:21 +02:00
Robin Ward a12c7fcb2f Revert "FIX: Allow JS transpilation" 
This reverts commit 6d1263812f.
 2020-03-25 16:13:01 -04:00
Robin Ward 6d1263812f FIX: Allow JS transpilation 2020-03-25 16:05:16 -04:00
Arpit Jalan 0e2cbee339 UX: add icon for Google Map onebox. 2020-02-03 18:12:42 +05:30
Martin Brennan 397adfd128
FIX: Wrap markdown videos with video-container class to stop post height jumping (#8806) 
This will lock video aspect ratio to 16:9 and stop them from making posts jump around on load.

See also discourse/onebox@6f58545 and fe20cb4.
 2020-01-29 15:52:02 +10:00
Kris b066a4128d Adding a text-overflow: ellipsis; mixin and related cleanup 2019-11-06 14:00:29 -05:00
David Taylor ecfba0bb37 UX: Ensure GitHub onebox info does not wrap unnecessarily 2019-10-17 11:00:44 +01:00
Penar Musaraj 5c5845f3f2 FIX: Minor Github onebox layout issues 
- prevents long branch names from overflowing

- fixes alignment of inline avatars in preview
 2019-10-10 21:35:36 -04:00
David Taylor 939a746dcd UX: Use theme colors for GitHub issue labels 
Bump onebox version to pull tag rendering bug fix
 2019-10-09 12:28:48 +01:00
David Taylor 3edd514c72 FEATURE: Redesigned GitHub oneboxes 
Bump onebox version, and add new styling

Commit, PR and Issue oneboxes are updated with a new design. Timestamps are now localized using local-dates (if installed).
 2019-10-09 11:47:58 +01:00
David Taylor 228a55a475 UX: Reduce size of github onebox icons 2019-10-08 11:08:36 +01:00
David Taylor 615039f228 FEATURE: Improve GitHub commit, PR and issue onebox rendering 
Bump onebox version to include new github rendering, and add relevant CSS

Avatars are reduced in size significantly, and icons are added to easily differentiate PRs and commits. The 'Issue:' prefix is removed from issue oneboxes, to make them consistent with commits and PRs.
 2019-10-07 19:26:10 +01:00
Arpit Jalan 59f7c92661 fix the build. 2019-09-11 23:32:58 +05:30
Arpit Jalan 4195548a17 Bump onebox version. 
- indicate and link to Flickr Album
 2019-09-11 23:23:11 +05:30
Kris 1232889b30 UX: Prevent twitter onebox iframes from being taller than mobie viewport 2019-08-12 11:03:54 -04:00
Joffrey JAFFEUX 02e27b5cff
UX: fixes onebox favicon vertical alignment (#7926) 2019-07-24 09:40:32 +02:00
Kris d841bff9f8 remove whitespace from twitter onebox 2019-07-18 09:45:09 -04:00
Arpit Jalan bb8cf81089 Bump onebox version. 
- better placeholders for audio/video/trello/typeform oneboxes
- added CSS for audio/video/trello/typeform onebox placeholders
 2019-07-08 21:40:33 +05:30
Arpit Jalan 5494e17c71 UX: improve twitter status onebox with line breaks 2019-07-05 20:37:08 +05:30
Arpit Jalan 5bc1fd23b0 Bump onebox version. 
- update HTML for twitter quoted onebox
- updated CSS for twitter quoted onebox
 2019-07-05 19:35:36 +05:30
Julian Calvento f3c9dbcf20 UX: Add styling for quoted tweets (#7832) 2019-07-03 10:34:46 -04:00
Arpit Jalan 9a2eb5c8cb UX: change icon for video placeholder 2019-06-27 12:27:14 +05:30
Arpit Jalan a3bcb8e887 UX: make onebox video placeholder icon grey 2019-06-26 23:40:36 +05:30
Arpit Jalan 168a38dc29 Bump onebox version. 
- better Twitch placeholder
- CSS for said placeholder
 2019-06-26 23:22:29 +05:30
Arpit Jalan 2af4002817 Bump onebox version. 
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
 2019-06-26 13:40:14 +05:30
David Taylor abbe812a0d FIX: Correct CSS for instagram video play icon 2019-05-10 10:46:07 +01:00
Arpit Jalan 9c1d1777db Bump onebox version 
- adds support for oneboxing google drive files
- add styling for google drive onebox favicon
 2019-04-10 13:37:24 +05:30
Maja Komel b0053f3a1c FEATURE: bump onebox version, add styling for new reddit image onebox 2019-04-04 11:24:30 +02:00
David Taylor fe20cb4b56 FIX: Enforce a fixed height on generic oneboxed videos 
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
 2019-01-08 16:22:03 +00:00
Penar Musaraj 7f361a546e UX: Add styling for updated twitter status icons in onebox 
Minor adjustments needed by onebox version 1.8.69
 2018-12-09 21:58:02 -05:00
Penar Musaraj 03deda2147
Upgrade to FontAwesome 5 (take two) (#6673) 
* Add missing icons to set

* Revert FA5 revert

 This reverts commit 42572ff

* use new SVG syntax in locales

* Noscript page changes (remove login button, center "powered by" footer text)

* Cast wider net for SVG icons in settings

- include any _icon setting for SVG registry (offers better support for plugin settings)

- let themes store multiple pipe-delimited icons in a setting

- also replaces broken onebox image icon with SVG reference in cooked post processor

* interpolate icons in locales

* Fix composer whisper icon alignment

* Add support for stacked icons

* SECURITY: enforce hostname to match discourse hostname

This ensures that the hostname rails uses for various helpers always matches
the Discourse hostname

* load SVG sprite with pre-initializers

* FIX: enable caching on SVG sprites

* PERF: use JSONP for SVG sprites so they are served from CDN

This avoids needing to deal with CORS for loading of the SVG

Note, added the svg- prefix to the filename so we can quickly tell in
dev tools what the file is

* Add missing SVG sprite JSONP script to CSP

* Upgrade to FA 5.5.0

* Add support for all FA4.7 icons

- adds complete frontend and backend for renamed FA4.7 icons

- improves performance of SvgSprite.bundle and SvgSprite.all_icons

* Fix group avatar flair preview

- adds an endpoint at /svg-sprites/search/:keyword

- adds frontend ajax call that pulls icon in avatar flair preview even when it is not in subset

* Remove FA 4.7 font files
 2018-11-26 16:49:57 -05:00
Arpit Jalan 1151c093ad bump onebox version 
- Better Google Photos oneboxing
 2018-11-09 15:44:06 +05:30
Sam 42572ff138 Revert font awesome 5 changes 
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
 2018-11-08 16:12:18 +11:00
Penar Musaraj 005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557) 
* First take on subsetting svg icons

* FontAwesome 5 svg subset WIP

* Include icons from plugins/badges into svg sprite subset

* add svg icon support to themes

* Add spec for SvgSprite

* Misc. SVG icon fixes

* Use FA5 svgs in local-dates plugin

* CSS adjustments, fix SVG icons in group flair

* Use SVG icons in poll plugin

* Add SVG icons to /wizard
 2018-11-07 13:05:43 -05:00
Arpit Jalan 6b9aeeea73 bump onebox version 2018-08-31 08:40:36 +05:30
Arpit Jalan 7c7509e1bd FEATURE: update TwitterApi for prettifying like/retweet count 2018-07-17 12:59:40 +05:30
Kris 82cb163ef3 formatting fix 2018-06-19 13:07:16 -04:00
Kris 0d81633da9 Replacing onebox loading gif with css spinner 2018-06-19 12:59:00 -04:00
Joffrey JAFFEUX 174d392e5a
DEV: adds prettier (#5956) 
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
 2018-06-08 11:49:31 +02:00
Kris 209a8d5e31 Reucing vertical spacing for github onebox pre 2018-05-21 23:29:36 -04:00
Arpit Jalan 597330ad1d UX: better github commit onebox 2018-04-23 12:35:27 +05:30
Arpit Jalan 33c1aeb2ac UX: wrap instagram images with aspect ratio 2018-03-22 21:35:10 +05:30
Arpit Jalan 4a6fb242bd UX: correct styling for Instagram onebox 2018-03-22 21:11:47 +05:30
Arpit Jalan 3a62eba299 bump onebox version 2018-03-22 11:38:01 +05:30
Arpit Jalan 3e32ab1523 UX: css for Instagram onebox 2018-03-19 13:32:36 +05:30
Rafael dos Santos Silva 4644757785 FEATURE: Style new gfycat onebox 2018-02-12 13:39:52 -02:00
Maja Komel 018cb7f36b add a custom user onebox (#5542) 
* add custom user onebox

* add specs
 2018-01-30 11:03:08 +01:00
Bruno Perel 6750ff6873 (S)CSS cleanup: 0px => O and removal of duplicated properties (#5526) 2018-01-25 09:53:36 -05:00
Kris 0c01e0b2fe
UX: Implementing a z-index system (#5507) 2018-01-16 19:05:12 -05:00
Kris 674013129a
UX: Type system rebuild (#5492) 2018-01-12 17:27:38 -05:00
Kris c1cb6053b7 UX: Adding a little space after oneboxes 2018-01-09 13:00:32 -05:00
Kris dea3e84f18 UX: Reducing number of font-sizes used in common 2017-12-21 12:59:19 -05:00
Kris 2d9d43ed1a UX: Removing px font defintions and replacing with em 2017-12-18 15:49:11 -05:00
Kris 1be32bf4cf FIX: text indent on twitter oneboxes 2017-12-12 11:17:09 -05:00
Sam b3b55e18d1 UX: stop warping tiny onebox images 2017-11-28 12:32:35 +11:00
Arpit Jalan abbb2b28eb bump onebox version 2017-11-25 15:53:18 +05:30
Sam 2fe131db9f UX: handle super tall images in onebox respectfully. 
Tall images got distorted previously
 2017-11-23 14:45:46 +11:00
Arpit Jalan 753a4fc369 UX: make onebox timestamp consistent with header 2017-11-21 16:39:15 +05:30
Kris 4daaa3544b mobile topic adjustments 2017-11-17 16:57:25 -05:00
Sam fc7dca58fe UX: oneboxes with avatars now display consistently 
Onebox avatar size is reduced to 60px

Also fixes regression with some oneboxes not cooking after post
 2017-11-08 11:50:01 +11:00
Arpit Jalan 6d8976e949 UX: support onebox labels 2017-11-01 15:44:52 +05:30
Sam 9197feefb8 UX: onebox images no longer cause jiggle 
This stops pages from "jiggling" while oneboxes download.

see: http://cssmojo.com/aspect-ratio-using-custom-properties-and-calc/
 2017-10-31 13:50:58 +11:00
Kris dc2d9f05dc removing scale-color, first pass 2017-10-13 11:57:10 -04:00
awesomerobot c29b7aa65d initial pass at color simplification 2017-07-14 21:43:35 -04:00
Robin Ward a9d5d2aee6 UX: Fix improper aspect ratio for xkcd oneboxes 2017-05-12 13:21:44 -04:00
Jeff Atwood a6dd1a2cd4 onebox last para needs less bottom margin 2017-02-16 15:39:46 -08:00
Jeff Atwood 77033f4855 simpler twitter onebox CSS that works everywhere 2017-02-08 17:18:53 -08:00
Jeff Atwood 933af0b40e align onebox twitter date 2017-02-08 17:14:11 -08:00
Jeff Atwood 485c36141c onebox right padding should not be asymmetric 2017-02-08 17:11:19 -08:00
Jeff Atwood fe32c64dd9 FIX: twitter onebox styling was poor on mobile 2017-02-08 17:08:40 -08:00
Arpit Jalan 75f154b177 bump onebox 2017-02-08 12:08:41 +05:30
Arpit Jalan 0c0da86e0c UX: CSS for pdf onebox 2017-02-07 00:04:01 +05:30
Jeff Atwood 56abe065bc tighten header margin on onebox 2017-01-14 22:11:46 -08:00
Jeff Atwood 4e44845714 de-emphasize onebox URL field with color 2017-01-03 14:08:56 -08:00
Arpit Jalan 615fd2eb87 UX: sane max-height for onebox images 2017-01-03 21:06:49 +05:30
Jeff Atwood 5db57abd7f fix onebox header misalignment issue 2017-01-02 02:22:57 -08:00
Régis Hanol 0c791e721e UX: better xkcd oneboxes 2016-11-28 15:14:59 +01:00
Arpit Jalan d65f7742a7 FEATURE: better google docs onebox 2016-08-10 19:01:18 +05:30
Arpit Jalan c7bbc1cebf update onebox gem 2016-07-13 21:54:49 +05:30
Jeff Atwood 2ef1dca335 slightly suppress onebox metadata 2016-06-07 00:26:42 -07:00
Jeff Atwood 547abda6d6 add higher res favicons for onebox 2016-05-24 12:10:29 -07:00
Jeff Atwood a367262125 UX: simpler "white box" for oneboxes 2016-05-23 05:02:24 -07:00
Robin Ward c06a6a96cc
FEATURE: Embed images in tweets with dimensions, if present 2016-05-11 16:11:26 -04:00
Arpit Jalan b473cd10a6 UX: remove top border from onebox body on mobile 2016-04-25 08:34:07 +05:30
Arpit Jalan 125d9b5d2e Revert "UX: bigger title font on local oneboxed topic" 
This reverts commit e492ed64ec.
 2016-04-19 21:40:50 +05:30
Arpit Jalan 272747f2b9 FIX: imgur album title onebox was large on mobile 2016-04-16 15:09:42 +05:30
Arpit Jalan e492ed64ec UX: bigger title font on local oneboxed topic 2016-04-15 18:12:21 +05:30
Arpit Jalan edbc7c4db8 UX: add text-overflow to imgur album description 2016-03-30 13:12:28 +05:30
Arpit Jalan c13d8176b5 UX: Imgur album width should be dependent on album description 2016-03-30 08:00:22 +05:30
Arpit Jalan 5b8817cc70 Merge pull request #3807 from riking/patch-8 
Add styling & assets for google docs placeholder oneboxes
 2016-01-26 14:37:57 +05:30
Arpit Jalan da32be9294 UX: resize stackexchange onebox image 2015-11-03 19:11:15 +05:30
Arpit Jalan 688d44278e UX: move imgur album CSS to Discourse repo 2015-11-03 12:27:09 +05:30
Kane York f67a877537 Add styling & assets for google docs placeholder oneboxes 2015-10-14 17:09:48 -07:00
Arpit Jalan 07ead44187 UX: make old twitter oneboxes look good 2015-09-23 18:02:28 +05:30
Arpit Jalan 4f31745e10 UX: improve twitter onebox 2015-09-21 17:40:17 +05:30