Commit Graph

5723 Commits

Author SHA1 Message Date
Sam 0920c4bea6 PERF: reduce storage requirements for incoming links
Only store incoming links for topics.
2014-08-04 11:06:48 +10:00
Régis Hanol b36273e4ac TRIVIAL: forgot to remove the href 2014-08-03 23:01:51 +02:00
Jeff Atwood 04682335d4 adjust img width to auto ONLY ON REPLY EXPANSIONS 2014-08-02 00:10:40 -07:00
Régis Hanol d13d42f3f6 FIX: automatic redirection to /top was a bit janky 2014-08-02 00:34:58 +02:00
Neil Lalonde b368667703 FIX: don't validate topic title if it isn't changing. topic stats were failing to update, causing necro topic warnings and other problems. 2014-08-01 17:30:07 -04:00
Robin Ward 3c66e48573 TESTS: Remove `URL_FIXTURES` constant for pretender 2014-08-01 17:27:01 -04:00
Robin Ward 6eb478f5fa Merge pull request #2614 from riking/email-tests
Email tests, and include posting error reason
2014-08-01 16:33:00 -04:00
Robin Ward 27273ac848 Merge pull request #2615 from riking/stream-len-prop
FIX: Topic progress bar was not updating after expanding gaps
2014-08-01 16:28:45 -04:00
Robin Ward 0a2036a99a OPTIMIZATION: Don't run 12 queries every 15 mins for the Top section.
Instead, run the daily queries once every hour, and the reset of the
queries once a day.
2014-08-01 16:25:20 -04:00
riking 4a75065b62 FIX: Topic progress bar was not updating after expanding gaps 2014-08-01 13:23:53 -07:00
Neil Lalonde 212d580745 FIX: styling of bouncing validation errors in composer was broken 2014-08-01 15:11:55 -04:00
Neil Lalonde 443caaa8f7 FIX: don't let admins skip post validations, unless it's faq, tos, or privacy 2014-08-01 14:53:35 -04:00
riking c0b2b9b341 Refactor out handle_failure method in PollMailbox 2014-08-01 11:12:06 -07:00
Régis Hanol 46a88e0c70 FIX: helpful/flagged posts styling on mobile 2014-08-01 19:18:31 +02:00
Robin Ward 09d7a697bf OPTIMIZATION: Add index to `post_timings` and adjust the query 2014-08-01 13:14:00 -04:00
Régis Hanol b414a3590a FIX: flag count displayed at wrong position 2014-08-01 19:03:12 +02:00
riking d87edce6c3 Pass rejection message along in rejection mail if present 2014-08-01 09:56:15 -07:00
Jeff Atwood 332e3ca8b6 #topic-progress-expanded needed +width too 2014-08-01 02:15:05 -07:00
Jeff Atwood 05e2f5c4a9 missed a few #topic-progress spots, go 145px 2014-08-01 01:41:06 -07:00
Jeff Atwood beabdc0809 that max-height was way small for mobile 2014-07-31 23:26:16 -07:00
Jeff Atwood aa9d1594a0 font colors incorrect on mobile user page bio 2014-07-31 22:41:11 -07:00
Jeff Atwood 2c44ac4454 slightly wider topic-progress bar 2014-07-31 21:53:28 -07:00
Sam 7d331760db FIX: not clearing floats in firefox 2014-08-01 12:52:37 +10:00
Jeff Atwood 71aa41ccac copyedits on new flagging behaviors 2014-07-31 16:17:38 -07:00
Robin Ward d7ad3bb2b6 TESTS: Integration tests for badge pages 2014-07-31 18:44:47 -04:00
Robin Ward adea5b36a0 TESTS: Integration tests for `login_required` 2014-07-31 17:59:52 -04:00
Robin Ward d3cc85c784 TESTS: Use Pretender in test mode for more flexible server responses 2014-07-31 16:49:30 -04:00
Robin Ward c5b5db48cf TESTS: Reset the preload store for testing 2014-07-31 13:25:40 -04:00
Neil Lalonde 3b46b5ecbf FIX: TL3 requirements now only counts agreed flags 2014-07-31 10:43:18 -04:00
Sam 5a8919e87a FIX: we don't need buttons that do nothing
Leading to v1 we don't need UI reminders in our product.
2014-07-31 18:59:18 +10:00
Sam dcc9923e4b FIX: failed messages posted via email silently ignored
also... test suite over mocking
2014-07-31 18:46:02 +10:00
Sam e907cca62e annotate 2014-07-31 13:14:40 +10:00
Sam e9a1af0113 FIX: Do not suppress reply-to when other posts quoted 2014-07-31 11:40:02 +10:00
Sam 9926382185 FIX: can't create badges 2014-07-31 09:09:03 +10:00
Régis Hanol 220f9e21e3 FIX: 'undo flag' marks the flag as disagreed 2014-07-30 23:35:42 +02:00
Robin Ward 87ca49e26e Merge pull request #2609 from BenLubar/benlubar-edit-history-public-2
FIX: save edit_history_public
2014-07-30 13:20:32 -04:00
Ben Lubar 4e80a4d091 FIX: save edit_history_public 2014-07-30 12:03:22 -05:00
riking f9ef715357 Improve email-in category settings UI 2014-07-30 09:58:41 -07:00
Robin Ward a6848bd9e9 FIX: Latest should link to `/latest` since the homepage can be
customized
2014-07-30 11:59:22 -04:00
Régis Hanol 0b648f4b18 FIX: make sure the quote-reply button is never squished on mobile 2014-07-30 17:39:53 +02:00
Régis Hanol 78e33f1931 FIX: link to the flagged post instead of its topic 2014-07-30 11:16:49 +02:00
Sam 6dbd6f7428 FIX: redirect to preserve json 2014-07-30 15:25:49 +10:00
Sam 662845f8be FIX: don't display category for PMs 2014-07-30 14:56:19 +10:00
Sam e7e70d14da Merge pull request #2591 from BenLubar/benlubar-edit-history-public
add profile option for edit history visibility
2014-07-30 14:09:10 +10:00
Kris Aubuchon 3d41ee5f9a removing text-transforms (interferes with translation) 2014-07-29 23:48:41 -04:00
Sam f29a761445 FIX: not highlighting stuff a second time 2014-07-30 12:32:14 +10:00
Sam e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam b143b64511 FIX: searchContext set too early
This was firing before previous route deactivated.
2014-07-30 11:55:38 +10:00
Sam 871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam 87dd681497 FEATURE: setting suppress reply when quoting 2014-07-30 10:55:49 +10:00
Sam 5c72297695 FEATURE: clean up badges admin 2014-07-30 08:56:46 +10:00
Sam ebf385aedc FEATURE: allow title overridable 2014-07-30 08:46:59 +10:00
Sam 367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00
Sam 5a3466a6c3 FIX: keep correct ordering on admin badges 2014-07-30 08:46:59 +10:00
Régis Hanol b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward 6844edc564 FIX: User email was changing in the HTML when you invited a user 2014-07-29 16:02:30 -04:00
Robin Ward ac4a33a656 FIX: Display proper error message when changing a trust level fails 2014-07-29 15:54:20 -04:00
Robin Ward 55457810ba FIX: Was not filtering correctly on the user's stream 2014-07-29 15:39:01 -04:00
Robin Ward 7cc4a157f6 Merge pull request #2603 from techAPJ/patch-1
FEATURE: allow staff to send multiple invites to same email
2014-07-29 14:58:39 -04:00
Régis Hanol 86a4a1f220 export the Button class so that we can use it in plugins 2014-07-29 20:56:05 +02:00
Arpit Jalan f571abfaaf FEATURE: allow staff to send multiple invites to same email 2014-07-30 00:13:11 +05:30
Robin Ward 16dfedef8f ES6: Remove dynamically generated static routes. They were causing lots
of confusion and bugs.
2014-07-29 14:24:16 -04:00
Robin Ward df9bd3d666 FIX: Clicking logo when `login_required` threw an error 2014-07-29 13:46:42 -04:00
Robin Ward af36df057c FIX: Show correct login page when `login_required` 2014-07-29 13:38:04 -04:00
Robin Ward 04643898c9 FIX: Typo in SiteSetting 2014-07-29 13:27:01 -04:00
Dung Quang 97507bbd87 Update categories.js.handlebars 2014-07-29 17:24:19 +07:00
Régis Hanol a49a8e8c05 FIX: no primary action on disposition buttons 2014-07-29 09:36:12 +02:00
Régis Hanol 9d864ab28a FIX: show disposition buttons when flagging a topic 2014-07-29 09:34:58 +02:00
Régis Hanol b93deae54b EXPERIMENT: put the quote button at the bottom of the selection on mobile 2014-07-29 09:23:49 +02:00
Jeff Atwood 7bc4ac3e61 Merge pull request #2601 from awesomerobot/master
tiger striping on mobile categories
2014-07-28 23:10:37 -07:00
Sam 49d03cf14e FEATURE: support for /t/1234 2014-07-29 16:04:28 +10:00
Kris Aubuchon 467b358659 tiger striping on mobile categories 2014-07-29 02:04:20 -04:00
Sam 5d9eefbfed FIX: don't notify on link reflections 2014-07-29 15:40:05 +10:00
Sam b2e29526ff FIX: custom css not using CDN 2014-07-29 14:55:48 +10:00
Sam 7c83823a95 FEATURE: Dismiss unread / new at top if more than 30. 2014-07-29 14:12:41 +10:00
Régis Hanol 44ba74789b FIX: actually retrieve the first 2 posts in a conversation about a flag 2014-07-28 22:54:03 +02:00
Neil Lalonde e1be478ef4 FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example. 2014-07-28 16:40:14 -04:00
Régis Hanol 57fef6864d FIX: update_counters wasn't properly updating topic counters 2014-07-28 22:08:31 +02:00
Robin Ward 380411457a UX: Show the category name even if there's an image. It's too confusing
otherwise for many sites.
2014-07-28 16:03:13 -04:00
Robin Ward 8603f492c7 FIX: Latest link in site map was not working correctly. 2014-07-28 15:53:46 -04:00
Robin Ward d17dbf61a8 Remove all the partials in the Site Map. Those made no sense. 2014-07-28 15:53:46 -04:00
Régis Hanol cbe3a72c1f FIX quote-button style on mobile 2014-07-28 21:22:09 +02:00
Robin Ward 5cd7e1b387 ES6: Convert more routes over 2014-07-28 13:39:33 -04:00
Régis Hanol bddffa7f9a FEATURE: flag dispositions normalization
All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Robin Ward 717f57c968 Revert "FIX: You couldn't span multiple lines with bold or italics"
This reverts commit 423d37a2b6.

Conflicts:
	test/javascripts/lib/markdown_test.js
2014-07-28 13:17:39 -04:00
Robin Ward 8866141ba2 Merge pull request #2592 from Elberet/fix-parser
Fixes for quirky markdown parser behaviours
2014-07-28 13:12:22 -04:00
Jens Maier 90d14d9ffc add comments and improve variable names 2014-07-28 19:03:34 +02:00
Neil Lalonde 39980631f5 Merge pull request #2596 from mcwumbly/tl3-low-water-mark
add a low water mark at 90% of variable TL3 requirements
2014-07-28 10:54:17 -04:00
Kris Aubuchon 22efc2147b fixing tiger striping on mobile 2014-07-28 10:33:23 -04:00
David McClure 025354f52f add a low water mark at 90% of variable TL3 requirements 2014-07-27 23:42:38 -07:00
Sam f9162d6add FIX: moderators had no access to admin user page 2014-07-28 11:59:46 +10:00
Sam 32cea9d8cc Feature: Show keyboard shortcuts link on desktop hamburger
(only shows up for desktop, hides "mobile view")

If you really need mobile view add ?mobile_view=1 to end of URL (also fixed)
2014-07-28 11:48:56 +10:00
Ben Lubar ac8c2e1e07 discourse#2591 2014-07-27 12:12:36 -05:00
Jens Maier 479eb64a76 FIX: rewrite replaceBlock logic to better handle mismatched nested quotes. 2014-07-27 16:07:47 +02:00
Sam 621b86dbb3 FIX: regression in seed 2014-07-27 18:32:04 +10:00
Sam 1a6aa07611 FEATURE: editable badge groups 2014-07-27 18:22:01 +10:00
Ben Lubar 44dc4b4a17 add profile option for edit history, visible only when edit history is disabled globally. 2014-07-26 23:04:46 -05:00
Sam 0ab456b647 FIX: allow position to be changed post seed 2014-07-27 11:33:33 +10:00
Régis Hanol 3d6e2713d1 BUGFIX: login was broken when login was required 2014-07-26 23:16:08 +02:00
Jeff Atwood f66c39c63b Merge pull request #2589 from awesomerobot/master
reverting notification style
2014-07-25 20:43:14 -07:00
Kris Aubuchon 1557f07e87 reverting notification style 2014-07-25 23:06:14 -04:00
Shiv Kumar aac9c24639 do not allow password changes if local logins disabled 2014-07-25 14:27:27 -07:00
Robin Ward f4f46aea48 FIX: No, for real don't show Uploading... for non-admin users when they
aren't uploading.
2014-07-25 17:08:54 -04:00
Robin Ward 227ca5dd23 FIX: Home logo wasn't scrolling to top if on second page of topic
results.
2014-07-25 17:02:46 -04:00
Neil Lalonde fcaeb885e5 FIX: don't show the option to notify yourself in the flag dialog 2014-07-25 16:37:03 -04:00
Robin Ward 6ba5f715f3 FIX: There was an error renaming the Uncategorized topic 2014-07-25 16:36:34 -04:00
riking 8af4ab2a63 Use settingName in settings_list like the others 2014-07-25 13:19:43 -07:00
Robin Ward 423d37a2b6 FIX: You couldn't span multiple lines with bold or italics 2014-07-25 16:08:00 -04:00
Neil Lalonde 46bdd13491 FIX: too_few_topics_notice check and message should use basic_requires_read_posts site setting 2014-07-25 15:58:22 -04:00
Robin Ward 4101a396ad FIX: Allow buttons to be hidden. Fixes persistent uploading progress on
file uploads for non-admins.
2014-07-25 15:09:15 -04:00
Neil Lalonde 5a33e6f00c Move FAQ, Terms of Service, and Privacy Policy into topics in the Staff category. First post of those topics will be rendered on their respective pages. Site settings and content are not used for these documents anymore. Translations of the default text is moved into the standard YML files. 2014-07-25 14:41:20 -04:00
Robin Ward e6819f8879 FIX: Don't capitalize category names in the breadcrumbs. See:
https://meta.discourse.org/t/categories-dropdown-inconsistent-text-formatting/18042
2014-07-25 14:37:31 -04:00
Robin Ward 15a51c6316 ES6: Patch up a few issues with the admin controllers conversion 2014-07-25 14:17:58 -04:00
Joshua Gorner e242368266 Convert admin section controllers to ES6 modules 2014-07-25 14:17:58 -04:00
Kris Aubuchon ab8bade9c6 fixing PM notification badge 2014-07-25 13:37:42 -04:00
Kris Aubuchon f050d3e917 fixing notification style update 2014-07-25 12:22:55 -04:00
Robin Ward e940723d99 FIX: Prevent Firefox browser crash with too many nested <kbd> tags 2014-07-25 11:16:01 -04:00
Robin Ward be408242bc Merge pull request #2581 from awesomerobot/master
new notification style, poster expansion border, changing media screen to media all...
2014-07-25 10:55:43 -04:00
Sam 1d1dd43e27 SECURITY: fix XSS using fancy mention hack 2014-07-25 17:26:57 +10:00
Sam ae686e8188 FIX: no new badges could be created 2014-07-25 15:48:43 +10:00
Sam 1297243759 FIX: stop tracking broken links 2014-07-25 15:34:31 +10:00
Sam d47d323f29 FIX: corrupt avatar record causing 404 2014-07-25 15:26:43 +10:00
Sam 354d40a6ea FIX: system attribute not set correctly on new badges 2014-07-25 15:22:29 +10:00
Sam 40af9ce612 FIX: do not store incoming links on avatars or uploads 2014-07-25 15:10:06 +10:00
Sam 95d13bf68a PERF: move avg time calculation to daily 2014-07-25 13:21:10 +10:00
Sam fbbd4999b6 FIX: remove invalid hack, correct whitelist to use value returned from callback 2014-07-25 12:16:00 +10:00
Robin Ward f2b554be13 FIX: Use placeholder for avatar image size in expansion 2014-07-24 17:17:47 -04:00
Robin Ward b88a8d2416 FIX: Clicking navigation pills a second time should refresh the list
you're looking at.
2014-07-24 14:59:53 -04:00
Jens Maier b19ad15086 FIX: improve list bbcodes: ignore newlines resulting in unnecessary blank lines 2014-07-24 19:39:16 +02:00
Robin Ward f33ebc512b FIX: Link a poster's name to their profile, makes much more sense now
that we're showing the popup to that.
2014-07-24 13:13:24 -04:00
Robin Ward fa25700400 FIX: Direct links to hash URLS were broken. Regression? 2014-07-24 12:52:43 -04:00
Kris Aubuchon 4a1ec20585 adding border to poster expansion, changing media screen to media all, trying new notification style 2014-07-24 12:21:22 -04:00
Jens Maier 79dc68512f FIX: dialects accept nested inline markup 2014-07-24 17:34:13 +02:00
Robin Ward 5aa411b58c FIX: When we don't have an `uploaded_avatar_id` don't try to show the
avatar. Wait until it's loaded.
2014-07-24 11:31:08 -04:00
Robin Ward 0b368993b7 FIX: If you hit back while a `replaceState` was queued up it would
update the URL even after navigating.
2014-07-24 11:26:53 -04:00
Sam a34037b26c FIX: typo 2014-07-24 18:38:27 +10:00
Sam ec03d135fa FEATURE: allow advanced badge options in admin screen
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
Sam 469e74316b FIX: don't show broken button 2014-07-24 18:28:23 +10:00
Jeff Atwood dc96cf6d4c Merge pull request #2578 from awesomerobot/master
minor alignment fix on embedded posts
2014-07-23 22:15:39 -07:00
Kris Aubuchon b43e4b05c2 minor alignment fix 2014-07-23 23:45:30 -04:00
Sam 526da15b9e Improve badge UI add links to badge descriptions 2014-07-24 12:21:24 +10:00
Robin Ward c8a0bf35c5 FIX: Navigating to a user's admin page would not populate
`availableGroups`
2014-07-23 16:54:04 -04:00
Robin Ward 27f786e06a FEATURE: Show user popup when clicking on an @mention in a post. 2014-07-23 16:10:29 -04:00
Robin Ward 04c6733ae7 FIX: If a deprecated view can't be found, look for a component 2014-07-23 16:10:29 -04:00
Robin Ward 06512685ab FEATURE: If there is a category scope and `show_subcategory_list` is set, only
show the local categories in the dropdown instead of all categories.
2014-07-23 13:10:06 -04:00
Neil Lalonde b4ad70d767 FEATURE: Continue to Discourse links are now buttons, and those pages will redirect automatically after 5 seconds 2014-07-23 12:32:12 -04:00
Robin Ward b29b94046c Merge pull request #2569 from lreeves/group-selector-datasource-finder
Move finder logic out of the group-selector component
2014-07-23 11:28:29 -04:00
Robin Ward 0a0d32efb4 TRIVIAL: Rename `map` to `idMap` because `map` means something for
enumerables.
2014-07-23 11:11:13 -04:00
Robin Ward 1a7eacc70a Merge pull request #2568 from lebek/optimize-category-lookup
Optimize Finding a Category by Id
2014-07-23 11:06:54 -04:00
Robin Ward 016927d5b9 Merge pull request #2566 from minasmart/master
Enumerate deferred scripts with a sprockets helper
2014-07-23 11:00:38 -04:00