0f2a303f00
Remove irrelevant comment.
2017-09-08 14:07:24 +08:00
5d4221fbe1
PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
657440b8be
FIX: consecutive_visits query wasn't properly setting 'granted_at' (3rd time's a charm)
2017-09-07 18:41:56 +02:00
58321d0783
PERF: Remove `Object#present?` check introduced in e0d5d9670a.
2017-09-07 21:36:27 +08:00
7d350d0d75
Revert plugin js changes ( #5139 )
...
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134 )"
This reverts commit b840170f8d#5103 )"
This reverts commit a14ab48829
2017-09-07 15:15:29 +02:00
e0d5d9670a
Fix the build.
2017-09-07 18:41:44 +08:00
3e123b1a39
PERF: Use `pluck` instead of enmurating through all the records.
2017-09-07 17:24:23 +08:00
4d840d10db
PERF: Reduce number of Redis hits per requests.
2017-09-07 13:34:27 +08:00
db920673dc
FIX: consecutive_visits query wasn't return only the first result per user
2017-09-07 01:08:28 +02:00
8a935a4b5f
FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days
2017-09-06 22:35:08 +02:00
a14ab48829
Do not load javascripts for disabled plugins ( #5103 )
...
* Do not load javascript for disabled plugins
* Appease rubocop
2017-09-06 10:06:47 +02:00
db929e58fc
FIX: Don't allow staff to approve users with unverified emails
2017-09-04 12:55:39 -04:00
cb56dcdf2e
FIX: Use proper `iconNode` when compiling virtual dom templates
2017-09-01 11:20:33 -04:00
dffb1fc4ee
FEATURE: Use Glimmer compiler for widget templates
...
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.
Example:
```javascript
createWidget('post-link-arrow', {
template: hbs`
{{#if attrs.above}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
{{fa-icon "arrow-up"}}
</a>
{{else}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
{{fa-icon "arrow-down"}}
</a>
{{/if}}
`,
click() {
DiscourseURL.routeTo(this.attrs.shareUrl);
}
});
```
2017-09-01 09:28:16 -04:00
7f8a90ef63
remove non english comment
2017-08-31 17:00:37 -04:00
48e95f01fc
Version bump to v1.9.0.beta8
2017-08-31 14:54:44 -04:00
e7885c20cb
Add reloadable support for patching in an avatar lookup
2017-08-30 14:24:03 -04:00
df9d662dab
FIX: Use `CASCADE` when dropping function.
2017-08-30 15:54:27 +08:00
54ad436258
Revert "FIX: Drop function first before removing trigger."
...
This reverts commit d229969afa
2017-08-30 15:38:09 +08:00
d229969afa
FIX: Drop function first before removing trigger.
2017-08-30 15:33:25 +08:00
c705159d22
Remove email column from user table
2017-08-29 11:50:56 -04:00
6bc74ceb50
Split alias levels in mentionable and messageable levels. ( #5065 )
...
* Split alias levels in mentionable and messageable levels.
* Fixed some tests.
* Set messageable level to everyone by default.
* By defaults, groups are not mentionable or messageable.
* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
552fbd3c8d
lint
2017-08-28 12:25:34 -04:00
4b5724ec02
Extend config/version.rb with more informations ( #5061 )
...
This gives installations not using git checkouts
to provide all the informations needed for the
internal version checks and version display in
the dashboard.
The build:stamp rake task was extended to also
add the new informations.
2017-08-28 12:24:56 -04:00
bb3a5910d7
Support for sending PMs to email addresses ( #4988 )
...
* Added support for sending PMs to email addresses.
* Made changes after review.
* Added settings validator.
* Fixed tests.
2017-08-28 12:07:30 -04:00
4623b46b0b
rescue error when remapping permalinks
2017-08-28 20:43:40 +05:30
6e1809ce32
add a debugging task for running all schedules
2017-08-25 12:19:34 -04:00
2c56f8df7c
FEATURE: show tags in search results
2017-08-25 11:52:59 -04:00
fef08c6fee
FEATURE: rake db:stats
...
Basic rake task to provide db stats like largest tables, row count and size
2017-08-25 10:29:04 -04:00
70f7a0ca1a
new rake task to remap old phpbb links
2017-08-25 15:09:11 +05:30
0b58848895
FIX: Category badge style of none was causing errors when rendering
2017-08-24 13:45:32 -04:00
fdc5c080ea
FIX: bump default max for int site settings to a much higher number
...
(close to long int)
2017-08-24 10:16:41 -04:00
7c15b27a90
Merge pull request #5073 from xrav3nz/extract-github-avatar
...
FEATURE: import Github profile picture
2017-08-23 16:18:46 +09:00
5868508e98
GH#retrieve_avatar: simplify conditional and restructured testing
2017-08-22 23:46:50 -04:00
49ddc98b38
Merge pull request #5066 from davidtaylorhq/docker-lint-changes
...
Docker lint SINGLE_PLUGIN
2017-08-23 09:56:15 +09:00
49f0119c12
FEATURE: import Github profile picture
2017-08-22 20:23:47 -04:00
bcf7dc38c2
FEATURE: server side support for upload:// markdown
...
This allows uploads to be specified using short sha1 hash instead of full
URL
Client side change is pending
2017-08-22 11:46:23 -04:00
ed6e1c3825
Combine docker:lint and docker:test into one command
2017-08-22 13:47:29 +01:00
2d4d76472d
FIX: Broken suspect user lists.
...
https://meta.discourse.org/t/server-error-code-500/68404
2017-08-22 11:16:55 +09:00
a3f5878ec9
Use `if`, not `unless`
2017-08-18 22:12:20 +01:00
7704e8246b
Allow SINGLE_PLUGIN environment variable to be used
2017-08-18 22:04:35 +01:00
ea43f50f6d
Add documentation for new ENV variables
2017-08-18 22:03:09 +01:00
aeedecd27c
correct erratically failing spec
2017-08-18 15:10:37 -04:00
d65570a8a1
Preparation for using chrome for qunit in docker images ( #5062 )
...
Move use_chrome option to ENV variable
Rewrite script to work with node 6 (current LTS version used in discourse_docker)
Add node stuff to gitignore
2017-08-18 14:08:58 -04:00
8ecf383c55
Extract linter in `docker:test` Rake task into `docker:lint`.
2017-08-18 12:22:01 +09:00
a83bd537f4
FIX: exception in excerpt parser for null nodes
2017-08-17 16:13:30 -04:00
df5142493c
Version bump to v1.9.0.beta7
2017-08-17 15:59:29 -04:00
0e656ff213
FIX: Can't reset AR schema cache due to versions table.
2017-08-17 19:27:35 +09:00
2157079d09
Add Plugin API to register a category custom field.
2017-08-17 15:59:57 +09:00
55f449edc5
FIX: reloading issues with classes
2017-08-16 23:00:52 +02:00
f9ff06b9d4
Allow ENV variable to force polling
2017-08-16 12:59:38 -04:00
0daeefc977
Version bump to v1.9.0.beta6
2017-08-16 12:49:25 -04:00
c8220e11f9
Better formatting for CSS errors
2017-08-16 11:48:07 -04:00
c981edfa20
Add option to run qunit tests in headless chrome ( #5054 )
2017-08-16 07:42:42 -04:00
6e59149a77
FIX: rebuild index when engine replaced ( #5021 )
2017-08-16 07:38:34 -04:00
b77aa29e71
Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5
...
FIX: add additional email to tests and clean up resulting mess
2017-08-16 16:19:28 +09:00
86adc8d717
Fix typo.
2017-08-16 13:06:47 +09:00
0b2d65f77a
Include the site setting file path for which a default value is missing.
2017-08-16 11:42:08 +09:00
ed851dbfff
FIX: Avoid publishing a gigantic payload.
...
* Certain sites have way too many categories.
2017-08-16 11:38:30 +09:00
1646bc0031
FIX: fails loud if default setting is not set
...
Noted:
- `push_api_secret_key` is set in initializer. Shimed with ''
- `default_theme_key` is set in seeding. Shimed with ''
2017-08-15 12:07:25 +02:00
506572bf04
FIX: display emojis (set, custom and native) in bio excerpt
2017-08-15 10:05:09 +02:00
7e9b2289bd
UX: make 404 page look better on dark theme
2017-08-15 12:15:56 +05:30
dd665c62f2
FIX: staff count on invites step of wizard should only include real users
2017-08-14 22:17:41 -04:00
0ef7a969f2
Some more HTML to Markdown fixes ( #5046 )
...
* FIX: handle spaces better within emphasis tags in html_to_markdown
* FIX: handle line breaks at beginning of emphasis tags in html_to_markdown
2017-08-14 22:13:24 +02:00
6fcb530b56
UX: setup wizard won't offer pre-existing users with reserved usernames
2017-08-14 15:31:57 -04:00
89e919ec42
UX: keep emojis in excerpts in flag queue
2017-08-14 15:16:47 +02:00
2f3f5477b0
UX: fix category badge style on 404 page
2017-08-14 16:26:25 +05:30
5ed809a15b
FIX: Reloading issues with classes
2017-08-13 13:19:50 -04:00
51ef36abb4
Add a bunch of reload-friendly class variables accessors plugin APIs
2017-08-12 04:21:02 +02:00
75e4f7f896
Shorten some very long lines
...
Prevent warnings from already defined constants when reloading
2017-08-12 04:18:04 +02:00
c924975086
FIX: wizard should only include human admins and system user as the site contact username options
2017-08-11 15:29:07 -04:00
59423b693b
Merge pull request #5035 from nbianca/remove_spork
...
Remove Spork dependency.
2017-08-11 09:52:16 +09:00
1c079bec33
Remove Spork dependency.
2017-08-10 22:54:52 +01:00
f7d3702454
FIX: Return 404 if API access is invalid.
2017-08-10 18:27:01 +09:00
dc15e48334
FIX: You can't cache the files here, plugin translations won't work
2017-08-09 17:28:11 -04:00
04460ecac5
'add_to_serializer' should define the 'include_' method by default
2017-08-09 22:22:18 +02:00
53e6ccf17b
Allow reloading of translation keys for plugins in development mode
2017-08-09 13:58:20 -04:00
f11253dcb6
Allow plugin patches to reload in development mode
2017-08-09 12:30:27 -04:00
a1f60cfcb8
Fix incorrect test migration.
2017-08-10 00:20:07 +09:00
7b3631454d
FIX: In development mode on OSX, plugin stylesheets were not reloading
...
It seems to be due to symlinks in the plugins folder. Watching
the individual plugins seems to fix the issue rather than the entire
plugin folder.
2017-08-09 11:06:27 -04:00
5324c9817f
FIX: Title prettify shoundn't downcase all non-ascii titles
2017-08-08 14:03:24 -03:00
6cd8203686
FIX: allows onebox to force GET hosts returning wrong headers on HEAD
2017-08-08 11:44:27 +02:00
2c39743d5d
Introduce multisite tests for better coverage.
2017-08-08 12:58:22 +09:00
764957dfc4
Merge pull request #5030 from tgxworld/fix_defaults_cache_cross_talk
...
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 17:07:31 +09:00
22a1db7b8a
FIX: Make `DbProvider#table_exits?` work with multisite.
2017-08-07 16:37:42 +09:00
c5850422f0
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 15:16:57 +09:00
412fa78b1f
FIX: `default_locale` cross talk in multisite setup.
2017-08-07 11:14:28 +09:00
3f24ed2b3e
Can't revert due to incompatibility of new site setting types.
...
Revert "Revert "FEATURE: Site settings defaults per locale""
This reverts commit 439fe8ba24
2017-08-07 10:43:09 +09:00
439fe8ba24
Revert "FEATURE: Site settings defaults per locale"
...
This reverts commit 468a8fcd20
2017-08-07 10:31:50 +09:00
ecbeaed0bc
fix weird indentation
2017-08-04 17:28:25 +02:00
c76161787c
eager load more tables for the topic_view
2017-08-04 17:23:53 +02:00
99527af38a
FIX: show rejected emails with unrecognized errors ( #5026 )
...
Although 407a23663d
2017-08-04 16:20:44 +02:00
c0a2d9e671
Make rubocop happy
2017-08-04 12:30:35 +05:30
687b05750b
add Permalinks support for vBulletin bulk import script
2017-08-04 12:23:11 +05:30
2d909f7894
new phpBB PostgreSQL bulk import script
2017-08-03 21:21:58 +05:30
8cc8010564
Maintain backwards compatibility before `Jobs::MigrateUploadExtensions` runs.
2017-08-03 11:56:55 +09:00
a47e297508
Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
...
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
65d5cd7239
FIX: generate valid markdown from <br></b> in an email ( #5022 )
...
* FIX: generate valid markdown from <br></b> in an email
* FIX: don't generate markdown for empty <strong> or <em> tags in emails
2017-08-02 23:02:59 +02:00
f6bc572fb8
FEATURE: option to enable inline oneboxes for all domains
...
Also, change to prefer title over open graph which is often way too sparse
2017-08-02 14:27:31 -04:00
582ae9ab8d
Add some more debugging information when a plugin can't find a gem
2017-08-02 14:00:18 -04:00
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
9bc3038728
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-02 21:33:56 +09:00
ea032d8372
Improve source code linting for continuous integration ( #5017 )
...
* Add rubocop linting to docker:test rake task
* Add eslint JS listing to plugin files, and add SKIP_LINT variable
* Fix failing ‘polls’ plugin eslint
Using eslint-disable-line, as is done in core qunit tests such as `acceptance/group-logs-test.js.es6`
* Add plugin test eslint to travis config
* Merge some eslint lines
2017-08-02 11:33:29 +09:00
97fa64d846
FIX: non tag/category # searches should be passed through
2017-08-01 18:15:14 -04:00
71ad3a48c2
Correct flaky distributed cache test
...
make distributed cache more testable
2017-08-01 16:11:48 -04:00
a870137845
Version bump to v1.9.0.beta5
2017-08-01 14:32:24 -04:00
7d5b6e2b3c
Disable MessageBus's keepalive when Redis is readonly.
2017-08-01 23:07:52 +09:00
1fdf2e4d4b
badly resolved conflicts
2017-07-31 20:28:16 -04:00
fa3c240e8b
Merge pull request #4981 from dmacjam/fix_limited_search_results
...
FIX: limited search results
2017-07-31 20:23:57 -04:00
836dee1120
FIX: add additional email to tests and clean up resulting mess
2017-07-31 22:27:29 +00:00
7c1d7fb423
Merge branch 'master' into fix_limited_search_results
2017-07-31 15:55:31 -04:00
f1eccd113c
Replace rmmseg gem for cppjieba_rb since better dictionary ( #5006 )
...
* Rename locale to ts config in search module to make it clear
* Replace rmmese-cpp for cppjieba_rb
2017-07-31 15:28:48 -04:00
83011045c8
fix rubocop offenses
2017-07-31 11:59:16 -04:00
5d528f0d15
Merge pull request #4958 from dmacjam/search_posts_by_filetype
...
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
4a5907b116
Merge branch 'master' into search_posts_with_images
2017-07-31 10:44:41 -04:00
b059a0f789
extract url escaping to a dedicated class method and improved tests
2017-07-29 22:16:51 +05:30
1fe553873c
FIX: preserve fragment identifier when escaping url
2017-07-29 17:22:45 +05:30
da5e7dc876
FIX: Pull last emoji-db revision
...
This commit will add new images in some sets and fix a bug where
🤦♂️ was using :person_facepalming: image which is in fact
represented as a woman in most sets.
2017-07-29 13:12:45 +02:00
43fd90b2da
Remove serve_public_dir -- it's not needed
2017-07-28 13:44:38 -04:00
5ae79697b8
Remove unused `register_theme` code, expose `serve_public`
2017-07-28 11:47:25 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
68b3dd43ce
fix intermittent failing tests, some watched word refactoring
2017-07-27 12:27:01 -04:00
5cfc2d8972
Run wizard specs in docker:test
2017-07-27 11:29:18 -04:00
6fc5ece628
FIX: onebox for dropbox video links not working
...
add dropbox to the list of ignore redirects for onebox links
2017-07-26 14:37:54 -06:00
2d41c5ed3c
missing bracket
2017-07-26 13:11:08 -04:00
2c6ed64ebe
Spawn a new rake process to run tests, so that LOAD_PLUGINS gets re-checked ( #5001 )
2017-07-26 12:54:56 -04:00
24cb950432
FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block
2017-07-26 11:01:09 -04:00
ea0e90b2b0
Merge branch 'master' into search_posts_with_images
2017-07-26 10:15:55 -04:00
febd7621ea
Qunit plugin rake tasks ( #4985 )
...
* Allow running specific plugin tests using ENV variables
* Add a `rake plugin:qunit` task to match the existing `rake plugin:spec` task
* Improve docker.rake to allow running specific plugin qunit tests
* Purge cache before and after qunit tests
* Stop module auto-loader trying to auto-load tests
* Use URL query parameters to pass config into Qunit, avoiding caching issues
* Oops, searchParams doesn’t work in phantomJS. Parse the URL manually.
* Escape ampersands before passing URL to phantomJS, otherwise multiple parameters go wrong
2017-07-26 09:07:46 -04:00
e3ac6585bd
FIX: Search by topic_id should not be restricted by `SiteSetting.min_search_term_length`.
2017-07-26 09:52:39 +09:00
96267f0845
Merge pull request #4960 from discourse/category-description-error
...
FIX: Explicit error when category description post is bad
2017-07-26 08:54:22 +09:00
d8c27e3871
Merge branch 'master' into search_posts_by_filetype
2017-07-25 14:41:20 -04:00
400a55eca3
Merge pull request #4995 from davidtaylorhq/qunit-warmup
...
Improve “server warmup” check for qunit rake task
2017-07-25 11:39:32 -04:00
4ad864892b
Improve “server warmup” check for qunit rake task
2017-07-25 16:31:30 +01:00
283d42d6f3
FEATURE: allow bisect and rspec seed
2017-07-25 11:09:51 -04:00
c7c93e7159
FEATURE: new 'strip image metadata' site setting
2017-07-25 11:48:39 +02:00
8a362a1c3c
Reset ActiveRecord cache after dropping columns.
2017-07-25 15:36:30 +09:00
dd932217ca
Fix docker tests not loading plugins.
2017-07-25 15:27:09 +09:00
04eac9f14a
lets attempt to get these specs working!
2017-07-24 18:35:20 -04:00
f67e715ef1
comment out specs that break others
...
will check in a fixed spec tomorrow
2017-07-24 17:28:24 -04:00
f97fb7b70c
tighten time to stop schedueler
2017-07-24 15:19:54 -04:00
0c47153808
clean up stop semantics
2017-07-24 15:17:48 -04:00
c08a7aee8f
clean up skipped tests
...
tighter connection handling in scheduler
2017-07-24 15:06:24 -04:00
66ef7976ea
FIX: don't re-scheduler correctly scheduled daily tasks
2017-07-24 14:30:43 -04:00
d940166a89
Re-enable skipped `Scheduler::ScheduleInfo` test.
2017-07-25 00:03:03 +09:00
e82efc7b03
Fix `SiteSetingExtension` specs to coerce int to string.
2017-07-24 22:54:42 +09:00
d792e81372
don't pollute test suite with warning message from readonly Redis
2017-07-24 10:22:32 +02:00
1b0750d7ef
Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
...
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
440b95a6f3
correctly return all v8 data as opposed to just one context
2017-07-21 16:37:19 -04:00
2f8f2aa1dd
FEATURE: Whitelists for inline oneboxing
2017-07-21 15:41:47 -04:00
Guo Xiang Tan
Régis Hanol
David Taylor
Robin Ward
Sam Saffron
Bianca Nenciu
darix
Arpit Jalan
Neil Lalonde
Guo Xiang Tan
Kyle Zhao
Erick Guan
Joffrey JAFFEUX
Leo McArdle
Bianca Nenciu
Rafael dos Santos Silva
Blake Erickson