77c48644eb
FIX: Dismissing unread topics with a tag ( #11832 )
...
This commits add missing router service to the mixin. It did not work
because 'router' was undefined.
2021-01-25 15:16:21 +02:00
21d6603245
DEV: followup to 8edd2b38cb to use existing spec ( #11830 )
...
This commit also better explains in spec why max_values might be off by one.
2021-01-25 12:04:27 +01:00
bed011feef
A11Y: uses role=button and supports ariaPressed for tapTile ( #11827 )
2021-01-25 11:31:52 +01:00
8edd2b38cb
FIX: ensures timeline_lookup includes last tuple ( #11829 )
...
A simplified version of the logic used in the function before my fix is as follow:
```ruby
result = []
things = [0,1,2,3]
max_values = 2
every = (things.size.to_f / max_values).ceil
things.each_with_index do |t, index|
next unless (t % every) === 0
result << t
end
p result # [0, 2]
# 3 doesn’t get included
```
The problem is that if you get unlucky two times you won't get last tuple(s) and might get a very erroneous date.
Double unlucky:
- last tuple index % computed every !== 0 and you don't get the last tuple
- the last tuple is related to a post with a very different date than the previous tuples (on year difference in our case)
2021-01-25 11:30:59 +01:00
aa1138ff71
FIX: reindex_search job should work on model with no search data ( #11819 )
...
Lots of changes but it's mostly a refactoring.
The interesting part that was fix are the 'load_problem_<model>_ids' methods.
They will now return records with no search data associated so they can be properly indexed for the search.
This "bad" state usually happens after a migration.
2021-01-25 11:23:36 +01:00
fcbb6c4143
FIX: remove rendering UX from bookmark model ( #11765 )
...
Fix for `bookmark.js` model. Most logic was moved to `topic` controller
2021-01-25 09:35:13 +11:00
0a51999a46
Build(deps): Bump rubocop-ast from 1.4.0 to 1.4.1 ( #11823 )
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.4.0...v1.4.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:47:38 +01:00
0a1b1f1aa3
Build(deps): Bump oj from 3.11.0 to 3.11.1 ( #11824 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.11.0...v3.11.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:46:23 +01:00
831e29873d
Build(deps): Bump ast from 2.4.1 to 2.4.2 ( #11825 )
...
Bumps [ast](https://github.com/whitequark/ast ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/whitequark/ast/releases )
- [Changelog](https://github.com/whitequark/ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/ast/compare/v2.4.1...v2.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:45:44 +01:00
2ab5637792
Build(deps-dev): Bump shoulda-matchers from 4.5.0 to 4.5.1 ( #11826 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.5.0...v4.5.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-24 22:44:45 +01:00
37f7f30640
edit button fix, follow up to 6f13d2b ( #11821 )
2021-01-22 20:31:01 -05:00
17e683d373
UX: Simplify narrative bot bio ( #11820 )
2021-01-22 17:21:26 -08:00
6d30e01d1c
A11Y: Structure user menu as tabs. ( #11789 )
...
* A11Y: Structure user menu as tabs.
Although the user menu content has the appearance of tabs and relies on the functionality of tabs to make sense in terms of content and focus order, it is not marked up correctly as tabs and tab panels. See [WAI-ARIA Authoring Practices 1.1](https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel ) and the [example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html ) for details.
* Make plugin api backwards compatible
2021-01-22 19:05:14 -03:00
73cb083b7b
FIX: Cannot find currentThemeColorSchemeId when no themeId is present ( #11817 )
2021-01-22 16:27:19 -05:00
cd11689446
FIX: Check the confirmation result before deleting SSO record ( #11816 )
2021-01-22 19:16:43 +00:00
56294b4fba
FIX: Remove scheduled DND timings when schedule is disabed ( #11814 )
2021-01-22 13:02:11 -06:00
6f13d2b039
A11Y: makes post-edits-indicator a button instead of a link ( #11811 )
2021-01-22 17:09:39 +01:00
dc268822a4
FIX: It seems sometimes shims are evaluated by older JS engines ( #11813 )
...
This gives us backwards compatibility with those.
2021-01-22 10:41:01 -05:00
4f01ca87e3
FEATURE: Add new features section in admin dashboard ( #11731 )
2021-01-22 10:09:02 -05:00
71656d2c37
UX: Makes the theme editor display placeholder correctly for RTL languages ( #11800 )
...
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-he#53834
2021-01-22 16:03:43 +01:00
436c8e9bcd
DEV: eslint rules should be defined in eslint-config-discourse ( #11812 )
2021-01-22 15:48:23 +01:00
f2fcc3d21a
Build(deps): Bump sidekiq from 6.1.2 to 6.1.3 ( #11794 )
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.1.2 to 6.1.3.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.1.2...v6.1.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-22 09:42:34 -05:00
5a5f6905d7
Build(deps): Bump logster from 2.9.4 to 2.9.5 ( #11796 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.9.4 to 2.9.5.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.9.4...v2.9.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-22 09:41:23 -05:00
15b5bd4e14
UX: show onebox error preview image as favicon ( #11810 )
2021-01-22 20:05:28 +05:30
039b4111e3
FIX: print raw html of logo image to skip unwanted html encoding ( #11805 )
...
Currently, the image logo is broken since the image tag is rendering incorrectly.
2021-01-22 19:48:01 +05:30
314e7be2b1
A11Y: improves search-in-options filter accessibility ( #11809 )
2021-01-22 14:39:16 +01:00
7521cb51c4
A11y: makes advanced search and html heading ( #11808 )
2021-01-22 14:35:17 +01:00
e81d93cf26
UX: specify width and height for onebox preview error image ( #11807 )
2021-01-22 19:02:23 +05:30
d2cf43a7d5
FIX: Update categories without full page refresh ( #11793 )
...
Creating or moving a category required a full page refresh until it
showed up correctly.
2021-01-22 10:21:09 +02:00
9e6ff9cc67
A11Y: associate search controls with their labels ( #11806 )
2021-01-21 22:24:15 -05:00
e031679f99
A11Y: Add aria-label to input clear button ( #11803 )
2021-01-21 21:58:34 -05:00
ff095e7249
A11Y: Update selected name role to button ( #11804 )
2021-01-21 21:58:06 -05:00
c889b676f8
DEV: Updates to api docs schema validation ( #11801 )
...
- Read in schemas from actual json files instead of a ruby hash. This is
helpful because we will be automatically generating .json schema files
from json responses and don't want to manually write ruby hash schema
files.
- Create a helper method for rspec schema validation tests to dry up code
2021-01-21 18:23:23 -07:00
7434116933
DEV: Add schema checking to api doc testing ( #11721 )
...
* DEV: Add schema checking to api doc testing
This commit improves upon rswag which lacks schema checking. rswag
really only checks that the https status matches, but this change adds
in the json-schema_builder gem which also has schema validation.
Now we can define schemas for each of our requests/responses in the
`spec/requests/api/schemas` directory which will make our documentation
specs a lot cleaner.
If we update a serializer by either adding or removing an attribute the
tests will now fail (this is a good thing!). Also if you change the type
of an attribute say from an array to a string the tests will now fail.
This will help significantly with keeping the docs in sync with actual
code changes! Now if you change how an endpoint will respond you will
have to update the docs too in order for the tests to pass. :D
This PR is inspired by:
https://www.tealhq.com/post/how-teal-keeps-their-api-tests-and-documentation-in-sync
* Swap out json schema validator gem
Swapped out the outdated json-schema_builder gem with the json_schemer
gem.
* Add validation fields to schema
In order to have "strict" validation we need to add
`additionalProperties: false` to the schema, and we need to specify
which attributes are required.
Updated the debugging test output to print out the error details if
there are any.
2021-01-21 16:28:08 -07:00
872f3e6934
UX: warn about messages to be orphaned while deleting a group. ( #11727 )
...
Currently, after destroying a group its messages are inaccessible to everyone. Only admins can access using direct URLs.
2021-01-22 03:29:34 +05:30
5cbb522c41
FIX: broken URL when username contains subfolder. ( #11786 )
...
The bug was mentioned on [meta](https://meta.discourse.org/t/two-bugs-with-usernames-starting-with-subfolder-name/169505 )
When discourse is installed on `/subfolder` and username is containing subfolder name like for example `subfolderadmin` - user URLs were incorrect.
Instead of having `/subfolder/u/subfolderadmin/summary/` we were leading to `/subfolder/uadmin/summary`.
The reason for that was incorrect check in `getUrl` helper:
```javascript
const found = url.indexOf(baseUri);
if (found >= 0 && found < 3) {
return url;
}
return baseUri + url;
```
baseUri is `/subfolder`, url is `/u/subfolderadmin` and indexOf returned position which in the end returned incorrect URL.
I think that we should check if the URL starts with baseUri and not if contains baseUri.
2021-01-22 08:43:14 +11:00
a8c5ef7dff
Build(deps-dev): Bump bullet from 6.1.2 to 6.1.3 ( #11798 )
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 6.1.2 to 6.1.3.
- [Release notes](https://github.com/flyerhzm/bullet/releases )
- [Changelog](https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/6.1.2...6.1.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-21 22:38:35 +01:00
ecd51197aa
Build(deps): Bump css_parser from 1.7.1 to 1.8.0 ( #11797 )
...
Bumps [css_parser](https://github.com/premailer/css_parser ) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/premailer/css_parser/releases )
- [Changelog](https://github.com/premailer/css_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/premailer/css_parser/compare/v1.7.1...v1.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-21 22:38:03 +01:00
5573d9eab9
Build(deps-dev): Bump test-prof from 0.12.2 to 1.0.0 ( #11795 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 0.12.2 to 1.0.0.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/commits/v1.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-21 22:37:11 +01:00
83347ac218
DEV: Sync up more Ember CLI features ( #11790 )
...
This is mostly changes to acceptance tests to allow them to run in both
versions of Ember.
2021-01-21 15:55:39 -05:00
4c0aa20dae
FIX: Share popup is positioned incorrectly in RTL locales ( #11792 )
2021-01-21 23:52:24 +03:00
c232b5a291
Version bump to v2.7.0.beta2
2021-01-21 14:52:01 -05:00
5f410979e2
UX: Make moment.js produce Arabic numerals instead of Hindi numerals in the Arabic locale ( #11788 )
...
Signed-off-by: OsamaSayegh <asooomaasoooma90@gmail.com>
2021-01-21 22:11:51 +03:00
53ab3dda5d
FIX: Embedded comments should only return regular posts ( #11773 )
...
There shoudln't be a situation where you'd want to see moderator actions
or small posts.
2021-01-21 12:47:03 -05:00
fb9e422bd6
FIX: Show the fallback locale warning when both settings are enabled. ( #11787 )
...
We only want to warn admins when both settings are enabled. When "set locale from accept language header" setting is enabled, the user locale will be set based on the header when they register an account on the site, which could be confusing.
2021-01-21 13:09:32 -03:00
b6afcf98b9
DEV: Remove an unused i18n string ( #11783 )
...
Originally added in 95ad4f90773bbd8b1258
2021-01-21 12:32:44 +01:00
9ee8a01c3a
FIX: Change default for IncomingEmail#created_via to 0 (unknown) and make NOT NULL ( #11782 )
...
Follow up to https://review.discourse.org/t/dev-add-created-via-column-to-incomingemail-pr-11751/18366/6
2021-01-21 12:59:50 +10:00
9d287f5ff9
Build(deps): Bump oauth from 0.5.4 to 0.5.5
...
Bumps oauth from 0.5.4 to 0.5.5.
Signed-off-by: dependabot[bot] <support@github.com>
2021-01-21 10:12:45 +08:00
c6bde9f239
DEV: Remove Dangerfile
...
We aren't using it anymore
2021-01-21 10:12:17 +08:00
3c42611096
It's 2021 🥳
2021-01-21 10:11:59 +08:00
Dan Ungureanu
Joffrey JAFFEUX
Régis Hanol
Krzysztof Kotlarek
dependabot[bot]
Kris
tshenry
Roman Rizzi
Penar Musaraj
David Taylor
Mark VanLandingham
Robin Ward
Gerhard Schlager
Arpit Jalan
Vinoth Kannan
Bianca Nenciu
Blake Erickson
Osama Sayegh
Neil Lalonde
Jarek Radosz
Martin Brennan
Gerhard Schlager