69779f79d9
DEV: Bump pg from 1.2.1 to 1.2.2 ( #8685 )
...
Bumps [pg](https://github.com/ged/ruby-pg ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/ged/ruby-pg/releases )
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc )
- [Commits](https://github.com/ged/ruby-pg/compare/v1.2.1...v1.2.2 )
Very safe upgrade, Discourse is not impacted by any of the changes.
2020-01-13 12:02:44 +11:00
c9327fce12
Build(deps-dev): Bump minitest from 5.13.0 to 5.14.0 ( #8703 )
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.13.0 to 5.14.0.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/compare/v5.13.0...v5.14.0 )
Very safe change only impacts our test framework.
2020-01-13 12:01:40 +11:00
d8412f409a
DEV: resolve symlinks in docker dev
...
symlinks where not fully resolved leading to docker not booting when you
had symlinks in the plugins directory pointing at relative paths.
2020-01-13 10:33:34 +11:00
1a31a403ce
DEV: Remove buffered-render file
...
This is the last and final commit in a multi-commit refactor to remove
all uses of buffered-render.
Previous commit: fc94b6cb9e
2020-01-10 18:19:23 -07:00
648a1124eb
FIX: Specs with old filename
2020-01-10 15:29:35 -05:00
72c3f36e58
Add optional file to precompile list
2020-01-10 15:14:32 -05:00
556d66a97c
FIX: Use CDN for the `discourse-internet-explorer`
...
Previously the CDN was skipped because the assets were not in the proper
place to be uploaded.
2020-01-10 15:06:55 -05:00
687c79ca1c
FIX: Remove padding while composer is saving
...
Padding on `#main-outlet` while compooser was in "saving" state was causing posts to bounce after replying.
2020-01-10 12:57:16 -05:00
7ee09aa0d2
FIX: Ran prettier on user-selector-test ( #8700 )
2020-01-10 09:27:41 -08:00
5898afaa73
FEATURE: pass in excluded usernames to user-selector ( #8695 )
2020-01-10 09:02:43 -08:00
5a70f50032
FEATURE: Use new Badging API
...
Now that the spec is finished use the unprefixed API, which was also moved
from window to navigator.
Still uses feature detection so it fail gracefully when not available in
the user agent.
2020-01-10 13:41:35 -03:00
3ddebc61a9
Build(deps): Bump public_suffix from 4.0.2 to 4.0.3 ( #8663 )
...
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby ) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/weppos/publicsuffix-ruby/releases )
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/4.0.2...4.0.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-10 10:04:54 -05:00
aa9450646b
Build(deps-dev): Bump test-prof from 0.10.1 to 0.10.2 ( #8676 )
...
Bumps [test-prof](https://github.com/palkan/test-prof ) from 0.10.1 to 0.10.2.
- [Release notes](https://github.com/palkan/test-prof/releases )
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/palkan/test-prof/compare/v0.10.1...v0.10.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-10 10:03:56 -05:00
d0cd08a67c
Build(deps): Bump parser from 2.7.0.1 to 2.7.0.2 ( #8686 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 2.7.0.1 to 2.7.0.2.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v2.7.0.1...v2.7.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-10 10:03:11 -05:00
815116f6a2
FIX: Make 'findBySlugPathWithID' when URL ends with a slash ( #8699 )
...
Make URLs such as 'https://discourse/c/foo/bar/ ' work the same way
'https://discourse/c/foo/bar ' does.
2020-01-10 17:02:36 +02:00
6e480392ea
Build(deps): Bump aws-sdk-core from 3.86.0 to 3.87.0 ( #8696 )
...
Bumps [aws-sdk-core](https://github.com/aws/aws-sdk-ruby ) from 3.86.0 to 3.87.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-10 10:01:57 -05:00
5ce602ecea
FIX: prevents url of file from being pasted when pasting file on iOS ( #8693 )
2020-01-10 08:39:01 +05:30
cb660ef952
SECURITY: Improve second factor auth logic
2020-01-10 10:45:56 +10:00
dd52291fb7
UX: Center featured topic on mobile profiles
2020-01-09 16:35:34 -05:00
ef9828b25d
UX: Remove reliance on JS for category box links
2020-01-09 16:25:41 -05:00
dcbe527a82
FIX: Don't log a claimed topic database error during tests
...
We now test the uniqueness validation, but also rescue a DB
exception in case the controller fails this check.
2020-01-09 12:32:05 -05:00
d043a4c6fe
FIX: Stop logging errors in postgres on reviewable conflict
...
The previous concurrency-safe implementation relied on catching an
index conflict and following through appropriately. Unfortunately
those conflicts were logged to Postgres and there is no easy way
to turn them off.
This solution approaches the problem differently. It should still
be safe under concurrency and not log errors.
2020-01-09 12:04:17 -05:00
531016f99b
DEV: Add missing indexes to user_profiles ( #8691 )
...
* DEV: Update model annotations
* DEV: Add missing indexes to user_profiles
The columns were changed in 24347ace10 (diff-baa5914c0c7cddf3c8b5cd9139e0d091)
2020-01-09 17:08:55 +01:00
2a06f67099
FIX: Decompressing lots of small files triggered error
...
An archive containing lots of small files could trigger an error even though the amount of decompressed data was way below the maximum allowed size. This happened because the decompression algorithm used the chunk size for calculating the remaining size instead of the actual size of the decompressed chunk.
2020-01-09 15:11:31 +01:00
8b3c40c79d
DEV: Bump mini_racer from 0.2.8 to 0.2.9 ( #8688 )
...
Bumps [mini_racer](https://github.com/discourse/mini_racer ) from 0.2.8 to 0.2.9.
- [Release notes](https://github.com/discourse/mini_racer/releases )
- [Changelog](https://github.com/rubyjs/mini_racer/blob/master/CHANGELOG )
- [Commits](https://github.com/discourse/mini_racer/compare/v0.2.8...v0.2.9 )
Very safe change, adds support for JavaScript Symbol which used to cause segfaults.
2020-01-09 13:11:26 +11:00
007c44ec56
Revert "DEV: Add smoke test to github actions ( #8580 )"
...
This is proving unreliable, so removing for now
This reverts commit 38b4e3b5a7
2020-01-08 23:38:11 +00:00
2d84bea653
DEV: watch for changes to plugin mobile/desktop SCSS
...
Previously, the watcher was only refreshing changes to non-targeted plugin stylesheets.
2020-01-08 13:25:36 -05:00
2683b7793b
REFACTOR: Simplify user title comparison
...
Follow-up to 6d6ffe51
2020-01-08 18:39:10 +01:00
92a9ae6ab0
REFACTOR: isValidLink
...
- Reduced verbose comments
- Merged 2 `if` which had the same logic
2020-01-08 18:14:24 +01:00
6d6ffe5131
FIX: Allow users to change title in locales other than English
2020-01-08 18:08:04 +01:00
5eda44f8f2
FIX: Do not redirect to `/auth/*` urls after authentication
...
When using the login confirmation screen, the referrer URL is `/auth/{provider}`. That means that the user is redirected back to the confirmation screen after logging in, even though login was successful. This is very confusing. Instead, they should be redirected to the homepage.
2020-01-08 17:06:03 +00:00
e616b92511
FIX: If the admin sso sync has no external ID, don't throw an error
...
Instead, return a HTTP error code and a message explaining the problem,
to avoid log pollution.
2020-01-08 11:47:37 -05:00
4d5b142f1d
DEV: Allow `doLogin` to be called with a set of parameters
...
This can be used for themes/plugins to specify additional URL parameters to be used when starting authentication. Example usage:
```
LoginMethod.findAll()[0].doLogin({params: {mydata: "myvalue"}});
```
2020-01-08 16:13:12 +00:00
502f154cfc
FIX: Don't leak event listeners in user-activity-drafts ( #8682 )
2020-01-08 16:55:10 +01:00
cf60de59b1
FIX: Allow omniauth confirmation page to pass through GET parameters
...
Using the rails `form_tag` helper generates a form with the action attribute set to the current URL (without parameters). In this case, we want to include any GET parameters, so it is better to exclude the action attribute from the form tag, and allow browsers to submit to the current URL.
2020-01-08 15:31:51 +00:00
f1cd599966
DEV: Bump rubocop from 0.78.0 to 0.79.0 ( #8667 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.78.0 to 0.79.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.78.0...v0.79.0 )
Changes seem pretty safe, nothing should impact Discourse. Merging so we are on latest version.
2020-01-08 17:09:24 +11:00
13f229808a
FIX: add noindex header to user profile pages.
2020-01-08 11:26:20 +05:30
bdff4561d4
FIX: Make scrolling to bottom post in topic more consistent ( #8671 )
...
* Make scrolling to bottom post in topic more consistent
* when using the slider to scroll past the bottom post,
we now scroll to the bottom of the post/page IF the
post height is > the window height (e.g. really long
posts). if the post height is smaller, then we lock
onto and jump to the top of the post
* this also removes the mobile hack that would always jump
to the top of the last post on mobile
* Prettier lint
2020-01-08 16:37:13 +11:00
710eafdd35
FIX: ensure we consistently pick the same topic for bench
...
We pick the first topic with 30 responses as our bench topic.
Previously we simply picked the last topic, but hand no guarantee on ordering.
This also attempts to correct previous runs of the bench.
2020-01-08 16:33:45 +11:00
fd6fbaa4ae
DEV: Update bench.rb for core changes ( #8670 )
...
- Use new api key rake task
- Switch to header-based API auth
- Stop hard-coding topic id
2020-01-08 16:23:29 +11:00
a8fbf7c128
minor subcategory box padding adjustments
2020-01-07 20:54:27 -05:00
c01c937151
DEV: Allow returning non-objects from addToolbarPopupMenuOptionsCallback ( #8677 )
2020-01-07 16:01:11 -06:00
cae60b5900
UX: Sub-sub categories in "Boxes with subcategories" + consistency
2020-01-07 16:38:17 -05:00
abff3716ba
Upgrade handlebars ( #8675 )
...
* Upgrade Handlebars to 4.3.0
* Upgrade Handlebars to the latest version
2020-01-07 15:37:37 -05:00
b51b2ccf61
Update browser support matrix
...
Removing Internet Explorer. See https://meta.discourse.org/t/-/137984 for more details
2020-01-07 12:20:46 -05:00
e0539d7ffe
remove log
2020-01-07 11:28:56 -05:00
eef21625c6
Rename 'target usernames' with 'target recipients' in Composer ( #8606 )
...
* Reapply "Rename 'target usernames' with 'target recipients' in Composer"
This reverts commit 9fe11d0fc3ebb288dc2c
2020-01-07 15:33:48 +02:00
50357b161e
DEV: Restore { visible: true } for login button in smoke test
...
This was removed erroneously in 38b4e3b5a7
2020-01-07 12:58:08 +00:00
38b4e3b5a7
DEV: Add smoke test to github actions ( #8580 )
2020-01-07 12:54:01 +00:00
c8d438cc63
DEV: Allow CSP to be enabled during QUnit tests ( #8668 )
...
The QUnit rake task starts a server in test mode. We need a tweak to allow dynamic CSP hostnames in test mode. This tweak is already present in development mode.
To allow CSP to work, the browser host/port must match what the server sees. Therefore we need to disable the enforce_hostname middleware in test mode. To keep rspec and production as similar as possible, we skip enforce_hostname using an environment variable.
Also move the qunit rake task to use unicorn, for consistency with development and production.
2020-01-07 12:22:58 +00:00
dependabot-preview[bot]
Sam Saffron
Blake Erickson
Robin Ward
Penar Musaraj
Mark VanLandingham
Rafael dos Santos Silva
Dan Ungureanu
Joffrey JAFFEUX
Martin Brennan
Kris
Jarek Radosz
Gerhard Schlager
David Taylor
Régis Hanol
Vinoth Kannan
Martin Brennan
Joshua Rosenfeld
Bianca Nenciu