55a1394342
DEV: pluck_first
...
Doing .pluck(:column).first is a very common pattern in Discourse and in
most cases, a limit cause isn't being added. Instead of adding a limit
clause to all these callsites, this commit adds two new methods to
ActiveRecord::Relation:
pluck_first, equivalent to limit(1).pluck(*columns).first
and pluck_first! which, like other finder methods, raises an exception
when no record is found
2019-10-21 12:08:20 +01:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
99856478d6
FIX: use discourse route_for function to check url route
...
it takes care if there is a relative url root
2019-01-11 14:58:45 +08:00
0fca3205b5
FIX: show error msg on grant badge if message available from backend ( #6801 )
2018-12-31 10:46:39 +01:00
1d649e147b
FEATURE: show avatar flair on group, badges and directory pages ( #6732 )
2018-12-06 12:18:52 +01:00
55945ec7c8
FIX: throw error when link in reason for grant badge is an external link ( #6690 )
2018-11-28 18:01:41 +01:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
5003f07b2c
FEATURE: new site setting show_inactive_accounts
2017-12-07 19:22:41 +05:30
628275fc31
FIX: Some badge routes were still working even with badges disabled
2017-11-21 12:22:44 -05:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
0bf001ccd7
FIX: badge grant count wasn't filtered to the current user in the user summary
2016-03-30 23:11:00 +02:00
a656a672a1
FIX: Don't limit the count of badges to 96
2016-03-05 10:57:32 +11:00
ca3e2b4da3
FEATURE: you can not drill down and see why you have badges
...
Clicking on badges filters down the list to a particular user.
2016-01-18 17:59:20 +11:00
8da8999aa1
Revert "FIX: properly filter badges when they're on a whisper"
...
This reverts commit 6b07575632
2015-09-25 10:20:47 +10:00
6b07575632
FIX: properly filter badges when they're on a whisper
2015-09-25 00:30:29 +02:00
8277a586bb
usage of raise corrected
2015-05-07 11:00:51 +10:00
f555bbb416
FEATURE: long descriptions for badges to help teach people
2015-02-27 17:19:18 +11:00
fe578f9944
FEATURE: Allow manual assignment of related post to badge
...
PERF: clean up performance of user badges admin when large number of badges exist
2015-02-25 12:53:01 +11:00
99c11e2184
Sort the badges on the user profile page
...
Also clean up UserBadgesController so it isn't doing two things in one
method
2014-08-25 12:40:51 -07:00
c8284170ad
FEATURE: badge grouping UI
...
FIX: not loading more badges on badge show page
2014-07-18 15:46:36 +10:00
88469721b9
FEATURE: Allow admins to disable specific badges
2014-07-14 17:40:36 +10:00
2e52f795ea
Backend changes to support improved badge pages.
2014-06-28 01:24:00 +05:30
67a2b2598d
Cosmetic changes.
2014-06-19 16:56:18 +05:30
d208e4d517
Multiple grant badges.
2014-05-21 12:54:55 +05:30
4de700b49b
Change badge user list limit to 96 so that it is divisible by 8.
2014-05-19 10:32:59 +05:30
1574485443
Perform the where(...).first to find_by(...) refactoring.
...
This refactoring was automated using the command: bundle exec "ruby refactorings/where_dot_first_to_find_by/app.rb"
2014-05-06 14:41:59 +01:00
4e89b64e64
Load 100 users at a time for the badge page, with a button to load more.
2014-04-24 14:48:26 +05:30
843023d7c9
Fix user_badges n+1 query.
2014-04-17 21:58:05 +05:30
30e73104e4
Bump up to 200 for now, UI perf needs lots of work
2014-04-17 16:25:06 +10:00
3136217fc1
Add badge page.
2014-04-17 01:57:57 +05:30
dcaa069bb5
Log badge grant/revoke to the staff actions log.
2014-03-21 11:10:07 +05:30
50ce93a850
Use render_serialized for rendering instances in UserBadgeController.
2014-03-21 11:09:19 +05:30
9b26c8584e
Initial badge system implementation.
2014-03-14 21:49:26 +05:30
Daniel Waterworth
Sam Saffron
Saurabh Patel
Maja Komel
Régis Hanol
Guo Xiang Tan
Arpit Jalan
Robin Ward
Guo Xiang Tan
riking
Vikhyat Korrapati
Louis Rose