1e666ddfd7
Build(deps-dev): Bump express from 4.18.2 to 4.18.3 ( #25974 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.18.3.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.18.3 )
---
updated-dependencies:
- dependency-name: express
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 22:53:08 +01:00
db2f5ae51b
UX: simplify styles for image uploader ( #25970 )
2024-02-29 14:39:00 -05:00
47b8e98cf7
UX: enable badge title on mobile, style cleanup ( #25968 )
2024-02-29 13:55:13 -05:00
841b353d38
DEV: Close user menu after clicking view-all notifications ( #25966 )
...
We needed to call closeUserMenu after navigating to the show all notifications url.
2024-02-29 11:52:51 -07:00
6c2c690479
DEV: Add push notification filtering to MessageBus alerts ( #25965 )
2024-02-29 12:49:46 -06:00
7aa3e15440
DEV: Deprecate FoundUserWithStatusSerializer ( #25883 )
...
A followup to b3a11994
2024-02-29 20:20:48 +04:00
0a58b18970
DEV: Move DiscourseEvent trigger in PostAlerter#push_notification ( #25931 )
2024-02-29 08:33:38 -06:00
03de0421af
DEV: Convert share-source to gjs ( #25964 )
2024-02-29 15:12:17 +01:00
e74a9efee1
FIX: Show "no category" in category-chooser ( #25917 )
...
CategoryChooser component usually displays just categories, but
sometimes it can show two none values: a "no category" or Uncategorized.
This commit makes sure that these are rendered correctly.
The problem was that the "none" item was automatically inserted in the
list of options, but that should not always happen. Toggling option
`autoInsertNoneItem` requires setting `none` too.
2024-02-29 13:48:20 +02:00
49e67d32fb
DEV: Convert second-factor-input to gjs ( #25946 )
2024-02-29 12:27:12 +01:00
5c54fbfdb1
DEV: Fix random typos ( #25957 )
...
February 2024 edition
2024-02-29 12:24:37 +01:00
8c22831672
UX: update appropriate `btn-flat` instances to `btn-transparent` ( #25945 )
...
With the adjustments of `btn-transparent` in https://github.com/discourse/discourse/pull/24666 , there are more buttons that could use this class instead of `btn-flat`. This mostly relates to `x` close buttons, but also includes composer and chat toggles.
The primary difference between these styles is that `btn-transparent` never has a background, where `btn-flat` may have a hover or focus background.
2024-02-29 11:47:07 +01:00
8bec0ca083
FEATURE: Support boolean, enum and integer fields for schema theme settings ( #25933 )
...
Continue from https://github.com/discourse/discourse/pull/25673 and https://github.com/discourse/discourse/pull/25811 .
This commit adds support for boolean, integer and enum types for schema theme settings.
2024-02-29 11:11:32 +03:00
f562da3150
PERF: Reduce ActiveRecord allocations in `CategoryList#find_relevant_topics` ( #25950 )
...
Why this change?
Prior to this change, the `CategoryList#find_relevant_topics` method was
loading and allocating all `CategoryFeaturedTopic` records in the
database to eventually only just use its `category_id` and `topic_id`
column. On a site with many `CategoryFeaturedTopic` records, the loading
of the ActiveRecord objects is a source of bottleneck.
The other problem with the `CategoryList#find_relevant_topics` method is
that it is unconditionally loading all records from the database even if
the user does not have access to the category. This again is wasteful.
What does this change do?
This commit makes it such that `CategoryList#find_relevant_topics` is
called only after `CategoryList#find_categories` in the `CategoryList#initialize`
method so that we can filter featured topics against categories that the
user has access to.
The second change is that Instead of loading `CategoryFeaturedTopic` records, we make an
inner join agains the `topics` table instead and skip any allocation of
`CatgoryFeaturedTopic` ActiveRecord objects.
2024-02-29 12:19:04 +08:00
53069fcb8e
DEV: Silence header upgrade deprecations for now ( #25947 )
...
We'll unsilence once we've published a clear upgrade path.
2024-02-29 00:36:23 +00:00
9acb4f55f2
Build(deps): Bump the babel group with 2 updates ( #25939 )
...
* Build(deps): Bump the babel group with 2 updates
Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) and [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ).
Updates `@babel/core` from 7.23.9 to 7.24.0
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-core )
Updates `@babel/standalone` from 7.23.10 to 7.24.0
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: babel
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: babel
...
Signed-off-by: dependabot[bot] <support@github.com>
* Clean up accidentally duplicated deps
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-02-29 00:27:17 +01:00
df4197c8b8
FIX: Show deleted bookmark reminders in user bookmarks menu ( #25905 )
...
When we send a bookmark reminder, there is an option to delete
the underlying bookmark. The Notification record stays around.
However, if you want to filter your notifications user menu
to only bookmark-based notifications, we were not showing unread
bookmark notifications for deleted bookmarks.
This commit fixes the issue _going forward_ by adding the
bookmarkable_id and bookmarkable_type to the Notification data,
so we can look up the underlying Post/Topic/Chat::Message
for a deleted bookmark and check user access in this way. Then,
it doesn't matter if the bookmark was deleted.
2024-02-29 09:03:49 +10:00
62e5c96487
Build(deps-dev): Bump the embroider group with 3 updates ( #25940 )
...
Bumps the embroider group with 3 updates: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ), [@embroider/core](https://github.com/embroider-build/embroider/tree/HEAD/packages/core ) and [@embroider/macros](https://github.com/embroider-build/embroider/tree/HEAD/packages/macros ).
Updates `@embroider/compat` from 3.4.4 to 3.4.5
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
Updates `@embroider/core` from 3.4.4 to 3.4.5
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/core )
Updates `@embroider/macros` from 1.13.5 to 1.14.0
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/macros )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/macros"
dependency-type: direct:development
update-type: version-update:semver-minor
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-28 23:40:46 +01:00
faec73e1e0
DEV: Override jsuites CSS in core ( #25944 )
2024-02-28 14:35:08 -08:00
b532c780c6
A11Y: markup sidebar form errors as live regions ( #25937 )
2024-02-28 15:31:57 -05:00
0e5307d8e2
DEV: Add glimmer header deprecation notice ( #25891 )
...
- Remove `_customHeaderClasses`. It was not supposed to have been a part of the glimmer header PR
- Add deprecation notice to `addHeaderPanel`
# Example
<img width="437" alt="Screenshot 2024-02-26 at 2 50 39 PM" src="https://github.com/discourse/discourse/assets/50783505/23fce1ee-fff9-4071-8c34-a480cec7e2e7 ">
2024-02-28 11:59:44 -07:00
36a9b5d0fa
DEV: Introduce a helper for handling events ( #25433 )
...
Instead of
```hbs
{{on "input" (action this.foo value="target.value")}}
{{on "input" (action (mut this.bar) value="target.value")}}
```
you can use:
```hbs
{{on "input" (with-event-value this.foo)}}
{{on "input" (with-event-value (fn (mut this.bar)))}}
```
or in gjs:
```gjs
import { fn } from "@ember/helper";
import { on } from "@ember/modifier";
import withEventValue from "discourse/helpers/with-event-value";
…
{{on "input" (withEventValue (fn (mut this.bar)))}}
```
2024-02-28 14:00:53 +01:00
4116bd9595
DEV: Drop ember-functions-as-helper-polyfill ( #25926 )
...
No longer required on recent Ember
2024-02-28 10:06:36 +00:00
9a07a9872f
FEATURE: Allow `rowspan` and `colspan` attributes on HTML tables ( #20973 )
...
Augment the `allowList` for HTML tables to allow the `rowspan` and
`colspan` attributes on `th` and `td` elements.
2024-02-28 16:59:36 +11:00
9e9673fac5
DEV: save/restore the previous sidebar panel state ( #25899 )
...
In this PR, the admin panel remembers the previous state and restores it when the admin panel is deactivated.
https://github.com/discourse/discourse/pull/25781
However, it would be better to have a more generic solution. When the panel is changed, the previous state is saved in the sidebarState. When a user returns to the specific panel, a previously remembered state is restored.
2024-02-28 12:33:59 +11:00
8b5204579c
FEATURE: filter admin sidebar ( #25853 )
...
Ability to filter admin sidebar. The filter can be cleared. In addition, it can be accessed with ctrl+/ shortcut
2024-02-28 12:15:02 +11:00
ffce2dd04f
A11Y: when adding custom sidebar link, first input of new row should get focus ( #25920 )
...
* A11Y: when adding custom sidebar links, ensure first input of new row gets focus
* switch to afterRender decorator
2024-02-28 11:39:25 +11:00
b426f85a81
DEV: Add modifiers for plugins to customize push notification translation arguments ( #25889 )
2024-02-27 14:03:55 -06:00
f44bee1333
DEV: Use `autocomplete="new-password"` ( #25913 )
...
And normalize `<PasswordField />` arguments
(we were getting `[DOM] Input elements should have autocomplete attributes (suggested: "current-password")` in smoke test logs, this may or may not fix that 😛 )
2024-02-27 13:29:12 +01:00
a8a39d86b4
UX: Improve invite error message when a user uses an email that has already redeemed ( #25695 )
...
Improve invite error message when a user uses an email that has already redeemed
2024-02-27 18:24:20 +08:00
7a14831695
DEV: Remove ember-router-service-refresh-polyfill ( #25910 )
2024-02-27 11:10:19 +01:00
299b323d9a
DEV: Update ember-cli to 5.6.0 ( #25886 )
2024-02-27 10:48:30 +01:00
8bfa2bcf3a
UX: flexible autocomplete width ( #25900 )
...
When tagging a user in composer, the autocomplete div has a fixed width, causing longer names and usernames to get cut off. This change allows the div to expand up until a max-width of 600px on desktop.
2024-02-27 17:17:30 +08:00
1bcb521fbf
DEV: Add DB backed problem checks to support perform_every config ( #25834 )
...
As part of problem checks refactoring, we're moving some data to be DB backed. In this PR it's the tracking of problem check execution. When was it last run, when was the last problem, when should it run next, how many consecutive checks had problems, etc.
This allows us to implement the perform_every feature in scheduled problem checks for checks that don't need to be run every 10 minutes.
2024-02-27 11:17:39 +08:00
4df4584396
DEV: adds `topic-below-suggested` plugin outlet ( #25896 )
2024-02-26 18:53:13 -05:00
3f4537eeb5
FEATURE: Schema theme setting input fields ( #25811 )
...
Continue from https://github.com/discourse/discourse/pull/25673 .
This commit starts building the inputs pane of schema theme settings. At the moment only string fields are rendered, but more types will be added in future commits.
2024-02-27 01:07:32 +03:00
52d357c1d1
DEV: Add loading spinner to install theme modal ( #25888 )
...
This commit adds a loading spinner when installing a theme as sometimes
installing a theme can take quite a bit of time this way we have some
indication that things are still working as the theme is being
installed.
2024-02-26 14:14:21 -07:00
8805a34001
DEV: Add before / after header-buttons plugin outlets ( #25887 )
2024-02-26 12:56:21 -07:00
a85e4adc85
Build(deps-dev): Bump ember-qunit from 6.2.0 to 8.0.2 ( #25880 )
...
* Build(deps-dev): Bump ember-qunit from 6.2.0 to 8.0.2
Bumps [ember-qunit](https://github.com/emberjs/ember-qunit ) from 6.2.0 to 8.0.2.
- [Release notes](https://github.com/emberjs/ember-qunit/releases )
- [Commits](https://github.com/emberjs/ember-qunit/compare/v6.2.0...v8.0.2 )
---
updated-dependencies:
- dependency-name: ember-qunit
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* shim for plugins/themes
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2024-02-26 16:18:33 +00:00
9ce2c20ab0
UX: make sure a-tag uses border radius var ( #25882 )
2024-02-26 16:17:04 +01:00
7adedfa37a
DEV: appEvents when desktop/push JS notifications are opened ( #25823 )
2024-02-26 09:00:39 -06:00
aee6f1d0fb
Build(deps): Bump @glimmer/syntax from 0.84.3 to 0.88.1 ( #25879 )
...
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm ) from 0.84.3 to 0.88.1.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases )
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md )
- [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.84.3...v0.88.1 )
---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-26 15:20:26 +01:00
03af9a796e
Build(deps): Bump ember-resolver from 10.1.1 to 11.0.1 ( #25865 )
...
Bumps [ember-resolver](https://github.com/ember-cli/ember-resolver ) from 10.1.1 to 11.0.1.
- [Release notes](https://github.com/ember-cli/ember-resolver/releases )
- [Changelog](https://github.com/ember-cli/ember-resolver/blob/main/CHANGELOG.md )
- [Commits](https://github.com/ember-cli/ember-resolver/compare/v10.1.1...v11.0.1 )
---
updated-dependencies:
- dependency-name: ember-resolver
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-26 15:15:51 +01:00
588a79c80c
DEV: Merge root JS packages ( #25857 )
...
Before this commit, we had a yarn package set up in the root directory and also in `app/assets/javascripts`. That meant two `yarn install` calls and two `node_modules` directories. This commit merges them both into the root location, and updates references to node_modules.
A previous attempt can be found at https://github.com/discourse/discourse/pull/21172 . This commit re-uses that script to merge the `yarn.lock` files.
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2024-02-26 13:45:58 +00:00
b3a1199493
FEATURE: Hide user status when user is hiding public profile and presence ( #24300 )
...
Users can hide their public profile and presence information by checking
“Hide my public profile and presence features” on the
`u/{username}/preferences/interface` page. In that case, we also don't
want to return user status from the server.
This work has been started in https://github.com/discourse/discourse/pull/23946 .
The current PR fixes all the remaining places in Core.
Note that the actual fix is quite simple – a5802f484d
2024-02-26 17:40:48 +04:00
794ef67268
DEV: Remove package.json and yarn.lock symlinks
...
These were part of the Ember 3/5 feature-flagging system, which is no longer required.
2024-02-26 12:22:05 +00:00
542cb22fd4
DEV: Drop Ember 3 feature flag
2024-02-26 12:22:05 +00:00
1d5f7f92e8
Build(deps): Bump terser from 5.27.2 to 5.28.1 in /app/assets/javascripts ( #25849 )
...
* Build(deps): Bump terser in /app/assets/javascripts
Bumps [terser](https://github.com/terser/terser ) from 5.27.2 to 5.28.1.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.27.2...v5.28.1 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-02-26 12:36:55 +08:00
23bce774d7
DEV: Update user dropdown aria-label ( #25845 )
2024-02-23 16:11:47 -07:00
21f23cc032
DEV: Convert header to glimmer ( #25214 )
...
Here is a breakdown of the changes that will be implemented in this PR.
# Widgets -> Glimmer
Obviously, the intention of the todo here is to convert the header from widgets to glimmer. This PR splits the respective widgets as so:
### widgets/site-header.js
```mermaid height=200
flowchart TB
A[widgets/site-header.js]
A-->B[components/glimmer-site-header.gjs]
```
### widgets/header.js and children
```mermaid height=200
flowchart TB
A[widgets/header.js]
A-->B[components/glimmer-header.gjs]
B-->C[glimmer-header/contents.gjs]
C-->D[./auth-buttons.gjs]
C-->E[./icons.gjs]
C-->F[./user-menu-wrapper.gjs]
C-->G[./hamburger-dropdown-wrapper.gjs]
C-->H[./user-menu-wrapper.gjs]
C-->I[./sidebar-toggle.gjs]
C-->J[./topic/info.gjs]
```
There are additional components rendered within the `glimmer-header/*` components, but I will leave those out for now. From this view you can see that we split apart the logic of `widgets/header.js` into 10+ components. Breaking apart these mega files has many benefits (readability, etc).
# Services
I have introduced a [header](cdb42caa04/app/assets/javascripts/discourse/app/services/header.jscdb42caa04/app/assets/javascripts/discourse/app/modifiers/close-on-click-outside.jshttps://github.com/discourse/discourse/blob/main/app/assets/javascripts/float-kit/addon/modifiers/close-on-click-outside.js ) that @jjaffeux built for float-kit. I think we could replace float-kit's implementation with mine and have it in a centralized location as they are extremely similar.
# Tests
Rewrote the existing header tests ([1](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/tests/integration/components/widgets/header-test.js ), [2](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/tests/integration/components/site-header-test.js )) as system tests.
# Other
- Converted `widgets/user-status-bubble.js` to a gjs component
- Converted `widgets/sidebar-toggle.js` to a gjs component
- Converted `topicFeaturedLinkNode()` to a gjs component
- Deprecated the [docking mixin](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/mixins/docking.js )
2024-02-23 11:08:15 -07:00
dependabot[bot]
Kris
Isaac Janzen
Mark VanLandingham
Andrei Prigorshnev
Jarek Radosz
Bianca Nenciu
Osama Sayegh
Alan Guo Xiang Tan
David Taylor
Martin Brennan
Keegan George
John L. Clark
Krzysztof Kotlarek
Natalie Tay
David Battersby
Ted Johansson
Blake Erickson
chapoi