Sam
6a54da0902
FIX: raise invalid params for bad callback
...
Corrects it so we raise a 400 instead of logged 500 error
2018-06-29 10:43:33 +10:00
Sam
e0bc6590fd
minor cleanup
2018-06-29 10:30:22 +10:00
Sam
982df3c17b
FIX: return status 400 for invalid member params
...
previously error returned was a 500 which is not ideal
and is logged
2018-06-29 10:15:17 +10:00
Robin Ward
5350429870
FIX: Don't replace the wiki button if the user can't edit
2018-06-28 14:48:28 -04:00
Robin Ward
5d1d7e0e7d
PERF: Scanning the `id` for this is signficantly slower in production
2018-06-28 11:04:40 -04:00
Robin Ward
fd7bb8e656
FIX: Scope the `cn` to the subfolder
2018-06-28 11:03:36 -04:00
Arpit Jalan
2c971c41f6
FIX: post deletions rate limit per day was not working
2018-06-28 19:21:27 +05:30
Arpit Jalan
a6d50d1ff7
FEATURE: new settings to control posts deletions rate limit
2018-06-28 17:03:37 +05:30
Arpit Jalan
c352f8eb15
FEATURE: rate limit post deletions to 50 per day
2018-06-28 16:38:58 +05:30
Maja Komel
4ca09599af
Add prettier preferences-second-factor-backup.js.es6
2018-06-28 18:32:20 +10:00
Sam
db14e10943
SECURITY: category badges should HTML escape names
2018-06-28 18:15:07 +10:00
Maja Komel
ec3e6a81a4
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
Arpit Jalan
c738f92234
Merge pull request #6046 from jjaffeux/tooltip-xss-1
...
SECURITY: prevents XSS when showing tooltip
2018-06-27 18:10:55 +05:30
Joffrey JAFFEUX
b5b847f6d6
SECURITY: prevents XSS when showing tooltip
2018-06-27 14:35:47 +02:00
Guo Xiang Tan
cfa7898c2d
Rename `TopicView#last_read_post_id` to `TopicView#filtered_post_id`.
2018-06-27 12:33:57 +08:00
Guo Xiang Tan
cb69888758
PERF: Don't pluck all the columns just to retrieve a single value.
2018-06-27 11:41:35 +08:00
misaka4e21
47cb46671a
FEATURE: Support disabling tag creation for non-staff users.
2018-06-27 07:15:02 +08:00
Arpit Jalan
6bcdc3ba4b
FEATURE: allow author to delete posts irrespective of post_edit_time_limit
2018-06-26 21:43:06 +05:30
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
Arpit Jalan
7efdccdbc5
FIX: allow staff to remove tags from queued topics
2018-06-26 17:08:40 +05:30
OsamaSayegh
a603660ba5
FIX: scroll to top when accessing admin dashboard
2018-06-26 12:19:58 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content)
2018-06-26 12:19:14 +02:00
Guo Xiang Tan
49ffc1eb61
Revert "PERF: Send down gaps as the relevant posts load instead of front loading."
...
This reverts commit 4c3352528e
.
2018-06-26 12:54:14 +08:00
Guo Xiang Tan
4c3352528e
PERF: Send down gaps as the relevant posts load instead of front loading.
2018-06-26 12:49:06 +08:00
Guo Xiang Tan
0b6a2e9d1f
Remove force summary mode for megatopics for now.
...
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
2018-06-26 12:49:06 +08:00
Maja Komel
24dfa1b657
Rename s3 vars, change condition when displaying s3 uploads
2018-06-25 17:16:01 +02:00
Kris
a0b799810b
post-info glyph margin fix
2018-06-25 10:50:16 -04:00
Joffrey JAFFEUX
803968147c
FIX: ListItem can’t have itemprop=url and itemprop=item together
2018-06-25 14:12:55 +02:00
Joffrey JAFFEUX
666386d4b7
FIX: allows more chars than a-z in select-kit
2018-06-25 12:52:20 +02:00
Guo Xiang Tan
d08b596e47
Remove unused function in post-stream.js.es6.
2018-06-25 17:23:34 +08:00
Ernesto Serrano
c5e24da5dd
Update poll_mailbox.rb
2018-06-25 16:18:07 +10:00
David Lee
4644d777bd
FEATURE: add website field to SSO
2018-06-25 16:09:39 +10:00
Leo McArdle
329c94a354
add user-preferences-emails-pref-email-settings outlet
2018-06-25 16:02:03 +10:00
Sam
85d97caa56
lint file
2018-06-25 15:35:45 +10:00
OsamaSayegh
d58ff44b04
Simplify to only support topics list for now
2018-06-25 15:02:22 +10:00
OsamaSayegh
b4a13a1afa
UX: keyboard shortcuts (j/k) should work with /categories
2018-06-25 15:02:22 +10:00
Christoph Holtermann
bed26ea0b3
fix indentation
2018-06-25 15:01:39 +10:00
Christoph Holtermann
a0af15d525
no redeclaring state
2018-06-25 15:01:39 +10:00
Christoph Holtermann
e874afaf31
read embed state info from data attribute
2018-06-25 15:01:39 +10:00
Christoph Holtermann
6eb0b310fe
add data attributes to reflect embed status
2018-06-25 15:01:39 +10:00
Christoph Holtermann
5914a3db20
Update embed.html.erb
...
Small fix
2018-06-25 15:01:39 +10:00
Christoph Holtermann
2244f19ff9
Update embed.html.erb
...
Add state descriptor to message being sent to parent window
2018-06-25 15:01:39 +10:00
Joffrey JAFFEUX
c722fc5164
FIX: makes sure category and tag drop headers have a title
2018-06-24 22:23:31 +02:00
Jeff Wong
41f76a74f8
FEATURE: send message when a user reaches tl1
2018-06-22 13:20:00 -07:00
Guo Xiang Tan
6597cc4cd0
Fix the build.
2018-06-22 13:42:43 +08:00
Guo Xiang Tan
cb622ead43
Make prettier happy.
2018-06-22 11:37:43 +08:00
Guo Xiang Tan
f69356e628
FIX: Users can't "show all posts" in forced summary topics.
2018-06-22 11:32:45 +08:00
Guo Xiang Tan
bad6a5142c
PERF: Don't include entire post stream when we're loading more posts.
2018-06-22 10:49:03 +08:00
Guo Xiang Tan
657c8a013a
UX: Don't display an empty participants section.
2018-06-22 10:16:43 +08:00
Guo Xiang Tan
4c6a0a4046
UX: Don't display participants count if it is zero.
...
This can happen for megatopics where we don't send
down the payload for participants count.
2018-06-22 08:32:20 +08:00
Joffrey JAFFEUX
fed86225c8
FEATURE: differentiate total and total for period on admin table report
2018-06-21 22:46:53 +02:00
Jeff Wong
bc52bdfa12
Feature: unconditionally consider TL0 users as "first day" users
2018-06-21 10:53:08 -07:00
Joffrey JAFFEUX
a41057aa6e
FEATURE: display report total value when showing report
2018-06-21 18:17:22 +02:00
Kris
5d0d56e474
removing unneeded line-height
2018-06-21 10:37:30 -04:00
Guo Xiang Tan
68388dfd25
Fix the build.
2018-06-21 15:57:59 +08:00
Guo Xiang Tan
71908cd634
Make prettier happy.
2018-06-21 15:37:24 +08:00
Guo Xiang Tan
9a7a079f4d
Force summary mode when user enters at the top of megalodoon topics.
2018-06-21 15:18:52 +08:00
Guo Xiang Tan
f7d22bad90
FEATURE: Forced summary mode for megalodon topics.
...
This is mainly done for performance reasons and megalodon
topics are usually a byproduct of imports where site setting
limits are not respected.
2018-06-21 14:00:20 +08:00
Guo Xiang Tan
ac80360bea
PERF: Help postgres make use of index in `Post.summary`.
2018-06-21 13:29:16 +08:00
Guo Xiang Tan
6ddd214476
FIX: `Post#summary` returning posts from other topics.
2018-06-21 12:00:54 +08:00
Guo Xiang Tan
c5cc582549
FIX: Participants may not be in topic maps's attributes.
2018-06-21 10:23:55 +08:00
Joffrey JAFFEUX
50d11fd582
FIX: improves durability display check
2018-06-20 23:15:11 +02:00
Joffrey JAFFEUX
95d99de7b4
FIX: hides durability section in dashboard if backups are disabled
2018-06-20 22:26:37 +02:00
Robin Ward
45a2c94fb3
FIX: Margin on `post-info` should be present in mobile and desktop
2018-06-20 15:39:36 -04:00
Robin Ward
5290138e84
Support for a decorator within the user name
2018-06-20 15:26:37 -04:00
Robin Ward
02cb944fee
FIX: Linting error
2018-06-20 13:44:03 -04:00
Robin Ward
e7fbcf4ba4
UX: Refactor topic metadata's many floats into flexbox ( #6018 )
2018-06-20 13:06:20 -04:00
Joffrey JAFFEUX
2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI
2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX
8126b603e4
fix prettier
2018-06-20 18:26:43 +02:00
Robin Ward
fbc194c330
Don't use `!important` for wiki color. Allow themes to override it.
2018-06-20 10:47:27 -04:00
Robin Ward
bb11375590
FIX: Don't add `undefined` as a class name
2018-06-20 10:37:24 -04:00
Guo Xiang Tan
0365806b93
FIX: Properly display error when post action fails to create.
2018-06-20 21:20:23 +08:00
Joffrey JAFFEUX
fa43969fe2
FIX: crashes with date conversion in reports
2018-06-20 14:42:15 +02:00
Guo Xiang Tan
9c925a66ff
PERF: Don't display days ago on timeline for megatopics.
...
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
2018-06-20 16:25:54 +08:00
Sam
35e0ccfc84
make linter happy
2018-06-20 18:03:27 +10:00
Sam
cb824a6b33
DEV: remove all calls to SqlBuilder use DB.build instead
...
This is part of the migration to mini_sql, SqlBuilder.new is being
deprecated and replaced with DB.build
2018-06-20 17:53:49 +10:00
Joe
5fc4e9e324
FIX: nav-pill dropdown overlaps category-selector when both are open
2018-06-20 13:09:14 +08:00
Jeff Wong
ca4d08f9d9
Make linter happy
2018-06-19 18:07:41 -07:00
Jeff Wong
406c6d679a
FIX: correct display for unlocking on tl0
2018-06-19 17:47:03 -07:00
riking
7f37ee9152
SearchLog: fix specs
2018-06-20 10:44:11 +10:00
riking
38a8e52ca4
FIX: Add time retention limit to search logs
...
3 years is a very conservative limit that allows for a very wide buffer
for year-over-year analysis. The max is set to 5 years because that is
the policy listed for logging in hosted Discourse.
2018-06-20 10:44:11 +10:00
riking
1de0ef137e
FIX: SearchLog: Do not store IP of logged in users
2018-06-20 10:44:11 +10:00
Sam
cbaf521fc1
correct regression and add integrity spec for onceoffs
2018-06-20 09:09:31 +10:00
Kris
b637b57e4f
FIX: Alignment of user dropdown menu icons
2018-06-19 15:38:06 -04:00
Kris
82cb163ef3
formatting fix
2018-06-19 13:07:16 -04:00
Kris
0d81633da9
Replacing onebox loading gif with css spinner
2018-06-19 12:59:00 -04:00
Jeff Wong
2ff226e509
FIX: consider staged users mature (no spam checks) after 1 day
2018-06-19 09:41:10 -07:00
Sam
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
Jeff Wong
68e4e6a575
FIX: staged users are still tl0 but do not trigger spam if 1 week old.
2018-06-18 17:20:04 -07:00
Neil Lalonde
3725fd8345
Merge pull request #6002 from featheredtoast/trust-previously-staged-users
...
FIX: don't punish a user for being previously staged for spam flags.
2018-06-18 15:14:31 -04:00
Jeff Wong
7a1cefce78
Fix: let user fields respond when their labels are clicked
2018-06-18 11:15:22 -07:00
Joffrey JAFFEUX
913d97e780
fix prettier
2018-06-18 20:10:48 +02:00
Kris
ceb9226518
Giving post admin menu variable width in case of long translations
2018-06-18 13:02:50 -04:00
Joffrey JAFFEUX
3fc82bf200
FIX: adds a title to composer actions header
2018-06-18 19:01:37 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports
2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
4b604b1e68
FIX: displays correct upload icon when only images are allowed
2018-06-18 11:16:34 +02:00
Arpit Jalan
f1d1207725
FIX: improve context when user deletes self
2018-06-18 11:36:22 +05:30
Joe
e8e8d540d3
FIX: desktop pin-topic modal not wide enough for date-picker
2018-06-16 15:19:08 +08:00
Arpit Jalan
a30165ab8d
FIX: show time on activity column instead of random number
2018-06-16 07:12:43 +05:30
Jeff Wong
9e55767f6a
FIX: don't punish a user for being previously staged for spam flags.
2018-06-15 12:25:25 -07:00
Rafael dos Santos Silva
51cb38783e
FIX: start_url was wrong in non-subfolder
2018-06-15 14:29:33 -03:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files
2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
Arpit Jalan
c7ee70941e
FEATURE: show category page options on wizard 'homepage' step
2018-06-15 19:11:41 +05:30
Joe
4645cf6b28
FIX: remove unwanted space in user notification items
2018-06-15 15:44:51 +08:00
Kris
a8660b8be9
formatting build fix
2018-06-15 00:09:09 -04:00
OsamaSayegh
06777aa47d
FIX: use the correct notification levels descriptions for PMs
2018-06-15 14:04:14 +10:00
Kris
872656fe52
Give admin list more horizontal space
2018-06-14 23:50:46 -04:00
Robin Ward
4a4406de8c
FIX: Properly avoid n+1 query on flagged posts
...
This code was in here previously but some columns were included that
were not used.
2018-06-14 09:46:52 -04:00
Joffrey JAFFEUX
c82887a0f0
Revert "tests prettier trigger"
...
This reverts commit f74d86639f
.
2018-06-14 15:46:03 +02:00
Joffrey JAFFEUX
f74d86639f
tests prettier trigger
2018-06-14 15:15:25 +02:00
Jeff Wong
160898acf3
Feature: add jump to post modal on mobile
2018-06-13 22:01:35 -07:00
Rafael dos Santos Silva
8fc08aad09
FEATURE: Update the webmanifest
...
- Remove share target because the spec is changing
- Allow any orientation again because natural is too restrictive
- Use correct file and mime types for the manifest
2018-06-14 00:13:28 -03:00
Arpit Jalan
94ae89f61f
FIX: properly retrieve user custom fields
2018-06-14 07:33:25 +05:30
Joffrey JAFFEUX
276526e30e
FIX: improves micro data support
2018-06-13 23:20:48 +02:00
Régis Hanol
ff06ce4cce
fix the build
2018-06-13 23:05:23 +02:00
Régis Hanol
051d1a3c36
PERF: faster Screened IP Address roll up
2018-06-13 22:47:23 +02:00
Robin Ward
fd54c92a52
FEATURE: New site setting, whitelisted_link_domains
...
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
Neil Lalonde
debbb5be16
FIX: staff see the wrong message when changing another user's email address
2018-06-13 15:18:48 -04:00
Robin Ward
ae728702a6
Revert "Revert "Preload custom user fields when viewing flag queue""
...
This reverts commit 1bb12ee1b6
.
2018-06-13 11:44:13 -04:00
Arpit Jalan
4107a02ae8
Merge pull request #5991 from jjaffeux/plugin-sharing-api
...
FEATURE: adds plugin sharing api
2018-06-13 17:24:03 +05:30
Joffrey JAFFEUX
eddcb07f03
FEATURE: adds plugin sharing api
2018-06-13 13:25:51 +02:00
Régis Hanol
f93ba5694e
UX: show quote button at end of selection on Opera
2018-06-13 11:07:19 +02:00
Joffrey JAFFEUX
4e0c06a0b1
FIX: focusing input displayed after clicking on a link more reliable
2018-06-13 10:31:46 +02:00
Maja Komel
6c9190357c
fix get from url for external uploads without CDN
2018-06-13 16:21:28 +10:00
Jeff Wong
0c2f590c64
Feature - allow user and group specific cards styling ( #5989 )
2018-06-13 14:08:03 +08:00
Sam
12fd0b827e
PERF: release results in a couple of cases
2018-06-13 15:11:43 +10:00
Jeff Wong
3d1ff8e0ad
FIX: correct group membership on cards for admins
2018-06-12 14:57:26 -07:00
Joshua Rosenfeld
1bb12ee1b6
Revert "Preload custom user fields when viewing flag queue"
...
This reverts commit 5bd1c5cc95
.
2018-06-12 16:46:31 -04:00
Robin Ward
5bd1c5cc95
Preload custom user fields when viewing flag queue
2018-06-12 16:17:22 -04:00
Régis Hanol
d8063d09d5
FIX: Add members button wasn't working on mobile for non-admin group owners
2018-06-12 15:05:22 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style
2018-06-12 12:47:03 +02:00
Sam Saffron
030e322a39
FEATURE: block top level /my/ routes
2018-06-12 19:47:45 +10:00
Arpit Jalan
59a8471308
FIX: do not show SSO external_email to moderators
2018-06-12 14:20:44 +05:30
Vinoth Kannan
72196ee951
Move the dashboard-problems block outside the condition
2018-06-12 12:01:41 +05:30
Guo Xiang Tan
c06824e9c2
FIX: Clients get stucked in readonly mode if messageBus fails.
2018-06-12 12:02:37 +08:00
kleinfreund
4ce1d230c7
Prefer throwing a new Error object instead of just a string expression
2018-06-12 12:56:22 +10:00
Angus McLeod
0997eb6486
Add theme stylesheet(s) to the crawler layout
2018-06-12 12:47:48 +10:00
riking
94f70c7b5c
FIX: TopicViewItem: do not store IP of logged in users
2018-06-12 12:43:56 +10:00
riking
4b2e2ea8ef
Change TopicViewItem to allow null IP address
2018-06-12 12:43:56 +10:00
Shoshana Berleant
f48338df54
add plugin outlet create-account-after-password
2018-06-12 12:42:37 +10:00
Jeff Wong
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
Jeff Wong
44ee26721a
FIX: add check for missing assets file in development
2018-06-11 11:18:34 -07:00
Gerhard Schlager
150ae21489
FEATURE: Log user merge in staff logs
2018-06-11 18:43:56 +02:00
Joffrey JAFFEUX
73731463a3
UX: makes sure close modal icon is aligned with title
2018-06-11 13:38:57 +02:00
Vinoth Kannan
a6303073a0
Strip images from cooked for topic excerpt
2018-06-11 14:43:53 +05:30
Joe
2ec53a9628
FIX: adjust 2FA input width in mobile login form
2018-06-10 21:33:41 +08:00
Joe
5eb0066be9
FIX: adjust max-width of social login buttons for non-English locals
2018-06-09 14:14:59 +08:00
Gerhard Schlager
a26889ada2
FIX: Don't delete profile views during user anonymization
...
There's no need for that and it can take a lot of time.
2018-06-08 15:50:07 +02:00