Sam
74d2d4f658
FEATURE: add APIS for unpausing all sites
...
This adjusts 53d592ad
by @tgxworld
- Adds Sidekiq.upause_all! to unpause all sites
- Adds Sidekiq.paused_dbs to list dbs that are currently paused
- Handles some edge cases where unpause thread could extend expiry on
sites that were unpaused from a different process
- Ensures tests always terminates background thread used for pause
keepalive
2019-02-14 13:34:20 +11:00
Guo Xiang Tan
53d592ad3b
FIX: Add multisite support to Sidekiq::Pausable. ( #6960 )
...
Having a global Sidekiq pause switch is problematic because a site in
the cluster can pause Sidekiq for the entire cluster.
2019-02-14 12:22:40 +11:00
Vinoth Kannan
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
Vinoth Kannan
7b5931013a
Update rake task to backfill etags from s3 inventory
2019-02-14 05:18:06 +05:30
Vinoth Kannan
1045bbc35b
FIX: S3 inventory data can be splitted into multiple csv files
2019-02-14 03:41:52 +05:30
Sam
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
Penar Musaraj
5cef5b34ef
DEV: Yarn-manage moment and moment-timezone libraries
2019-02-12 13:57:52 -05:00
Robin Ward
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
David Taylor
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
Dan Ungureanu
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
Robin Ward
12d061a45b
Remove stubbing of `auto_close_threshold_reached?`
2019-02-11 15:41:03 -05:00
David Taylor
705c898c21
FEATURE: Calculate CSP based on active themes ( #6976 )
2019-02-11 12:32:04 +00:00
Arpit Jalan
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
Penar Musaraj
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
Gerhard Schlager
84a10f8212
Fix failing spec
...
The Report class created its own BackupStore without a stubbed S3 client
2019-02-08 21:38:10 +01:00
Robin Ward
b75a3e391a
Use `skip` not `pending`
2019-02-08 13:48:29 -05:00
Robin Ward
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
Robin Ward
fb18c57372
For now, make spec pending since it is broken.
2019-02-08 12:46:19 -05:00
Robin Ward
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
Robin Ward
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
David Taylor
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
Vinoth Kannan
cc496de10e
FIX: Remove double quotes from etag value in API response
...
https://github.com/aws/aws-sdk-ruby/issues/1134
2019-02-08 14:31:19 +05:30
Penar Musaraj
2a007bafa2
FEAT: Allow image resize by width or height
...
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.
Resize value can be from 1 to 999 (incl. for percentages).
2019-02-07 15:04:39 -05:00
Régis Hanol
c256121833
FIX: add support for style element in SVGs
2019-02-07 12:09:06 +01:00
Arpit Jalan
ab2c2ea605
FIX: validate Invite email against `EmailValidator.email_regex` ( #6975 )
2019-02-06 22:38:06 +05:30
David Taylor
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes ( #6973 )
...
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
Vinoth Kannan
ba9cc83d4c
FIX: Destination prefix in S3 inventory configuration is incorrect
2019-02-06 20:51:28 +05:30
Arpit Jalan
381793243e
FIX: include error message if the "accept invite" process fails
2019-02-06 19:20:25 +05:30
Vinoth Kannan
ff12c4b2d4
FIX: Bucket name is missing in S3 inventory data path
2019-02-06 19:16:08 +05:30
Vinoth Kannan
e7821a63e7
FIX: Users should able check the emails for self
2019-02-05 23:31:19 +05:30
David Taylor
a3b47c1dd1
FEATURE: Allow string theme settings to display with multiple lines
...
To use, add `textarea: true` to the theme settings.yml. For example:
```
my_setting:
default: "some string"
textarea: true
```
2019-02-05 14:14:53 +00:00
David Taylor
7b7bc3db39
FIX: Rescue and display import errors when updating theme via git
2019-02-05 13:49:16 +00:00
Bianca Nenciu
4f3ee86bbd
FIX: in:title should work irrespective of the order. ( #6968 )
2019-02-05 10:54:52 +01:00
Penar Musaraj
edcdbe1946
DEV: Restore textarea type for site settings
...
Currenty, no settings in core use this, but textareas will be useful in theme settings and plugins.
2019-02-04 15:41:58 -05:00
Robin Ward
e5a81aeb6e
REFACTOR: Remove stubbed methods in tests
2019-02-04 15:06:00 -05:00
Robin Ward
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
Vinoth Kannan
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
Guo Xiang Tan
a1b4d9b061
DEV: Fix specs using deprecated site settings.
2019-02-01 12:31:03 +08:00
Sam
a84aaf197a
DEV: correct heisentest testing for avatars
...
If for some reason we created andupload with id 1 in the test then the
test would fail. This can happen if this is the absolute first test to
run on the db.
Fix sets the upload to a legitimate which in turn means the last upload
will not be upload id 1 and stops using id hard coding for the testing.
2019-02-01 13:27:06 +11:00
Robin Ward
720e896e17
FIX: `PostActionCreator` was not checking the guardian properly
...
It also exposed a bug in the EmailReceiver spec, where a test had a user
liking their own post and was not failing.
2019-01-31 14:48:42 -05:00
Gerhard Schlager
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
David Taylor
886ba9dff9
DEV: Correct spec for theme export change
2019-01-31 17:52:03 +00:00
David Taylor
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
Régis Hanol
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
Arpit Jalan
f83533e1cb
FIX: use absolute url for `/images/example.png` links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
David Taylor
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
Gerhard Schlager
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
Guo Xiang Tan
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
Penar Musaraj
421d47da1e
FIX: user and group mentions in subfolder installs
2019-01-29 21:54:29 -05:00
Robin Ward
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00