discourse

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jarek Radosz	c972a31819	DEV: Fix typos and formatting (#27320 )	2024-06-04 15:16:24 +02:00
Martin Brennan	73c6bb2593	FIX: Admin sidebar disappeared on some routes for header dropdown (#27216 ) When navigation_menu is set to header dropdown, we are still forcing admin sidebar by checking if the user is an admin route (c.f. `9bcbfbba43`). However in the initial commit the route check had the false premise that all admin routes started with `admin.`; there are others that don't. We need to force admin sidebar on all routes starting with `admin` (no `.`). c.f. https://meta.discourse.org/t/feedback-on-admin-sidebar-when-header-dropdown-navigation-selected/309490/3?u=martin	2024-05-28 11:47:54 +10:00
Martin Brennan	9bcbfbba43	FEATURE: Force admin sidebar for all admins in `admin_sidebar_enabled_groups` and handle legacy "hamburger dropdown" in this mode (#26899 ) Some sites are still on the legacy "hamburger dropdown" navigation_menu setting. In this case to avoid confusion, we want to show both the sidebar icon and the header dropdown hamburger when visiting the admin portal. Otherwise, the hamburger switches sides from right to left for admins and takes on different behaviour. The hamburger in this case _only_ shows the main panel, not other sidebar panels like the admin one.	2024-05-13 14:40:23 +10:00

Jarek Radosz

c972a31819

DEV: Fix typos and formatting (#27320 )

2024-06-04 15:16:24 +02:00

Martin Brennan

73c6bb2593

FIX: Admin sidebar disappeared on some routes for header dropdown (#27216 )

When navigation_menu is set to header dropdown, we are
still forcing admin sidebar by checking if the user is an
admin route (c.f. 9bcbfbba43).

However in the initial commit the route check had the
false premise that all admin routes started with `admin.`;
there are others that don't. We need to force admin sidebar
on all routes starting with `admin` (no `.`).

c.f. https://meta.discourse.org/t/feedback-on-admin-sidebar-when-header-dropdown-navigation-selected/309490/3?u=martin

2024-05-28 11:47:54 +10:00

Martin Brennan

9bcbfbba43

FEATURE: Force admin sidebar for all admins in `admin_sidebar_enabled_groups` and handle legacy "hamburger dropdown" in this mode (#26899 )

Some sites are still on the legacy "hamburger dropdown"
navigation_menu setting. In this case to avoid confusion,
we want to show both the sidebar icon and the header dropdown
hamburger when visiting the admin portal. Otherwise, the
hamburger switches sides from right to left for admins
and takes on different behaviour.

The hamburger in this case _only_ shows the main panel, not
other sidebar panels like the admin one.

2024-05-13 14:40:23 +10:00

3 Commits