OsamaSayegh
767f022b29
REFACTOR: admin screened ip addresses controller specs to requests ( #5965 )
2018-06-11 12:48:34 +08:00
OsamaSayegh
93b1386fb2
REFACTOR: admin site settings controller specs to requests ( #5966 )
2018-06-11 12:48:09 +08:00
OsamaSayegh
325f975ed3
REFACTOR: admin dashboard controller specs to requests ( #5967 )
2018-06-11 12:47:42 +08:00
OsamaSayegh
a4574cf2ca
REFACTOR: admin webhooks controller specs to requests ( #5969 )
2018-06-11 12:47:29 +08:00
OsamaSayegh
a914ec28fc
REFACTOR: admin impersonate controller specs to requests ( #5968 )
2018-06-11 12:47:14 +08:00
OsamaSayegh
d22b552c9b
REFACTOR: admin emojis controller specs to requests ( #5974 )
2018-06-11 12:39:31 +08:00
OsamaSayegh
12b1687e1f
REFACTOR: admin permalinks controller specs to requests ( #5970 )
2018-06-11 12:37:21 +08:00
OsamaSayegh
37c84451ed
REFACTOR: admin staff action logs controller specs to requests ( #5971 )
2018-06-11 12:37:06 +08:00
OsamaSayegh
65241c6778
REFACTOR: admin api controller specs to requests ( #5972 )
2018-06-11 12:35:45 +08:00
OsamaSayegh
2c8a9d36af
REFACTOR: admin versions controller specs to requests ( #5973 )
2018-06-11 12:35:05 +08:00
OsamaSayegh
237559c76f
REFACTOR: admin screened emails controller specs to requests ( #5975 )
2018-06-11 12:33:54 +08:00
OsamaSayegh
f30c2dacb2
REFACTOR: admin screened urls controller specs to requests ( #5976 )
2018-06-11 12:33:38 +08:00
OsamaSayegh
63b2207065
REFACTOR: admin plugins controller specs to requests ( #5977 )
2018-06-11 12:33:07 +08:00
OsamaSayegh
c6fe082fe4
REFACTOR: admin controller specs to requests ( #5978 )
2018-06-11 12:32:55 +08:00
OsamaSayegh
4ac7be1d1c
REFACTOR: admin embeddable hosts controller specs to requests ( #5979 )
2018-06-11 12:32:13 +08:00
OsamaSayegh
062aecd239
REFACTOR: admin embedding controller specs to requests ( #5980 )
2018-06-11 12:31:58 +08:00
OsamaSayegh
f5ad0022f7
REFACTOR: admin users controller specs to requests ( #5946 )
2018-06-08 12:42:06 +08:00
Arpit Jalan
f9ab3848ed
FEATURE: support disabling emails for non-staff users
2018-06-07 18:31:08 +05:30
Sam
945cb90e7e
update specs
2018-06-07 20:55:42 +10:00
Guo Xiang Tan
3a8f69c3d2
DEV: Assert for 200 response code to avoid changing magic helper in the future.
2018-06-07 16:11:09 +08:00
Sam
f331d2603d
DEV: improve design of site setting default provider
...
This refactors it so "Defaults provider" is only responsible for "defaults"
Locale handling and management of locale settings is moved back into
SiteSettingExtension
This eliminates complex state management using DistributedCache and makes
it way easier to test SiteSettingExtension
2018-06-07 14:33:41 +10:00
Sam
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
Guo Xiang Tan
7fc8a36529
DEV: Take 2 Queue jobs in tests by default.
...
On my machine this cuts the time taken to run our test suite
from ~11mins to ~9mins.
2018-05-31 16:23:23 +08:00
Guo Xiang Tan
56e9ff6853
Revert "DEV: Queue jobs in tests by default."
...
Too risky for now
This reverts commit be28154d3b
.
2018-05-31 15:34:46 +08:00
Guo Xiang Tan
be28154d3b
DEV: Queue jobs in tests by default.
2018-05-31 14:45:47 +08:00
Blake Erickson
3edca8b104
Return a 403 instead of 200 when trying to delete a user with posts
...
See [this commit][1] for more info
[1]: bd352a17bf
2018-05-22 17:02:02 -06:00
Régis Hanol
53f8f6095d
FEATURE: staff action logs when creating/updating/deleting badges
2018-05-17 18:09:27 +02:00
Blake Erickson
bd352a17bf
FIX: Show a json api response when deleting a user with posts
...
A 500 error was actually caused with no response when using the api, so
it wasn't very clear that you need to delete the posts first when using
the api.
2018-05-10 13:04:36 -06:00
Guo Xiang Tan
c82b2dcc24
Remove admin group management pages.
2018-04-09 15:14:50 +08:00
Guo Xiang Tan
eb755dd2a7
Fix the build.
2018-04-06 10:40:57 +08:00
Guo Xiang Tan
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
Arpit Jalan
d96c1058a2
FEATURE: add staff action log for 'restore topic'
2018-03-21 18:04:13 +05:30
Sam
39e679d3cb
FEATURE: allow themes to live in private git repos
...
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
Guo Xiang Tan
b6e82815bd
Fix rspec description.
2018-02-21 09:02:42 +08:00
Robin Ward
7348513848
FIX: Include post in staff action logs when silencing a user
2018-02-13 15:59:10 -05:00
Gerhard Schlager
8765279c90
FIX: Customizing site texts ignored current locale for _MF keys
2018-02-07 16:57:08 +01:00
Robin Ward
8ff4104555
Many enhancements to the flagging / suspending interface.
2018-02-01 17:13:02 -05:00
Sam
49ed382c2a
FIX: return 429 when admin api key is limited on admin route
...
This also handles a general case where exceptions leak out prior to being handled by the application controller
2018-01-12 14:15:26 +11:00
Arpit Jalan
ef4c6c67ba
fix the build
2017-12-23 14:42:40 +05:30
Guo Xiang Tan
97ceebb570
SECURITY: Don't pass email backup token to sidekiq as a parameter.
...
* This exposes the token in the Sidekiq dashboard which can be
viewed by an admin and defeats the purpose of using a token
in the download backup email ink.
2017-12-18 11:25:22 +08:00
Guo Xiang Tan
1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
...
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Robin Ward
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
Guo Xiang Tan
5805979e88
FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
...
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Robin Ward
0a9daba627
FIX: Support for long suspension emails
2017-11-20 12:45:46 -05:00
Robin Ward
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
Sam
47e4c9bb46
FIX: import/export theme should work with uploads
2017-11-14 16:30:23 +11:00
Robin Ward
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
Robin Ward
f73a3cc0d4
Don't include suspended_at or suspended_till unless suspended
2017-10-13 12:17:54 -04:00
Régis Hanol
6a7920ad75
FIX: wasn't able to change default theme
2017-09-27 20:05:31 +02:00
Robin Ward
383d771265
Fix broken tests
2017-09-25 12:52:45 -04:00