Commit Graph

14348 Commits

Author SHA1 Message Date
Sam 0d66a41753 Merge pull request #4989 from begrif/html-safe-category-desc
Stop Rails from escaping the HTML in this description.
2017-07-25 13:41:30 -04:00
Robin Ward f2e592c1ab UX: Apply `btn-flat` class to flat buttons on posts 2017-07-25 12:00:19 -04:00
Robin Ward 3152eabbb0 UX: Use flat button style for bulk selection 2017-07-25 12:00:19 -04:00
Robin Ward 5da848088a UX: Refactor composer buttons into flat buttons 2017-07-25 12:00:19 -04:00
Régis Hanol d67fe4c674 FIX: block all emails associated to a user when destroying their record 2017-07-25 17:44:46 +02:00
Guo Xiang Tan 601064a95a Remove stray debugger. 2017-07-25 22:51:47 +09:00
Guo Xiang Tan bdf1be65a3 FIX: Broken topic invite button. 2017-07-25 22:48:10 +09:00
Jakub Macina 2d45b3fc6d Add infinite loading to full page search. 2017-07-25 15:33:25 +02:00
Joffrey JAFFEUX 8556d3c27f FIX: emoji-picker do not reload all everything when changing diversity 2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX 22c5fb20b4 FIX: emoji-picker broken and skipped specs 2017-07-25 12:23:38 +02:00
Régis Hanol c7c93e7159 FEATURE: new 'strip image metadata' site setting 2017-07-25 11:48:39 +02:00
Guo Xiang Tan 6c0a29698b Fix JS tests failing when running in `RAILS_ENV=test`.
Fixes the following error:

```
phantomjs /home/tgxworld/work/discourse/vendor/assets/javascripts/run-qunit.js http://localhost:60099/qunit
2017-07-25 16:27:41 +0900: Rack app error handling request { GET /stylesheets/desktop.css }
<Errno::ENOENT: No such file or directory @ rb_sysopen - /home/tgxworld/work/discourse/tmp/stylesheet-cache/desktop.css>
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `write'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:65:in `show_resource'
/home/tgxworld/work/discourse/app/controllers/stylesheets_controller.rb:9:in `show'
```
2017-07-25 16:31:31 +09:00
awesomerobot 3905d6bc0d mildly lighter @mention 2017-07-24 22:26:14 -04:00
Jeff Atwood df653a2350 Merge pull request #4991 from awesomerobot/master
fixing @mention color
2017-07-24 18:33:00 -07:00
awesomerobot 3dd79b3b3a fixing @mention color 2017-07-24 21:11:14 -04:00
Benjamin Elijah Griffin 4f77ca72a3 Stop Rails from escaping the HTML in this description. 2017-07-24 17:15:15 -07:00
Sam 4da98cdcfe FIX: allow bbcode to be unquoted for default 2017-07-24 18:36:17 -04:00
Neil Lalonde 25097deb39 FIX: saving profile preferences removes name in account preferences 2017-07-24 13:13:50 -04:00
Sam 40abcfc2f5 FIX: smart quote edge case with quotes 2017-07-24 12:21:49 -04:00
Sam Saffron 045a2abcec FEATURE: remove the timecop gem
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
Robin Ward 5dd56a41d9 Merge branch 'master' into master 2017-07-24 12:01:48 -04:00
Neil Lalonde b5a375c70a FIX: oops, real fix for change email instructions 2017-07-24 11:15:55 -04:00
Neil Lalonde 1f1d84c378 FIX: wrong position for change email instructions 2017-07-24 11:14:36 -04:00
Guo Xiang Tan 6b17178533 Validate uniquness of `api_key`. 2017-07-24 21:46:08 +09:00
Joffrey JAFFEUX d9696c98c3 FIX: broken spec 2017-07-24 13:59:36 +02:00
Joffrey JAFFEUX 995d253030 FIX: improves efficiency 2017-07-24 12:42:54 +02:00
Guo Xiang Tan 1b0750d7ef Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
Guo Xiang Tan 6593f0355f FIX: Exclude `www` in topic map links.
https://meta.discourse.org/t/topic-popular-links-panel-domain-extraction-doesnt-handle-country-tlds/60156/38?u=tgxworld
2017-07-24 10:14:33 +09:00
Guo Xiang Tan 887c3b66f5 Revert "UX: Don't try to figure out root domain."
This reverts commit 7690cc6ca5.
2017-07-24 09:40:57 +09:00
Régis Hanol 65ab5f58fe FIX: keep newlines between paragraphs when quoting a post 2017-07-23 15:25:28 +02:00
David Taylor 2ddf365e3a Fix user stats colour for dark themes 2017-07-22 23:48:31 +01:00
Joffrey JAFFEUX f68e711fb2 FIX: makes emoji filter case insensitive 2017-07-22 22:48:22 +02:00
Jeff Atwood bc9270defb filetype comparison needs to be case insensitive 2017-07-22 13:18:15 -07:00
Joffrey JAFFEUX e2e0221dd7 FIX: make sure there are meaningful titles on the picker 2017-07-22 17:32:12 +02:00
Robin Ward bc3a32385c FIX: Empty lines should be selected for block quotes 2017-07-21 16:32:29 -04:00
Sam 9b4f5710e6 api cleanup for before / after rules 2017-07-21 16:12:11 -04:00
Joffrey JAFFEUX bb35d9fc07 FIX: do not restore scroll on successive click on the same first emoji 2017-07-21 21:42:23 +02:00
Robin Ward 2f8f2aa1dd FEATURE: Whitelists for inline oneboxing 2017-07-21 15:41:47 -04:00
Arpit Jalan 9727977fef Fix the build. 2017-07-22 00:34:39 +05:30
Joffrey JAFFEUX 8c17596aa5 FIX: keep scroll position when adding first recent emoji 2017-07-21 20:57:17 +02:00
Joffrey JAFFEUX cdefb58018 FIX: emoji-picker filtering false positive 2017-07-21 20:42:34 +02:00
Arpit Jalan 6d09fbde44 UX: use down chevron icon to expand "show more links.." 2017-07-22 00:10:37 +05:30
Régis Hanol fff5e2c3a5 Merge pull request #4984 from LeoMcA/unrecognized-error-email
FEATURE: send rejection email for unrecognized errors
2017-07-21 20:40:18 +02:00
Robin Ward 574681dc47 FIX: Show emoji in inline oneboxes 2017-07-21 14:24:48 -04:00
Joffrey JAFFEUX c2db2c5c78 FIX: do not store scroll position in local storage 2017-07-21 20:18:32 +02:00
Joffrey JAFFEUX d5f53da43f FIX: filtered emojis now correctly include custom emojis 2017-07-21 19:46:40 +02:00
Joffrey JAFFEUX e36d9f55c3 replaces links/imgs by buttons in the emoji-picker 2017-07-21 19:42:50 +02:00
Joffrey JAFFEUX 54e0075a3e use the EMOJI_VERSION constant 2017-07-21 19:42:49 +02:00
Leo McArdle 407a23663d FEATURE: send rejection email for unrecognized errors 2017-07-21 18:26:52 +01:00
Sam e1ce47a901 Pass the full CommonMark spec 2017-07-21 13:20:52 -04:00
Robin Ward aa5b8a5749 REFACTOR: Merge onebox and inline onebox code paths 2017-07-21 13:12:30 -04:00
Leo McArdle ddc0134b48 add DiscourseEvent triggers necessary to update a user's permissions before they're notified 2017-07-21 11:03:54 -04:00
Guo Xiang Tan 2a17f1ccd7 FIX: Group owners should be able to invite users to their groups.
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
Joffrey JAFFEUX c7f2b0fe58 tweaks to copy and styles 2017-07-21 14:19:04 +02:00
Joffrey JAFFEUX 79c8b505e8 FIX: faster successive loading of emojis 2017-07-21 14:18:02 +02:00
Joffrey JAFFEUX 1ce1953ee1 FIX: makes sure we don’t track when clicking on recent emojis 2017-07-21 13:35:55 +02:00
Joffrey JAFFEUX c906bd3f22 emoji-picker refactoring 2017-07-21 13:35:29 +02:00
Joffrey JAFFEUX 1ca0c33802 FIX: dot not close emoji-picker when click is inside picker 2017-07-21 12:01:39 +02:00
Joffrey JAFFEUX 0c9ea1aaf2 reduce emoji loading threshold 2017-07-21 11:46:34 +02:00
Jakub Macina 44bd8f3837 Add info about more results to full-page search frontend. 2017-07-21 09:35:04 +02:00
Robin Ward 657e592a39 FIX: Oneboxes were not being previewed 2017-07-20 17:12:54 -04:00
Jeff Atwood 18d1ff0c0a Merge pull request #4980 from cpradio/fix-ol-margin-padding
Fix ol margin/padding so it displays ordered lists without cutting them off.
2017-07-20 13:58:17 -07:00
Robin Ward 3882722195 FEATURE: Inline (Mini) Oneboxing
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
Sam 44fb2a2833 DEV: support multiple capture groups for text post process 2017-07-20 15:33:44 -04:00
Joffrey JAFFEUX d7a20c8e93 FIX: Object.assign is not supported in all browsers 2017-07-20 20:27:59 +02:00
Joffrey JAFFEUX ac6413f456 FIX: broken specs 2017-07-20 20:08:11 +02:00
Sam 1096dcd602 correct bbcode parsing edge case 2017-07-20 13:02:40 -04:00
Sam 0791d740a6 FIX: only highlight exact word matches in results
- also fixes phrase highlighting
2017-07-20 12:26:46 -04:00
Jakub Macina e5ee4ccc48 Add pagination and checking for more results to search. 2017-07-20 18:12:34 +02:00
Jakub Macina 7b40de5ac4 Add attribute to grouped search results for more available posts. 2017-07-20 18:07:13 +02:00
Sam 911ffbb98c Correct mention edge cases
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
Joffrey JAFFEUX a9ab3f9ef0 FIX: emoji-picker positioning glitches on few edge cases 2017-07-20 17:03:45 +02:00
cpradio 8101b630f2 Fix ol margin/padding so it displays ordered lists without cutting them off.
https://meta.discourse.org/t/numbers-cut-off-in-long-list/59856
2017-07-20 11:03:04 -04:00
Joffrey JAFFEUX a5a3651cf3 FIX: improves emoji-picker handling of its different states
- closing modal with escape
- using modal less frequently
- closing the picker by clicking anywhere
2017-07-20 16:08:25 +02:00
Régis Hanol bf6c3b7017 FIX: don't error out when an unsubscribe key isn't associated to a user anymore 2017-07-20 12:24:24 +02:00
Leo McArdle d0b027d88d FEATURE: phase 1 of supporting multiple email addresses 2017-07-20 11:22:27 +09:00
Joffrey JAFFEUX 739794f0cb resets img src before changing it 2017-07-19 23:24:50 +02:00
Joffrey JAFFEUX 26a7ae3750 increase time needed to load section in emoji-picker 2017-07-19 23:20:27 +02:00
Joffrey JAFFEUX d27f744d16 refactor async code of the emoji-picker 2017-07-19 22:54:58 +02:00
Joffrey JAFFEUX ce982d9935 enforce that emoji-picker is not active by default 2017-07-19 22:54:57 +02:00
Joffrey JAFFEUX bb7241ccc2 simplify emoji-picker recent usage logic 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX 0112b9aa43 FIX: emoji-picker works with dark theme 2017-07-19 22:54:56 +02:00
Joffrey JAFFEUX f32950a475 unbind div-resizing event 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX bd0607b15b makes emoji-picker position more dynamic 2017-07-19 22:54:55 +02:00
Joffrey JAFFEUX d2581bbf21 FIX: make sure the emoji picker is hidden 2017-07-19 22:54:54 +02:00
Joffrey JAFFEUX d238de87a4 FIX: infinite rebinding when filtering emojis 2017-07-19 22:54:53 +02:00
Joffrey JAFFEUX d1f2b981b5 scope .section-group to .emoji-picker 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX 69a52cca83 improve emoji picker filter style 2017-07-19 22:54:52 +02:00
Joffrey JAFFEUX 8620662ac7 do not display clear on windows 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX a1de26d614 more consistent positioning 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 81c1cc4f22 should be a const 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 33c1ce8d55 better scroll/touch handling on mobiles 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b3454b535f refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 4ef52d5e88 correctly hide the picker 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 8d91e7d493 pixel perfect position 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 2322118d4f es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX c99a5bce8f faster tests 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b83f430ef0 better positioning on mobile devices 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 8cf7e614d9 move picker at top of the screen on mobile 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9956a58df0 uses es6 shorthands 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 0b98bfe1dc function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 7739b2f53e reduces element search scope 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX d992ef24ce emphasizes it's a jquery object 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX b5c5c9c883 formating 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6ebdf86ec1 storing scroll position every 100 ms should be enough 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9a4dcd1a1c es-lint 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX bd0e5b91c0 function is not needed 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX f4c20472d2 refactoring 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 80ff685148 disable modale escape for now 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 60c0b5f0d2 bind hover only on desktop 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 38be969727 do not apply touch start hack on emojis 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 89573e3427 simplifying code 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 03508b72b9 clarification 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6a4d74d9f8 performance/memory optimizations 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 2a0dcedb3d fixes regression 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 9664fd7302 fixes es-lint errors 2017-07-19 16:48:23 +02:00
Joffrey JAFFEUX 6de258d4cf FEATURE: Introduces new emoji-picker 2017-07-19 16:48:23 +02:00
Guo Xiang Tan 87a1ff15fd Treat URL as loaded when loading script with tag. 2017-07-19 10:25:13 +09:00
Sam c7b0764089 correct more edge cases with new engine 2017-07-17 17:44:48 -04:00
Sam 8921058c67 FIX: medium URL with @ incorrectly handled as mention
Also:

- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Robin Ward 29d529020b UX: Allow site settings to display as textareas if they like 2017-07-17 16:38:26 -04:00
Robin Ward cdb3706025 Track clicks on topics in search results 2017-07-17 15:42:32 -04:00
Robin Ward 21e02d6969 Include the `search_log_id` in search results 2017-07-17 12:10:32 -04:00
Sam Saffron d0c5205a52 Feature: Change markdown engine to markdown it
This commit removes the old evilstreak markdownjs engine.

- Adds specs to WhiteLister and changes it to stop using globals
    (Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
    CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Guo Xiang Tan 2ddf2e0e95 FIX: Concurently loading deferred loading of a script incorrectly resolves the promise. 2017-07-17 14:41:46 +09:00
Guo Xiang Tan d613f3f559 Fix guard against concurrently loading of assets. 2017-07-17 13:04:30 +09:00
Guo Xiang Tan c5401a0927 Log errors when trying to load a `markdown-it-bunlde.js`. 2017-07-17 11:21:57 +09:00
awesomerobot c29b7aa65d initial pass at color simplification 2017-07-14 21:43:35 -04:00
Robin Ward 610728a70f FIX: Don't include images in the topic map top links 2017-07-14 16:37:41 -04:00
Robin Ward 6b6ad9391b Clean up job for search logs 2017-07-14 14:30:58 -04:00
Robin Ward 97e211f837 FEATURE: Log Search Queries 2017-07-14 14:30:58 -04:00
Neil Lalonde 951fd1219d FIX: set a max height for the tag input field 2017-07-14 12:00:35 -04:00
Guo Xiang Tan 9792e03c63 FIX: Group name was being reverted to non-localized version.
https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16
2017-07-14 14:15:33 +09:00
Neil Lalonde 3ebd8838af FEATURE: cross-domain tracking for Google universal analytics 2017-07-13 15:21:44 -04:00
Sam 79a084dd58 Revert "remove old markdown engine work-in-progress"
This reverts commit ee470b5317.
2017-07-12 18:10:51 -04:00
Sam bcbb9f208d Revert "Integrate new engine, correct old specs"
This reverts commit f1b38ba4fb.
2017-07-12 18:10:07 -04:00
Sam d609f8a53c Revert "correct more specs"
This reverts commit 40bcc6bbdc.
2017-07-12 18:10:05 -04:00
Sam 40bcc6bbdc correct more specs 2017-07-12 17:44:40 -04:00
Sam f1b38ba4fb Integrate new engine, correct old specs
corrects edge cases with

- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron ee470b5317 remove old markdown engine work-in-progress 2017-07-12 17:44:40 -04:00
Neil Lalonde 24db001bfa FIX: user card contents can go up out of the bounds of the card when user has a title and full name 2017-07-12 16:16:59 -04:00
Arpit Jalan 76981605fa FIX: don't raise error when inviting existing user to private topic via email
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
Jakub Macina 677267ae78 Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests. 2017-07-12 17:19:27 +02:00
Régis Hanol a6dff79c2c change log level to info when failing to download a hotlinked image 2017-07-12 11:06:28 +02:00
Sam 98e03b04b5 Don't depend on imports for md extensions 2017-07-11 16:48:25 -04:00
Sam 5d139e461c FIX: multi option poll not working (new engine) 2017-07-11 14:43:34 -04:00
Sam 3f950a756a FEATURE: support image dimensions via Markdown image 2017-07-11 12:13:03 -04:00
Robin Ward 1163c086a3 FIX: Missing `model` binding 2017-07-11 11:19:49 -04:00
Arpit Jalan 3fb1c21dd5 Fix the build. 2017-07-11 19:26:33 +05:30
Sam 9840e4285d Merge pull request #4962 from nbianca/add_composer_events
Added events to show and hide the preview pane.
2017-07-11 08:26:25 -04:00