* Phase 0 for user-selectable theme components
- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
This feature introduces the concept of themes. Themes are an evolution
of site customizations.
Themes introduce two very big conceptual changes:
- A theme may include other "child themes", children can include grand
children and so on.
- A theme may specify a color scheme
The change does away with the idea of "enabled" color schemes.
It also adds a bunch of big niceties like
- You can source a theme from a git repo
- History for themes is much improved
- You can only have a single enabled theme. Themes can be selected by
users, if you opt for it.
On a technical level this change comes with a whole bunch of goodies
- All CSS is now compiled using a custom pipeline that uses libsass
see /lib/stylesheet
- There is a single pipeline for css compilation (in the past we used
one for customizations and another one for the rest of the app
- The stylesheet pipeline is now divorced of sprockets, there is no
reliance on sprockets for CSS bundling
- CSS is generated with source maps everywhere (including themes) this
makes debugging much easier
- Our "live reloader" is smarter and avoid a flash of unstyled content
we run a file watcher in "puma" in dev so you no longer need to run
rake autospec to watch for CSS changes
<% s=Time.now;
main_app.categories_path
main_app.guidelines_path
main_app.tos_path
main_app.privacy_path
p (Time.now-s)*1000%>
Returns 10-20ms consistently on i7-4770k, on shared hosts the cost
could easily reach 40ms
This code simply calculates the strings
/categories
/guidelines
/tos
/privacy
It is ludicrous to spend this enormous amount of work just to calculate
4 strings.
I do not know if this is something specific about Discourse or a bug in
Rails (I tried without the main_app prefix and got similar results),
regardless we can got to avoid these _path APIs for now
Discovered this when running a flamegraph on our home page.
- add microdata based on schema.org
- add breadcrumb on the top of topic
- add navigations link on the bottom of every pages
- add category description on the category list
Saurabh Patel
Guo Xiang Tan
David Taylor
Joe
Sam Saffron
Gerhard Schlager
Osama Sayegh
Angus McLeod
Neil Lalonde
Rafael dos Santos Silva
Régis Hanol
Arpit Jalan
Robin Ward
Erick Guan
riking
Jeff Atwood
Vikhyat Korrapati