221503cd10
FIX: Add server side uniqueness validations for `Group#name` and `User#username`.
...
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
2018-04-02 18:19:18 +08:00
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
efb19dbdaf
Merge pull request #5705 from discourse/new_webhooks
...
FEATURE: Webhook for group and category events
2018-04-02 10:53:21 +05:30
31ce955487
Add destroy rake task
...
Adds several rake tasks to delete users, topics, pm's and site stats so
that you can have a fresh site but maintain site settings and category
structure.
2018-03-30 18:32:21 -06:00
73c1d3e7fe
FIX: tag notification preferences were being cleared when other preferences were changed
2018-03-29 15:08:32 -04:00
52e75eaee9
UX: Tweaks to group pages.
2018-03-29 17:04:48 +08:00
31d0998506
FIX: Don't allow links with no href
2018-03-28 12:32:16 -04:00
dc33f2d071
Add new web hook serializers
2018-03-28 17:40:29 +05:30
ee69d58a59
FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.
2018-03-28 14:49:05 +08:00
5f4ff4a8c0
Fix failing spec.
2018-03-28 12:01:50 +08:00
21ae49ab92
Simplify log in for request specs.
2018-03-28 11:32:47 +08:00
7311023a52
Merge pull request #5700 from discourse/crawl-block
...
FEATURE: control web crawlers access with white/blacklist
2018-03-27 15:06:03 -04:00
4d12ff2e8a
when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler.
2018-03-27 13:44:14 -04:00
fcd352e089
FIX: Try fixing unparsable email addresses
...
The mail gem returns `UnstructuredField` when it fails to parse email addresses, but the `Receiver` always expects an `AddressList`.
2018-03-27 18:28:54 +02:00
62edf3c401
Add spec test for authComplete param carry-forward
2018-03-27 18:04:40 +05:30
518f7ba91b
FIX: show private message topic count on admin dashboard reports
2018-03-27 17:10:33 +05:30
7edab1c0b9
UX: Add `groups/custom/new` route for admins to create a new group.
2018-03-27 17:39:05 +08:00
558914b986
Fix random spec errors
2018-03-27 11:14:06 +02:00
31dea5d5fc
correct flaky spec
2018-03-27 17:57:19 +11:00
e7407d0adc
FEATURE: Webhook for group and category events
2018-03-27 11:53:35 +05:30
2ecd234e27
UX: Consolidation group manangement into a single tab.
2018-03-27 13:34:46 +08:00
b945a2dc39
Call `on_drop` only when tables/columns are dropped
2018-03-27 13:18:13 +11:00
4ad401bac5
Ignore delay when first migration was < 10min ago
2018-03-27 13:18:13 +11:00
cd17f60952
Improve specs for accidental table/column drops and renames
2018-03-27 13:18:13 +11:00
19c5afc69d
Protect against accidental table renames
2018-03-27 13:18:13 +11:00
f2c060bdf2
FEATURE: option for tags in a tag group to be visible only to staff
2018-03-26 17:05:09 -04:00
f03b6bd8c9
FIX: Update `last_version_at` when publishing
2018-03-26 16:06:20 -04:00
d4296f33ff
FIX: Publishing should update the public_version too
2018-03-26 15:46:25 -04:00
2b161a2391
FIX: Don't include shared drafts in global latest
2018-03-26 10:43:55 -04:00
b75b6de982
FIX: respect nofollow settings for onebox links
2018-03-26 18:21:16 +05:30
dcd1d422d1
UX: Allow admins to set users as owners while adding users.
...
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/9
2018-03-26 17:33:50 +08:00
35745166b5
UX: New group membership management workflow.
...
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084
2018-03-26 16:15:02 +08:00
3d18cd1d9d
Raise error when timestamp is invalid when creating topic timers.
...
https://meta.discourse.org/t/topic-timer-doesnt-work-for-fa-ir-locale/83702
2018-03-26 11:33:52 +08:00
25bf5278e0
Add a couple more tests for site settings import
2018-03-23 15:14:54 -06:00
9fdf139235
Add tests for Site Settings import/export
...
- extracted out site settings rake task to a class
- added tests for import and export of site settings
2018-03-23 14:55:17 -06:00
5f19ad9507
FIX: allow destination categories to be set if not at first
2018-03-23 11:33:02 -04:00
38af67eb73
Update the destination category id when a user changes it
2018-03-23 11:12:56 -04:00
27bde6bc11
Fix the build.
2018-03-23 11:43:32 +08:00
a84bb81ab5
only applies to get html requests
2018-03-22 17:57:44 -04:00
ced7e9a691
FEATURE: control which web crawlers can access using a whitelist or blacklist
2018-03-22 15:41:02 -04:00
f3b402ffd5
UX: Allow users to filter members on group page.
...
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
d96c1058a2
FEATURE: add staff action log for 'restore topic'
2018-03-21 18:04:13 +05:30
eebe1d8c56
Allow delayed dropping and renaming of tables
2018-03-21 12:05:12 +01:00
a23509cbf3
UX: Limit the number of group names displayed on user page.
2018-03-21 16:38:33 +08:00
6a3c8fe69c
FEATURE: protect against accidental column or table drops
...
Often we need to amend our schema, it is tempting to use
drop_table, rename_column and drop_column to amned schema
trouble though is that existing code that is running in production
can depend on the existance of previous schema leading to application
breaking until new code base is deployed.
The commit enforces new rules to ensure we can never drop tables or
columns in migrations and instead use Migration::ColumnDropper and
Migration::TableDropper to defer drop the db objects
2018-03-21 15:43:32 +11:00
9f216ac182
FIX: Infinite loading more on groups page.
2018-03-21 09:25:42 +08:00
2baff71518
Improve specs.
2018-03-21 08:33:06 +08:00
b9abd7dc9e
FEATURE: Shared Drafts
...
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.
* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.
* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.
* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.
* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
b39fbf7187
A staff member can hide another staff's member's post by flagging
2018-03-20 09:38:23 -04:00
15bcfcd182
UX: Allow users to filter by different group types on groups page.
2018-03-20 17:38:11 +08:00
63a1e9b60a
backup restorer: tidy pg_dump schema portability logic, add test
2018-03-20 10:32:39 +08:00
69a53210d3
Improve `UserEmail#email` validation to use the index.
2018-03-20 10:22:06 +08:00
4d44024c82
FIX: error when trying to block an IP address. Return a message when IP address matches an existing screened IP address, including ranges.
2018-03-19 14:34:43 -04:00
6ca71e1319
FIX: when creating a topic in a category that only allows tags from a tag group, don't allow creation of new tags
2018-03-19 11:42:10 -04:00
c5d26992d4
Prefer to use primary email for new user creation over other available emails
2018-03-19 17:10:35 +05:30
41b0fbe001
UX: Indicate user's group membership on groups page.
2018-03-19 18:29:30 +08:00
5005482dd8
Fix random spec failures
2018-03-19 15:25:05 +05:30
05ea034490
UX: Allow groups page to be searchable.
2018-03-19 17:16:51 +08:00
0522aabaab
UX: Allow user_count on groups page to be sortable.
2018-03-19 16:15:13 +08:00
ec57ca54b5
FEATURE: Admins should be able to view PMs of any group.
2018-03-19 14:12:01 +08:00
7fad30dacc
Refactor test case.
2018-03-19 13:39:29 +08:00
f053e4cf37
Merge pull request #5682 from techAPJ/allowed-tags-page
...
FIX: show only allowed tags on PM tags page and display correct count
2018-03-17 08:29:00 +05:30
89f5c90ce0
FIX: show an error page on click tracking error
2018-03-17 00:33:11 +01:00
6c736a1fa4
FIX: Translation overrides for flag types didn't expire cache
2018-03-16 22:10:19 +01:00
e9bc763440
FIX: show only allowed tags on PM tags page and display correct count
...
FIX: tags page should link to user profile we are browsing
2018-03-17 00:17:48 +05:30
aa91bd61a7
Improve specs for `TopicQuery#list_group_topics`.
2018-03-16 16:18:26 +08:00
fe96ef6ed2
UX: Use topic list for displaying group messages on group page.
...
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
2018-03-16 11:56:40 +08:00
58bb3967e5
SECURITY: Oneboxer should escape the URL before processing
2018-03-15 19:57:55 +05:30
c589564f6a
FIX: color schemes not updating when remote saves
2018-03-15 18:26:54 +11:00
a35227918f
UX: Display group topics in a topic list.
2018-03-15 11:37:55 +08:00
5ce8177662
FIX: unable to delete user belonging to a group that grants a trust level
2018-03-14 15:12:11 -04:00
135195363b
FIX: Not logging old post contents properly
2018-03-14 15:01:36 -04:00
6f40037ba5
Add test guarding against the SSO logic I broke
2018-03-13 18:39:39 -04:00
58508e553d
FIX: tag input should not include tags you've already chosen in the search results
2018-03-13 17:17:16 -04:00
31a0c4a9be
FEATURE: Add `quote-modified` class if a quote has been modified
2018-03-13 13:41:06 -04:00
f7bd05e534
FEATURE: set 'Retry-After' header for 429 responses ( #5659 )
2018-03-13 23:12:41 +08:00
7d375690c1
Merge pull request #5667 from techAPJ/pm-tags-page
...
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:08:21 +05:30
24338fbbe8
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:06:58 +05:30
2ad2ed2eb2
FIX: Couldn't move a topic into the uncategorized category.
2018-03-13 10:20:47 +08:00
d5c828213f
FIX: Circular references warning in `TopicTrackingState`.
2018-03-13 08:35:15 +08:00
ab2f3e43eb
FIX: excerpts in summary email are too short when there are images or links
2018-03-12 18:12:09 -04:00
65ac80b014
FEATURE: Log Staff edits in Staff Action Logs
...
Why? Some edits by staff are not tracked. For example, during the grace
period, or via the flags/silence dialog.
If a staff member is editing someone else's post, it now goes into the
Staff Action Logs so it can be audited by other staff members.
2018-03-12 13:51:40 -04:00
82143a421c
FIX: `max topic invitations per day` should apply on PM invites as well
...
FIX: do not apply `max topic invitations per day` on email invites
2018-03-12 23:17:58 +05:30
d243b82fb3
FIX: Calculation of text length for <details> in excerpt was wrong
2018-03-12 16:55:23 +01:00
758b9a7dda
FEATURE: prototype of local theme directory watcher
...
(note this will be documented a bit late)
2018-03-12 18:36:06 +11:00
89f41f8236
FIX: error when group_in_subject enabled but no group in pm
2018-03-11 12:22:11 +00:00
f862122978
FIX: do not log personal message view if there exists a similar log in previous hour
2018-03-11 09:23:32 +05:30
12706c4b29
FEATURE: support markdown rendering for embedded posts
2018-03-11 08:00:48 +05:30
3c3d205180
FIX: sso_overrides_username may inappropriately change the username if the case changed
2018-03-09 16:06:55 -05:00
aac7796124
FIX: do not show tags with 0 count on /tags page
2018-03-09 20:57:31 +05:30
dc77cce8d9
FIX: Create notifications for mentions in PMs
2018-03-09 11:04:29 +01:00
39e679d3cb
FEATURE: allow themes to live in private git repos
...
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
34a0e79bec
FIX: use digest_min_excerpt_length site setting in summary emails
2018-03-08 23:35:10 -05:00
5b6e49ae1d
FEATURE: split out max diff to 2 settings
...
We trust staff + tl2 and up to perform edits in grace period.
Allow them significantly more edit room in grace period prior to storing
a revision.
editing_grace_period_max_diff_high_trust applies to users with tl2 and up.
So
tl0 / 1 : we store an extra revision if more than 100 chars change
tl2 and up : we store an extra revision if more than 400 chars change
We may tweak these numbers as we go.
2018-03-09 11:58:50 +11:00
4b23634092
FIX: converting topic to message for a second time was broken
2018-03-08 17:59:04 +05:30
0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown
...
FEATURE: filter personal messages by tags
2018-03-08 16:30:38 +05:30
a8149f8969
FIX: user should not be able to invite to PM if trust level requirment not met
...
FIX: when personal messages are disabled let user invite to a public topic
2018-03-08 14:59:04 +05:30
c29660c8f1
FEATURE: filter personal messages by tags
2018-03-08 14:42:07 +05:30
88fdc926d1
Move external_id from UserSerializer to CurrentUserSerializer ( #5658 )
2018-03-07 22:54:31 -05:00
b57d4c87a4
FEATURE: update CommonMark to version 0.28
2018-03-08 12:19:53 +11:00
e162cd16b6
FEATURE: editing_grace_period_max_diff to force revisions in grace period
...
If a user performs a substantive edit of 20 chars or more during grace period
we will store a revision to track the change
This allows for better auditing of changes that happen during the grace period
2018-03-07 18:34:34 +11:00
3045c589f6
FIX: Publish live messages to both team inbox and archive on update.
2018-03-07 14:01:20 +08:00
5169be6080
FIX: User archiving message should also publish to sent section.
2018-03-07 11:39:23 +08:00
bef35f7be5
FIX: User archive messages should only publish to the user.
2018-03-07 11:28:29 +08:00
81780d8607
Merge remote-tracking branch 'origin/analyze-code-fix'
2018-03-06 13:16:37 -05:00
07649cd42d
FIX: email_domains_whitelist prevented creation of anonymous users
2018-03-06 18:14:53 +01:00
c74d10cf34
FIX: Consider live links in `<code>` as links when counting
2018-03-06 11:46:12 -05:00
1365bab0d7
FEATURE: Live updates for user's messages page.
...
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
2018-03-06 18:15:21 +08:00
d576056cff
REFACTOR: Add basic tests for `TopicTrackingState#publish_*`.
...
* Ensure we don't publish events for PMs.
2018-03-06 17:37:53 +08:00
0134e41286
FEATURE: detect when client thinks user is logged on but is not
...
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
f0d5f83424
FEATURE: limit assets less that non asset paths
...
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
2018-03-06 15:20:39 +11:00
8e48b339fa
Drop unused tables ( #5630 )
2018-03-05 17:27:30 -05:00
17a615165c
FIX: Don't lock wiki posts when they're edited
2018-03-05 14:50:06 -05:00
0f66a99eb2
Setting to prevent logging details when anonymizing
2018-03-05 14:38:18 -05:00
003b03d939
allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age
2018-03-05 23:31:29 +05:30
ce1994beea
FIX: do not treat :: as a valid emoji
2018-03-05 15:35:24 +01:00
07f1d90b88
FIX: Inviting a group that I am part of creates a notification.
...
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
2018-03-05 13:51:32 +08:00
42e0aaed61
FIX: Set first visit PM notification level to group default notification level.
...
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
2018-03-05 13:39:00 +08:00
9331b4849d
FEATURE: we need access to settings in theme js
2018-03-05 15:35:41 +11:00
282f53f0cd
FEATURE: Theme settings (2) ( #5611 )
...
Allows theme authors to specify custom theme settings for the theme.
Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
31e3bf6d8d
FEATURE: New "Categories and Top" homepage style
...
Select this option if you want to show top topics on the homepage
instead of latest topics.
2018-03-03 14:26:57 -05:00
cd6c5fc5fb
FIX: Disable "Make Personal Message" if they are disabled
2018-03-02 20:28:39 -05:00
730201d423
New interface to upsert custom fields
2018-03-02 12:45:52 -05:00
6a78669ca3
FIX: 'reply by email addresses' site settings should allow email addresses without a 'reply_key' when 'find related post with key' is disabled
2018-03-02 17:53:18 +01:00
2e202495a3
FIX: do not allow invite notifications from muted user/topic
2018-03-02 12:24:51 +05:30
d39d2b9352
FEATURE: whitelist data for themes
2018-03-02 14:52:09 +11:00
939180efa8
FIX: Missing 2FA guards when sso is enabled or when local login is disabled.
2018-03-02 10:39:10 +08:00
4f301905b6
Make rubocop happy.
2018-03-02 10:15:53 +08:00
b3883f5c32
FIX: Don't lock a post on edit unless the raw changes
2018-03-01 20:40:19 -05:00
5c93d07d2a
Remove duplication of params in tests.
2018-03-02 09:25:46 +08:00
75172024ca
SECURITY: ensure users have permission when moving categories
2018-03-02 12:13:27 +11:00
79590e4bec
FIX: Merging users shouldn't add more than 1 secondary email
2018-03-01 17:50:13 +01:00
a7c50039de
FIX: Allow changing post owner even when topic validations fail
2018-03-01 17:31:58 +01:00
7a2183e8ab
FEATURE: rake task for merging users
2018-03-01 12:28:12 +01:00
fffd1a6602
FIX: Associated Instagram account was missing at some places
2018-03-01 12:26:40 +01:00
fb75f188ba
FEATURE: Disallow login via omniauth when user has 2FA enabled.
2018-03-01 15:47:07 +08:00
0fabf80dca
Migrate controller type specs to request types for omniauth.
2018-03-01 15:33:00 +08:00
81ca3677f7
Add guard for `nil` in our `RateLimiter`.
2018-03-01 13:20:42 +08:00
5d9f9c2614
FIX: `RateLimiter` max of zero or less should raise rate limit exceeded.
2018-03-01 13:14:46 +08:00
47c41f474d
Missing indentation.
2018-03-01 13:12:13 +08:00
947b6fdf46
FIX: Incorrect rate limit applied to topics invitation flow.
2018-03-01 12:50:00 +08:00
b283bb2ba7
FIX: Don't include unlisted topic in groups/posts
2018-02-28 14:40:18 -05:00
baf1c385eb
UX: when a post is blocked due to a watched word, message includes the word being blocked
2018-02-28 11:22:18 -05:00
e7a7356986
Remove ancient votes code that is no longer used.
2018-02-28 14:37:22 +08:00
902c5d11cf
FIX: Don't allow other flag actions after `notify_moderator` has happened.
...
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
51544047dc
Add external_id to User Serializer
2018-02-28 10:13:27 +08:00
f295a18e94
FIX: stop double counting net calls in logs
2018-02-28 10:45:11 +11:00
c22e56499a
FIX: Allow changing post owner even when validations fail
2018-02-27 15:46:20 +01:00
486bbe9cc2
FIX: Auto re-opened topics should restore category auto close settings.
...
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
2018-02-27 15:33:31 +08:00
06891ce51d
FIX: Direct link to group activity page results in 400 error.
...
https://meta.discourse.org/t/following-a-direct-link-to-group-activity-results-in-400-error/81596
2018-02-27 13:43:22 +08:00
Guo Xiang Tan
Vinoth Kannan
Blake Erickson
Neil Lalonde
Robin Ward
Gerhard Schlager
Arpit Jalan
Sam
Michael Brown
Régis Hanol
Kyle Zhao
Leo McArdle
Simon Cossar
Joffrey JAFFEUX
OsamaSayegh