bf322281e3
Improve handling of inlined images in incoming emails
2017-05-03 23:02:02 +02:00
e9bb9a167b
Fix reply-by-mail for 8-bit transfer encodings
...
The mail class seems to handle mails sent with Content-Transfer-Encoding: 8bit
somewhat weirdly: It decodes them (to utf-8), changes the raw source to base64,
and does not modify the Content-Type:charset= header.
This leads to Discourse trying the message encoding (in my example ISO-8859-1)
first, and if that does not contain any unparseable characters, it uses that.
Sadly, in ISO-8859-1, every byte sequence is valid.
Fix this by always trying to decode as UTF-8 first. The probability of someone
using another encoding that cleanly (but wrongly) decodes as UTF-8 should be
fairly low.
2017-04-30 23:30:40 +02:00
0ec15af970
restore the 'incoming_email_prefer_html' site setting
2017-04-27 14:31:11 +02:00
b76674f640
FEATURE: convert incoming emails in HTML to markdown
...
- remove incoming_email_prefer_html site setting
- remove HtmlCleaner class
2017-04-26 16:49:06 +02:00
04016f0dec
Support Ruby 2.4.
2017-04-15 12:29:00 +08:00
1853a4852c
FIX: use email prefix only in subject
2017-03-21 20:29:57 +05:30
ee9d621d9c
FIX: surround the FROM alias with " in order to support the @ character
2017-03-07 23:37:21 +01:00
e634b37f9a
FIX: from field of emails should be including email_site_title or site title settings
2017-02-27 14:23:07 -05:00
82555ca761
FIX: mail threading wasn't working properly in Mac Mail
2017-02-01 23:02:41 +01:00
8fc7420f83
FIX: prevent huge custom emojis in emails
2017-01-30 18:06:48 +01:00
521ced38c5
fix spec for default email title
2017-01-19 14:01:51 -08:00
185dcb2ca1
handle emails with localized headers 😠
2017-01-09 22:59:30 +01:00
495a511862
simplify quote markup in emails
2017-01-02 21:37:01 +05:30
18f400e652
Remove RSpec given.
2016-12-14 10:29:22 +08:00
eb453d0f82
the note in a FWed email should be a whisper only in PM and when the author is member of the group
2016-12-01 18:43:56 +01:00
62763f025c
FIX: wasn't able to parse FROM email in the embedded email
2016-12-01 18:34:47 +01:00
a03287f2ee
FIX: 'In-Reply-To' header should default to topic_message_id
2016-11-28 14:18:02 +01:00
74b6fe8739
FIX: respect RFCs when setting 'In-Reply-To' and 'References' email headers
2016-11-25 23:25:39 +01:00
f8caae0be7
FIX: don't overwrite custom email headers when using mandrill/sparkpost
2016-10-30 11:38:55 +01:00
2a61cc8c88
FIX: email styling with blacklisted iframes
2016-10-21 12:37:03 +02:00
51322a46b3
FEATURE: retry processing incoming emails on rate limit
2016-08-08 22:28:27 +02:00
b08ab829b8
added 'X-Auto-Response-Suppress' email header (props to elijah)
2016-08-03 11:02:07 +02:00
3588780ac3
Don't reject likes by email for closed topics ( #4311 )
2016-07-05 17:33:08 +02:00
e858def372
remove invalid specs
2016-07-04 10:34:26 +10:00
7a1e99dacb
Add some clarifying specs around new-topic-creating emails work
...
Strangers get to create new topics (if the appropriate tickbox is ticked)
but low-TL existing users don't. That might seem a bit backwards, but
the tickbox says 'strangers', not 'everyone'.
2016-06-30 22:24:25 +10:00
20359788dc
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:02:43 +08:00
214f5bff5c
don't send more than 1 reply per day to auto-generated emails
2016-06-28 16:42:05 +02:00
800081f606
FIX: staged users weren't able to reply in restricted categories
2016-06-26 19:25:45 +02:00
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
dffe50a2e6
new alternative reply by email addresses
2016-06-10 16:14:42 +02:00
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
a92fd9d701
Add Site Setting to use HTML from incoming email when available. ( #4236 )
2016-05-26 10:13:01 +02:00
c75d58ab21
FEATURE: new 'ignore_by_title' site setting
2016-05-18 23:07:01 +02:00
5f76287b18
FEATURE: cap number of staged users (defaults to 10) created per incoming email
2016-05-16 21:45:34 +02:00
1e57bbf5c8
Lots bounce emails related fixes
...
- Show bounce score on user admin page
- Added reset bounce score button on user admin page
- Only whitelisted email types are sent to emails with high bounce score
- FIX: properly detect bounces even when there is no TO: header in the email
- Don't desactivate a user when reaching the bounce threshold
2016-05-06 19:34:33 +02:00
8e611ec7a1
FEATURE: handle bounced emails
2016-05-02 23:15:32 +02:00
84d4ebd910
use 'reply_by_email_address' setting for handling bounce emails using VERP
2016-04-25 20:06:45 +02:00
4960b62110
FEATURE: new 'block_auto_generated_emails' site setting
2016-04-20 21:29:27 +02:00
7d9f2265b9
FIX: improve support for handling emails coming from screened email addresses
2016-04-18 23:01:54 +02:00
fad017d842
FEATURE: add support for bounce emails
...
We now optionally add a Variable Email Return Path to every email we send.
This allows us to cleanly handle email bounces, which in turn will improve
deliverability.
2016-04-18 17:14:01 +10:00
4d9c81fde7
Merge pull request #4148 from tgxworld/dont_reply_to_emails_that_are_autogenerated
...
FIX: Don't send rejection mailer to bounced emails.
2016-04-13 15:36:14 +02:00
56089c4856
FEATURE: new 'auto_generated_whitelist' site setting
2016-04-11 22:47:34 +02:00
e4980392da
improve receiver specs to account for posts approval
2016-04-11 18:20:26 +02:00
c5794ab0f6
allow magic login route emails even when emails are disabled
2016-04-08 11:20:09 +05:30
5734c7f3f3
FIX: Don't send rejection mailer to bounced emails.
2016-04-07 22:21:17 +08:00
39863953cd
new 'enable_staged_users' site setting
2016-03-23 18:56:03 +01:00
03a1aa0000
SECURITY: only add elided part of email in PM
2016-03-17 23:10:46 +01:00
4a3cb4a000
FIX: use MD5 of the email_string when there's no 'Message-Id'
2016-03-14 18:18:58 +01:00
841cec1bc1
FIX: support emails in with weird encoding
2016-03-11 18:51:53 +01:00
6d84a8a1b3
FIX: don't send out elided message in email notifications
...
UX: improved details tag for elided messages
2016-03-11 17:51:16 +01:00
2747e14b4c
FEATURE: hide elided part of incoming emails behind a [details] tag
2016-03-09 18:51:54 +01:00
622d804d46
FEATURE: Add rejection message on rejected IncomingEmail
...
FIX: Better RateLimit description in rejected IncomingEmail
FEATURE: Send email when hitting a rate limit
2016-03-07 16:56:17 +01:00
be5a54d67d
FEATURE: new 'allow_all_attachments_for_group_messages' site setting
2016-02-29 22:39:24 +01:00
f7432d8ec9
FEATURE: add support for multiple incoming emails for groups & categories
2016-02-24 19:47:58 +01:00
54262cc9b2
FIX: properly handle invalid from header
2016-02-24 17:40:57 +01:00
5415b2666d
FIX: staged users couldn't create new topic in a private category via email
2016-02-22 19:57:53 +01:00
52a6682690
FIX: don't create an EmailLog when we can't send a digest
2016-02-17 17:31:46 +01:00
cad7fc1062
FIX: don't allow blocked user to send emails in
2016-02-11 10:39:57 +01:00
82a75c00c0
UX: change 'Visit Topic' to 'Visit Message' for message notification email
2016-02-09 13:39:10 +05:30
49d1f88f6e
FIX: support incoming emails with no subject
2016-02-01 12:16:15 +01:00
27aaed0aa5
FIX: don't use 'Return-Path' header to determine whether the email was auto generated
2016-02-01 10:21:58 +01:00
46b6c55197
FIX: replace 'discourse_email_parser' with 'email_reply_trimmer' to better trim replies from plain text emails
...
FIX: undefined method `number_to_human_size' when email contains attachments
2016-01-30 01:29:31 +01:00
378b7f964c
Revert "FEATURE (WIP): add max-width and center email notifications"
2016-01-29 11:13:59 +01:00
77167f12ad
move styles to Styles
2016-01-27 19:07:21 -08:00
8d10130c10
test format_notifications
2016-01-27 15:44:49 -08:00
3f09ec2aca
add layout for notifications
2016-01-27 11:27:32 -08:00
4a17cdc1e4
FIX: don't invite users with emails configured as 'incoming' (reply, group our category)
2016-01-20 23:08:27 +01:00
f145310cd5
FIX: associates email replies using both 'In-Reply-To' and 'References' headers
2016-01-20 22:52:08 +01:00
c2c01cdb5d
FIX: username suggester to account for the more relaxed username rules ( closes #3907 )
2016-01-20 15:37:34 +01:00
c7283751a3
Unsubscribe via email
2016-01-20 22:25:25 +13:00
735017dd9f
FIX: don't invite users with the same email as 'reply_be_email_address'
2016-01-19 15:24:34 +01:00
3083657358
FEATURE: better email in support
...
FEATURE: new incoming_email model
FEATURE: infinite scrolling in emails admin
FEATURE: new 'emails:import' rake task
2016-01-19 00:57:55 +01:00
6ceb108946
Add specs for post action guardian
2015-12-30 20:52:36 +01:00
86da47880a
Allow +1 via email
2015-12-30 12:17:45 +01:00
3e923c7a41
FIX: ensure inactive users can't email in
2015-12-21 17:54:02 +01:00
51b2279af0
fix the build
2015-12-16 01:31:19 +01:00
4bb31daa2e
FIX: when getting a reply by email, ensure it's by the same user
2015-12-16 00:43:05 +01:00
02279c41cb
Merge pull request #3918 from techAPJ/better-email-parsing
...
FEATURE: better email reply parsing
2015-12-11 14:51:24 +01:00
1f003e3472
fix inline reply test case
2015-12-11 14:48:42 +05:30
323e3cee22
when creating a staged account, use the display name provided in the email
2015-12-10 23:52:20 +01:00
93d1cc6294
add support for incoming emails in CC/BCC fields
2015-12-10 23:49:16 +01:00
7a8e5a50ff
FEATURE: better email reply parsing
2015-12-09 23:47:01 +05:30
1cde276656
FEATURE: ability to send emails to a group
2015-12-07 17:01:08 +01:00
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
2196160549
FIX: Allow emails to begin with a quote (but skip it!)
2015-11-18 15:23:10 -05:00
897563a309
FIX: List-ID should not contain space
2015-10-21 00:00:06 +05:30
54d6d24cbf
FIX: timing issue with edits and cook post processing
2015-09-29 18:51:26 +02:00
e3a80936c8
prefer empty href attribute to #
2015-09-08 18:27:20 +02:00
27b1ec2917
FIX: incorrect emoji stripping logic
2015-08-19 09:12:08 +10:00
6669a2d94d
FEATURE: per-topic unsubscribe option in emails
2015-08-12 23:00:16 +02:00
b0802abae2
FIX: crop & optimize user background profile/card images
2015-07-15 17:15:43 +02:00
8e7bfd0f29
FIX: automatically growing uploads tree
2015-05-28 01:03:24 +02:00
693b5234da
FIX: nil emails are invalid
2015-05-27 14:12:10 +10:00
9ded21e4c6
FIX: consistent and future-proof upload storage pattern
2015-05-19 12:31:12 +02:00
e6df97f01d
FIX: add email reply error message for topic not getting created in restricted category
2015-04-10 17:11:52 +05:30
f3daae6dec
Improve auto generated email reply error message
2015-02-18 18:58:51 +05:30
e97755ab5d
FIX: remove custom Discourse headers in email
2015-01-29 17:25:50 +05:30
b0369061e2
FIX: always set a default Message ID in email
2015-01-28 14:49:38 +05:30
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
45dbdb6896
FEATURE: custom emojis
2014-12-23 01:12:26 +01:00
d28515792a
FIX: auto response email replies should not be accepted
2014-12-04 22:39:13 +05:30
15c105eba5
Add test for email with inline reply
2014-12-01 23:51:14 +05:30
529014d56e
FEATURE: switch to GitHub email_reply_parser library and parse plain text email content
2014-12-01 09:00:35 +05:30
20044da474
FIX: cleanup commas in email From and Reply-to fields
2014-11-24 19:55:20 +05:30
b1a0cd417d
Avoid a deprecation warning by poly-filling #deliver_now and #deliver_now
2014-11-10 01:05:46 -08:00
ada750b384
fixed some more deprecations. 20 to go
2014-10-29 16:06:50 +01:00
3a11e5b52e
Merge pull request #2921 from techAPJ/patch-1
...
FIX: email replies should not be accepted for deleted topics
2014-10-28 14:11:33 +11:00
370f50250b
FIX: attachment links in mail lacks protocol
2014-10-28 00:08:51 +05:30
b37d845dd3
FIX: email replies should not be accepted for deleted topics
2014-10-27 13:05:33 +05:30
08dc0e6ee6
FIX: email replies to closed topic should not be accepted
2014-10-25 23:47:13 +05:30
4eb1288dba
FIX: Broken spec from @coding-horror
2014-10-20 17:13:45 -04:00
2131a37811
FEATURE: show raw email for replies/topics created via email
2014-10-17 22:22:19 +05:30
24a0db3244
FIX: fix email replies for ms outlook
2014-10-14 16:20:35 +05:30
47d48b4dd8
FEATURE: add Precedence header
2014-10-09 01:40:48 +05:30
0c739bb5b6
Merge pull request #2860 from techAPJ/patch-2
...
include category in List-Id instead of topic
2014-10-08 15:28:41 -04:00
c53f635b2c
include category in List-Id instead of topic
2014-10-09 00:34:27 +05:30
b457005b07
FIX: handle multiple paragraphs in email reply when parsing html
2014-10-08 19:45:46 +05:30
b1271ed44b
FIX: Remove html entities from text emails
2014-10-06 13:57:38 -04:00
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
c1df25e856
Add test for "on day, name wrote" quote trigger
2014-09-09 16:27:06 -07:00
59d04c0695
Internal renaming of elder,leader,regular,basic to numbers
...
Changed internals so trust levels are referred to with
TrustLevel[1], TrustLevel[2] etc.
This gives us much better flexibility naming trust levels, these names
are meant to be controlled by various communities.
2014-09-05 15:20:52 +10:00
1c5e8efa68
FEATURE: Show an email icon beside posts that arrived via email
2014-09-04 13:04:41 -04:00
8ddd90daa4
Have parse_body() recover from ASCII-8BIT encoding
...
Added a test to make sure that the result can be passed into TextCleaner
(which expects UTF-8)
2014-08-28 14:38:19 -07:00
1c9f6159cd
Update the Receiver and PollMailbox specs for the changes
...
Tests are both added, moved, and deleted.
Add test for topic not being created
Move html_only.eml to parse_body testing section
2014-08-28 14:38:19 -07:00
77ba2015eb
FEATURE: new disable_emails site setting
2014-08-23 11:07:37 +02:00
cce8b4720a
Have reciever handle multiple To addresses
2014-08-13 11:43:49 -07:00
50ac4c6336
FIX: cleanup aliases in email From and Reply-to fields to prevent Bad sender address syntax errors
2014-08-08 13:35:47 -04:00
dcc9923e4b
FIX: failed messages posted via email silently ignored
...
also... test suite over mocking
2014-07-31 18:46:02 +10:00
b3c149de22
FIX: use email_site_title for emails like reset password and account activation too
2014-07-22 15:52:20 -04:00
1682f5d584
Fix message, and add test, for EmailUnparseableError
2014-07-17 10:25:53 -07:00
17db265b41
Remove use of email_in_address and email_in_category
2014-07-17 10:25:13 -07:00
01a68f8cc7
Emails are case insensitive
2014-07-16 10:22:01 -04:00
dd6fd7fa39
FIX: Don't put iframes in emails where they are sanitized out. Replace
...
them with links.
2014-07-14 16:41:37 -04:00
4750f4b5b8
Expect the right error in reciever_spec
...
Makes the tests less likely to silently break
2014-07-11 12:26:52 -07:00
a1482f24d9
remove borked test
2014-06-13 17:03:45 -07:00
679b3fab79
correct broken test, List-ID is correct
...
see http://www.ietf.org/rfc/rfc2919.txt
2014-06-13 16:45:34 -07:00
beaa145572
some email notification header fixes
2014-06-13 15:42:20 -07:00
c690fa0d19
FIX: Replace protocol relative URLs in emails
2014-06-13 17:11:04 -04:00
93f5f98b58
Corrected and added appropriate specs to confirm correct behaviour.
...
Tests ensure that the site name is used for public replies and the username is used for private replies.
2014-06-09 18:26:19 +08:00
cd6ab981f3
FIX: preferences URL changed
2014-04-29 21:18:23 -04:00
2505d18aa9
FEATURE: support email attachments
2014-04-14 22:55:57 +02:00
c3a1c867dd
REFACTOR: poll mailbox specs
2014-04-09 19:26:19 +02:00
e6989b5313
Merge pull request #2192 from jorgemanrubia/configurable-emails-prefix
...
Option to change the subject prefix in emails
2014-03-28 15:08:50 +01:00
fd504e741f
FIX: reply by email can handle emails with attachments. Attachments are still ignored, but a post or topic can be created from the email now.
2014-03-28 09:57:20 -04:00
806924dd7e
Option to change the email subject prefix
...
It adds a new setting 'email_prefix' to configure which [label] will be used in the subject of emails. Discourse currently uses '[title]'. The problem is that sometimes you need to set a longer title, that doesn't really work well for emails. I think this is very common since the HTML `<title>` tag is very important for SEO.
It will default to '[title]' if this setting is not used.
See: https://meta.discourse.org/t/where-to-change-the-email-subject-prefix/11989
2014-03-26 23:06:00 +01:00
c3e5ee1d7e
FIX: Failing specs
2014-03-07 12:06:20 -05:00
024597e643
Switch to proper exception handling system for better user feedback
...
- Replace implicit return code-system in Email::Receiver with proper exception system
- Update tests to check for exceptions instead
- Test the PollMailbox for expected failures
- Add proper email-handling of problematic emails
"
2014-02-28 17:02:58 +01:00
d32cb55837
Add public-inbox to Email-In-Feature
...
- Adds the advanced option to accept email from non-users per category email-address
- Adds tests covering the new feature
- Adds UI to configure this feature in the frontend
2014-02-28 16:53:58 +01:00
37cea49459
Add Email-In-Per-Category
...
- allow the configuration of an inbox-email-address per category
- post emails to that email into that category instead of global
- Adds UI for configuration
- Adds Documentation for configuration
- Adds Tests for new feature
2014-02-28 16:53:58 +01:00
Régis Hanol
Claus Strasburger
Guo Xiang Tan
Arpit Jalan
Neil Lalonde
Jeff Atwood
James Kiesel
Sam
Matt Palmer
David McClure
scossar
Andy Waite
Robin Ward
Luciano Sousa
Godfrey Chan
riking
Jeff Atwood
Peter N Lewis
Jorge Manrubia
Benjamin Kampmann