Commit Graph

10731 Commits

Author SHA1 Message Date
Robin Ward 926e45d030 SECURITY: User action route was returning too much data 2014-08-29 13:46:50 -04:00
Arpit Jalan 84d0b599a4 FIX: do not redirect topic for JSON request 2014-08-29 23:09:02 +05:30
Robin Ward 16c9f073b5 FIX: Back button breaks translation of incoming stuff 2014-08-29 12:53:06 -04:00
Neil Lalonde ec42b61a4d FIX: suspended users cannot be trust level 3 2014-08-29 12:33:34 -04:00
Neil Lalonde 6b41c6b335 add permalinks route constraint 2014-08-29 11:28:16 -04:00
cpradio 8033972536 UX: Add keyboard bidning for incoming/updated topics
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio 5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio 096bc0c0ae Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
Conflicts:
	app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio cde64580b1 Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding 2014-08-29 09:35:38 -04:00
cpradio 3f085c3fd3 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 09:22:47 -04:00
cpradio ede9d1e057 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 08:46:35 -04:00
cpradio 9e72b97a75 Corrected an issue with using the same ID for the header/footer of the buttons 2014-08-29 08:33:45 -04:00
cpradio e4ce995369 FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu 2014-08-29 08:11:23 -04:00
cpradio ed8d828ff1 FIX: Added keyboard bindings for dismiss buttons 2014-08-29 08:04:57 -04:00
Régis Hanol e823f568a7 FIX: preprocessing regexes in vBulletin importer 2014-08-29 13:11:56 +02:00
Régis Hanol fd6dd88afb FIX: dual modal when deleting spammer in the flag modal 2014-08-29 13:05:51 +02:00
Régis Hanol 521cb6bd0d FIX: dual modal when selecting 'delete spammer' in flags section 2014-08-29 12:54:24 +02:00
Jeff Atwood 8bda8a2235 Revert "UX: stop displaying "user deleted, OK" dialog"
This reverts commit 36405287b4.
2014-08-29 03:49:00 -07:00
Jeff Atwood 36405287b4 UX: stop displaying "user deleted, OK" dialog 2014-08-29 03:34:23 -07:00
Jeff Atwood dd972856d6 Update INSTALL-digital-ocean.md 2014-08-29 00:42:32 -07:00
Sam 163bbb1d3a comment out test till fixed 2014-08-29 17:27:28 +10:00
Sam 911b8647cf FIX: Revert permalink support until implemented correctly 2014-08-29 17:06:14 +10:00
Jeff Atwood 2c7d694c34 UX: extremely confusing copy on setting 2014-08-28 23:09:37 -07:00
Sam 4a3f24ea24 Merge pull request #2705 from riking/live-lightbox
Publish lightboxing on the message bus
2014-08-29 15:36:44 +10:00
riking 085b18577c Remove unnecessary user/topic load in PostCreator 2014-08-28 22:07:40 -07:00
riking 24ba7ccfbb FEATURE: Add a plugin callback when editing a post
FIX: Wrap PostRevisor database work in a transaction
2014-08-28 21:27:40 -07:00
riking 3396e6fea3 Centralize MessageBus post updates
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
cpradio 723798cc30 Correct Perform Search Test 2014-08-28 23:32:56 -04:00
cpradio 185769c07b Correct Perform Search Test 2014-08-28 23:21:43 -04:00
riking 0a7a4eae99 Publish lightboxing on the message bus
With this change, images appear to lightbox instantly on my development
machine.
2014-08-28 20:16:33 -07:00
Sam b7e8bcda07 FIX: strip leading/trailing spaces from developer emails 2014-08-29 12:21:33 +10:00
Sam fe6e4d7da1 FIX: fails on initial migration if default_locale is nil 2014-08-29 12:01:28 +10:00
cpradio 0784c52a24 FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
Sam c07d76677d Merge pull request #2701 from riking/email-pr-ssl
Rename POP3 settings, fix multisite SSL state leak
2014-08-29 10:02:05 +10:00
Sam 1bef22bbb9 Merge pull request #2703 from riking/email-pr-receiver
Heavy refactor for Email::Receiver
2014-08-29 09:59:59 +10:00
cpradio 3e7084743c FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
Sam 8ab9c57ca5 Merge pull request #2707 from eyalev/rtl-email
Enable RTL direction in emails.
2014-08-29 09:54:57 +10:00
Sam 5b696ca25a Merge pull request #2708 from Wilhansen/sso_override_avatar
Fix SSO avatar downloading issues.
2014-08-29 09:53:48 +10:00
Jeff Atwood bfb9fc4e99 FEATURE: reduce user edit window from 1y to 6m 2014-08-28 15:47:38 -07:00
Robin Ward 85c6eb9b08 SECURITY: Only redirect to our host by path on the login action 2014-08-28 17:45:13 -04:00
riking 8ddd90daa4 Have parse_body() recover from ASCII-8BIT encoding
Added a test to make sure that the result can be passed into TextCleaner
(which expects UTF-8)
2014-08-28 14:38:19 -07:00
riking 1c9f6159cd Update the Receiver and PollMailbox specs for the changes
Tests are both added, moved, and deleted.

Add test for topic not being created

Move html_only.eml to parse_body testing section
2014-08-28 14:38:19 -07:00
riking 0a09593f3b FIX: Prefer HTML in incoming emails, heavily refactor email receiver
This commit heavily refactors Email::Receiver to both better handle
different emails and improve testability.

A primary focus of the refactor is reducing the usage of class
variables, in favor of actually passing parameters - making it possible
for multiple tests to use the same Receiver instance.

The EmailLog reported when a topic is created is reflected to put the
user's email in the to_address field, instead of the system address.

The discourse_email_parser function is renamed to
discourse_email_trimmer, and additional stopping conditions are added to
make up for EmailReplyParser's inability to deal with html at the start
of a line.

The force_encoding calls are refactored out to a 'fix_charset' method.

parse_body is renamed to select_body, and the scrub_html method is
dropped in favor of the new HtmlCleaner class.

A new parse_body method is added, which performs the job of the removed
lines of code in the 'process' method.

EmailUnparsableError is redefined again, to be encoding errors (when the
declared encoding is not what was delivered).
2014-08-28 14:36:10 -07:00
riking cb55ef4702 Add Email::HtmlCleaner for email processing
This class is in charge of stripping out most of the crap from the HTML
portion of emails that email clients generate, so that it can be sanely
post-processed for signatures and quoting boundaries.
2014-08-28 14:36:10 -07:00
riking 0d0225133c FIX: Failed incoming emails could create empty topics
A failure condition is eliminated where a topic would be created, but post
creation would fail, leaving the forum with a topic without any posts.
By asking PostCreator to create the topic instead, inside of its
transaction, this failure condition is eliminated.

Additionally, attachments are restored to working status. Previously,
the attachment code would build up the post raw, but then drop it and
not do anything with the result (creating orphaned uploads). By actually
placing the raw value back in the options hash, it is included in the
created post.
2014-08-28 14:35:43 -07:00
Robin Ward 9e2c72e277 Allow restoring from backups in development mode even if the setting is
off.
2014-08-28 17:02:48 -04:00
Neil Lalonde 464a922910 FIX: permalinks table: increase limit of url column, make url index unique 2014-08-28 16:16:39 -04:00
cpradio 1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio 4fd73a2b2f Set focus on site-map and user menu
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Neil Lalonde 14890a6002 FEATURE: add a way to map arbitrary urls to a topic, post, or category. Useful for sites that have migrated to Discourse and want to redirect from their old site to Discourse with 301 redirects. 2014-08-28 15:58:24 -04:00